https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #13 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Pedro Amorim from comment #12)
Hi Lisette, thank you so much for your testing and detailed feedback.
(In reply to Lisette Scheer from comment #10)
http://main-intra.localhost/cgi-bin/koha/ill/iso18626_requests - table shows "Supplying Agency ID" but links to http://main-intra.localhost/cgi-bin/koha/ill/iso18626_requests/1 in that column
This is by design. The ISO18626 request ID is the ID of the request in the Supplying Agency (i.e. Supplying Agency ID). If this is confusing I'm open to ideas on how to improve it of course.
Maybe Supplying Agency Request ID, that makes it clear its the request ID not the id of the supplying agency? In the details page the "Requesting Agency Request ID:" does specify request ID and I think that makes it clearer (should probably change both in column and details screen)
Under step 12, if we click "place hold" from this screen can there be an option to mark it as for the ill from the results place hold link (not the button, but the link by the bib)
Sorry I don't fully understand this one please clarify if possible.
When I save the hold, it just says processing and doesn't load the table. Same thing if I refresh or go to another record with non ill holds. In console: Uncaught ReferenceError: create_iso18626_request_link is not defined Same thing after checking it out for loading the checkout table -Failing SO for this,
Follow-up pushed to address this: https://github.com/openfifth/koha/commit/ 45ac09bb72008507877e794ad56e33372a61fd72 Can you please retest? Thanks!
This is working now
If you place an item level hold it will immediately go to "mark as loaned" and skips activating the hold and sending the "will supply" message. If you fill the hold it will change to will supply.
If we place an item level hold the ISO18626 request's status becomes 'ExpectToSupply'. The 'Mark as loaned' is an available action at this stage, yes. At this point, one of the following may happen: 1) 'Mark as loaned' is clicked from the ISO18626 request, a check-out will be facilitated. 2) The eligible barcode is checked-in through the circulation module, the hold confirmed, and the ISO18626 request updated to 'Will supply', as well as the corresponding message sent to the requesting agency.
The above is working as designed, but of course any suggestion of improvement or making it clearer is welcome.
Great, I just wasn't sure if that was expected and put it in since it wasn't in the test plan (I went off plan looking at other stuff)
Retry possible works, though pending requesting agency action should probably be updated from N/A to Retry or similar?
This is a valid point, but I think 'Pending requesting agency action' is ambiguous and causing confusion here, understandably. 'Pending requesting agency action' is an action performed by the Requesting Agency that then requires an action by the Supplying Agency e.g. 'Cancel' or 'Renew'. In other words, it's the opposite of what RetryPossible is. RetryPossible is triggered by the Supplying Agency and then it's the Requesting agency that must act. Maybe a better way to word 'Pending requesting agency action' would be 'Requesting agency has requested'. Better alternative suggestions here are of course appreciated.
I like "Requesting agency has requested" I think it's more clear
If you override another hold to check the item out it doesn't do the correct status update.
I was able to reproduce this issue: 1. Place an item-level hold for Henry 2. Check-in that item e.g. 39999000003130 (make it waiting) 3. Create a new ISO18626 request and 'Search to hold', place a bib-level hold on the same bib as above (for patron Walker) 4. Check-out the item from 2. 39999000003130 to Walker 5. Confirm an ISO18626 message input is shown and that the respective ISO18626 request is updated to 'Loaned' once the check-out happens (i.e. override Henry's hold).
Submitted follow-up to address this: https://github.com/openfifth/koha/commit/ 9d971b9c1c3c06248a55becbc19e55a2192c1bbd
Works great now, thanks!
Can you please retest when convenient? Thank you. I'm considering the rest of the comments as future enhancements not within immediate scope, happy to discuss further.
Agreed, I just wanted the notes somewhere folks could see until I can go file followups once this is pushed. Going to do a little more testing to confirm nothing broke from those updates, but so far it's all been good. -- You are receiving this mail because: You are watching all bug changes.