https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181970|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181988&action=edit Bug 39545: (follow-up) Apply same logic to Koha::Biblio This patch updates the Koha::Biblio->generate_marc_host_field method to more closely match the updated logic in C4::Biblio::prep_marc_host. We change a number of things including: 1) Constructinging the 773 subfield generation from a hash to an array to preserve field order. 2) Updating main entry handling for 100/110/111 fields to clone the field and then remove relevant subfields as apposed to fetching only a limited set of subfields. 3) Add handling to generate subfield 7 content depending on LDR and Main Entry information 4) Improve handling for title subfield construction from 245 to respect non-filing characters and remove trailing punctuation 5) Remove trailing punctuation from subfield b when generated from 250 6) Remove generation of subfield s from the 240 field entirely 7) Remove trailing punctuation from subfield d when generated from 260 8) Add generation of subfield k from 800-830 fields Rebased-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> We dropped the upstream aforementioned C4::Biblio method, but this patch faithfully replicates it's functionality within Koha::Biblio->generate_marc_host_field -- You are receiving this mail because: You are watching all bug changes.