https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 180572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180572&action=edit Bug 39545: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180571|0 |1 is obsolete| | Attachment #180572|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 180600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180600&action=edit Bug 39545: Better generation of 773 field for a child record (MARC21) When creating a child record (New > New child record from Normal view) the information put in field 773 is very basic, sometimes not complete (e.g. only one ISBN, only 245 $a in 773 $t, 773 $w missing 003 of the host record etc.) and put in random order. Test plan: ========== 1. Find any record to be a host record for an analytical record. You can enrich the record with multiple 020, 490+830 fields, make sure that there are 001 and 003 fields present. 2. From upper menu chose New > New child record. 3. See the generated field 773 - the subfields are incomplete and in random order. 4. Apply the patch ; restart_all. 5. Repeat p. 2.-3. See that the generated 773 field contains now much more information, including 773 $7 and also preset leader. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- We have three functions for this.. I really want to merge them at some point, but I also don't want them to fall further out of sync in the meantime. Can we also look at PrepMarcHost in the same file, and more importantly in my opinion the generate_marc_host_field method in Koha::Biblio? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181877&action=edit Bug 39545: (follow-up) Apply same logic to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |flyingendpaper@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I need a cataloguer to weight in here I'm afraid. I've used the operation of syncing this up in the Koha::Biblio method to do a deep dive back into it. I've noted all the changes explicitly in my commit message, and I'm not entirely sure they're all correct. For instance, I'm not really sure about the punctuation handling and I could see that possibly causing problems for others. I'm also not sure about the removal of subfield s handling.. maybe that needs more consideration. Finally.. I also found whilst updating unit tests, that the regular expression used for punctuation handling in the 245 work of the original patch doesn't catch trailing whitespace which doesn't feel entirely appropriate as in my findings 'as_string' adds such space. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|37305 | Depends on| |37305 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305 [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Rebasing this now, we can drop your patch entirely as the dependencies already removed that method. We can then use my patch that implements your changes against the more modern method. However, I think we're doing too much in one bug here still and we need a clear discussion around the changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181970|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181988&action=edit Bug 39545: (follow-up) Apply same logic to Koha::Biblio This patch updates the Koha::Biblio->generate_marc_host_field method to more closely match the updated logic in C4::Biblio::prep_marc_host. We change a number of things including: 1) Constructinging the 773 subfield generation from a hash to an array to preserve field order. 2) Updating main entry handling for 100/110/111 fields to clone the field and then remove relevant subfields as apposed to fetching only a limited set of subfields. 3) Add handling to generate subfield 7 content depending on LDR and Main Entry information 4) Improve handling for title subfield construction from 245 to respect non-filing characters and remove trailing punctuation 5) Remove trailing punctuation from subfield b when generated from 250 6) Remove generation of subfield s from the 240 field entirely 7) Remove trailing punctuation from subfield d when generated from 260 8) Add generation of subfield k from 800-830 fields Rebased-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> We dropped the upstream aforementioned C4::Biblio method, but this patch faithfully replicates it's functionality within Koha::Biblio->generate_marc_host_field -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 --- Comment #16 from Heather Hernandez <flyingendpaper@gmail.com> --- Retired cataloger here!! Looking at Comment 15 from Martin, all looks good with these caveats/comments: I really must object to "Remove generation of subfield s from the 240 field entirely" because VAST quantities of records have an incredibly valuable 240 that absolutely must be included in the 773, including records for Bibles, books of the Bible, laws and statutes, and translations. The preservation of this string in the 773 is essential, and frequently used--analytic records/child records are, indeed, created for these entities due to their being issued serially, for chapters/parts being used/assigned in academic settings, analytic/child records being cataloged for relevant treaties and/or conventions issued in compilations, etc. Especially for legal materials, the $s and the $t should be included together--it's normal to include both, anyway. These fields are incredibly important for academic libraries, specialized libraries, government libraries, law libraries, etc. There should also be generation of subfield d from 264, since many catalogs have newer records with a 264 while also having older records with a 260. Hope this helps!! --h2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181987|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183542&action=edit Bug 39545: Better generation of 773 field for a child record (MARC21) When creating a child record (New > New child record from Normal view) the information put in field 773 is very basic, sometimes not complete (e.g. only one ISBN, only 245 $a in 773 $t, 773 $w missing 003 of the host record etc.) and put in random order. Test plan: ========== 1. Find any record to be a host record for an analytical record. You can enrich the record with multiple 020, 490+830 fields, make sure that there are 001 and 003 fields present. 2. From upper menu chose New > New child record. 3. See the generated field 773 - the subfields are incomplete and in random order. 4. Apply the patch ; restart_all. 5. Repeat p. 2.-3. See that the generated 773 field contains now much more information, including 773 $7 and also preset leader. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Rebased-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> The rebase removed the majority of this patch as the prepare_host_field method was removed entirely upstream. The follow-up patch re-implements the same but in the newer Koha::Biblio->generate_marc_host_field method instead. We also dropped the Unit tests that were introduced in the subsequent patch. Signed-off-by: Heather Hernandez <flyingendpaper@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183544&action=edit Bug 39545: (QA follow-up) Restore 240 field processing for subfield s This patch restores the generation of subfield s from field 240 (Uniform Title) in the MARC21 773 field generation, addressing cataloger feedback about the critical importance of this field for: - Bibles and books of the Bible - Laws and statutes - Translations - Academic and specialized library materials - Legal materials and treaties The MARC21 standard defines subfield s as "Uniform title (NR)" and this data is essential for proper bibliographic relationships. This patch also fixes a warning when 245 indicator 2 contains non-numeric values by adding proper validation. Test plan: 1. Create a record with a 240 field containing uniform title data 2. Generate a child record from it 3. Verify the 773 field now contains subfield s with the uniform title 4. Run prove t/db_dependent/Koha/Biblio.t to ensure all tests pass Signed-off-by: Heather Hernandez <flyingendpaper@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183542|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183600&action=edit Bug 39545: Better generation of 773 field for a child record (MARC21) When creating a child record (New > New child record from Normal view) the information put in field 773 is very basic, sometimes not complete (e.g. only one ISBN, only 245 $a in 773 $t, 773 $w missing 003 of the host record etc.) and put in random order. Test plan: ========== 1. Find any record to be a host record for an analytical record. You can enrich the record with multiple 020, 490+830 fields, make sure that there are 001 and 003 fields present. 2. From upper menu chose New > New child record. 3. See the generated field 773 - the subfields are incomplete and in random order. 4. Apply the patch ; restart_all. 5. Repeat p. 2.-3. See that the generated 773 field contains now much more information, including 773 $7 and also preset leader. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Rebased-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> The rebase removed the majority of this patch as the prepare_host_field method was removed entirely upstream. The follow-up patch re-implements the same but in the newer Koha::Biblio->generate_marc_host_field method instead. We also dropped the Unit tests that were introduced in the subsequent patch. Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Heather Hernandez <flyingendpaper@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183544|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183602&action=edit Bug 39545: (QA follow-up) Restore 240 field processing for subfield s This patch restores the generation of subfield s from field 240 (Uniform Title) in the MARC21 773 field generation, addressing cataloger feedback about the critical importance of this field for: - Bibles and books of the Bible - Laws and statutes - Translations - Academic and specialized library materials - Legal materials and treaties The MARC21 standard defines subfield s as "Uniform title (NR)" and this data is essential for proper bibliographic relationships. This patch also fixes a warning when 245 indicator 2 contains non-numeric values by adding proper validation. Test plan: 1. Create a record with a 240 field containing uniform title data 2. Generate a child record from it 3. Verify the 773 field now contains subfield s with the uniform title 4. Run prove t/db_dependent/Koha/Biblio.t to ensure all tests pass Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Heather Hernandez <flyingendpaper@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183600|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183758&action=edit Bug 39545: Better generation of 773 field for a child record (MARC21) When creating a child record (New > New child record from Normal view) the information put in field 773 is very basic, sometimes not complete (e.g. only one ISBN, only 245 $a in 773 $t, 773 $w missing 003 of the host record etc.) and put in random order. Test plan: ========== 1. Find any record to be a host record for an analytical record. You can enrich the record with multiple 020, 490+830 fields, make sure that there are 001 and 003 fields present. 2. From upper menu chose New > New child record. 3. See the generated field 773 - the subfields are incomplete and in random order. 4. Apply the patch ; restart_all. 5. Repeat p. 2.-3. See that the generated 773 field contains now much more information, including 773 $7 and also preset leader. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Rebased-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> The rebase removed the majority of this patch as the prepare_host_field method was removed entirely upstream. The follow-up patch re-implements the same but in the newer Koha::Biblio->generate_marc_host_field method instead. We also dropped the Unit tests that were introduced in the subsequent patch. Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Heather Hernandez <flyingendpaper@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183602|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183760&action=edit Bug 39545: (QA follow-up) Restore 240 field processing for subfield s This patch restores the generation of subfield s from field 240 (Uniform Title) in the MARC21 773 field generation, addressing cataloger feedback about the critical importance of this field for: - Bibles and books of the Bible - Laws and statutes - Translations - Academic and specialized library materials - Legal materials and treaties The MARC21 standard defines subfield s as "Uniform title (NR)" and this data is essential for proper bibliographic relationships. This patch also fixes a warning when 245 indicator 2 contains non-numeric values by adding proper validation. Test plan: 1. Create a record with a 240 field containing uniform title data 2. Generate a child record from it 3. Verify the 773 field now contains subfield s with the uniform title 4. Run prove t/db_dependent/Koha/Biblio.t to ensure all tests pass Sponsored-by: Open Fifth <https://openfifth.co.uk> Signed-off-by: Heather Hernandez <flyingendpaper@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22439 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22439 [Bug 22439] Duplicated code in PrepHostMarcField and prepare_host_field -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 --- Comment #27 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|34482 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 --- Comment #29 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett@familysearch | |.org --- Comment #31 from Angela Berrett <angela.berrett@familysearch.org> --- Is this a syspref that we can turn off? We do not need the $7 info and having the 003 host record information is messing up our OAI export - we still want the 001, just not the 003 in front of it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.