http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 Bug ID: 10876 Summary: opac-MARCdetail.pl display items intended for hiding Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org The opac/opac-MARCdetail.pl file is what is viewed when "MARC view" is clicked while viewing a specific search result. Items hidden on opac/opac-detail.pl based on OpacHiddenItems are shown! This should not happen. I believe this bug goes back several versions, not just master. While coding this, a lack of use or require in C4::Items was discovered. See bug 10872. By adding calls to GetItemsInfo and GetHiddenItems, a filter on the items is placed. As this is processing MARC data, GetMarcFromKohaField was used to properly determine what the item number (952$9) is. Test Plan ========= 1) Find a biblio with multiple items. (e.g. a book with multiple branches) 2) Look it up in OPAC 3) View the details. 4) In the staff client, set the OpacHiddenItems system preference to hide some of the data. (e.g. homebranch: [BRANCH2HIDE]) 5) Refresh the OPAC 6) Some of the details should be hidden now. Save this URL for later (e.g. http://..../opac-detail.pl?biblionumber=#####) 7) Click the MARC view. 8) All the items are showing. 9) Apply patch from 10872 10) Apply this patch 11) Refresh the OPAC 12) The MARC view should now only show the same things the normal view shows. 13) In the staff client hide all the items for this record using OpacHiddenItems. (e.g. homebranch: [BRANCH1,BRANCH2,BRANCH3]) 14) Refresh the OPAC 15) There should be a "404.pl" displayed. 16) Paste the URL saved in step 6. 17) There should be a "404.pl" displayed. 18) In the staff client blank the OpacHiddenItems system preference. 19) Paste the URL saved in step 6. 20) All the items should be displayed in normal view. 21) Click the MARC view and all the items should be displayed. -- You are receiving this mail because: You are watching all bug changes.