[Bug 10876] New: opac-MARCdetail.pl display items intended for hiding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 Bug ID: 10876 Summary: opac-MARCdetail.pl display items intended for hiding Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org The opac/opac-MARCdetail.pl file is what is viewed when "MARC view" is clicked while viewing a specific search result. Items hidden on opac/opac-detail.pl based on OpacHiddenItems are shown! This should not happen. I believe this bug goes back several versions, not just master. While coding this, a lack of use or require in C4::Items was discovered. See bug 10872. By adding calls to GetItemsInfo and GetHiddenItems, a filter on the items is placed. As this is processing MARC data, GetMarcFromKohaField was used to properly determine what the item number (952$9) is. Test Plan ========= 1) Find a biblio with multiple items. (e.g. a book with multiple branches) 2) Look it up in OPAC 3) View the details. 4) In the staff client, set the OpacHiddenItems system preference to hide some of the data. (e.g. homebranch: [BRANCH2HIDE]) 5) Refresh the OPAC 6) Some of the details should be hidden now. Save this URL for later (e.g. http://..../opac-detail.pl?biblionumber=#####) 7) Click the MARC view. 8) All the items are showing. 9) Apply patch from 10872 10) Apply this patch 11) Refresh the OPAC 12) The MARC view should now only show the same things the normal view shows. 13) In the staff client hide all the items for this record using OpacHiddenItems. (e.g. homebranch: [BRANCH1,BRANCH2,BRANCH3]) 14) Refresh the OPAC 15) There should be a "404.pl" displayed. 16) Paste the URL saved in step 6. 17) There should be a "404.pl" displayed. 18) In the staff client blank the OpacHiddenItems system preference. 19) Paste the URL saved in step 6. 20) All the items should be displayed in normal view. 21) Click the MARC view and all the items should be displayed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 20985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20985&action=edit Bug 10876 - MARC view displays what should be hidden The opac/opac-MARCdetail.pl file is what is viewed when "MARC view" is clicked while viewing a specific search result. Items hidden on opac/opac-detail.pl based on OpacHiddenItems are shown! This should not happen. I believe this bug goes back several versions, not just master. While coding this, a lack of use or require in C4::Items was discovered. See bug 10872. By adding calls to GetItemsInfo and GetHiddenItems, a filter on the items is placed. As this is processing MARC data, GetMarcFromKohaField was used to properly determine what the item number (952$9) is. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10872 Assignee|oleonard@myacpl.org |mtompset@hotmail.com Summary|opac-MARCdetail.pl display |MARC view displays what |items intended for hiding |should be hidden -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart@biblibre.co | |m Depends on| |10872 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch should be rebased on bug 10872. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- I tried to fix the conflict but the behavior is not what you described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- I hadn't gotten to fixing this one yet. Basically, this adds a next if check into a loop that builds the %this_row stuff, and would require bug 10872 and 10584 to be applied. I'll be fixing this up shortly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 21079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21079&action=edit Bug 10876 - Fix opac-MARCdetail.pl partial hides When OpacHiddenItems is used to hide some, but not all of the items for a biblio, then the opac-MARCdetail page displayed all the items, rather than just the ones intended to be visible. By determining the tag and subtag for items.itemnumber, the loop which builds the big array can be filtered to exclude records that should be hidden. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20985|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21079|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 21082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21082&action=edit Fix opac-MARCdetail.pl partial hides Test Plan ========= 1) Find a biblio with multiple items. (e.g. a book with multiple branches) 2) Look it up in OPAC 3) View the details. 4) Normal view and MARC view should have the identical number of items. (Normal view: http://..../opac-detail.pl?biblionumber=#####) (MARC view: http://..../opac-MARCdetail.pl?biblionumber=#####) 5) In the staff client, set the OpacHiddenItems system preference to hide some of the data. (e.g. homebranch: [BRANCH2HIDE]) NOTE: if your multiple items are all the same branch, find another distinguishing feature to hide on. The goal is to hide some but not all items for this biblio. 5) Refresh the OPAC 6) Some of the details should be hidden now in Normal view, but not MARC view. 7) Click the MARC view. 8) All the items are showing. 9) Apply patches from 10872, 10584 10) Apply this patch 11) Refresh the OPAC 12) The MARC view should now only show the same things the normal view shows. (Normal view: http://..../opac-detail.pl?biblionumber=#####) (MARC view: http://..../opac-MARCdetail.pl?biblionumber=#####) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10872 |10584 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|MARC view displays what |Fix opac-MARCdetail.pl |should be hidden |partial hides -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21082|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 21122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21122&action=edit Bug 10876 - Fix opac-MARCdetail.pl partial hides When OpacHiddenItems is used to hide some, but not all of the items for a biblio, then the opac-MARCdetail page displayed all the items, rather than just the ones intended to be visible. By determining the tag and subtag for items.itemnumber, the loop which builds the big array can be filtered to exclude records that should be hidden. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Works as expected, passes koha-qa also. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21122|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21135&action=edit Bug 10876 - Fix opac-MARCdetail.pl partial hides When OpacHiddenItems is used to hide some, but not all of the items for a biblio, then the opac-MARCdetail page displayed all the items, rather than just the ones intended to be visible. By determining the tag and subtag for items.itemnumber, the loop which builds the big array can be filtered to exclude records that should be hidden. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Works as expected, passes koha-qa also. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- The patch depends on bug 10584 and bug 10872. Works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mark! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- *** Bug 10194 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10584 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org