https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA comments: # TODO This module should be based on Koha::Object[s] This is very true indeed. But not the scope of this report. But we feel it here. Looking at various subroutines in Koha/Patron/Discharge I am wondering if we need to also check cancelled now. sub count ? sub get_pendings ? sub get_validated ? Not sure if we get bitten by that omission somewhere else. Intuitively, I tend to think so. Can we fix the sign-off lines? Or do we need another signoff for testing? Apart from the above and looking at some git greps with discharge, this feels safe enough to get further. -- You are receiving this mail because: You are watching all bug changes.