https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #278 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to David Nind from comment #257)
Thanks Martin for fixing all these things!
On retesting, some more issues (sorry!).
1. Error on OPAC - there looks to be something wrong with the patch 'Add feedback to the patron on submission':
Damn, I missed a comma in the rebuse just prior to uploading that last set of patches.. resolved now.
2. Staff interface home page display - "Catalog concerns pending: X": - If CatalogConcerns is not enabled, then this doesn't display (not expected - would expect it to display if staff user can manage catalog concerns) - If there are active purchase suggestions, problem reports, article requests, and allow checkout notes (with these system preferences enabled), it does display (tested various combinations, and ended up confusing myself!) - If purchase suggestions, problem reports, article requests, and allow checkout notes are not enabled (or there are no active requests), then it doesn't display catalog concerns pending
So the conditions here are 'IF ( CatalogConcerns is enabled OR OpacCatalogConcerns is enabled ) AND there are pending concerns AND the user has the edit_catalog permission DISPLAY the pending concerns count'. I'm wondering if we got a database update mixed in somewhere a long the lines or something here. I just tested this with a fresh k-t-d running just the db update and yarn builds and it appears to work as expected for me.
3. Notices:
3.1 TICKET_ACKNOWLEDGE notice: . there are lots of extra lines in the message, not sure whether that is something to do with using Gmail to test or not [1] . there is a span tag visible around the record name . If I select HTML message for the notice, it comes through as one line . This is similar for the other notices (and non-catalog concern notices as well) - it maybe something more generic with my setup/HTML email message generation
I've updated the final patch to go back to html emails and I've replaced the \r\n with <br>.. hopefully that'll resolve this one.
3.2 TICKET_NOTIFY notice - warning in the /var/log/koha/kohadev/plack-api-error.log: [2022/11/04 19:36:16] [WARN] No catalog TICKET_NOTIFY letter transported by email at /kohadevbox/koha/C4/Letters.pm line 584. . This warning may explain why I'm not receiving the TICKET_NOTIFY notices, I'm assuming it is probably a combination of system preferences and the mail setup using Gmail to send notices
Hmm.. wonder if this was again a mix up in the database updates.. running this in a fresh k-t-d now to try to replicate.
3.3 Patron sent notices: I'm now only seeing the catalog concern acknowledgements notice under the patron's notices (previously I was only seeing 'Catalog concern updated' and 'Catalog concern resolved' notices)
These only send when 'Notify' is set.. I'm testing this in k-t-d again now myself. -- You are receiving this mail because: You are watching all bug changes.