[Bug 31028] New: Enhance 'Report a problem' to specify catalogue problems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Bug ID: 31028 Summary: Enhance 'Report a problem' to specify catalogue problems Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Currently we have a generic 'Report a problem' link at the bottom of all pages on the OPAC.. however there's no easy way to report a problem about a specific biblio. We could add a more specific 'Report a problem with this record' option on the details display and record the biblionumber so staff can quickly see the record in context. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 [Bug 4461] Add a context-sensitive report a problem process -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25466 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137412&action=edit Specification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've opted to specify this as an independence feature.. it more closely resembled checkout notes from a workflow perspective than it does the opac problem reports system and the sponsor wanted to be able to enabled/disable the features separately. I can see a route to merging the checkout notes feature into this piece as part of a modernisation effort at a later date too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Enhance 'Report a problem' |Add 'Report a concern' |to specify catalogue |feature for patrons to |problems |report concerns about | |catalogue records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|4461 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 [Bug 4461] Add a context-sensitive report a problem process -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=25466 |?id=31123 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/mrenvoiz | |e/Koha/-/tree/bug_31028 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add 'Report a concern' |Add 'Report a concern' |feature for patrons to |feature for patrons to |report concerns about |report concerns about |catalogue records |catalog records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139222&action=edit Bug 31028: Add catalog_concerns table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139223&action=edit Bug 31028: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139224&action=edit Bug 31028: Add `CatalogConcerns` and `OpacCatalogConcerns` preferences This patch adds the `CatalogConcerns` and `OpacCatalogeConcerns` system preferences to enable/disable the catalog concerns feature on the OPAC and Staff client interfaces. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139225&action=edit Bug 31028: Add catalog concerns endpoints This patch adds the staff accessible REST API endpoints for catalog concerns. New endpoints available: * POST /catalog/concerns * GET /catalog/concerns * GET /catalog/concerns/{concern_id} * PUT /catalog/concerns/{concern_id} * DELETE /catalog/concenrs/{concern_id} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139226&action=edit Bug 31028: Add relations to Catalog::Concern This patch adds the reporter, resolver and biblio relations to the Catalog::Concern class and exposes them to the API as appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139227&action=edit Bug 31028: Add Public API endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139228&action=edit Bug 31028: Add 'Report a concern' to OPAC details This patch adds a new 'Report a concern' option to the right sidebar on the opac detail page. On clicking the link, a modal will display allowing the user to enter a short message regarding their concerns and then submission will record said message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139229&action=edit Bug 31028: Trigger login modal when not logged in This isn't perfect, we detect if there is a logged in user on the OPAC and replace the concern report modal with the login modal if we don't find a valid session. Unfortunelty, we can't then trigger a redirect back to the record details as that's not how our get_template_and_user authentication system works.. instead we end up back at opac-user.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139230&action=edit Bug 31028: Tie OPAC display to logged in state This is an alternative to th previous patch.. we can't easily redirect back to the right location after login from our modal. It would be preferable to display the button and prompt a login if we don't have a valid session.. but that's not trivial using the API's and our login flows at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139231&action=edit Bug 31028: Add a catalog concerns management page This patch adds a new cataloguing concerns page to the staff client for managing reported catalog concerns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139232&action=edit Bug 31028: Add 'special:undefined' to handle passing 'null' We can't pass 'null' to the column.search as it gets stringified. This patch adds a special string 'special:undefined' to denote that we want to search on undef for the field in question. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139233&action=edit Bug 31028: Add filters to concerns management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139234&action=edit Bug 31028: Add resolution endpoint This patch adds a /resolve endpoint to the catalog concerns endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139235&action=edit Bug 31028: Add resolve action This patch adds a resolution workflow to the catalog concerns management page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139236&action=edit Bug 31028: Add 'Add catalog concern' to cataloguing toolbar This patch moves the add concern modal js and template markup into their own files and then references them to add the 'Add concern' option to the cataloguing toolbar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139237&action=edit Bug 31028: Add notice trigger for catalog concerns This patch adds a new system prefernce, `CatalogerEmails`. If set with a valid email address adding a new catalog concern should produce a notification email sent to that address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139238&action=edit Bug 31028: Add trigger and notice to resolve This patch adds a sample notice and sets up the trigger to notify the concern reporter when a concern is marked as resolved. The notification itself is optional at resolve time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- The text in the template, "A short summary of what the library policy is for dealing with such concerns and what constitutes a valid concern" should be customizable via Additional Contents -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- * Should we prevent the user from submitting more than one concern on a record? I'm thinking in particular about how this feature might be abused. * The breadcrumbs on the page say Cataloging > Concerns, but currently the feature is only accessible via tools or the home page. I would probably pick tools for now and maybe revise that choice after the new cataloging home page arrives? Same with the sidebar menu. * I get an error in the browser console when I click "Configure" on the datatable on the catalog concerns page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Owen Leonard from comment #21)
* Should we prevent the user from submitting more than one concern on a record? I'm thinking in particular about how this feature might be abused.
That's probably a good idea, though I don't think we do anything like this for OPAC Problem Reports which could face similar abuse. I'd be tempted to add this as a follow-up bug to keep the submission here a little smaller if you'd be happy with that?
* The breadcrumbs on the page say Cataloging > Concerns, but currently the feature is only accessible via tools or the home page. I would probably pick tools for now and maybe revise that choice after the new cataloging home page arrives? Same with the sidebar menu.
Good point.. Adding a link to tools was somewhat of an afterthought to be honest.. I initially only exposed it via the 'Pending catalog concerns' display on the main page. I can strip those bits out here, though it could also lead to code inconsistencies as the templates and controllers live under /cataloguing at the moment.
* I get an error in the browser console when I click "Configure" on the datatable on the catalog concerns page.
Oh, good catch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139222|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139572&action=edit Bug 31028: Add catalog_concerns table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139223|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139573&action=edit Bug 31028: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139224|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139574&action=edit Bug 31028: Add `CatalogConcerns` and `OpacCatalogConcerns` preferences This patch adds the `CatalogConcerns` and `OpacCatalogeConcerns` system preferences to enable/disable the catalog concerns feature on the OPAC and Staff client interfaces. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139225|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139575&action=edit Bug 31028: Add catalog concerns endpoints This patch adds the staff accessible REST API endpoints for catalog concerns. New endpoints available: * POST /catalog/concerns * GET /catalog/concerns * GET /catalog/concerns/{concern_id} * PUT /catalog/concerns/{concern_id} * DELETE /catalog/concenrs/{concern_id} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139226|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139576&action=edit Bug 31028: Add relations to Catalog::Concern This patch adds the reporter, resolver and biblio relations to the Catalog::Concern class and exposes them to the API as appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139227|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139577&action=edit Bug 31028: Add Public API endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139228|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139578&action=edit Bug 31028: Add 'Report a concern' to OPAC details This patch adds a new 'Report a concern' option to the right sidebar on the opac detail page. On clicking the link, a modal will display allowing the user to enter a short message regarding their concerns and then submission will record said message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139229|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139579&action=edit Bug 31028: Trigger login modal when not logged in This isn't perfect, we detect if there is a logged in user on the OPAC and replace the concern report modal with the login modal if we don't find a valid session. Unfortunelty, we can't then trigger a redirect back to the record details as that's not how our get_template_and_user authentication system works.. instead we end up back at opac-user.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139230|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139580&action=edit Bug 31028: Tie OPAC display to logged in state This is an alternative to th previous patch.. we can't easily redirect back to the right location after login from our modal. It would be preferable to display the button and prompt a login if we don't have a valid session.. but that's not trivial using the API's and our login flows at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139231|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139581&action=edit Bug 31028: Add a catalog concerns management page This patch adds a new cataloguing concerns page to the staff client for managing reported catalog concerns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139232|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139582&action=edit Bug 31028: Add 'special:undefined' to handle passing 'null' We can't pass 'null' to the column.search as it gets stringified. This patch adds a special string 'special:undefined' to denote that we want to search on undef for the field in question. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139233|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139583&action=edit Bug 31028: Add filters to concerns management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139234|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139584&action=edit Bug 31028: Add resolution endpoint This patch adds a /resolve endpoint to the catalog concerns endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139235|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139585&action=edit Bug 31028: Add resolve action This patch adds a resolution workflow to the catalog concerns management page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139236|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139586&action=edit Bug 31028: Add 'Add catalog concern' to cataloguing toolbar This patch moves the add concern modal js and template markup into their own files and then references them to add the 'Add concern' option to the cataloguing toolbar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139237|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139587&action=edit Bug 31028: Add notice trigger for catalog concerns This patch adds a new system prefernce, `CatalogerEmails`. If set with a valid email address adding a new catalog concern should produce a notification email sent to that address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139238|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139588&action=edit Bug 31028: Add trigger and notice to resolve This patch adds a sample notice and sets up the trigger to notify the concern reporter when a concern is marked as resolved. The notification itself is optional at resolve time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139589&action=edit Bug 31028: (QA follow-up) This is a 'tool' At the moment, this feature is accessible under tools only rather than cataloging. Whilst we await the new cataloging homepage and sidebar this path replaces the breadcrumb with 'Tools' and removes the 'cat-menu' include. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139590&action=edit Bug 31028: (QA follow-up) Table configuration This patch properly adds the table configuration options to the catalog concerns table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139591&action=edit Bug 31028: Use additional_contents for help block This patch updates the modal to use the additional_contents system for the modals help block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for testing Owen.. I think that should deal with all but one of your pieces of feedback.. the final one as noted I think should be on it's own bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31373 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139572|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140289&action=edit Bug 31028: Add catalog_concerns table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139573|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140290&action=edit Bug 31028: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139574|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140291&action=edit Bug 31028: Add `CatalogConcerns` and `OpacCatalogConcerns` preferences This patch adds the `CatalogConcerns` and `OpacCatalogeConcerns` system preferences to enable/disable the catalog concerns feature on the OPAC and Staff client interfaces. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139575|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140292&action=edit Bug 31028: Add catalog concerns endpoints This patch adds the staff accessible REST API endpoints for catalog concerns. New endpoints available: * POST /catalog/concerns * GET /catalog/concerns * GET /catalog/concerns/{concern_id} * PUT /catalog/concerns/{concern_id} * DELETE /catalog/concenrs/{concern_id} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139576|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140293&action=edit Bug 31028: Add relations to Catalog::Concern This patch adds the reporter, resolver and biblio relations to the Catalog::Concern class and exposes them to the API as appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139577|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140294&action=edit Bug 31028: Add Public API endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139578|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140295&action=edit Bug 31028: Add 'Report a concern' to OPAC details This patch adds a new 'Report a concern' option to the right sidebar on the opac detail page. On clicking the link, a modal will display allowing the user to enter a short message regarding their concerns and then submission will record said message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139579|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140296&action=edit Bug 31028: Trigger login modal when not logged in This isn't perfect, we detect if there is a logged in user on the OPAC and replace the concern report modal with the login modal if we don't find a valid session. Unfortunelty, we can't then trigger a redirect back to the record details as that's not how our get_template_and_user authentication system works.. instead we end up back at opac-user.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139580|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140297&action=edit Bug 31028: Tie OPAC display to logged in state This is an alternative to th previous patch.. we can't easily redirect back to the right location after login from our modal. It would be preferable to display the button and prompt a login if we don't have a valid session.. but that's not trivial using the API's and our login flows at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139581|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140298&action=edit Bug 31028: Add a catalog concerns management page This patch adds a new cataloguing concerns page to the staff client for managing reported catalog concerns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139582|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140299&action=edit Bug 31028: Add 'special:undefined' to handle passing 'null' We can't pass 'null' to the column.search as it gets stringified. This patch adds a special string 'special:undefined' to denote that we want to search on undef for the field in question. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139583|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140300&action=edit Bug 31028: Add filters to concerns management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139584|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140301&action=edit Bug 31028: Add resolution endpoint This patch adds a /resolve endpoint to the catalog concerns endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139585|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140302&action=edit Bug 31028: Add resolve action This patch adds a resolution workflow to the catalog concerns management page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139586|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140303&action=edit Bug 31028: Add 'Add catalog concern' to cataloguing toolbar This patch moves the add concern modal js and template markup into their own files and then references them to add the 'Add concern' option to the cataloguing toolbar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139587|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140304&action=edit Bug 31028: Add notice trigger for catalog concerns This patch adds a new system prefernce, `CatalogerEmails`. If set with a valid email address adding a new catalog concern should produce a notification email sent to that address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139588|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140305&action=edit Bug 31028: Add trigger and notice to resolve This patch adds a sample notice and sets up the trigger to notify the concern reporter when a concern is marked as resolved. The notification itself is optional at resolve time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139589|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140306&action=edit Bug 31028: (QA follow-up) This is a 'tool' At the moment, this feature is accessible under tools only rather than cataloging. Whilst we await the new cataloging homepage and sidebar this path replaces the breadcrumb with 'Tools' and removes the 'cat-menu' include. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139590|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140307&action=edit Bug 31028: (QA follow-up) Table configuration This patch properly adds the table configuration options to the catalog concerns table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139591|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140308&action=edit Bug 31028: Use additional_contents for help block This patch updates the modal to use the additional_contents system for the modals help block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140289|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140436&action=edit Bug 31028: Add catalog_concerns table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140290|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140437&action=edit Bug 31028: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140291|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140438&action=edit Bug 31028: Add `CatalogConcerns` and `OpacCatalogConcerns` preferences This patch adds the `CatalogConcerns` and `OpacCatalogeConcerns` system preferences to enable/disable the catalog concerns feature on the OPAC and Staff client interfaces. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140292|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140439&action=edit Bug 31028: Add catalog concerns endpoints This patch adds the staff accessible REST API endpoints for catalog concerns. New endpoints available: * POST /catalog/concerns * GET /catalog/concerns * GET /catalog/concerns/{concern_id} * PUT /catalog/concerns/{concern_id} * DELETE /catalog/concenrs/{concern_id} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140293|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140440&action=edit Bug 31028: Add relations to Catalog::Concern This patch adds the reporter, resolver and biblio relations to the Catalog::Concern class and exposes them to the API as appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140294|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140441&action=edit Bug 31028: Add Public API endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140295|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140442&action=edit Bug 31028: Add 'Report a concern' to OPAC details This patch adds a new 'Report a concern' option to the right sidebar on the opac detail page. On clicking the link, a modal will display allowing the user to enter a short message regarding their concerns and then submission will record said message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140296|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140443&action=edit Bug 31028: Trigger login modal when not logged in This isn't perfect, we detect if there is a logged in user on the OPAC and replace the concern report modal with the login modal if we don't find a valid session. Unfortunelty, we can't then trigger a redirect back to the record details as that's not how our get_template_and_user authentication system works.. instead we end up back at opac-user.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140297|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140444&action=edit Bug 31028: Tie OPAC display to logged in state This is an alternative to th previous patch.. we can't easily redirect back to the right location after login from our modal. It would be preferable to display the button and prompt a login if we don't have a valid session.. but that's not trivial using the API's and our login flows at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140298|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140445&action=edit Bug 31028: Add a catalog concerns management page This patch adds a new cataloguing concerns page to the staff client for managing reported catalog concerns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140299|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140446&action=edit Bug 31028: Add 'special:undefined' to handle passing 'null' We can't pass 'null' to the column.search as it gets stringified. This patch adds a special string 'special:undefined' to denote that we want to search on undef for the field in question. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140300|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140447&action=edit Bug 31028: Add filters to concerns management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140301|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140448&action=edit Bug 31028: Add resolution endpoint This patch adds a /resolve endpoint to the catalog concerns endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140302|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140449&action=edit Bug 31028: Add resolve action This patch adds a resolution workflow to the catalog concerns management page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140303|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140450&action=edit Bug 31028: Add 'Add catalog concern' to cataloguing toolbar This patch moves the add concern modal js and template markup into their own files and then references them to add the 'Add concern' option to the cataloguing toolbar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140304|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140451&action=edit Bug 31028: Add notice trigger for catalog concerns This patch adds a new system prefernce, `CatalogerEmails`. If set with a valid email address adding a new catalog concern should produce a notification email sent to that address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140305|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140452&action=edit Bug 31028: Add trigger and notice to resolve This patch adds a sample notice and sets up the trigger to notify the concern reporter when a concern is marked as resolved. The notification itself is optional at resolve time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140306|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140453&action=edit Bug 31028: (QA follow-up) This is a 'tool' At the moment, this feature is accessible under tools only rather than cataloging. Whilst we await the new cataloging homepage and sidebar this path replaces the breadcrumb with 'Tools' and removes the 'cat-menu' include. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140307|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140454&action=edit Bug 31028: (QA follow-up) Table configuration This patch properly adds the table configuration options to the catalog concerns table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140308|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140455&action=edit Bug 31028: Use additional_contents for help block This patch updates the modal to use the additional_contents system for the modals help block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |holiver@tavi-port.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140436|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140764&action=edit Bug 31028: Add catalog_concerns table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140437|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140765&action=edit Bug 31028: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140438|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140766&action=edit Bug 31028: Add `CatalogConcerns` and `OpacCatalogConcerns` preferences This patch adds the `CatalogConcerns` and `OpacCatalogeConcerns` system preferences to enable/disable the catalog concerns feature on the OPAC and Staff client interfaces. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140439|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140767&action=edit Bug 31028: Add catalog concerns endpoints This patch adds the staff accessible REST API endpoints for catalog concerns. New endpoints available: * POST /catalog/concerns * GET /catalog/concerns * GET /catalog/concerns/{concern_id} * PUT /catalog/concerns/{concern_id} * DELETE /catalog/concenrs/{concern_id} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140440|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140768&action=edit Bug 31028: Add relations to Catalog::Concern This patch adds the reporter, resolver and biblio relations to the Catalog::Concern class and exposes them to the API as appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140441|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140769&action=edit Bug 31028: Add Public API endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140442|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140770&action=edit Bug 31028: Add 'Report a concern' to OPAC details This patch adds a new 'Report a concern' option to the right sidebar on the opac detail page. On clicking the link, a modal will display allowing the user to enter a short message regarding their concerns and then submission will record said message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140443|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140771&action=edit Bug 31028: Trigger login modal when not logged in This isn't perfect, we detect if there is a logged in user on the OPAC and replace the concern report modal with the login modal if we don't find a valid session. Unfortunelty, we can't then trigger a redirect back to the record details as that's not how our get_template_and_user authentication system works.. instead we end up back at opac-user.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140444|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140772&action=edit Bug 31028: Tie OPAC display to logged in state This is an alternative to th previous patch.. we can't easily redirect back to the right location after login from our modal. It would be preferable to display the button and prompt a login if we don't have a valid session.. but that's not trivial using the API's and our login flows at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140445|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140773&action=edit Bug 31028: Add a catalog concerns management page This patch adds a new cataloguing concerns page to the staff client for managing reported catalog concerns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140446|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140774&action=edit Bug 31028: Add 'special:undefined' to handle passing 'null' We can't pass 'null' to the column.search as it gets stringified. This patch adds a special string 'special:undefined' to denote that we want to search on undef for the field in question. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140447|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140775&action=edit Bug 31028: Add filters to concerns management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140448|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140776&action=edit Bug 31028: Add resolution endpoint This patch adds a /resolve endpoint to the catalog concerns endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140449|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140777&action=edit Bug 31028: Add resolve action This patch adds a resolution workflow to the catalog concerns management page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140450|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140778&action=edit Bug 31028: Add 'Add catalog concern' to cataloguing toolbar This patch moves the add concern modal js and template markup into their own files and then references them to add the 'Add concern' option to the cataloguing toolbar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140451|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140779&action=edit Bug 31028: Add notice trigger for catalog concerns This patch adds a new system prefernce, `CatalogerEmails`. If set with a valid email address adding a new catalog concern should produce a notification email sent to that address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140452|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140780&action=edit Bug 31028: Add trigger and notice to resolve This patch adds a sample notice and sets up the trigger to notify the concern reporter when a concern is marked as resolved. The notification itself is optional at resolve time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140453|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140781&action=edit Bug 31028: (QA follow-up) This is a 'tool' At the moment, this feature is accessible under tools only rather than cataloging. Whilst we await the new cataloging homepage and sidebar this path replaces the breadcrumb with 'Tools' and removes the 'cat-menu' include. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140454|0 |1 is obsolete| | --- Comment #102 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140782&action=edit Bug 31028: (QA follow-up) Table configuration This patch properly adds the table configuration options to the catalog concerns table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140455|0 |1 is obsolete| | --- Comment #103 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140783&action=edit Bug 31028: Use additional_contents for help block This patch updates the modal to use the additional_contents system for the modals help block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #104 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased.. again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #105 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140793&action=edit Bug 31028: Add concerns tab to biblio details display This patch adds a 'Concerns' tab to the catalogue/detail display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #106 from Owen Leonard <oleonard@myacpl.org> --- This seems to be working well but I've found one bug: The "Hide resolved" control doesn't work -- I get a JavaScript error in the console. Some cosmetic issues that I'd like to see resolved: - The page title updated to match the breadcrumbs - The tools sidebar should be included on the page - The tools sidebar should be updated to include the link to Concerns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #107 from Owen Leonard <oleonard@myacpl.org> --- Also, this file is updated: koha-tmpl/intranet-tmpl/prog/en/includes/cat-menu.inc Is it used anywhere? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #108 from Owen Leonard <oleonard@myacpl.org> --- One more: The new system preferences should link to each other instead of showing the preference in plain text, e.g. `OpacCatalogConcerns`. It should be a link. See UsageStatsLibraryName for example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140764|0 |1 is obsolete| | --- Comment #109 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140929&action=edit Bug 31028: Add catalog_concerns table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140765|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140930&action=edit Bug 31028: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140766|0 |1 is obsolete| | --- Comment #111 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140931&action=edit Bug 31028: Add `CatalogConcerns` and `OpacCatalogConcerns` preferences This patch adds the `CatalogConcerns` and `OpacCatalogeConcerns` system preferences to enable/disable the catalog concerns feature on the OPAC and Staff client interfaces. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140767|0 |1 is obsolete| | --- Comment #112 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140932&action=edit Bug 31028: Add catalog concerns endpoints This patch adds the staff accessible REST API endpoints for catalog concerns. New endpoints available: * POST /catalog/concerns * GET /catalog/concerns * GET /catalog/concerns/{concern_id} * PUT /catalog/concerns/{concern_id} * DELETE /catalog/concenrs/{concern_id} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140768|0 |1 is obsolete| | --- Comment #113 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140933&action=edit Bug 31028: Add relations to Catalog::Concern This patch adds the reporter, resolver and biblio relations to the Catalog::Concern class and exposes them to the API as appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140769|0 |1 is obsolete| | --- Comment #114 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140934&action=edit Bug 31028: Add Public API endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140770|0 |1 is obsolete| | --- Comment #115 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140935&action=edit Bug 31028: Add 'Report a concern' to OPAC details This patch adds a new 'Report a concern' option to the right sidebar on the opac detail page. On clicking the link, a modal will display allowing the user to enter a short message regarding their concerns and then submission will record said message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140771|0 |1 is obsolete| | --- Comment #116 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140936&action=edit Bug 31028: Trigger login modal when not logged in This isn't perfect, we detect if there is a logged in user on the OPAC and replace the concern report modal with the login modal if we don't find a valid session. Unfortunelty, we can't then trigger a redirect back to the record details as that's not how our get_template_and_user authentication system works.. instead we end up back at opac-user.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140772|0 |1 is obsolete| | --- Comment #117 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140937&action=edit Bug 31028: Tie OPAC display to logged in state This is an alternative to th previous patch.. we can't easily redirect back to the right location after login from our modal. It would be preferable to display the button and prompt a login if we don't have a valid session.. but that's not trivial using the API's and our login flows at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140773|0 |1 is obsolete| | --- Comment #118 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140938&action=edit Bug 31028: Add a catalog concerns management page This patch adds a new cataloguing concerns page to the staff client for managing reported catalog concerns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140774|0 |1 is obsolete| | --- Comment #119 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140939&action=edit Bug 31028: Add 'special:undefined' to handle passing 'null' We can't pass 'null' to the column.search as it gets stringified. This patch adds a special string 'special:undefined' to denote that we want to search on undef for the field in question. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140775|0 |1 is obsolete| | --- Comment #120 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140940&action=edit Bug 31028: Add filters to concerns management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140776|0 |1 is obsolete| | --- Comment #121 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140941&action=edit Bug 31028: Add resolution endpoint This patch adds a /resolve endpoint to the catalog concerns endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140777|0 |1 is obsolete| | --- Comment #122 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140942&action=edit Bug 31028: Add resolve action This patch adds a resolution workflow to the catalog concerns management page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140778|0 |1 is obsolete| | --- Comment #123 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140943&action=edit Bug 31028: Add 'Add catalog concern' to cataloguing toolbar This patch moves the add concern modal js and template markup into their own files and then references them to add the 'Add concern' option to the cataloguing toolbar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140779|0 |1 is obsolete| | --- Comment #124 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140944&action=edit Bug 31028: Add notice trigger for catalog concerns This patch adds a new system prefernce, `CatalogerEmails`. If set with a valid email address adding a new catalog concern should produce a notification email sent to that address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140780|0 |1 is obsolete| | --- Comment #125 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140945&action=edit Bug 31028: Add trigger and notice to resolve This patch adds a sample notice and sets up the trigger to notify the concern reporter when a concern is marked as resolved. The notification itself is optional at resolve time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140781|0 |1 is obsolete| | --- Comment #126 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140946&action=edit Bug 31028: (QA follow-up) This is a 'tool' At the moment, this feature is accessible under tools rather than cataloging. Whilst we await the new cataloging homepage and sidebar this patch replaces the breadcrumb and title with 'Tools', replaces the 'cat-menu' include with 'tools-menu' and adds the 'Catalog concerns' tool to the tools-menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140782|0 |1 is obsolete| | --- Comment #127 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140947&action=edit Bug 31028: (QA follow-up) Table configuration This patch properly adds the table configuration options to the catalog concerns table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140783|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140948&action=edit Bug 31028: Use additional_contents for help block This patch updates the modal to use the additional_contents system for the modals help block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140793|0 |1 is obsolete| | --- Comment #129 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140949&action=edit Bug 31028: Add concerns tab to biblio details display This patch adds a 'Concerns' tab to the catalogue/detail display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #130 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140950&action=edit Bug 31028: Crosslink preferences This patch adds crosslinks to the CatalogConcerns and OpacCatalogConcerns system preferences. We also slightly update the wording of OpacCatalogConcerns to clarify intent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #131 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Owen Leonard from comment #106)
This seems to be working well but I've found one bug:
The "Hide resolved" control doesn't work -- I get a JavaScript error in the console.
This was a rebase issue.. now fixed inline in the refreshed patches
Some cosmetic issues that I'd like to see resolved:
- The page title updated to match the breadcrumbs - The tools sidebar should be included on the page - The tools sidebar should be updated to include the link to Concerns
Fixed in line in `(QA follow-up) This is a 'tool'`
Also, this file is updated:
koha-tmpl/intranet-tmpl/prog/en/includes/cat-menu.inc
Is it used anywhere?
It was, but got removed again in the above mentioned patch.. I've reset it in the original patch again now.. it will be done in the cataloging home page stuff instead.
One more: The new system preferences should link to each other instead of showing the preference in plain text, e.g. `OpacCatalogConcerns`. It should be a link. See UsageStatsLibraryName for example.
Done, see final patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140929|0 |1 is obsolete| | --- Comment #132 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141133&action=edit Bug 31028: Add catalog_concerns table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140930|0 |1 is obsolete| | --- Comment #133 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141134&action=edit Bug 31028: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140931|0 |1 is obsolete| | --- Comment #134 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141135&action=edit Bug 31028: Add `CatalogConcerns` and `OpacCatalogConcerns` preferences This patch adds the `CatalogConcerns` and `OpacCatalogeConcerns` system preferences to enable/disable the catalog concerns feature on the OPAC and Staff client interfaces. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140932|0 |1 is obsolete| | --- Comment #135 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141136&action=edit Bug 31028: Add catalog concerns endpoints This patch adds the staff accessible REST API endpoints for catalog concerns. New endpoints available: * POST /catalog/concerns * GET /catalog/concerns * GET /catalog/concerns/{concern_id} * PUT /catalog/concerns/{concern_id} * DELETE /catalog/concenrs/{concern_id} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140933|0 |1 is obsolete| | --- Comment #136 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141137&action=edit Bug 31028: Add relations to Catalog::Concern This patch adds the reporter, resolver and biblio relations to the Catalog::Concern class and exposes them to the API as appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140934|0 |1 is obsolete| | --- Comment #137 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141138&action=edit Bug 31028: Add Public API endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140935|0 |1 is obsolete| | --- Comment #138 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141139&action=edit Bug 31028: Add 'Report a concern' to OPAC details This patch adds a new 'Report a concern' option to the right sidebar on the opac detail page. On clicking the link, a modal will display allowing the user to enter a short message regarding their concerns and then submission will record said message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140936|0 |1 is obsolete| | --- Comment #139 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141140&action=edit Bug 31028: Trigger login modal when not logged in This isn't perfect, we detect if there is a logged in user on the OPAC and replace the concern report modal with the login modal if we don't find a valid session. Unfortunelty, we can't then trigger a redirect back to the record details as that's not how our get_template_and_user authentication system works.. instead we end up back at opac-user.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140937|0 |1 is obsolete| | --- Comment #140 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141141&action=edit Bug 31028: Tie OPAC display to logged in state This is an alternative to th previous patch.. we can't easily redirect back to the right location after login from our modal. It would be preferable to display the button and prompt a login if we don't have a valid session.. but that's not trivial using the API's and our login flows at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140938|0 |1 is obsolete| | --- Comment #141 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141142&action=edit Bug 31028: Add a catalog concerns management page This patch adds a new cataloguing concerns page to the staff client for managing reported catalog concerns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140939|0 |1 is obsolete| | --- Comment #142 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141143&action=edit Bug 31028: Add 'special:undefined' to handle passing 'null' We can't pass 'null' to the column.search as it gets stringified. This patch adds a special string 'special:undefined' to denote that we want to search on undef for the field in question. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140940|0 |1 is obsolete| | --- Comment #143 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141144&action=edit Bug 31028: Add filters to concerns management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140941|0 |1 is obsolete| | --- Comment #144 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141145&action=edit Bug 31028: Add resolution endpoint This patch adds a /resolve endpoint to the catalog concerns endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140942|0 |1 is obsolete| | --- Comment #145 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141146&action=edit Bug 31028: Add resolve action This patch adds a resolution workflow to the catalog concerns management page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140943|0 |1 is obsolete| | --- Comment #146 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141147&action=edit Bug 31028: Add 'Add catalog concern' to cataloguing toolbar This patch moves the add concern modal js and template markup into their own files and then references them to add the 'Add concern' option to the cataloguing toolbar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140944|0 |1 is obsolete| | --- Comment #147 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141148&action=edit Bug 31028: Add notice trigger for catalog concerns This patch adds a new system prefernce, `CatalogerEmails`. If set with a valid email address adding a new catalog concern should produce a notification email sent to that address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140945|0 |1 is obsolete| | --- Comment #148 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141149&action=edit Bug 31028: Add trigger and notice to resolve This patch adds a sample notice and sets up the trigger to notify the concern reporter when a concern is marked as resolved. The notification itself is optional at resolve time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140946|0 |1 is obsolete| | --- Comment #149 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141150&action=edit Bug 31028: (QA follow-up) This is a 'tool' At the moment, this feature is accessible under tools rather than cataloging. Whilst we await the new cataloging homepage and sidebar this patch replaces the breadcrumb and title with 'Tools', replaces the 'cat-menu' include with 'tools-menu' and adds the 'Catalog concerns' tool to the tools-menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140947|0 |1 is obsolete| | --- Comment #150 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141151&action=edit Bug 31028: (QA follow-up) Table configuration This patch properly adds the table configuration options to the catalog concerns table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140948|0 |1 is obsolete| | --- Comment #151 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141152&action=edit Bug 31028: Use additional_contents for help block This patch updates the modal to use the additional_contents system for the modals help block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140949|0 |1 is obsolete| | --- Comment #152 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141153&action=edit Bug 31028: Add concerns tab to biblio details display This patch adds a 'Concerns' tab to the catalogue/detail display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140950|0 |1 is obsolete| | --- Comment #153 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141154&action=edit Bug 31028: Crosslink preferences This patch adds crosslinks to the CatalogConcerns and OpacCatalogConcerns system preferences. We also slightly update the wording of OpacCatalogConcerns to clarify intent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141133|0 |1 is obsolete| | --- Comment #154 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141440&action=edit Bug 31028: Add catalog_concerns table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141134|0 |1 is obsolete| | --- Comment #155 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141441&action=edit Bug 31028: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141135|0 |1 is obsolete| | --- Comment #156 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141442&action=edit Bug 31028: Add `CatalogConcerns` and `OpacCatalogConcerns` preferences This patch adds the `CatalogConcerns` and `OpacCatalogeConcerns` system preferences to enable/disable the catalog concerns feature on the OPAC and Staff client interfaces. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141136|0 |1 is obsolete| | --- Comment #157 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141443&action=edit Bug 31028: Add catalog concerns endpoints This patch adds the staff accessible REST API endpoints for catalog concerns. New endpoints available: * POST /catalog/concerns * GET /catalog/concerns * GET /catalog/concerns/{concern_id} * PUT /catalog/concerns/{concern_id} * DELETE /catalog/concenrs/{concern_id} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141137|0 |1 is obsolete| | --- Comment #158 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141444&action=edit Bug 31028: Add relations to Catalog::Concern This patch adds the reporter, resolver and biblio relations to the Catalog::Concern class and exposes them to the API as appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141138|0 |1 is obsolete| | --- Comment #159 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141445&action=edit Bug 31028: Add Public API endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141139|0 |1 is obsolete| | --- Comment #160 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141446&action=edit Bug 31028: Add 'Report a concern' to OPAC details This patch adds a new 'Report a concern' option to the right sidebar on the opac detail page. On clicking the link, a modal will display allowing the user to enter a short message regarding their concerns and then submission will record said message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141140|0 |1 is obsolete| | --- Comment #161 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141447&action=edit Bug 31028: Trigger login modal when not logged in If the user is not logged in we should trigger the login modal in place of the report a concern modal and then use the code added in bug 31699 to redirect the user back to the current content and open the report a concern modal upon successful login. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141142|0 |1 is obsolete| | --- Comment #162 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141448&action=edit Bug 31028: Add a catalog concerns management page This patch adds a new cataloguing concerns page to the staff client for managing reported catalog concerns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141143|0 |1 is obsolete| | --- Comment #163 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141449&action=edit Bug 31028: Add 'special:undefined' to handle passing 'null' We can't pass 'null' to the column.search as it gets stringified. This patch adds a special string 'special:undefined' to denote that we want to search on undef for the field in question. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141144|0 |1 is obsolete| | --- Comment #164 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141450&action=edit Bug 31028: Add filters to concerns management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141145|0 |1 is obsolete| | --- Comment #165 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141451&action=edit Bug 31028: Add resolution endpoint This patch adds a /resolve endpoint to the catalog concerns endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141146|0 |1 is obsolete| | --- Comment #166 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141452&action=edit Bug 31028: Add resolve action This patch adds a resolution workflow to the catalog concerns management page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141147|0 |1 is obsolete| | --- Comment #167 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141453&action=edit Bug 31028: Add 'Add catalog concern' to cataloguing toolbar This patch moves the add concern modal js and template markup into their own files and then references them to add the 'Add concern' option to the cataloguing toolbar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141148|0 |1 is obsolete| | --- Comment #168 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141454&action=edit Bug 31028: Add notice trigger for catalog concerns This patch adds a new system prefernce, `CatalogerEmails`. If set with a valid email address adding a new catalog concern should produce a notification email sent to that address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141149|0 |1 is obsolete| | --- Comment #169 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141455&action=edit Bug 31028: Add trigger and notice to resolve This patch adds a sample notice and sets up the trigger to notify the concern reporter when a concern is marked as resolved. The notification itself is optional at resolve time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141150|0 |1 is obsolete| | --- Comment #170 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141456&action=edit Bug 31028: (QA follow-up) This is a 'tool' At the moment, this feature is accessible under tools rather than cataloging. Whilst we await the new cataloging homepage and sidebar this patch replaces the breadcrumb and title with 'Tools', replaces the 'cat-menu' include with 'tools-menu' and adds the 'Catalog concerns' tool to the tools-menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141151|0 |1 is obsolete| | --- Comment #171 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141457&action=edit Bug 31028: (QA follow-up) Table configuration This patch properly adds the table configuration options to the catalog concerns table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141152|0 |1 is obsolete| | --- Comment #172 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141458&action=edit Bug 31028: Use additional_contents for help block This patch updates the modal to use the additional_contents system for the modals help block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141153|0 |1 is obsolete| | --- Comment #173 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141459&action=edit Bug 31028: Add concerns tab to biblio details display This patch adds a 'Concerns' tab to the catalogue/detail display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141154|0 |1 is obsolete| | --- Comment #174 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141460&action=edit Bug 31028: Crosslink preferences This patch adds crosslinks to the CatalogConcerns and OpacCatalogConcerns system preferences. We also slightly update the wording of OpacCatalogConcerns to clarify intent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141440|0 |1 is obsolete| | --- Comment #175 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142164&action=edit Bug 31028: Add catalog_concerns table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141441|0 |1 is obsolete| | --- Comment #176 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142165&action=edit Bug 31028: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141442|0 |1 is obsolete| | --- Comment #177 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142166&action=edit Bug 31028: Add `CatalogConcerns` and `OpacCatalogConcerns` preferences This patch adds the `CatalogConcerns` and `OpacCatalogeConcerns` system preferences to enable/disable the catalog concerns feature on the OPAC and Staff client interfaces. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141443|0 |1 is obsolete| | --- Comment #178 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142167&action=edit Bug 31028: Add catalog concerns endpoints This patch adds the staff accessible REST API endpoints for catalog concerns. New endpoints available: * POST /catalog/concerns * GET /catalog/concerns * GET /catalog/concerns/{concern_id} * PUT /catalog/concerns/{concern_id} * DELETE /catalog/concenrs/{concern_id} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141444|0 |1 is obsolete| | --- Comment #179 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142168&action=edit Bug 31028: Add relations to Catalog::Concern This patch adds the reporter, resolver and biblio relations to the Catalog::Concern class and exposes them to the API as appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141445|0 |1 is obsolete| | --- Comment #180 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142169&action=edit Bug 31028: Add Public API endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141446|0 |1 is obsolete| | --- Comment #181 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142170&action=edit Bug 31028: Add 'Report a concern' to OPAC details This patch adds a new 'Report a concern' option to the right sidebar on the opac detail page. On clicking the link, a modal will display allowing the user to enter a short message regarding their concerns and then submission will record said message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141447|0 |1 is obsolete| | --- Comment #182 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142171&action=edit Bug 31028: Trigger login modal when not logged in If the user is not logged in we should trigger the login modal in place of the report a concern modal and then use the code added in bug 31699 to redirect the user back to the current content and open the report a concern modal upon successful login. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141448|0 |1 is obsolete| | --- Comment #183 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142172&action=edit Bug 31028: Add a catalog concerns management page This patch adds a new cataloguing concerns page to the staff client for managing reported catalog concerns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141449|0 |1 is obsolete| | --- Comment #184 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142173&action=edit Bug 31028: Add 'special:undefined' to handle passing 'null' We can't pass 'null' to the column.search as it gets stringified. This patch adds a special string 'special:undefined' to denote that we want to search on undef for the field in question. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141450|0 |1 is obsolete| | --- Comment #185 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142174&action=edit Bug 31028: Add filters to concerns management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141451|0 |1 is obsolete| | --- Comment #186 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142175&action=edit Bug 31028: Add resolution endpoint This patch adds a /resolve endpoint to the catalog concerns endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141452|0 |1 is obsolete| | --- Comment #187 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142177&action=edit Bug 31028: Add resolve action This patch adds a resolution workflow to the catalog concerns management page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141453|0 |1 is obsolete| | --- Comment #188 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142179&action=edit Bug 31028: Add 'Add catalog concern' to cataloguing toolbar This patch moves the add concern modal js and template markup into their own files and then references them to add the 'Add concern' option to the cataloguing toolbar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141454|0 |1 is obsolete| | --- Comment #189 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142180&action=edit Bug 31028: Add notice trigger for catalog concerns This patch adds a new system prefernce, `CatalogerEmails`. If set with a valid email address adding a new catalog concern should produce a notification email sent to that address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141455|0 |1 is obsolete| | --- Comment #190 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142181&action=edit Bug 31028: Add trigger and notice to resolve This patch adds a sample notice and sets up the trigger to notify the concern reporter when a concern is marked as resolved. The notification itself is optional at resolve time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141456|0 |1 is obsolete| | --- Comment #191 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142182&action=edit Bug 31028: (QA follow-up) This is a 'tool' At the moment, this feature is accessible under tools rather than cataloging. Whilst we await the new cataloging homepage and sidebar this patch replaces the breadcrumb and title with 'Tools', replaces the 'cat-menu' include with 'tools-menu' and adds the 'Catalog concerns' tool to the tools-menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141457|0 |1 is obsolete| | --- Comment #192 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142183&action=edit Bug 31028: (QA follow-up) Table configuration This patch properly adds the table configuration options to the catalog concerns table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141458|0 |1 is obsolete| | --- Comment #193 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142184&action=edit Bug 31028: Use additional_contents for help block This patch updates the modal to use the additional_contents system for the modals help block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141459|0 |1 is obsolete| | --- Comment #194 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142185&action=edit Bug 31028: Add concerns tab to biblio details display This patch adds a 'Concerns' tab to the catalogue/detail display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141460|0 |1 is obsolete| | --- Comment #195 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142186&action=edit Bug 31028: Crosslink preferences This patch adds crosslinks to the CatalogConcerns and OpacCatalogConcerns system preferences. We also slightly update the wording of OpacCatalogConcerns to clarify intent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #196 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142187&action=edit Bug 31028: Add input template This patch adds an example 'CatalogConcernTemplate' to allow pre-population of the catalog concern report text area modal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #197 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142188&action=edit Bug 31028: Add acknowledgement notification This patch adds an acknowledgement notification to acknowledge to the patron via email that we have received their catalog concern report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #198 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142189&action=edit Bug 31028: Add page-section to concerns management page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #199 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142190&action=edit Bug 31028: Move back to cataloging from tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #200 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142191&action=edit Bug 31028: Add `wrapfix` class rule to set pre-wrap on content This patch adds a `wrapfix` css class that sets the 'white-space: pre-wrap' rule and applies it to the message content of our catalog concerns allowing multi-line reports to display properly in the table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141141|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142164|0 |1 is obsolete| | Attachment #142165|0 |1 is obsolete| | Attachment #142166|0 |1 is obsolete| | Attachment #142167|0 |1 is obsolete| | Attachment #142168|0 |1 is obsolete| | Attachment #142169|0 |1 is obsolete| | Attachment #142170|0 |1 is obsolete| | Attachment #142171|0 |1 is obsolete| | Attachment #142172|0 |1 is obsolete| | Attachment #142173|0 |1 is obsolete| | Attachment #142174|0 |1 is obsolete| | Attachment #142175|0 |1 is obsolete| | Attachment #142177|0 |1 is obsolete| | Attachment #142179|0 |1 is obsolete| | Attachment #142180|0 |1 is obsolete| | Attachment #142181|0 |1 is obsolete| | Attachment #142182|0 |1 is obsolete| | Attachment #142183|0 |1 is obsolete| | Attachment #142184|0 |1 is obsolete| | Attachment #142185|0 |1 is obsolete| | Attachment #142186|0 |1 is obsolete| | Attachment #142187|0 |1 is obsolete| | Attachment #142188|0 |1 is obsolete| | Attachment #142189|0 |1 is obsolete| | Attachment #142190|0 |1 is obsolete| | Attachment #142191|0 |1 is obsolete| | --- Comment #201 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142616&action=edit Bug 31028: Add `tickets` and `ticket_updates` tables This patch adds the new `tickets` and `ticket_updates` tables for tracking catalog concern tickets. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #202 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142617&action=edit Bug 31028: DBIC Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #203 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142618&action=edit Bug 31028: Add new Koha::Object(s) classes This patch adds new Koha::Object(s) for the newly introduced tables, including updateing existing Koha::Objects adding new relations as required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #204 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142619&action=edit Bug 31028: Add API's for tickets This patch adds basic CRUD API's for the ticket endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #205 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142620&action=edit Bug 31028: Add `OpacCatalogConcerns` preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #206 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142621&action=edit Bug 31028: Add ability to report catalog concerns from the OPAC This patch adds the ability for patrons to report catalog concerns via the opac. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #207 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142622&action=edit Bug 31028: Add configurable help text and templates This patch adds configurable help text and a template option to the catalog concern report modal in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #208 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142623&action=edit Bug 31028: Add acknowledgement notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #209 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142624&action=edit Bug 31028: Add catalog concern management page to staff This patch adds a catalog concern management page to the staff client accessible via the cataloging home page and a new 'Pending catalog concerns' link on the front page. This includes added the requisit ticket_updates api endpoints and notice triggers and templates for notifying patrons of changes to their reported concerns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #210 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142625&action=edit Bug 31028: Add email notification of cataloguers on submissions This patch adds an optional catalogeur notification to email the cataloging team whenever a new catalog concern is reported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #211 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142626&action=edit Bug 31028: Add ability to report concerns from the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #212 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142627&action=edit Bug 31028: Add display to details page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #213 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- A big rebase and squash of patches.. lots of little improvements to the feature as a whole.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #214 from David Nind <david@davidnind.com> --- Here are the things I noted from testing. See the draft test plan posted as a separate comment - I have referred to these notes where appropriate. [1] Wording for system preferences: - for OpacCatalogConcerns "..staff client." should be "..staff interface.". - most notes are formatted as NOTES: in bold [2] If the CatalogConcerns system preference is not enabled (with all of these also disabled: suggestions, OPACReportProblem, and AllowCheckoutNotes), then on the staff interface home page pending concerns are not shown. However, if any of suggestions, OPACReportProblem, or AllowCheckoutNotes are enabled and they have an active item(s), then it is displayed. Note: I had mixed results with this - sometime it worked, other times it didn't, so it was a bit confusing! [3] Viewing the details for a concern in the staff interface (Details action) - on the "Ticket details" for a concern: - there is a line after the text inside the border for the ticket details info - there are no line breaks, so whatever is entered appears as a continuous line [4] Clicking on resolve or comment does nothing: there is an error in the web developer tools console: Uncaught ReferenceError: logged_in_user_borrowernumber is not defined <anonymous> http://127.0.0.1:8081/intranet-tmpl/prog/js/modals/display_ticket_22.0600075... jQuery 2 dispatch handle [5] Things I noted about the staff report a concern modal: - The width is very narrow (maybe more related to the new staff interface design) - If the CatalogConcernHelp has some HTML, such as a bulleted list after the existing paragraph, then this doesn't display correctly - displays to the right of the paragraph without any bullets (bold seem to display OK) - There is no title field, as there is on the OPAC (not sure whether this is an issue, or what will be displayed in the list of concerns - The buttons are Confirm and Cancel (in the OPAC they are Submit and Cancel) - Nothing happens when clicking Confirm - the web developer tools console shows an error: XHR POST http://127.0.0.1:8081/api/v1/tickets 400 Bad Request [6] On Tools > Patrons and circulation > Notices and slips for the new notices: . the new notices are listed under module "catalog" (with a small "c" - all the other notice modules are shown in sentence case, so this should perhaps be "Catalog". . For TICKET_ACKNOWLEDGEME, maybe the code could be just TICKET_ACKNOWLEDGE in the yaml file as the 'NT' is cut off and not displayed . Note that for the sample notices, TICKET_ACKNOWLEDGEMENT is used, but this is shortened when added to the database to TICKET_ACKNOWLEDGEME [7] I'm not sure what permissions are required for non-super librarian staff to see and manage catalog concerns. Initially I thought it was manage_problem_reports permission - but then I started getting mixed results. On some occasions on the Cataloguing home page, the option Reports > Catalog concerns was still displayed. Clicking on this sends you to a login box that says "Error: You don't have permission to access this page". See also step 8.4. [8] Editing the catalog concern help text and concern templates: - If you use the WYSIWYG editor to edit the concern template: the mark up (such as <br/>s, <li>s, etc) is displayed in the form input area when reporting a concern from the OPAC and staff interface - Does this mean we can only edit the concern template using the text editor? - If you use the WYSIWYG editor to edit the help text: some mark up is not displayed correctly in the staff interface, for example: after adding a bulleted list after the first paragraph, on the modal the list is displayed to the right of the paragraph without the bullets. (Initially it didn't display correctly in the OPAC, but this was probably a browser caching issue.) [9] Display of concerns on a record page in the staff interface - no details listed: I created some concerns for a record - the tab shows the number, but the list only shows the table header row and no concern details. [10] CatalogerEmails: it appears you can add multiple email addresses - is a comma used to separate these? [11] Sidebar menu when in the Catalog concerns area: currently displays the Tools sidebar, now needs to be the Cataloguing sidebar menu, along with the page title. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #215 from David Nind <david@davidnind.com> --- Here is the draft test plan I used. See also the Specification attached to the bug. The notes referenced are included in comment #214. 1. Apply patches 2. Update database: updatedatabase 3. Run DBIC: dbic (not sure if this is required) 4. Enable the new system preference: OpacCatalogConcerns [see note 1] 5. Report a catalog concern from the OPAC: 5.1 Search for a record and view the details page 5.2 There is now a "Report a concern" link in the actions box on the right-hand sidebar (under "Suggest a purchase") 5.3 Click on "Report a concern" 5.4 Add some information to the form (Title, information for each of the headings) and click Submit 5.5 Log out from the OPAC and click on the "Report a concern" link for a record - you should be prompted to log in. After logging in, you are then redirected back to the record page and the form is displayed to report a concern. 6. Manage catalog concerns from the staff interface: 6.1 Disable these system preferences: suggestions, OPACReportProblem, and AllowCheckoutNotes 6.2 From the staff interface, select the link in the block after the module options (the "Call to action" area): where there are concerns, "Catalog concerns pending: X" is displayed [see note 2] OR 6.3 Go to Cataloging > Reports > Catalog concerns 6.4 The concern(s) you entered in the OPAC should be listed 6.5 Click on "Details" in the actions column ==> Ticket details displayed in a modal window [see note 3] 6.6 Add some text in the update field for the concern, select the Notify checkbox, and click on either the Resolve or Comment buttons [see note 4] 6.7 If Resolve clicked, then this will no longer be displayed in the list of concerns (make sure the 'Hide resolve' or 'Show all' toggles work and display concerns raised correctly based on status) 6.8 If Comment clicked, this will continue to be displayed in the list of concerns 6.9 Check that the filters for each column work as expected 6.10 [Not sure how comments are displayed, assume when viewing the details for a concern that any previous comments are displayed in the modal window with the date] 6.11 Testing notifications - see step 8.2 7. Report a catalog concern from the staff interface [see note 5]: 7.1 Enable the CatalogConcerns system preference 7.1 Search for a record and view the details page 7.2 Select New > New catalog concern 7.4 Add some information to the form (information for each of the headings) and click Confirm 8. Other things to test: 8.1 API: not sure what to test here (if needed) . Enable the RESTPublicAPI system preference . Go to http://127.0.0.1:8080/api/v1/.html . Not that there are APIs for addTicket, addTicketPublic, addTicketUpdate, deleteTicket, getTicket, listTicketUpdates, listTickets, and updateTicket 8.2 Notifications [see note 6] [need to expand and actually test this]: . There are four new notice templates: TICKET_NOTIFY, TICKET_ACKNOWLEDGEME, TICKET_RESOLVE, TICKET_UPDATE . Set up KTD so that email can be sent (using a Gmail address and an app password) . Set up a patron with your Gmail email address . Setup system preference CatalogerEmails with your Gmail email address . Trigger the various notices and make sure they work as expected: . TICKET_ACKNOWLEDGEME: email to patron when they raise a concern . TICKET_NOTIFY: email to library staff when a concern is raised . TICKET_UPDATE: add an update to a concern . TICKET_RESOLVE: when concern marked as resolved 8.3 Test with OPACReportProblem enabled: . Enable the system preference . Submit a "Report a problem" report from the OPAC . Check that this works as expected in the staff interface, and that both pending problem reports and catalog concerns are displayed . BONUS tests: test various combinations of enabling and disabling suggestions, OPACReportProblem, AllowCheckoutNotes, and CatalogConcerns system preferences [not sure whether this is really required] 8.4 Test a non-super librarian and set them up so that they can manage catalog concerns. What permissions are required? I initially thought you needed the manage_problem_reports permission, then I couldn't figure out the correct permissions to give [see also note 7]. These steps need updating once figured out: . Log in as a non-super librarian (needs manage_problem_reports permission, for example Henry Acevedo with a basic set of persmissions including: catalogue, circulate, borrowers, reserveforothers, editcatalogue, updatecharges, reports, lists, clubs, manage_problem_reports) . Check that they can view and manage catalog concerns 8.4 Table configuration: have some active catalog concerns, click configure, hide status column by default, check that you can toggle the status column on and off. 8.5 Customise the catalog concern help text and template [see note 8]: . Go to Tools > HTML customizations . Note that there are two entries available for editing: CatalogConcernHelp and CatalogConcernTemplate . Make some edits to these entries . From the OPAC, report a concern for a record . The changes you made should be reflected in the report a concern form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142616|0 |1 is obsolete| | --- Comment #216 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142932&action=edit Bug 31028: Add `tickets` and `ticket_updates` tables This patch adds the new `tickets` and `ticket_updates` tables for tracking catalog concern tickets. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142617|0 |1 is obsolete| | --- Comment #217 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142933&action=edit Bug 31028: DBIC Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142618|0 |1 is obsolete| | --- Comment #218 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142934&action=edit Bug 31028: Add new Koha::Object(s) classes This patch adds new Koha::Object(s) for the newly introduced tables, including updateing existing Koha::Objects adding new relations as required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142619|0 |1 is obsolete| | --- Comment #219 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142935&action=edit Bug 31028: Add API's for tickets This patch adds basic CRUD API's for the ticket endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142620|0 |1 is obsolete| | --- Comment #220 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142936&action=edit Bug 31028: Add `OpacCatalogConcerns` preference Enabling this preference should allow catalog concerns to be added by logged in patrons on the opac. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142621|0 |1 is obsolete| | --- Comment #221 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142937&action=edit Bug 31028: Add ability to report catalog concerns from the OPAC This patch adds the ability for patrons to report catalog concerns via the opac. Test plan 1) Enable the new `OpacCatalogConcerns` system preference 2) Navigate to the record details page of a biblio record on the OPAC 3) You should see a new 'Report a concern' option in the right side actions box 4) If not logged in you should have the login modal displayed and upon a successful login you should be redirected back to the details page with a new model displayed for entering concern details 5) Submit your concern with a title and details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142622|0 |1 is obsolete| | --- Comment #222 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142938&action=edit Bug 31028: Add configurable help text and templates This patch adds configurable help text and a template option to the catalog concern report modal in the OPAC. Test plan 1) Enable `OpacCatalogConcerns` preference 2) Build the CSS for the OPAC 3) Check that there is a 'CatalogConcernHelp' block listed in the HTML Customisations page. 4) On the OPAC navigate to a record and click the 'Report a concern' button. 5) Confirm that the content of 'CatalogConcernHelp' displays beneath the detail entry box and that it displays as expected. 6) Check that there is a 'CatalogConcernTemplate' block listed in the HTML customisations page. 7) On the OPAC 'Report a concern' modal, you should see the content of the 'CatalogConcernTemplate' block pre-filled in the details textarea. Note: There is a caveat to the template.. as textarea can only be used to submit plaintext with this patch and as such the template needs to not utilise the WYSIWYG editor else you will be faced with raw HTML inside your textarea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142623|0 |1 is obsolete| | --- Comment #223 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142939&action=edit Bug 31028: Add acknowledgement notice This patch adds an acknowledgement notice that will be sent to the opac user upon submission of a catalog concern report. Test plan 1) Confirm that a new notice template is added to the notices management page. 2) If using a sandbox, check the 'email log' from the management UI to see the resultant notice has been 'sent' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142624|0 |1 is obsolete| | --- Comment #224 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142940&action=edit Bug 31028: Add catalog concern management page to staff This patch adds a catalog concern management page to the staff client accessible via the cataloging home page and a new 'Pending catalog concerns' link on the front page. This includes added the requisit ticket_updates api endpoints and notice triggers and templates for notifying patrons of changes to their reported concerns. Test plan 1) Enable the `OpacCatalogConcerns` system preference 2) Catalog concern management is tied to your users ability to edit the catalog, `editcatalogue`. 3) Confirm that you can see 'Catalog concerns' listed on the cataloging home page if you have the `editcatalogue` permission and not if you do not. 4) Add a new concern as an opac user. 5) Confirm that once a concern is present in the system you see a count of 'catalog concerns pending' on the intranet main page if you have the `editcatalogue` permission. 6) Click through either the cataloging home page or pending concerns link on the main page to view the new concerns management page. 7) Confirm the table displays as one would expect. 8) Confirm clicking on details or the concern title exposes a 'details' modal with the option to add an update or resolve the concern. 9) Verify that if selecting 'notify' when updateing or resolving a concern triggers a notice to be sent to the opac user who first reported the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142625|0 |1 is obsolete| | --- Comment #225 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142941&action=edit Bug 31028: Add email notification of cataloguers on submissions This patch adds an optional catalogeur notification to email the cataloging team whenever a new catalog concern is reported. Test plan 1) Enable `OpacCatalogConcerns` 2) Add at least one email address to the new `CataloguerEmails` prefernce (a comma delimited list is also allowed). 3) Confirm that a default template has been added to the Notices management, `TICKET_NOTIFY`. 4) Submit a new concern using the OPAC 5) Confirm that an email is sent to those email addresses listed in CataloguerEmails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142626|0 |1 is obsolete| | --- Comment #226 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142942&action=edit Bug 31028: Add ability to report concerns from the staff interface This patch brings the CatalogConcerns feature to the staff client allowing non-cataloguers to report issues with catalog records from the record details page. Test plan 1) Enable the new `CatalogConcerns` system preference 2) Confirm that without the `edit_catalogue` permission your user can submit a catalog concern via `New -> New catalog concern` from the toolbar on a records detail display. 3) Confirm that the right user was recorded as the reporter on the catalog concern management page (You must have logged in again as a user with the `edit_catalogue` permission to see this page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142627|0 |1 is obsolete| | --- Comment #227 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142943&action=edit Bug 31028: Add display to details page This patch adds the display of biblio specific concerns to the biblio detail display page. Test plan 1) Enable the feature as in prior patch test plans 2) Add a concern as per prior patch test plans 3) Confirm that a new tab appears at the bottom of the catalog record details display and all functionality from the concern management page is precent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #228 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142944&action=edit Bug 31028: Improve display-ticket modal form display This patch improves the display of the concern details modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #229 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142945&action=edit Bug 31028: (follow-up) System preference terminology Capitalise NOTE and swap 'client' for 'interface'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #230 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142946&action=edit Bug 31028: Only show pending concerns if there are some This patch adds logic to catch when pending_biblio_tickets equals zero. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #231 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142947&action=edit Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop the 'MENT' to ensure it fits. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #232 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142948&action=edit Bug 31028: (follow-up) Update notice module codes This patch updates the notice codes from 'catalog' to 'catalogue' to be consistent with the existing codebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #233 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142949&action=edit Bug 31028: (follow-up) Consistently style help-block This patch updates the opac and staff modals to set the help-block inside a div instead of a paragraph element allowing for the wysiwyg edited content to display as prescribed. We move the scss inside the fieldset definition to ensure we are specific enough to catch only the intended elements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #234 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thankyou so much for your thorough testing and feedback again David.. it's great to see this level of detail. My apologies for some bits that clearly weren't working as expected.. there was a rebase issue that had crept in so some things clearly just weren't working a all :(. I believe I've resolved all those issues now and have taken into account all of your feedback on top. I've also tried to fold some of your excellent test plan into test plans attached to each commit. The permission you were looking for and wasn't at all documented is 'edit_catalogue'.. I took the approach that cataloguers should be dealing with concerns raised so adopted the pre-existing permission. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #235 from David Nind <david@davidnind.com> --- Thanks Martin for addressing the items I raised! I've retested and here are some more comments. 1. When submitting a concern on the OPAC, there is no acknowledgement message, for example like when you report a problem or make a purchase suggestion (such as, "Your catalog concern report was submitted.") - you are just returned to the record. 2. Last comment/update is prepopulated into the update field without a hard page refresh: 2.1 Click on the Details action for a concern 2.2 Add a comment in the update field and click on comment 2.3 Click on the details action again for the same concern without refreshing the page: note that the update field is populated with the last comment made 2.4 Click on another concern: same results as 2.3 2.5 If you click away to another page (or a hard referesh - Shift + Refresh), and then go back to the catalog concerns page this doesn't happen. 3. Permissions to manage concerns - I still can't get this to work using the editcatalog permission: 3.1 I added the editcatalog permission + all tools to a staff user (Henry). 3.2 When I go to access catalog concerns (either from 'Pending catalog concerns' on the home page or from the cataloging home page), I get "You do not have permission to access this page" and the login form. 3.3 Without the permission, I don't see 'Pending catalog concerns' on the home page or "Catalog concerns" on the Cataloguing home page (as expected). 3.4 I also gave all permissions except "Access to all librarian functions (superlibrarian)" and I still get the same permission error as in 3.2. 4. Details of concerns listed on the record details page are now shown, however: 4.1 If resolved, can still add comments, and can also click on resolve again (using the koha superlibrarian user). 4.2 Whereas, in the Cataloging > Catalog concerns area, once you have resolved the concern the only option you have is the "Comment" button. 4.2 If you don't have permission, can see the details in modal window and the Resolve and Comment buttons are displayed. When attempting to make a comment or resolve, the modal sits there with the "spinner" on the button. 5. Reporting a catalog concern from the staff interface - display of help text: 5.1 If the help text has a bulleted list, the bullets aren't shown (add some lines to the help text, make them into a bulleted list, report a problem in the staff interface for a record). 6. Notices sent using email (see [1] for how I set up to test): 8.1 Acknowledgement, update, and resolved notifications come through (acknowledgement messages cam straight through, but update and resolved came through when I ran misc/cronjobs/process_message_queue.pl). 8.2 The notify message to CatalogersEmail address didn't come through and is not in the message queue. 8.3 Messages come through as a single line without any line breaks. Does the notice need HTML tags for this? See [2] for examples of what was received. 8.4 Only the 'Catalog concern updated' and 'Catalog concern resolved; notices were displayed under the patron's record of notices - the acknowledgement notice wasn't listed. 7. Setting CatalogerEmails - wrong name in test plan for patch 'Add email notification of cataloguers on submissions' (CataloguerEmails should be CatalogerEmails. 8. List of concerns - should it default to only displaying the unresolved concerns? Otherwise, the list could get quite long... Maybe this should be a separate bug if considered an issue, as I noticed that this is the same pattern used for OPAC problem reports and AllowCheckoutNotes. [1] Set up for testing notifications using Gmail when using KTD. Add this to /etc/koha/sites/kohadev/koha-conf.xml, setup an App password for your Gmail account, add the details as indicated, and add your Gmail address as the email for a patron(s) used in testing: <smtp_server> <host>smtp.gmail.com</host> <port>587</port> <timeout>5</timeout> <ssl_mode>STARTTLS</ssl_mode> <user_name>YOURGMAILADDRESS</user_name> <password>YOURAPPPASSWORD/password> <debug>1</debug> </smtp_server> [2] Text of email messages - came through as a single line: Acknowledgement: Dear koha (42), Thankyou for your report concerning Lady Susan ; The Watsons ; Sanditon / . You reported: **Describe the concern** A clear and concise description of what the concern is. **To Reproduce** Steps to reproduce the behavior: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See error **Expected behavior** A clear and concise description of what you expected to happen. Thankyou Update: Dear koha (42), The library has added an update to the concern you reported against Lady Susan ; The Watsons ; Sanditon / . The following comment was left: Send an update Thankyou Resolved: Dear koha (42), The library has now marked your concern with Lady Susan ; The Watsons ; Sanditon / as resolved. The following comment was left: This is now fixed! Thankyou -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142932|0 |1 is obsolete| | --- Comment #236 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143238&action=edit Bug 31028: Add `tickets` and `ticket_updates` tables This patch adds the new `tickets` and `ticket_updates` tables for tracking catalog concern tickets. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142933|0 |1 is obsolete| | --- Comment #237 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143239&action=edit Bug 31028: DBIC Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142934|0 |1 is obsolete| | --- Comment #238 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143240&action=edit Bug 31028: Add new Koha::Object(s) classes This patch adds new Koha::Object(s) for the newly introduced tables, including updateing existing Koha::Objects adding new relations as required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142935|0 |1 is obsolete| | --- Comment #239 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143241&action=edit Bug 31028: Add API's for tickets This patch adds basic CRUD API's for the ticket endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142936|0 |1 is obsolete| | --- Comment #240 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143242&action=edit Bug 31028: Add `OpacCatalogConcerns` preference Enabling this preference should allow catalog concerns to be added by logged in patrons on the opac. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142937|0 |1 is obsolete| | --- Comment #241 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143243&action=edit Bug 31028: Add ability to report catalog concerns from the OPAC This patch adds the ability for patrons to report catalog concerns via the opac. Test plan 1) Enable the new `OpacCatalogConcerns` system preference 2) Navigate to the record details page of a biblio record on the OPAC 3) You should see a new 'Report a concern' option in the right side actions box 4) If not logged in you should have the login modal displayed and upon a successful login you should be redirected back to the details page with a new model displayed for entering concern details 5) Submit your concern with a title and details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142938|0 |1 is obsolete| | --- Comment #242 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143244&action=edit Bug 31028: Add configurable help text and templates This patch adds configurable help text and a template option to the catalog concern report modal in the OPAC. Test plan 1) Enable `OpacCatalogConcerns` preference 2) Build the CSS for the OPAC 3) Check that there is a 'CatalogConcernHelp' block listed in the HTML Customisations page. 4) On the OPAC navigate to a record and click the 'Report a concern' button. 5) Confirm that the content of 'CatalogConcernHelp' displays beneath the detail entry box and that it displays as expected. 6) Check that there is a 'CatalogConcernTemplate' block listed in the HTML customisations page. 7) On the OPAC 'Report a concern' modal, you should see the content of the 'CatalogConcernTemplate' block pre-filled in the details textarea. Note: There is a caveat to the template.. as textarea can only be used to submit plaintext with this patch and as such the template needs to not utilise the WYSIWYG editor else you will be faced with raw HTML inside your textarea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142939|0 |1 is obsolete| | --- Comment #243 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143245&action=edit Bug 31028: Add acknowledgement notice This patch adds an acknowledgement notice that will be sent to the opac user upon submission of a catalog concern report. Test plan 1) Confirm that a new notice template is added to the notices management page. 2) If using a sandbox, check the 'email log' from the management UI to see the resultant notice has been 'sent' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142940|0 |1 is obsolete| | --- Comment #244 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143246&action=edit Bug 31028: Add catalog concern management page to staff This patch adds a catalog concern management page to the staff client accessible via the cataloging home page and a new 'Pending catalog concerns' link on the front page. This includes added the requisit ticket_updates api endpoints and notice triggers and templates for notifying patrons of changes to their reported concerns. Test plan 1) Enable the `OpacCatalogConcerns` system preference 2) Catalog concern management is tied to your users ability to edit the catalog, `editcatalogue`. 3) Confirm that you can see 'Catalog concerns' listed on the cataloging home page if you have the `editcatalogue` permission and not if you do not. 4) Add a new concern as an opac user. 5) Confirm that once a concern is present in the system you see a count of 'catalog concerns pending' on the intranet main page if you have the `editcatalogue` permission. 6) Click through either the cataloging home page or pending concerns link on the main page to view the new concerns management page. 7) Confirm the table displays as one would expect. 8) Confirm clicking on details or the concern title exposes a 'details' modal with the option to add an update or resolve the concern. 9) Verify that if selecting 'notify' when updateing or resolving a concern triggers a notice to be sent to the opac user who first reported the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142941|0 |1 is obsolete| | --- Comment #245 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143247&action=edit Bug 31028: Add email notification of cataloguers on submissions This patch adds an optional cataloger notification to email the cataloging team whenever a new catalog concern is reported. Test plan 1) Enable `OpacCatalogConcerns` 2) Add at least one email address to the new `CatalogerEmails` prefernce (a comma delimited list is also allowed). 3) Confirm that a default template has been added to the Notices management, `TICKET_NOTIFY`. 4) Submit a new concern using the OPAC 5) Confirm that an email is sent to those email addresses listed in CatalogerEmails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142942|0 |1 is obsolete| | --- Comment #246 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143248&action=edit Bug 31028: Add ability to report concerns from the staff interface This patch brings the CatalogConcerns feature to the staff client allowing non-cataloguers to report issues with catalog records from the record details page. Test plan 1) Enable the new `CatalogConcerns` system preference 2) Confirm that without the `edit_catalogue` permission your user can submit a catalog concern via `New -> New catalog concern` from the toolbar on a records detail display. 3) Confirm that the right user was recorded as the reporter on the catalog concern management page (You must have logged in again as a user with the `edit_catalogue` permission to see this page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142943|0 |1 is obsolete| | --- Comment #247 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143249&action=edit Bug 31028: Add display to details page This patch adds the display of biblio specific concerns to the biblio detail display page. Test plan 1) Enable the feature as in prior patch test plans 2) Add a concern as per prior patch test plans 3) Confirm that a new tab appears at the bottom of the catalog record details display and all functionality from the concern management page is precent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142945|0 |1 is obsolete| | --- Comment #248 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143250&action=edit Bug 31028: (follow-up) System preference terminology Capitalise NOTE and swap 'client' for 'interface'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142946|0 |1 is obsolete| | --- Comment #249 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143251&action=edit Bug 31028: Only show pending concerns if there are some This patch adds logic to catch when pending_biblio_tickets equals zero. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142947|0 |1 is obsolete| | --- Comment #250 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143252&action=edit Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop the 'MENT' to ensure it fits. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142948|0 |1 is obsolete| | --- Comment #251 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143253&action=edit Bug 31028: (follow-up) Update notice module codes This patch updates the notice codes from 'catalog' to 'catalogue' to be consistent with the existing codebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142949|0 |1 is obsolete| | --- Comment #252 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143254&action=edit Bug 31028: (follow-up) Consistently style help-block This patch updates the opac and staff modals to set the help-block inside a div instead of a paragraph element allowing for the wysiwyg edited content to display as prescribed. We move the scss inside the fieldset definition to ensure we are specific enough to catch only the intended elements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #253 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143255&action=edit Bug 31028: Add feedback to the patron on submission This patch adds a success alert box when a patron submits a concern sucessfully. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #254 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143256&action=edit Bug 31028: (follow-up) Fix permissions names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #255 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143257&action=edit Bug 31028: (follow-up) Set notice to non-html This should resolve the lack of linebreaks in resulting emails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142944|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #256 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to David Nind from comment #235)
I've retested and here are some more comments.
Thank you so much for persevering here :)
1. When submitting a concern on the OPAC, there is no acknowledgement message, for example like when you report a problem or make a purchase suggestion (such as, "Your catalog concern report was submitted.") - you are just returned to the record.
Added now to the OPAC.. I didn't add it to the staff client yet, I wasn't sure it was as important here.
2. Last comment/update is prepopulated into the update field without a hard page refresh: 2.1 Click on the Details action for a concern 2.2 Add a comment in the update field and click on comment 2.3 Click on the details action again for the same concern without refreshing the page: note that the update field is populated with the last comment made 2.4 Click on another concern: same results as 2.3 2.5 If you click away to another page (or a hard referesh - Shift + Refresh), and then go back to the catalog concerns page this doesn't happen.
This should be resolved now.
3. Permissions to manage concerns - I still can't get this to work using the editcatalog permission: 3.1 I added the editcatalog permission + all tools to a staff user (Henry). 3.2 When I go to access catalog concerns (either from 'Pending catalog concerns' on the home page or from the cataloging home page), I get "You do not have permission to access this page" and the login form. 3.3 Without the permission, I don't see 'Pending catalog concerns' on the home page or "Catalog concerns" on the Cataloguing home page (as expected). 3.4 I also gave all permissions except "Access to all librarian functions (superlibrarian)" and I still get the same permission error as in 3.2.
Great work spotting this one, there was a misnamed permission on my part in the code. Fixed now.
4. Details of concerns listed on the record details page are now shown, however: 4.1 If resolved, can still add comments, and can also click on resolve again (using the koha superlibrarian user). 4.2 Whereas, in the Cataloging > Catalog concerns area, once you have resolved the concern the only option you have is the "Comment" button. 4.2 If you don't have permission, can see the details in modal window and the Resolve and Comment buttons are displayed. When attempting to make a comment or resolve, the modal sits there with the "spinner" on the button.
This should now match the main concern management page.
5. Reporting a catalog concern from the staff interface - display of help text: 5.1 If the help text has a bulleted list, the bullets aren't shown (add some lines to the help text, make them into a bulleted list, report a problem in the staff interface for a record).
Resolved, but required a CSS rebuild to test
6. Notices sent using email (see [1] for how I set up to test): 8.1 Acknowledgement, update, and resolved notifications come through (acknowledgement messages came straight through, but update and resolved came through when I ran misc/cronjobs/process_message_queue.pl).
Timing is as designed, acknowledgement is immediate, other notices are queued.
8.2 The notify message to CatalogersEmail address didn't come through and is not in the message queue.
I can't seem to replicate this not coming through.. - Perhaps the empty CatalogersEmail preference was cached?
8.3 Messages come through as a single line without any line breaks. Does the notice need HTML tags for this? See [2] for examples of what was received.
This should be resolved now by dropping the 'is_html' flag.
8.4 Only the 'Catalog concern updated' and 'Catalog concern resolved; notices were displayed under the patron's record of notices - the acknowledgement notice wasn't listed.
Acknowledgement should now also show here.
7. Setting CatalogerEmails - wrong name in test plan for patch 'Add email notification of cataloguers on submissions' (CataloguerEmails should be CatalogerEmails.
Corrected, but I also noticed you cannot enter a comma delimited list.. I think it's OK to only allow one email address for now.
8. List of concerns - should it default to only displaying the unresolved concerns? Otherwise, the list could get quite long... Maybe this should be a separate bug if considered an issue, as I noticed that this is the same pattern used for OPAC problem reports and AllowCheckoutNotes.
Good idea, but I agree perhaps it's one for a later bug.
[1] Set up for testing notifications using Gmail when using KTD. Add this to /etc/koha/sites/kohadev/koha-conf.xml, setup an App password for your Gmail account, add the details as indicated, and add your Gmail address as the email for a patron(s) used in testing:
<smtp_server> <host>smtp.gmail.com</host> <port>587</port> <timeout>5</timeout> <ssl_mode>STARTTLS</ssl_mode> <user_name>YOURGMAILADDRESS</user_name> <password>YOURAPPPASSWORD/password> <debug>1</debug> </smtp_server>
[2] Text of email messages - came through as a single line:
Acknowledgement:
Dear koha (42), Thankyou for your report concerning Lady Susan ; The Watsons ; Sanditon / . You reported: **Describe the concern** A clear and concise description of what the concern is. **To Reproduce** Steps to reproduce the behavior: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See error **Expected behavior** A clear and concise description of what you expected to happen. Thankyou
Update:
Dear koha (42), The library has added an update to the concern you reported against Lady Susan ; The Watsons ; Sanditon / . The following comment was left: Send an update Thankyou
Resolved:
Dear koha (42), The library has now marked your concern with Lady Susan ; The Watsons ; Sanditon / as resolved. The following comment was left: This is now fixed! Thankyou
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #257 from David Nind <david@davidnind.com> --- Thanks Martin for fixing all these things! On retesting, some more issues (sorry!). 1. Error on OPAC - there looks to be something wrong with the patch 'Add feedback to the patron on submission': - I get this error in the console when accessing thedetails page for a record: 09:25:59.890 Uncaught SyntaxError: missing } after property list catalog_concern_22.0600077.js:45:12 note: { opened at line 32, column 15 - Clicking on 'Report a concern' in the OPAC doesn't prompt you to login, and doesn't do anything when you submit - I skipped this patch for testing everything else 2. Staff interface home page display - "Catalog concerns pending: X": - If CatalogConcerns is not enabled, then this doesn't display (not expected - would expect it to display if staff user can manage catalog concerns) - If there are active purchase suggestions, problem reports, article requests, and allow checkout notes (with these system preferences enabled), it does display (tested various combinations, and ended up confusing myself!) - If purchase suggestions, problem reports, article requests, and allow checkout notes are not enabled (or there are no active requests), then it doesn't display catalog concerns pending 3. Notices: 3.1 TICKET_ACKNOWLEDGE notice: . there are lots of extra lines in the message, not sure whether that is something to do with using Gmail to test or not [1] . there is a span tag visible around the record name . If I select HTML message for the notice, it comes through as one line . This is similar for the other notices (and non-catalog concern notices as well) - it maybe something more generic with my setup/HTML email message generation 3.2 TICKET_NOTIFY notice - warning in the /var/log/koha/kohadev/plack-api-error.log: [2022/11/04 19:36:16] [WARN] No catalog TICKET_NOTIFY letter transported by email at /kohadevbox/koha/C4/Letters.pm line 584. . This warning may explain why I'm not receiving the TICKET_NOTIFY notices, I'm assuming it is probably a combination of system preferences and the mail setup using Gmail to send notices 3.3 Patron sent notices: I'm now only seeing the catalog concern acknowledgements notice under the patron's notices (previously I was only seeing 'Catalog concern updated' and 'Catalog concern resolved' notices) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143238|0 |1 is obsolete| | Attachment #143239|0 |1 is obsolete| | Attachment #143240|0 |1 is obsolete| | Attachment #143241|0 |1 is obsolete| | Attachment #143242|0 |1 is obsolete| | Attachment #143243|0 |1 is obsolete| | Attachment #143244|0 |1 is obsolete| | Attachment #143245|0 |1 is obsolete| | Attachment #143246|0 |1 is obsolete| | Attachment #143247|0 |1 is obsolete| | Attachment #143248|0 |1 is obsolete| | Attachment #143249|0 |1 is obsolete| | Attachment #143250|0 |1 is obsolete| | Attachment #143251|0 |1 is obsolete| | Attachment #143252|0 |1 is obsolete| | Attachment #143253|0 |1 is obsolete| | Attachment #143254|0 |1 is obsolete| | Attachment #143255|0 |1 is obsolete| | Attachment #143256|0 |1 is obsolete| | Attachment #143257|0 |1 is obsolete| | --- Comment #258 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143302&action=edit Bug 31028: Add `tickets` and `ticket_updates` tables This patch adds the new `tickets` and `ticket_updates` tables for tracking catalog concern tickets. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #259 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143303&action=edit Bug 31028: DBIC Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #260 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143304&action=edit Bug 31028: Add new Koha::Object(s) classes This patch adds new Koha::Object(s) for the newly introduced tables, including updateing existing Koha::Objects adding new relations as required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #261 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143305&action=edit Bug 31028: Add API's for tickets This patch adds basic CRUD API's for the ticket endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #262 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143306&action=edit Bug 31028: Add `OpacCatalogConcerns` preference Enabling this preference should allow catalog concerns to be added by logged in patrons on the opac. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #263 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143307&action=edit Bug 31028: Add ability to report catalog concerns from the OPAC This patch adds the ability for patrons to report catalog concerns via the opac. Test plan 1) Enable the new `OpacCatalogConcerns` system preference 2) Navigate to the record details page of a biblio record on the OPAC 3) You should see a new 'Report a concern' option in the right side actions box 4) If not logged in you should have the login modal displayed and upon a successful login you should be redirected back to the details page with a new model displayed for entering concern details 5) Submit your concern with a title and details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #264 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143308&action=edit Bug 31028: Add configurable help text and templates This patch adds configurable help text and a template option to the catalog concern report modal in the OPAC. Test plan 1) Enable `OpacCatalogConcerns` preference 2) Build the CSS for the OPAC 3) Check that there is a 'CatalogConcernHelp' block listed in the HTML Customisations page. 4) On the OPAC navigate to a record and click the 'Report a concern' button. 5) Confirm that the content of 'CatalogConcernHelp' displays beneath the detail entry box and that it displays as expected. 6) Check that there is a 'CatalogConcernTemplate' block listed in the HTML customisations page. 7) On the OPAC 'Report a concern' modal, you should see the content of the 'CatalogConcernTemplate' block pre-filled in the details textarea. Note: There is a caveat to the template.. as textarea can only be used to submit plaintext with this patch and as such the template needs to not utilise the WYSIWYG editor else you will be faced with raw HTML inside your textarea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #265 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143309&action=edit Bug 31028: Add acknowledgement notice This patch adds an acknowledgement notice that will be sent to the opac user upon submission of a catalog concern report. Test plan 1) Confirm that a new notice template is added to the notices management page. 2) If using a sandbox, check the 'email log' from the management UI to see the resultant notice has been 'sent' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #266 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143310&action=edit Bug 31028: Add catalog concern management page to staff This patch adds a catalog concern management page to the staff client accessible via the cataloging home page and a new 'Pending catalog concerns' link on the front page. This includes added the requisit ticket_updates api endpoints and notice triggers and templates for notifying patrons of changes to their reported concerns. Test plan 1) Enable the `OpacCatalogConcerns` system preference 2) Catalog concern management is tied to your users ability to edit the catalog, `editcatalogue`. 3) Confirm that you can see 'Catalog concerns' listed on the cataloging home page if you have the `editcatalogue` permission and not if you do not. 4) Add a new concern as an opac user. 5) Confirm that once a concern is present in the system you see a count of 'catalog concerns pending' on the intranet main page if you have the `editcatalogue` permission. 6) Click through either the cataloging home page or pending concerns link on the main page to view the new concerns management page. 7) Confirm the table displays as one would expect. 8) Confirm clicking on details or the concern title exposes a 'details' modal with the option to add an update or resolve the concern. 9) Verify that if selecting 'notify' when updateing or resolving a concern triggers a notice to be sent to the opac user who first reported the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #267 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143311&action=edit Bug 31028: Add email notification of cataloguers on submissions This patch adds an optional cataloger notification to email the cataloging team whenever a new catalog concern is reported. Test plan 1) Enable `OpacCatalogConcerns` 2) Add at least one email address to the new `CatalogerEmails` prefernce (a comma delimited list is also allowed). 3) Confirm that a default template has been added to the Notices management, `TICKET_NOTIFY`. 4) Submit a new concern using the OPAC 5) Confirm that an email is sent to those email addresses listed in CatalogerEmails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #268 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143312&action=edit Bug 31028: Add ability to report concerns from the staff interface This patch brings the CatalogConcerns feature to the staff client allowing non-cataloguers to report issues with catalog records from the record details page. Test plan 1) Enable the new `CatalogConcerns` system preference 2) Confirm that without the `edit_catalogue` permission your user can submit a catalog concern via `New -> New catalog concern` from the toolbar on a records detail display. 3) Confirm that the right user was recorded as the reporter on the catalog concern management page (You must have logged in again as a user with the `edit_catalogue` permission to see this page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #269 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143313&action=edit Bug 31028: Add display to details page This patch adds the display of biblio specific concerns to the biblio detail display page. Test plan 1) Enable the feature as in prior patch test plans 2) Add a concern as per prior patch test plans 3) Confirm that a new tab appears at the bottom of the catalog record details display and all functionality from the concern management page is precent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #270 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143314&action=edit Bug 31028: (follow-up) System preference terminology Capitalise NOTE and swap 'client' for 'interface'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #271 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143315&action=edit Bug 31028: Only show pending concerns if there are some This patch adds logic to catch when pending_biblio_tickets equals zero. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #272 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143316&action=edit Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop the 'MENT' to ensure it fits. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #273 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143317&action=edit Bug 31028: (follow-up) Update notice module codes This patch updates the notice codes from 'catalog' to 'catalogue' to be consistent with the existing codebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #274 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143318&action=edit Bug 31028: (follow-up) Consistently style help-block This patch updates the opac and staff modals to set the help-block inside a div instead of a paragraph element allowing for the wysiwyg edited content to display as prescribed. We move the scss inside the fieldset definition to ensure we are specific enough to catch only the intended elements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #275 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143319&action=edit Bug 31028: Add feedback to the patron on submission This patch adds a success alert box when a patron submits a concern sucessfully. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #276 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143320&action=edit Bug 31028: (follow-up) Fix permissions names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #277 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143321&action=edit Bug 31028: (follow-up) Add <br> to notices This should resolve the lack of linebreaks in resulting emails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #278 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to David Nind from comment #257)
Thanks Martin for fixing all these things!
On retesting, some more issues (sorry!).
1. Error on OPAC - there looks to be something wrong with the patch 'Add feedback to the patron on submission':
Damn, I missed a comma in the rebuse just prior to uploading that last set of patches.. resolved now.
2. Staff interface home page display - "Catalog concerns pending: X": - If CatalogConcerns is not enabled, then this doesn't display (not expected - would expect it to display if staff user can manage catalog concerns) - If there are active purchase suggestions, problem reports, article requests, and allow checkout notes (with these system preferences enabled), it does display (tested various combinations, and ended up confusing myself!) - If purchase suggestions, problem reports, article requests, and allow checkout notes are not enabled (or there are no active requests), then it doesn't display catalog concerns pending
So the conditions here are 'IF ( CatalogConcerns is enabled OR OpacCatalogConcerns is enabled ) AND there are pending concerns AND the user has the edit_catalog permission DISPLAY the pending concerns count'. I'm wondering if we got a database update mixed in somewhere a long the lines or something here. I just tested this with a fresh k-t-d running just the db update and yarn builds and it appears to work as expected for me.
3. Notices:
3.1 TICKET_ACKNOWLEDGE notice: . there are lots of extra lines in the message, not sure whether that is something to do with using Gmail to test or not [1] . there is a span tag visible around the record name . If I select HTML message for the notice, it comes through as one line . This is similar for the other notices (and non-catalog concern notices as well) - it maybe something more generic with my setup/HTML email message generation
I've updated the final patch to go back to html emails and I've replaced the \r\n with <br>.. hopefully that'll resolve this one.
3.2 TICKET_NOTIFY notice - warning in the /var/log/koha/kohadev/plack-api-error.log: [2022/11/04 19:36:16] [WARN] No catalog TICKET_NOTIFY letter transported by email at /kohadevbox/koha/C4/Letters.pm line 584. . This warning may explain why I'm not receiving the TICKET_NOTIFY notices, I'm assuming it is probably a combination of system preferences and the mail setup using Gmail to send notices
Hmm.. wonder if this was again a mix up in the database updates.. running this in a fresh k-t-d now to try to replicate.
3.3 Patron sent notices: I'm now only seeing the catalog concern acknowledgements notice under the patron's notices (previously I was only seeing 'Catalog concern updated' and 'Catalog concern resolved' notices)
These only send when 'Notify' is set.. I'm testing this in k-t-d again now myself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143302|0 |1 is obsolete| | Attachment #143303|0 |1 is obsolete| | Attachment #143304|0 |1 is obsolete| | Attachment #143305|0 |1 is obsolete| | Attachment #143306|0 |1 is obsolete| | Attachment #143307|0 |1 is obsolete| | Attachment #143308|0 |1 is obsolete| | Attachment #143309|0 |1 is obsolete| | Attachment #143310|0 |1 is obsolete| | Attachment #143311|0 |1 is obsolete| | Attachment #143312|0 |1 is obsolete| | Attachment #143313|0 |1 is obsolete| | Attachment #143314|0 |1 is obsolete| | Attachment #143315|0 |1 is obsolete| | Attachment #143316|0 |1 is obsolete| | Attachment #143317|0 |1 is obsolete| | Attachment #143318|0 |1 is obsolete| | Attachment #143319|0 |1 is obsolete| | Attachment #143320|0 |1 is obsolete| | Attachment #143321|0 |1 is obsolete| | --- Comment #279 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143322&action=edit Bug 31028: Add `tickets` and `ticket_updates` tables This patch adds the new `tickets` and `ticket_updates` tables for tracking catalog concern tickets. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #280 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143323&action=edit Bug 31028: DBIC Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #281 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143324&action=edit Bug 31028: Add new Koha::Object(s) classes This patch adds new Koha::Object(s) for the newly introduced tables, including updateing existing Koha::Objects adding new relations as required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #282 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143325&action=edit Bug 31028: Add API's for tickets This patch adds basic CRUD API's for the ticket endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #283 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143326&action=edit Bug 31028: Add `OpacCatalogConcerns` preference Enabling this preference should allow catalog concerns to be added by logged in patrons on the opac. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #284 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143327&action=edit Bug 31028: Add ability to report catalog concerns from the OPAC This patch adds the ability for patrons to report catalog concerns via the opac. Test plan 1) Enable the new `OpacCatalogConcerns` system preference 2) Navigate to the record details page of a biblio record on the OPAC 3) You should see a new 'Report a concern' option in the right side actions box 4) If not logged in you should have the login modal displayed and upon a successful login you should be redirected back to the details page with a new model displayed for entering concern details 5) Submit your concern with a title and details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #285 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143328&action=edit Bug 31028: Add configurable help text and templates This patch adds configurable help text and a template option to the catalog concern report modal in the OPAC. Test plan 1) Enable `OpacCatalogConcerns` preference 2) Build the CSS for the OPAC 3) Check that there is a 'CatalogConcernHelp' block listed in the HTML Customisations page. 4) On the OPAC navigate to a record and click the 'Report a concern' button. 5) Confirm that the content of 'CatalogConcernHelp' displays beneath the detail entry box and that it displays as expected. 6) Check that there is a 'CatalogConcernTemplate' block listed in the HTML customisations page. 7) On the OPAC 'Report a concern' modal, you should see the content of the 'CatalogConcernTemplate' block pre-filled in the details textarea. Note: There is a caveat to the template.. as textarea can only be used to submit plaintext with this patch and as such the template needs to not utilise the WYSIWYG editor else you will be faced with raw HTML inside your textarea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #286 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143329&action=edit Bug 31028: Add acknowledgement notice This patch adds an acknowledgement notice that will be sent to the opac user upon submission of a catalog concern report. Test plan 1) Confirm that a new notice template is added to the notices management page. 2) If using a sandbox, check the 'email log' from the management UI to see the resultant notice has been 'sent' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #287 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143330&action=edit Bug 31028: Add catalog concern management page to staff This patch adds a catalog concern management page to the staff client accessible via the cataloging home page and a new 'Pending catalog concerns' link on the front page. This includes added the requisit ticket_updates api endpoints and notice triggers and templates for notifying patrons of changes to their reported concerns. Test plan 1) Enable the `OpacCatalogConcerns` system preference 2) Catalog concern management is tied to your users ability to edit the catalog, `editcatalogue`. 3) Confirm that you can see 'Catalog concerns' listed on the cataloging home page if you have the `editcatalogue` permission and not if you do not. 4) Add a new concern as an opac user. 5) Confirm that once a concern is present in the system you see a count of 'catalog concerns pending' on the intranet main page if you have the `editcatalogue` permission. 6) Click through either the cataloging home page or pending concerns link on the main page to view the new concerns management page. 7) Confirm the table displays as one would expect. 8) Confirm clicking on details or the concern title exposes a 'details' modal with the option to add an update or resolve the concern. 9) Verify that if selecting 'notify' when updateing or resolving a concern triggers a notice to be sent to the opac user who first reported the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #288 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143331&action=edit Bug 31028: Add email notification of cataloguers on submissions This patch adds an optional cataloger notification to email the cataloging team whenever a new catalog concern is reported. Test plan 1) Enable `OpacCatalogConcerns` 2) Add at least one email address to the new `CatalogerEmails` prefernce (a comma delimited list is also allowed). 3) Confirm that a default template has been added to the Notices management, `TICKET_NOTIFY`. 4) Submit a new concern using the OPAC 5) Confirm that an email is sent to those email addresses listed in CatalogerEmails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #289 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143332&action=edit Bug 31028: Add ability to report concerns from the staff interface This patch brings the CatalogConcerns feature to the staff client allowing non-cataloguers to report issues with catalog records from the record details page. Test plan 1) Enable the new `CatalogConcerns` system preference 2) Confirm that without the `edit_catalogue` permission your user can submit a catalog concern via `New -> New catalog concern` from the toolbar on a records detail display. 3) Confirm that the right user was recorded as the reporter on the catalog concern management page (You must have logged in again as a user with the `edit_catalogue` permission to see this page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #290 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143333&action=edit Bug 31028: Add display to details page This patch adds the display of biblio specific concerns to the biblio detail display page. Test plan 1) Enable the feature as in prior patch test plans 2) Add a concern as per prior patch test plans 3) Confirm that a new tab appears at the bottom of the catalog record details display and all functionality from the concern management page is precent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #291 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143334&action=edit Bug 31028: (follow-up) System preference terminology Capitalise NOTE and swap 'client' for 'interface'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #292 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143335&action=edit Bug 31028: Only show pending concerns if there are some This patch adds logic to catch when pending_biblio_tickets equals zero. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #293 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143336&action=edit Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop the 'MENT' to ensure it fits. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #294 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143337&action=edit Bug 31028: (follow-up) Update notice module codes This patch updates the notice codes from 'catalog' to 'catalogue' to be consistent with the existing codebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #295 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143338&action=edit Bug 31028: (follow-up) Consistently style help-block This patch updates the opac and staff modals to set the help-block inside a div instead of a paragraph element allowing for the wysiwyg edited content to display as prescribed. We move the scss inside the fieldset definition to ensure we are specific enough to catch only the intended elements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #296 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143339&action=edit Bug 31028: Add feedback to the patron on submission This patch adds a success alert box when a patron submits a concern sucessfully. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #297 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143340&action=edit Bug 31028: (follow-up) Fix permissions names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #298 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143341&action=edit Bug 31028: (follow-up) Add <br> to notices This should resolve the lack of linebreaks in resulting emails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #299 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Found and resolved the issue with update/resolve emails not sending. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #300 from David Nind <david@davidnind.com> --- Thanks Martin for looking at things I raised! 1. An update is required to the DBIC Schema Update patch. The DBIC patch failed - I skipped this patch, and then ran dbic. 2. Displaying "Catalog concerns pending: X". I think I found the cause of the problem I was experiencing (using KTD and the koha (superliabrarian user)) - a capital P is required in line 180 for Koha.Preferences in intranet-main.tt (see 2.4). To replicate: 2.1 Enable OpacCatalogConcerns and add a concern using the OPAC. ==> Pending concerns are not displayed on the staff interface home page 2.2 Display logic and expected results when there are pending concerns and correct permissions: 2.2.1 CatalogConcerns and OpacCatalogConcerns: both enabled - displays 2.2.2 CatalogConcerns and OpacCatalogConcerns: both disabled - doesn't display 2.2.3 CatalogConcerns enabled and OpacCatalogConcerns disabled: displays 2.2.4 CatalogConcerns disabled and OpacCatalogConcerns enabled: displays 2.3 Currently with the preferences set as per 2.2.4, pending concerns are not displayed. 2.4 Edit line 180 of koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt - a capital P required for Koha.Preference . change Koha.preference('OpacCatalogConcerns') to Koha.Preference('OpacCatalogConcerns') 2.5 Set preferences as per 2.2.4 - refresh the home page and now pending concerns are now displayed. 3. Notices - now showing acknowledgement, update and resolved notices for a patron. Thanks for fixing! 4. Notices - notification to cataloguers still not coming through for me. I'll put this down to a combination of the email configuration for Gmail that I'm using and system preferences for email addresses. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143322|0 |1 is obsolete| | --- Comment #301 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143470&action=edit Bug 31028: Add `tickets` and `ticket_updates` tables This patch adds the new `tickets` and `ticket_updates` tables for tracking catalog concern tickets. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143323|0 |1 is obsolete| | --- Comment #302 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143471&action=edit Bug 31028: DBIC Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143324|0 |1 is obsolete| | --- Comment #303 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143472&action=edit Bug 31028: Add new Koha::Object(s) classes This patch adds new Koha::Object(s) for the newly introduced tables, including updateing existing Koha::Objects adding new relations as required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143325|0 |1 is obsolete| | --- Comment #304 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143473&action=edit Bug 31028: Add API's for tickets This patch adds basic CRUD API's for the ticket endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143326|0 |1 is obsolete| | --- Comment #305 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143474&action=edit Bug 31028: Add `OpacCatalogConcerns` preference Enabling this preference should allow catalog concerns to be added by logged in patrons on the opac. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143327|0 |1 is obsolete| | --- Comment #306 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143475&action=edit Bug 31028: Add ability to report catalog concerns from the OPAC This patch adds the ability for patrons to report catalog concerns via the opac. Test plan 1) Enable the new `OpacCatalogConcerns` system preference 2) Navigate to the record details page of a biblio record on the OPAC 3) You should see a new 'Report a concern' option in the right side actions box 4) If not logged in you should have the login modal displayed and upon a successful login you should be redirected back to the details page with a new model displayed for entering concern details 5) Submit your concern with a title and details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143328|0 |1 is obsolete| | --- Comment #307 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143476&action=edit Bug 31028: Add configurable help text and templates This patch adds configurable help text and a template option to the catalog concern report modal in the OPAC. Test plan 1) Enable `OpacCatalogConcerns` preference 2) Build the CSS for the OPAC 3) Check that there is a 'CatalogConcernHelp' block listed in the HTML Customisations page. 4) On the OPAC navigate to a record and click the 'Report a concern' button. 5) Confirm that the content of 'CatalogConcernHelp' displays beneath the detail entry box and that it displays as expected. 6) Check that there is a 'CatalogConcernTemplate' block listed in the HTML customisations page. 7) On the OPAC 'Report a concern' modal, you should see the content of the 'CatalogConcernTemplate' block pre-filled in the details textarea. Note: There is a caveat to the template.. as textarea can only be used to submit plaintext with this patch and as such the template needs to not utilise the WYSIWYG editor else you will be faced with raw HTML inside your textarea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143329|0 |1 is obsolete| | --- Comment #308 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143477&action=edit Bug 31028: Add acknowledgement notice This patch adds an acknowledgement notice that will be sent to the opac user upon submission of a catalog concern report. Test plan 1) Confirm that a new notice template is added to the notices management page. 2) If using a sandbox, check the 'email log' from the management UI to see the resultant notice has been 'sent' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143330|0 |1 is obsolete| | --- Comment #309 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143478&action=edit Bug 31028: Add catalog concern management page to staff This patch adds a catalog concern management page to the staff client accessible via the cataloging home page and a new 'Pending catalog concerns' link on the front page. This includes added the requisit ticket_updates api endpoints and notice triggers and templates for notifying patrons of changes to their reported concerns. Test plan 1) Enable the `OpacCatalogConcerns` system preference 2) Catalog concern management is tied to your users ability to edit the catalog, `editcatalogue`. 3) Confirm that you can see 'Catalog concerns' listed on the cataloging home page if you have the `editcatalogue` permission and not if you do not. 4) Add a new concern as an opac user. 5) Confirm that once a concern is present in the system you see a count of 'catalog concerns pending' on the intranet main page if you have the `editcatalogue` permission. 6) Click through either the cataloging home page or pending concerns link on the main page to view the new concerns management page. 7) Confirm the table displays as one would expect. 8) Confirm clicking on details or the concern title exposes a 'details' modal with the option to add an update or resolve the concern. 9) Verify that if selecting 'notify' when updateing or resolving a concern triggers a notice to be sent to the opac user who first reported the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143331|0 |1 is obsolete| | --- Comment #310 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143479&action=edit Bug 31028: Add email notification of cataloguers on submissions This patch adds an optional cataloger notification to email the cataloging team whenever a new catalog concern is reported. Test plan 1) Enable `OpacCatalogConcerns` 2) Add at least one email address to the new `CatalogerEmails` prefernce (a comma delimited list is also allowed). 3) Confirm that a default template has been added to the Notices management, `TICKET_NOTIFY`. 4) Submit a new concern using the OPAC 5) Confirm that an email is sent to those email addresses listed in CatalogerEmails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143332|0 |1 is obsolete| | --- Comment #311 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143480&action=edit Bug 31028: Add ability to report concerns from the staff interface This patch brings the CatalogConcerns feature to the staff client allowing non-cataloguers to report issues with catalog records from the record details page. Test plan 1) Enable the new `CatalogConcerns` system preference 2) Confirm that without the `edit_catalogue` permission your user can submit a catalog concern via `New -> New catalog concern` from the toolbar on a records detail display. 3) Confirm that the right user was recorded as the reporter on the catalog concern management page (You must have logged in again as a user with the `edit_catalogue` permission to see this page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143333|0 |1 is obsolete| | --- Comment #312 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143481&action=edit Bug 31028: Add display to details page This patch adds the display of biblio specific concerns to the biblio detail display page. Test plan 1) Enable the feature as in prior patch test plans 2) Add a concern as per prior patch test plans 3) Confirm that a new tab appears at the bottom of the catalog record details display and all functionality from the concern management page is precent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143334|0 |1 is obsolete| | --- Comment #313 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143482&action=edit Bug 31028: (follow-up) System preference terminology Capitalise NOTE and swap 'client' for 'interface'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143335|0 |1 is obsolete| | --- Comment #314 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143483&action=edit Bug 31028: Only show pending concerns if there are some This patch adds logic to catch when pending_biblio_tickets equals zero. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143336|0 |1 is obsolete| | --- Comment #315 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143484&action=edit Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop the 'MENT' to ensure it fits. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143337|0 |1 is obsolete| | --- Comment #316 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143485&action=edit Bug 31028: (follow-up) Update notice module codes This patch updates the notice codes from 'catalog' to 'catalogue' to be consistent with the existing codebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143338|0 |1 is obsolete| | --- Comment #317 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143486&action=edit Bug 31028: (follow-up) Consistently style help-block This patch updates the opac and staff modals to set the help-block inside a div instead of a paragraph element allowing for the wysiwyg edited content to display as prescribed. We move the scss inside the fieldset definition to ensure we are specific enough to catch only the intended elements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143339|0 |1 is obsolete| | --- Comment #318 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143487&action=edit Bug 31028: Add feedback to the patron on submission This patch adds a success alert box when a patron submits a concern sucessfully. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143340|0 |1 is obsolete| | --- Comment #319 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143488&action=edit Bug 31028: (follow-up) Fix permissions names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143341|0 |1 is obsolete| | --- Comment #320 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143489&action=edit Bug 31028: (follow-up) Add <br> to notices This should resolve the lack of linebreaks in resulting emails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #321 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143490&action=edit Bug 31028: (follow-up) Fix template whitespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #322 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Wow master is moving so fast.. Fixed the DBIC schema issue, thanks. Great spot of `p` vs `P`.. fixed now, thanks. 4. Notices - notification to cataloguers still not coming through for me. I'll put this down to a combination of the email configuration for Gmail that I'm using and system preferences for email addresses. This got me to dig a little further.. I found a regression from one of the rebases.. 'catalog' vs 'catalogue' module name.. sorted now. Whitespace in emails in the database is still an issue, but as they're HTML in the email client they should appear OK I believe. (I'm working on removing the superflous whitespace from the includes in a new bug now) Thanks again for all the testing David, Martin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #323 from David Nind <david@davidnind.com> --- Thanks Martin! Hopefully this is the last set of issues: 1. OPAC redirect to log in: - I get redirected to the login page - After enter the details, I get this message (in Firefox) (it may be something to do with bug 31699, and I haven't set things up correctly): "Oops. The site at http://127.0.0.1:8080/cgi-bin/koha/opac-user.pl?has-search-query=;return=http://127.0.0.1:8080/cgi-bin/koha/opac-detail.pl?biblionumber=262&query_desc=kw%2Cwrdl%3A%20perl&modal=concern has experienced a network protocol violation that cannot be repaired. The page you are trying to view cannot be shown because an error in the data transmission was detected. Please contact the website owners to inform them of this problem." 2. Catalog concerns landing page: the filter for the Status column doesn't seem to work: - Have two catalog concerns - one open and one closed - For the status column filter, start typing Open - No results shown Otherwise, happy to finally sign off! David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #324 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to David Nind from comment #323)
1. OPAC redirect to log in:
This was because of the work that happened on 21699 between times.. I've got a fix ready here now and will upload shortly.
2. Catalog concerns landing page: the filter for the Status column doesn't seem to work: - Have two catalog concerns - one open and one closed - For the status column filter, start typing Open - No results shown
This one is much harder.. searches happen serverside and run against the 'resolved_date' right now (i.e A search for the displayed words won't work as it's expecting to search on a date). It highlighted to me that I also display resolver name so we should fire against the firstname and lastname fields for the resolver (So a search for 'David' would filter.. but this doesn't help with a search for 'Open' still and I have no clear way around that.. we do have the filter at the top of the page especially for this reason though..) Should just remove searching for that field do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143470|0 |1 is obsolete| | --- Comment #325 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143647&action=edit Bug 31028: Add `tickets` and `ticket_updates` tables This patch adds the new `tickets` and `ticket_updates` tables for tracking catalog concern tickets. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143471|0 |1 is obsolete| | --- Comment #326 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143648&action=edit Bug 31028: DBIC Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143472|0 |1 is obsolete| | --- Comment #327 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143649&action=edit Bug 31028: Add new Koha::Object(s) classes This patch adds new Koha::Object(s) for the newly introduced tables, including updateing existing Koha::Objects adding new relations as required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143473|0 |1 is obsolete| | --- Comment #328 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143650&action=edit Bug 31028: Add API's for tickets This patch adds basic CRUD API's for the ticket endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143474|0 |1 is obsolete| | --- Comment #329 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143651&action=edit Bug 31028: Add `OpacCatalogConcerns` preference Enabling this preference should allow catalog concerns to be added by logged in patrons on the opac. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143475|0 |1 is obsolete| | --- Comment #330 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143652&action=edit Bug 31028: Add ability to report catalog concerns from the OPAC This patch adds the ability for patrons to report catalog concerns via the opac. Test plan 1) Enable the new `OpacCatalogConcerns` system preference 2) Navigate to the record details page of a biblio record on the OPAC 3) You should see a new 'Report a concern' option in the right side actions box 4) If not logged in you should have the login modal displayed and upon a successful login you should be redirected back to the details page with a new model displayed for entering concern details 5) Submit your concern with a title and details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143476|0 |1 is obsolete| | --- Comment #331 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143653&action=edit Bug 31028: Add configurable help text and templates This patch adds configurable help text and a template option to the catalog concern report modal in the OPAC. Test plan 1) Enable `OpacCatalogConcerns` preference 2) Build the CSS for the OPAC 3) Check that there is a 'CatalogConcernHelp' block listed in the HTML Customisations page. 4) On the OPAC navigate to a record and click the 'Report a concern' button. 5) Confirm that the content of 'CatalogConcernHelp' displays beneath the detail entry box and that it displays as expected. 6) Check that there is a 'CatalogConcernTemplate' block listed in the HTML customisations page. 7) On the OPAC 'Report a concern' modal, you should see the content of the 'CatalogConcernTemplate' block pre-filled in the details textarea. Note: There is a caveat to the template.. as textarea can only be used to submit plaintext with this patch and as such the template needs to not utilise the WYSIWYG editor else you will be faced with raw HTML inside your textarea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143477|0 |1 is obsolete| | --- Comment #332 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143654&action=edit Bug 31028: Add acknowledgement notice This patch adds an acknowledgement notice that will be sent to the opac user upon submission of a catalog concern report. Test plan 1) Confirm that a new notice template is added to the notices management page. 2) If using a sandbox, check the 'email log' from the management UI to see the resultant notice has been 'sent' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143478|0 |1 is obsolete| | --- Comment #333 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143655&action=edit Bug 31028: Add catalog concern management page to staff This patch adds a catalog concern management page to the staff client accessible via the cataloging home page and a new 'Pending catalog concerns' link on the front page. This includes added the requisit ticket_updates api endpoints and notice triggers and templates for notifying patrons of changes to their reported concerns. Test plan 1) Enable the `OpacCatalogConcerns` system preference 2) Catalog concern management is tied to your users ability to edit the catalog, `editcatalogue`. 3) Confirm that you can see 'Catalog concerns' listed on the cataloging home page if you have the `editcatalogue` permission and not if you do not. 4) Add a new concern as an opac user. 5) Confirm that once a concern is present in the system you see a count of 'catalog concerns pending' on the intranet main page if you have the `editcatalogue` permission. 6) Click through either the cataloging home page or pending concerns link on the main page to view the new concerns management page. 7) Confirm the table displays as one would expect. 8) Confirm clicking on details or the concern title exposes a 'details' modal with the option to add an update or resolve the concern. 9) Verify that if selecting 'notify' when updateing or resolving a concern triggers a notice to be sent to the opac user who first reported the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143479|0 |1 is obsolete| | --- Comment #334 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143656&action=edit Bug 31028: Add email notification of cataloguers on submissions This patch adds an optional cataloger notification to email the cataloging team whenever a new catalog concern is reported. Test plan 1) Enable `OpacCatalogConcerns` 2) Add at least one email address to the new `CatalogerEmails` prefernce (a comma delimited list is also allowed). 3) Confirm that a default template has been added to the Notices management, `TICKET_NOTIFY`. 4) Submit a new concern using the OPAC 5) Confirm that an email is sent to those email addresses listed in CatalogerEmails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143480|0 |1 is obsolete| | --- Comment #335 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143657&action=edit Bug 31028: Add ability to report concerns from the staff interface This patch brings the CatalogConcerns feature to the staff client allowing non-cataloguers to report issues with catalog records from the record details page. Test plan 1) Enable the new `CatalogConcerns` system preference 2) Confirm that without the `edit_catalogue` permission your user can submit a catalog concern via `New -> New catalog concern` from the toolbar on a records detail display. 3) Confirm that the right user was recorded as the reporter on the catalog concern management page (You must have logged in again as a user with the `edit_catalogue` permission to see this page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143481|0 |1 is obsolete| | --- Comment #336 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143658&action=edit Bug 31028: Add display to details page This patch adds the display of biblio specific concerns to the biblio detail display page. Test plan 1) Enable the feature as in prior patch test plans 2) Add a concern as per prior patch test plans 3) Confirm that a new tab appears at the bottom of the catalog record details display and all functionality from the concern management page is precent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143482|0 |1 is obsolete| | --- Comment #337 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143659&action=edit Bug 31028: (follow-up) System preference terminology Capitalise NOTE and swap 'client' for 'interface'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143483|0 |1 is obsolete| | --- Comment #338 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143660&action=edit Bug 31028: Only show pending concerns if there are some This patch adds logic to catch when pending_biblio_tickets equals zero. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143484|0 |1 is obsolete| | --- Comment #339 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143661&action=edit Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop the 'MENT' to ensure it fits. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143485|0 |1 is obsolete| | --- Comment #340 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143662&action=edit Bug 31028: (follow-up) Update notice module codes This patch updates the notice codes from 'catalog' to 'catalogue' to be consistent with the existing codebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143486|0 |1 is obsolete| | --- Comment #341 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143663&action=edit Bug 31028: (follow-up) Consistently style help-block This patch updates the opac and staff modals to set the help-block inside a div instead of a paragraph element allowing for the wysiwyg edited content to display as prescribed. We move the scss inside the fieldset definition to ensure we are specific enough to catch only the intended elements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143487|0 |1 is obsolete| | --- Comment #342 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143664&action=edit Bug 31028: Add feedback to the patron on submission This patch adds a success alert box when a patron submits a concern sucessfully. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143488|0 |1 is obsolete| | --- Comment #343 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143665&action=edit Bug 31028: (follow-up) Fix permissions names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143489|0 |1 is obsolete| | --- Comment #344 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143666&action=edit Bug 31028: (follow-up) Add <br> to notices This should resolve the lack of linebreaks in resulting emails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143490|0 |1 is obsolete| | --- Comment #345 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143667&action=edit Bug 31028: (follow-up) Fix template whitespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143667|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #346 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all your testing David, Hopefully this last rebase has the redirects working properly again. As for the searching issue on the Status column, I've got it searching on firstname, surname and date but I can't easily add a special case for 'Open' vs 'Resolved'.. but there are the filters at the top of the page for that.. I think this one will have to just come down to training. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #347 from David Nind <david@davidnind.com> --- Created attachment 143708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143708&action=edit Bug 31699: (follow-up) Protect more against open redirects This change checks that the OPACBaseURL exists, and uses its scheme and authority to rewrite the URL passed through the "return" param. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143647|0 |1 is obsolete| | --- Comment #348 from David Nind <david@davidnind.com> --- Created attachment 143709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143709&action=edit Bug 31028: Add `tickets` and `ticket_updates` tables This patch adds the new `tickets` and `ticket_updates` tables for tracking catalog concern tickets. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143649|0 |1 is obsolete| | --- Comment #349 from David Nind <david@davidnind.com> --- Created attachment 143710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143710&action=edit Bug 31028: Add new Koha::Object(s) classes This patch adds new Koha::Object(s) for the newly introduced tables, including updateing existing Koha::Objects adding new relations as required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143650|0 |1 is obsolete| | --- Comment #350 from David Nind <david@davidnind.com> --- Created attachment 143711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143711&action=edit Bug 31028: Add API's for tickets This patch adds basic CRUD API's for the ticket endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143651|0 |1 is obsolete| | --- Comment #351 from David Nind <david@davidnind.com> --- Created attachment 143712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143712&action=edit Bug 31028: Add `OpacCatalogConcerns` preference Enabling this preference should allow catalog concerns to be added by logged in patrons on the opac. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143652|0 |1 is obsolete| | --- Comment #352 from David Nind <david@davidnind.com> --- Created attachment 143713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143713&action=edit Bug 31028: Add ability to report catalog concerns from the OPAC This patch adds the ability for patrons to report catalog concerns via the opac. Test plan 1) Enable the new `OpacCatalogConcerns` system preference 2) Navigate to the record details page of a biblio record on the OPAC 3) You should see a new 'Report a concern' option in the right side actions box 4) If not logged in you should have the login modal displayed and upon a successful login you should be redirected back to the details page with a new model displayed for entering concern details 5) Submit your concern with a title and details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143653|0 |1 is obsolete| | --- Comment #353 from David Nind <david@davidnind.com> --- Created attachment 143714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143714&action=edit Bug 31028: Add configurable help text and templates This patch adds configurable help text and a template option to the catalog concern report modal in the OPAC. Test plan 1) Enable `OpacCatalogConcerns` preference 2) Build the CSS for the OPAC 3) Check that there is a 'CatalogConcernHelp' block listed in the HTML Customisations page. 4) On the OPAC navigate to a record and click the 'Report a concern' button. 5) Confirm that the content of 'CatalogConcernHelp' displays beneath the detail entry box and that it displays as expected. 6) Check that there is a 'CatalogConcernTemplate' block listed in the HTML customisations page. 7) On the OPAC 'Report a concern' modal, you should see the content of the 'CatalogConcernTemplate' block pre-filled in the details textarea. Note: There is a caveat to the template.. as textarea can only be used to submit plaintext with this patch and as such the template needs to not utilise the WYSIWYG editor else you will be faced with raw HTML inside your textarea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143654|0 |1 is obsolete| | --- Comment #354 from David Nind <david@davidnind.com> --- Created attachment 143715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143715&action=edit Bug 31028: Add acknowledgement notice This patch adds an acknowledgement notice that will be sent to the opac user upon submission of a catalog concern report. Test plan 1) Confirm that a new notice template is added to the notices management page. 2) If using a sandbox, check the 'email log' from the management UI to see the resultant notice has been 'sent' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143655|0 |1 is obsolete| | --- Comment #355 from David Nind <david@davidnind.com> --- Created attachment 143716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143716&action=edit Bug 31028: Add catalog concern management page to staff This patch adds a catalog concern management page to the staff client accessible via the cataloging home page and a new 'Pending catalog concerns' link on the front page. This includes added the requisit ticket_updates api endpoints and notice triggers and templates for notifying patrons of changes to their reported concerns. Test plan 1) Enable the `OpacCatalogConcerns` system preference 2) Catalog concern management is tied to your users ability to edit the catalog, `editcatalogue`. 3) Confirm that you can see 'Catalog concerns' listed on the cataloging home page if you have the `editcatalogue` permission and not if you do not. 4) Add a new concern as an opac user. 5) Confirm that once a concern is present in the system you see a count of 'catalog concerns pending' on the intranet main page if you have the `editcatalogue` permission. 6) Click through either the cataloging home page or pending concerns link on the main page to view the new concerns management page. 7) Confirm the table displays as one would expect. 8) Confirm clicking on details or the concern title exposes a 'details' modal with the option to add an update or resolve the concern. 9) Verify that if selecting 'notify' when updateing or resolving a concern triggers a notice to be sent to the opac user who first reported the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143656|0 |1 is obsolete| | --- Comment #356 from David Nind <david@davidnind.com> --- Created attachment 143717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143717&action=edit Bug 31028: Add email notification of cataloguers on submissions This patch adds an optional cataloger notification to email the cataloging team whenever a new catalog concern is reported. Test plan 1) Enable `OpacCatalogConcerns` 2) Add at least one email address to the new `CatalogerEmails` prefernce (a comma delimited list is also allowed). 3) Confirm that a default template has been added to the Notices management, `TICKET_NOTIFY`. 4) Submit a new concern using the OPAC 5) Confirm that an email is sent to those email addresses listed in CatalogerEmails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143657|0 |1 is obsolete| | --- Comment #357 from David Nind <david@davidnind.com> --- Created attachment 143718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143718&action=edit Bug 31028: Add ability to report concerns from the staff interface This patch brings the CatalogConcerns feature to the staff client allowing non-cataloguers to report issues with catalog records from the record details page. Test plan 1) Enable the new `CatalogConcerns` system preference 2) Confirm that without the `edit_catalogue` permission your user can submit a catalog concern via `New -> New catalog concern` from the toolbar on a records detail display. 3) Confirm that the right user was recorded as the reporter on the catalog concern management page (You must have logged in again as a user with the `edit_catalogue` permission to see this page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143658|0 |1 is obsolete| | --- Comment #358 from David Nind <david@davidnind.com> --- Created attachment 143719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143719&action=edit Bug 31028: Add display to details page This patch adds the display of biblio specific concerns to the biblio detail display page. Test plan 1) Enable the feature as in prior patch test plans 2) Add a concern as per prior patch test plans 3) Confirm that a new tab appears at the bottom of the catalog record details display and all functionality from the concern management page is precent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143659|0 |1 is obsolete| | --- Comment #359 from David Nind <david@davidnind.com> --- Created attachment 143720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143720&action=edit Bug 31028: (follow-up) System preference terminology Capitalise NOTE and swap 'client' for 'interface'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143660|0 |1 is obsolete| | --- Comment #360 from David Nind <david@davidnind.com> --- Created attachment 143721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143721&action=edit Bug 31028: Only show pending concerns if there are some This patch adds logic to catch when pending_biblio_tickets equals zero. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143661|0 |1 is obsolete| | --- Comment #361 from David Nind <david@davidnind.com> --- Created attachment 143722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143722&action=edit Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop the 'MENT' to ensure it fits. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143662|0 |1 is obsolete| | --- Comment #362 from David Nind <david@davidnind.com> --- Created attachment 143723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143723&action=edit Bug 31028: (follow-up) Update notice module codes This patch updates the notice codes from 'catalog' to 'catalogue' to be consistent with the existing codebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143663|0 |1 is obsolete| | --- Comment #363 from David Nind <david@davidnind.com> --- Created attachment 143724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143724&action=edit Bug 31028: (follow-up) Consistently style help-block This patch updates the opac and staff modals to set the help-block inside a div instead of a paragraph element allowing for the wysiwyg edited content to display as prescribed. We move the scss inside the fieldset definition to ensure we are specific enough to catch only the intended elements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143664|0 |1 is obsolete| | --- Comment #364 from David Nind <david@davidnind.com> --- Created attachment 143725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143725&action=edit Bug 31028: Add feedback to the patron on submission This patch adds a success alert box when a patron submits a concern sucessfully. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143665|0 |1 is obsolete| | --- Comment #365 from David Nind <david@davidnind.com> --- Created attachment 143726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143726&action=edit Bug 31028: (follow-up) Fix permissions names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143666|0 |1 is obsolete| | --- Comment #366 from David Nind <david@davidnind.com> --- Created attachment 143727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143727&action=edit Bug 31028: (follow-up) Add <br> to notices This should resolve the lack of linebreaks in resulting emails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #367 from David Nind <david@davidnind.com> --- (In reply to Martin Renvoize from comment #346)
Thanks for all your testing David,
Hopefully this last rebase has the redirects working properly again.
As for the searching issue on the Status column, I've got it searching on firstname, surname and date but I can't easily add a special case for 'Open' vs 'Resolved'.. but there are the filters at the top of the page for that.. I think this one will have to just come down to training.
Thanks Martin! Good call - I think this is pretty minor in the scheme of things! I've signed off, but the DBIC patch no longer applies - I skipped this and then ran dbic (things are moving so quickly!)... On the OPAC for the report a concern form, the template text is now below the input form and help text - I'm assuming it is to do with the DBIC patch not working. If not, I'll let you add a follow-up patch! I'll also attach an updated consolidated testing plan/notes, if this is any help for the QA Team and documenting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #368 from David Nind <david@davidnind.com> --- Updated consolidated test plan/notes - may (or may not) make it easier for testing/QA/documenting as there are so many patches: 1. Apply patches 2. Update database: updatedatabase 3. Build CSS: 3.1 yarn install 3.2 yarn build 3.3 yarn build --opac 4. Setup for testing: 4.1 Configure email for testing the work flow and notices - see [1] for using Gmail and an app password 4.2 Add an email address to the patron account used for testing the OPAC (for example, koha) 4.3 Add an email address to the staff account used for testing the staff interface (for example, koha) 4.4 Add an email address to the new CatalogerEmails system preference 5. Report a catalog concern from the OPAC: 5.1 Enable the new system preference: OpacCatalogConcerns 5.2 Search for a record and view the details page 5.3 There is now a "Report a concern" link in the actions box on the right-hand sidebar (under "Suggest a purchase") 5.4 Click on "Report a concern" 5.5 Add some information to the form (Title, information for each of the headings) and click Submit 5.6 Success message:"Your concern was successfully submitted." 5.7 Repeat steps 5.2-5.6 for another record 5.7 Log out from the OPAC and click on the "Report a concern" link for a record - you should be prompted to log in. After logging in, you are then redirected back to the record page and the form is displayed to report a concern. 5.8 Confirm emails received: . Patron that logged the cataloging concern should have received a "Catalog concern acknowledgement" message . The email address configured for CatalogerEmails system preference should have received a "Catalog concern reported" message 6. Manage catalog concerns from the staff interface: 6.1 From the staff interface home page, select the "Catalog concerns pending: 2" link after the main module links. OR 6.0 Go to Cataloging > Reports > Catalog concerns 6.4 The concern(s) you entered on the OPAC should be listed 6.5 Click on "Details" in the actions column ==> Ticket details displayed in a modal window 6.6 Add some text in the update field for the concern, select the Notify checkbox, and click on the Comment button 6.7 Click the "Details" action again, add an update, select the Notify checkbox, and click on the Resolve button 6.8 Check that the table filters for each column work as expected 6.9 Check that "Hide resolved" and "Show all" filters for the page work as expected 6.10 Check that notifications are sent: . process the mail queue: misc/cronjobs/process_message_queue.pl . the patron should receive a "Catalog concern updated" and "Catalog concern resolved" messages 7. Report a catalog concern from the staff interface: 7.1 Enable the CatalogConcerns system preference 7.1 Search for a record and view the details page 7.2 Select New > New catalog concern 7.4 Enter a title and details, and submit 7.5 Catalog concerns created by staff are managed in the exact same way as those reported from the OPAC - see 6. (includes email notifications) 8. View catalog concerns for a record in the staff interface: 8.1 Go to the record that a concern was logged for in step 5 8.2 Note that there is now a "Concerns" tab for the record 8.3 The "Concerns" tab should list catalog concerns, and you can view the "Details" and manage concern in the same way as step 6 9. Notifications: 9.1 There are four new notice templates in the Catalog category: TICKET_NOTIFY, TICKET_ACKNOWLEDGE, TICKET_RESOLVE, TICKET_UPDATE (see Tools > Patrons and circulation > Notices and slips) 9.2 Prevous steps should have triggered the various notices: . TICKET_ACKNOWLEDGE: email to patron when they raise a concern . TICKET_NOTIFY: email to library staff when a concern is raised . TICKET_UPDATE: add an update to a concern . TICKET_RESOLVE: when concern marked as resolved 9.3 Check that you can see the notices for the patron used in step 5 in their account: Patron details > Notices section 10. Test with OPACReportProblem enabled: 10.1 Enable the system preference 10.2 Submit a "Report a problem" report from the OPAC 10.3 Check that this works as expected in the staff interface, and that both pending problem reports and catalog concerns are displayed 10.4 BONUS tests (optional): test various combinations of enabling and disabling suggestions, OPACReportProblem, AllowCheckoutNotes, OpacCatalogConcerns, and CatalogConcerns system preferences 11. Test a non-super librarian and set them up so that they can manage catalog concerns: 11.1 Add a username and password to a staff user (for example: Henry Acevedo) 11.2 Set the account so that they have some permissions, such as staff access, suggestion management, place and manage holds, but NOT Edit catalog (editcatalogue) 11.3 Log in to the staff interface 11.4 With active concerns, you should not see "Catalog concerns pending: X" on the home page or be able to access Cataloging > Reports > Catalog concerns 11.5 Change their permissions so that they have the Edit catalog (editcatalogue) permission 11.6 You should now see the pending concerns on the home page and be able to view and manage catalog concerns 12. Table configuration: have some active catalog concerns, click configure, hide status column by default, check that you can toggle the status column on and off. 13. Customise the catalog concern help text and template: 13.1 Go to Tools > HTML customizations 13.2 Note that there are two entries available for editing: CatalogConcernHelp and CatalogConcernTemplate 13.3 Make some edits to the CatalogConcernTemplate (note: only use the text editor) 13.4 Make some edits to the CatalogConcernHelp using the WYSIWYG editor - add a bulleted list and some bold text 13.5 Go to report a concern from the OPAC and staff interface 13.6 The changes you made should be reflected in the report a concern forms [1] Set up KTD so that email can be sent (using a Gmail address and an app password): Fromm your Gmail account, set up an App Password. Add these lines (with <user_name> and <password> updated) to /etc/koha/sites/kohadev/koha-conf.xml: <smtp_server> <host>smtp.gmail.com</host> <port>587</port> <timeout>5</timeout> <ssl_mode>STARTTLS</ssl_mode> <user_name>YOURGMAILADDRESS</user_name> <password>GMAILAPPPASSORD</password> <debug>1</debug> </smtp_server> restart_all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435 [Bug 32435] Add resolution types to catalog concerns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32436 [Bug 32436] Add 'quick replies' to catalog concerns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143709|0 |1 is obsolete| | --- Comment #369 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144647&action=edit Bug 31028: Add `tickets` and `ticket_updates` tables This patch adds the new `tickets` and `ticket_updates` tables for tracking catalog concern tickets. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143648|0 |1 is obsolete| | --- Comment #370 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144648&action=edit Bug 31028: DBIC Schema update Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143710|0 |1 is obsolete| | --- Comment #371 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144649&action=edit Bug 31028: Add new Koha::Object(s) classes This patch adds new Koha::Object(s) for the newly introduced tables, including updateing existing Koha::Objects adding new relations as required. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143711|0 |1 is obsolete| | --- Comment #372 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144650&action=edit Bug 31028: Add API's for tickets This patch adds basic CRUD API's for the ticket endpoints. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143712|0 |1 is obsolete| | --- Comment #373 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144651&action=edit Bug 31028: Add `OpacCatalogConcerns` preference Enabling this preference should allow catalog concerns to be added by logged in patrons on the opac. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143713|0 |1 is obsolete| | --- Comment #374 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144652&action=edit Bug 31028: Add ability to report catalog concerns from the OPAC This patch adds the ability for patrons to report catalog concerns via the opac. Test plan 1) Enable the new `OpacCatalogConcerns` system preference 2) Navigate to the record details page of a biblio record on the OPAC 3) You should see a new 'Report a concern' option in the right side actions box 4) If not logged in you should have the login modal displayed and upon a successful login you should be redirected back to the details page with a new model displayed for entering concern details 5) Submit your concern with a title and details. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143714|0 |1 is obsolete| | --- Comment #375 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144653&action=edit Bug 31028: Add configurable help text and templates This patch adds configurable help text and a template option to the catalog concern report modal in the OPAC. Test plan 1) Enable `OpacCatalogConcerns` preference 2) Build the CSS for the OPAC 3) Check that there is a 'CatalogConcernHelp' block listed in the HTML Customisations page. 4) On the OPAC navigate to a record and click the 'Report a concern' button. 5) Confirm that the content of 'CatalogConcernHelp' displays beneath the detail entry box and that it displays as expected. 6) Check that there is a 'CatalogConcernTemplate' block listed in the HTML customisations page. 7) On the OPAC 'Report a concern' modal, you should see the content of the 'CatalogConcernTemplate' block pre-filled in the details textarea. Note: There is a caveat to the template.. as textarea can only be used to submit plaintext with this patch and as such the template needs to not utilise the WYSIWYG editor else you will be faced with raw HTML inside your textarea. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143715|0 |1 is obsolete| | --- Comment #376 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144654&action=edit Bug 31028: Add acknowledgement notice This patch adds an acknowledgement notice that will be sent to the opac user upon submission of a catalog concern report. Test plan 1) Confirm that a new notice template is added to the notices management page. 2) If using a sandbox, check the 'email log' from the management UI to see the resultant notice has been 'sent' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143716|0 |1 is obsolete| | --- Comment #377 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144655&action=edit Bug 31028: Add catalog concern management page to staff This patch adds a catalog concern management page to the staff client accessible via the cataloging home page and a new 'Pending catalog concerns' link on the front page. This includes added the requisit ticket_updates api endpoints and notice triggers and templates for notifying patrons of changes to their reported concerns. Test plan 1) Enable the `OpacCatalogConcerns` system preference 2) Catalog concern management is tied to your users ability to edit the catalog, `editcatalogue`. 3) Confirm that you can see 'Catalog concerns' listed on the cataloging home page if you have the `editcatalogue` permission and not if you do not. 4) Add a new concern as an opac user. 5) Confirm that once a concern is present in the system you see a count of 'catalog concerns pending' on the intranet main page if you have the `editcatalogue` permission. 6) Click through either the cataloging home page or pending concerns link on the main page to view the new concerns management page. 7) Confirm the table displays as one would expect. 8) Confirm clicking on details or the concern title exposes a 'details' modal with the option to add an update or resolve the concern. 9) Verify that if selecting 'notify' when updateing or resolving a concern triggers a notice to be sent to the opac user who first reported the issue. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143717|0 |1 is obsolete| | --- Comment #378 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144656&action=edit Bug 31028: Add email notification of cataloguers on submissions This patch adds an optional cataloger notification to email the cataloging team whenever a new catalog concern is reported. Test plan 1) Enable `OpacCatalogConcerns` 2) Add at least one email address to the new `CatalogerEmails` prefernce (a comma delimited list is also allowed). 3) Confirm that a default template has been added to the Notices management, `TICKET_NOTIFY`. 4) Submit a new concern using the OPAC 5) Confirm that an email is sent to those email addresses listed in CatalogerEmails. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143718|0 |1 is obsolete| | --- Comment #379 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144657&action=edit Bug 31028: Add ability to report concerns from the staff interface This patch brings the CatalogConcerns feature to the staff client allowing non-cataloguers to report issues with catalog records from the record details page. Test plan 1) Enable the new `CatalogConcerns` system preference 2) Confirm that without the `edit_catalogue` permission your user can submit a catalog concern via `New -> New catalog concern` from the toolbar on a records detail display. 3) Confirm that the right user was recorded as the reporter on the catalog concern management page (You must have logged in again as a user with the `edit_catalogue` permission to see this page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143719|0 |1 is obsolete| | --- Comment #380 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144658&action=edit Bug 31028: Add display to details page This patch adds the display of biblio specific concerns to the biblio detail display page. Test plan 1) Enable the feature as in prior patch test plans 2) Add a concern as per prior patch test plans 3) Confirm that a new tab appears at the bottom of the catalog record details display and all functionality from the concern management page is precent. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143720|0 |1 is obsolete| | --- Comment #381 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144659&action=edit Bug 31028: (follow-up) System preference terminology Capitalise NOTE and swap 'client' for 'interface'. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143721|0 |1 is obsolete| | --- Comment #382 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144660&action=edit Bug 31028: Only show pending concerns if there are some This patch adds logic to catch when pending_biblio_tickets equals zero. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143722|0 |1 is obsolete| | --- Comment #383 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144661&action=edit Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop the 'MENT' to ensure it fits. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143723|0 |1 is obsolete| | --- Comment #384 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144662&action=edit Bug 31028: (follow-up) Update notice module codes This patch updates the notice codes from 'catalog' to 'catalogue' to be consistent with the existing codebase. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143724|0 |1 is obsolete| | --- Comment #385 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144663&action=edit Bug 31028: (follow-up) Consistently style help-block This patch updates the opac and staff modals to set the help-block inside a div instead of a paragraph element allowing for the wysiwyg edited content to display as prescribed. We move the scss inside the fieldset definition to ensure we are specific enough to catch only the intended elements. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143725|0 |1 is obsolete| | --- Comment #386 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144664&action=edit Bug 31028: Add feedback to the patron on submission This patch adds a success alert box when a patron submits a concern sucessfully. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143726|0 |1 is obsolete| | --- Comment #387 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144665&action=edit Bug 31028: (follow-up) Fix permissions names Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143727|0 |1 is obsolete| | --- Comment #388 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144666&action=edit Bug 31028: (follow-up) Add <br> to notices This should resolve the lack of linebreaks in resulting emails Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #389 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144667&action=edit Bug 31028: (follow-up) Fix notices whitespace We we're using [% %] rather than [%- -%] in our the notice template introduced with this patchset. This leads to some interesting rendering results in some email clients. Using the proper whitespace ignoring template markup fixes the situation. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #390 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144668&action=edit Bug 31028: Update patron and biblio includes to remove whitespace These includes used lots of [% %] blocks instead of [%- -%] and as such the produced markup contains superflous spacing. This is OK in the browser, but for some reason does affect rendering in HTML email. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143708|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #391 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #392 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145542&action=edit Bug 31028: (QA follow-up) Fix misc QA issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #393 from Kyle M Hall <kyle@bywatersolutions.com> --- Please add unit tests for the new modules and REST APIs! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #394 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nearly there here.. I've rolled the QA fixes into the various commits and added tests for all the new object methods and api's introduced. However.. writing those tests has made me want to do a tiny bit of refactoring.. I'm going to move the notice generation that currently happens inside the API controller into the Koha::Ticket::Update object to match what I did for similar message generation in the Koha::Ticket store method. Once I've done that, I'll also want to enhance/add some additional unit tests to cover those notices and ticket triggers. Hopefully I'll get all that done on Monday and have a fresh patchset to upload... thanks for taking a look already Kyle.. I'll poke again once we're ready for a final review. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144647|0 |1 is obsolete| | --- Comment #395 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146214&action=edit Bug 31028: Add `tickets` and `ticket_updates` tables This patch adds the new `tickets` and `ticket_updates` tables for tracking catalog concern tickets. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144648|0 |1 is obsolete| | --- Comment #396 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146215&action=edit Bug 31028: DBIC Schema update Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144649|0 |1 is obsolete| | --- Comment #397 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146216&action=edit Bug 31028: Add new Koha::Object(s) classes This patch adds new Koha::Object(s) for the newly introduced tables, including updateing existing Koha::Objects adding new relations as required. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144650|0 |1 is obsolete| | --- Comment #398 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146217&action=edit Bug 31028: Add API's for tickets This patch adds basic CRUD API's for the ticket endpoints. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144651|0 |1 is obsolete| | --- Comment #399 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146218&action=edit Bug 31028: Add `OpacCatalogConcerns` preference Enabling this preference should allow catalog concerns to be added by logged in patrons on the opac. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144652|0 |1 is obsolete| | --- Comment #400 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146219&action=edit Bug 31028: Add ability to report catalog concerns from the OPAC This patch adds the ability for patrons to report catalog concerns via the opac. Test plan 1) Enable the new `OpacCatalogConcerns` system preference 2) Navigate to the record details page of a biblio record on the OPAC 3) You should see a new 'Report a concern' option in the right side actions box 4) If not logged in you should have the login modal displayed and upon a successful login you should be redirected back to the details page with a new model displayed for entering concern details 5) Submit your concern with a title and details. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144653|0 |1 is obsolete| | --- Comment #401 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146220&action=edit Bug 31028: Add configurable help text and templates This patch adds configurable help text and a template option to the catalog concern report modal in the OPAC. Test plan 1) Enable `OpacCatalogConcerns` preference 2) Build the CSS for the OPAC 3) Check that there is a 'CatalogConcernHelp' block listed in the HTML Customisations page. 4) On the OPAC navigate to a record and click the 'Report a concern' button. 5) Confirm that the content of 'CatalogConcernHelp' displays beneath the detail entry box and that it displays as expected. 6) Check that there is a 'CatalogConcernTemplate' block listed in the HTML customisations page. 7) On the OPAC 'Report a concern' modal, you should see the content of the 'CatalogConcernTemplate' block pre-filled in the details textarea. Note: There is a caveat to the template.. as textarea can only be used to submit plaintext with this patch and as such the template needs to not utilise the WYSIWYG editor else you will be faced with raw HTML inside your textarea. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144654|0 |1 is obsolete| | --- Comment #402 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146221&action=edit Bug 31028: Add acknowledgement notice This patch adds an acknowledgement notice that will be sent to the opac user upon submission of a catalog concern report. Test plan 1) Confirm that a new notice template is added to the notices management page. 2) If using a sandbox, check the 'email log' from the management UI to see the resultant notice has been 'sent' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144655|0 |1 is obsolete| | --- Comment #403 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146222&action=edit Bug 31028: Add catalog concern management page to staff This patch adds a catalog concern management page to the staff client accessible via the cataloging home page and a new 'Pending catalog concerns' link on the front page. This includes added the requisit ticket_updates api endpoints and notice triggers and templates for notifying patrons of changes to their reported concerns. Test plan 1) Enable the `OpacCatalogConcerns` system preference 2) Catalog concern management is tied to your users ability to edit the catalog, `editcatalogue`. 3) Confirm that you can see 'Catalog concerns' listed on the cataloging home page if you have the `editcatalogue` permission and not if you do not. 4) Add a new concern as an opac user. 5) Confirm that once a concern is present in the system you see a count of 'catalog concerns pending' on the intranet main page if you have the `editcatalogue` permission. 6) Click through either the cataloging home page or pending concerns link on the main page to view the new concerns management page. 7) Confirm the table displays as one would expect. 8) Confirm clicking on details or the concern title exposes a 'details' modal with the option to add an update or resolve the concern. 9) Verify that if selecting 'notify' when updateing or resolving a concern triggers a notice to be sent to the opac user who first reported the issue. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144656|0 |1 is obsolete| | --- Comment #404 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146223&action=edit Bug 31028: Add email notification of cataloguers on submissions This patch adds an optional cataloger notification to email the cataloging team whenever a new catalog concern is reported. Test plan 1) Enable `OpacCatalogConcerns` 2) Add at least one email address to the new `CatalogerEmails` prefernce (a comma delimited list is also allowed). 3) Confirm that a default template has been added to the Notices management, `TICKET_NOTIFY`. 4) Submit a new concern using the OPAC 5) Confirm that an email is sent to those email addresses listed in CatalogerEmails. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144657|0 |1 is obsolete| | --- Comment #405 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146224&action=edit Bug 31028: Add ability to report concerns from the staff interface This patch brings the CatalogConcerns feature to the staff client allowing non-cataloguers to report issues with catalog records from the record details page. Test plan 1) Enable the new `CatalogConcerns` system preference 2) Confirm that without the `edit_catalogue` permission your user can submit a catalog concern via `New -> New catalog concern` from the toolbar on a records detail display. 3) Confirm that the right user was recorded as the reporter on the catalog concern management page (You must have logged in again as a user with the `edit_catalogue` permission to see this page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144658|0 |1 is obsolete| | --- Comment #406 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146225&action=edit Bug 31028: Add display to details page This patch adds the display of biblio specific concerns to the biblio detail display page. Test plan 1) Enable the feature as in prior patch test plans 2) Add a concern as per prior patch test plans 3) Confirm that a new tab appears at the bottom of the catalog record details display and all functionality from the concern management page is precent. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144659|0 |1 is obsolete| | --- Comment #407 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146226&action=edit Bug 31028: (follow-up) System preference terminology Capitalise NOTE and swap 'client' for 'interface'. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144660|0 |1 is obsolete| | --- Comment #408 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146227&action=edit Bug 31028: Only show pending concerns if there are some This patch adds logic to catch when pending_biblio_tickets equals zero. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144661|0 |1 is obsolete| | --- Comment #409 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146228&action=edit Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop the 'MENT' to ensure it fits. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144662|0 |1 is obsolete| | --- Comment #410 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146229&action=edit Bug 31028: (follow-up) Update notice module codes This patch updates the notice codes from 'catalog' to 'catalogue' to be consistent with the existing codebase. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144663|0 |1 is obsolete| | --- Comment #411 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146230&action=edit Bug 31028: (follow-up) Consistently style help-block This patch updates the opac and staff modals to set the help-block inside a div instead of a paragraph element allowing for the wysiwyg edited content to display as prescribed. We move the scss inside the fieldset definition to ensure we are specific enough to catch only the intended elements. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144664|0 |1 is obsolete| | --- Comment #412 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146231&action=edit Bug 31028: Add feedback to the patron on submission This patch adds a success alert box when a patron submits a concern sucessfully. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144665|0 |1 is obsolete| | --- Comment #413 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146232&action=edit Bug 31028: (follow-up) Fix permissions names Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144666|0 |1 is obsolete| | --- Comment #414 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146233&action=edit Bug 31028: (follow-up) Add <br> to notices This should resolve the lack of linebreaks in resulting emails Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144667|0 |1 is obsolete| | --- Comment #415 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146234&action=edit Bug 31028: (follow-up) Fix notices whitespace We we're using [% %] rather than [%- -%] in our the notice template introduced with this patchset. This leads to some interesting rendering results in some email clients. Using the proper whitespace ignoring template markup fixes the situation. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144668|0 |1 is obsolete| | --- Comment #416 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146235&action=edit Bug 31028: Update patron and biblio includes to remove whitespace These includes used lots of [% %] blocks instead of [%- -%] and as such the produced markup contains superflous spacing. This is OK in the browser, but for some reason does affect rendering in HTML email. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #417 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146236&action=edit Bug 31028: Unit tests for ticket create notice triggers This patch adds unit tests for the two notices that can be triggered upon ticket creation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #418 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146237&action=edit Bug 31028: Unit tests for ticket update api's This patch adds the missing unit tests for the ticket updates api endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #419 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Back to you Kyle.. I metric tonne of unit tests added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146214|0 |1 is obsolete| | --- Comment #420 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146238&action=edit Bug 31028: Add `tickets` and `ticket_updates` tables This patch adds the new `tickets` and `ticket_updates` tables for tracking catalog concern tickets. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146215|0 |1 is obsolete| | --- Comment #421 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146239&action=edit Bug 31028: DBIC Schema update Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146216|0 |1 is obsolete| | --- Comment #422 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146240&action=edit Bug 31028: Add new Koha::Object(s) classes This patch adds new Koha::Object(s) for the newly introduced tables, including updateing existing Koha::Objects adding new relations as required. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146217|0 |1 is obsolete| | --- Comment #423 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146241&action=edit Bug 31028: Add API's for tickets This patch adds basic CRUD API's for the ticket endpoints. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146218|0 |1 is obsolete| | --- Comment #424 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146242&action=edit Bug 31028: Add `OpacCatalogConcerns` preference Enabling this preference should allow catalog concerns to be added by logged in patrons on the opac. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146219|0 |1 is obsolete| | --- Comment #425 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146243&action=edit Bug 31028: Add ability to report catalog concerns from the OPAC This patch adds the ability for patrons to report catalog concerns via the opac. Test plan 1) Enable the new `OpacCatalogConcerns` system preference 2) Navigate to the record details page of a biblio record on the OPAC 3) You should see a new 'Report a concern' option in the right side actions box 4) If not logged in you should have the login modal displayed and upon a successful login you should be redirected back to the details page with a new model displayed for entering concern details 5) Submit your concern with a title and details. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146220|0 |1 is obsolete| | --- Comment #426 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146244&action=edit Bug 31028: Add configurable help text and templates This patch adds configurable help text and a template option to the catalog concern report modal in the OPAC. Test plan 1) Enable `OpacCatalogConcerns` preference 2) Build the CSS for the OPAC 3) Check that there is a 'CatalogConcernHelp' block listed in the HTML Customisations page. 4) On the OPAC navigate to a record and click the 'Report a concern' button. 5) Confirm that the content of 'CatalogConcernHelp' displays beneath the detail entry box and that it displays as expected. 6) Check that there is a 'CatalogConcernTemplate' block listed in the HTML customisations page. 7) On the OPAC 'Report a concern' modal, you should see the content of the 'CatalogConcernTemplate' block pre-filled in the details textarea. Note: There is a caveat to the template.. as textarea can only be used to submit plaintext with this patch and as such the template needs to not utilise the WYSIWYG editor else you will be faced with raw HTML inside your textarea. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146221|0 |1 is obsolete| | --- Comment #427 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146245&action=edit Bug 31028: Add acknowledgement notice This patch adds an acknowledgement notice that will be sent to the opac user upon submission of a catalog concern report. Test plan 1) Confirm that a new notice template is added to the notices management page. 2) If using a sandbox, check the 'email log' from the management UI to see the resultant notice has been 'sent' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146222|0 |1 is obsolete| | --- Comment #428 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146246&action=edit Bug 31028: Add catalog concern management page to staff This patch adds a catalog concern management page to the staff client accessible via the cataloging home page and a new 'Pending catalog concerns' link on the front page. This includes added the requisit ticket_updates api endpoints and notice triggers and templates for notifying patrons of changes to their reported concerns. Test plan 1) Enable the `OpacCatalogConcerns` system preference 2) Catalog concern management is tied to your users ability to edit the catalog, `editcatalogue`. 3) Confirm that you can see 'Catalog concerns' listed on the cataloging home page if you have the `editcatalogue` permission and not if you do not. 4) Add a new concern as an opac user. 5) Confirm that once a concern is present in the system you see a count of 'catalog concerns pending' on the intranet main page if you have the `editcatalogue` permission. 6) Click through either the cataloging home page or pending concerns link on the main page to view the new concerns management page. 7) Confirm the table displays as one would expect. 8) Confirm clicking on details or the concern title exposes a 'details' modal with the option to add an update or resolve the concern. 9) Verify that if selecting 'notify' when updateing or resolving a concern triggers a notice to be sent to the opac user who first reported the issue. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146223|0 |1 is obsolete| | --- Comment #429 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146247&action=edit Bug 31028: Add email notification of cataloguers on submissions This patch adds an optional cataloger notification to email the cataloging team whenever a new catalog concern is reported. Test plan 1) Enable `OpacCatalogConcerns` 2) Add at least one email address to the new `CatalogerEmails` prefernce (a comma delimited list is also allowed). 3) Confirm that a default template has been added to the Notices management, `TICKET_NOTIFY`. 4) Submit a new concern using the OPAC 5) Confirm that an email is sent to those email addresses listed in CatalogerEmails. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146224|0 |1 is obsolete| | --- Comment #430 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146248&action=edit Bug 31028: Add ability to report concerns from the staff interface This patch brings the CatalogConcerns feature to the staff client allowing non-cataloguers to report issues with catalog records from the record details page. Test plan 1) Enable the new `CatalogConcerns` system preference 2) Confirm that without the `edit_catalogue` permission your user can submit a catalog concern via `New -> New catalog concern` from the toolbar on a records detail display. 3) Confirm that the right user was recorded as the reporter on the catalog concern management page (You must have logged in again as a user with the `edit_catalogue` permission to see this page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146225|0 |1 is obsolete| | --- Comment #431 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146249&action=edit Bug 31028: Add display to details page This patch adds the display of biblio specific concerns to the biblio detail display page. Test plan 1) Enable the feature as in prior patch test plans 2) Add a concern as per prior patch test plans 3) Confirm that a new tab appears at the bottom of the catalog record details display and all functionality from the concern management page is precent. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146226|0 |1 is obsolete| | --- Comment #432 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146250&action=edit Bug 31028: (follow-up) System preference terminology Capitalise NOTE and swap 'client' for 'interface'. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146227|0 |1 is obsolete| | --- Comment #433 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146251&action=edit Bug 31028: Only show pending concerns if there are some This patch adds logic to catch when pending_biblio_tickets equals zero. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146228|0 |1 is obsolete| | --- Comment #434 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146252&action=edit Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop the 'MENT' to ensure it fits. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146229|0 |1 is obsolete| | --- Comment #435 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146253&action=edit Bug 31028: (follow-up) Update notice module codes This patch updates the notice codes from 'catalog' to 'catalogue' to be consistent with the existing codebase. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146230|0 |1 is obsolete| | --- Comment #436 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146254&action=edit Bug 31028: (follow-up) Consistently style help-block This patch updates the opac and staff modals to set the help-block inside a div instead of a paragraph element allowing for the wysiwyg edited content to display as prescribed. We move the scss inside the fieldset definition to ensure we are specific enough to catch only the intended elements. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146231|0 |1 is obsolete| | --- Comment #437 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146255&action=edit Bug 31028: Add feedback to the patron on submission This patch adds a success alert box when a patron submits a concern sucessfully. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146232|0 |1 is obsolete| | --- Comment #438 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146256&action=edit Bug 31028: (follow-up) Fix permissions names Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146233|0 |1 is obsolete| | --- Comment #439 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146257&action=edit Bug 31028: (follow-up) Add <br> to notices This should resolve the lack of linebreaks in resulting emails Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146234|0 |1 is obsolete| | --- Comment #440 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146258&action=edit Bug 31028: (follow-up) Fix notices whitespace We we're using [% %] rather than [%- -%] in our the notice template introduced with this patchset. This leads to some interesting rendering results in some email clients. Using the proper whitespace ignoring template markup fixes the situation. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146235|0 |1 is obsolete| | --- Comment #441 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146259&action=edit Bug 31028: Update patron and biblio includes to remove whitespace These includes used lots of [% %] blocks instead of [%- -%] and as such the produced markup contains superflous spacing. This is OK in the browser, but for some reason does affect rendering in HTML email. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146236|0 |1 is obsolete| | --- Comment #442 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146260&action=edit Bug 31028: Unit tests for ticket create notice triggers This patch adds unit tests for the two notices that can be triggered upon ticket creation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146237|0 |1 is obsolete| | --- Comment #443 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146261&action=edit Bug 31028: Unit tests for ticket update api's This patch adds the missing unit tests for the ticket updates api endpoints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #444 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146262&action=edit Bug 31028: (follow-up) Mark public as boolean -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #445 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm getting unit test failures for: t/db_dependent/Circulation.t t/db_dependent/Accounts.t t/db_dependent/Auth_with_ldap.t t/db_dependent/Illrequests.t among others. It seems like a good number of the failures are related to notices, and centered around the inclusion of html_helpers.inc in Letters.pm I'm not sure how to remedy these failures, I tried using newline eaters in html_helpers.inc but it proved insufficient. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #446 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146697&action=edit Bug 31028: (follow-up) Move html_helpers into notices This patch removes the addition of html_helpers out of C4::Letters and into the relevant notice templates where it belongs. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #447 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch Kyle.. that's my mistake, I thought I'd already moved that into the notice templates themselves. Back into the queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Bug 31028 depends on bug 31699, which changed state. Bug 31699 Summary: Add a generic way to redirect back to the page you were on at login for modal logins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://gitlab.com/mrenvoiz | |e/Koha/-/tree/bug_31028 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146238|0 |1 is obsolete| | Attachment #146239|0 |1 is obsolete| | Attachment #146240|0 |1 is obsolete| | Attachment #146241|0 |1 is obsolete| | Attachment #146242|0 |1 is obsolete| | Attachment #146243|0 |1 is obsolete| | Attachment #146244|0 |1 is obsolete| | Attachment #146245|0 |1 is obsolete| | Attachment #146246|0 |1 is obsolete| | Attachment #146247|0 |1 is obsolete| | Attachment #146248|0 |1 is obsolete| | Attachment #146249|0 |1 is obsolete| | Attachment #146250|0 |1 is obsolete| | Attachment #146251|0 |1 is obsolete| | Attachment #146252|0 |1 is obsolete| | Attachment #146253|0 |1 is obsolete| | Attachment #146254|0 |1 is obsolete| | Attachment #146255|0 |1 is obsolete| | Attachment #146256|0 |1 is obsolete| | Attachment #146257|0 |1 is obsolete| | Attachment #146258|0 |1 is obsolete| | Attachment #146259|0 |1 is obsolete| | Attachment #146260|0 |1 is obsolete| | Attachment #146261|0 |1 is obsolete| | Attachment #146262|0 |1 is obsolete| | Attachment #146697|0 |1 is obsolete| | --- Comment #448 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146870&action=edit Bug 31028: Add `tickets` and `ticket_updates` tables This patch adds the new `tickets` and `ticket_updates` tables for tracking catalog concern tickets. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #449 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146871&action=edit Bug 31028: DBIC Schema update Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #450 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146872&action=edit Bug 31028: Add new Koha::Object(s) classes This patch adds new Koha::Object(s) for the newly introduced tables, including updateing existing Koha::Objects adding new relations as required. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #451 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146873&action=edit Bug 31028: Add API's for tickets This patch adds basic CRUD API's for the ticket endpoints. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #452 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146874&action=edit Bug 31028: Add `OpacCatalogConcerns` preference Enabling this preference should allow catalog concerns to be added by logged in patrons on the opac. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #453 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146875&action=edit Bug 31028: Add ability to report catalog concerns from the OPAC This patch adds the ability for patrons to report catalog concerns via the opac. Test plan 1) Enable the new `OpacCatalogConcerns` system preference 2) Navigate to the record details page of a biblio record on the OPAC 3) You should see a new 'Report a concern' option in the right side actions box 4) If not logged in you should have the login modal displayed and upon a successful login you should be redirected back to the details page with a new model displayed for entering concern details 5) Submit your concern with a title and details. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #454 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146876&action=edit Bug 31028: Add configurable help text and templates This patch adds configurable help text and a template option to the catalog concern report modal in the OPAC. Test plan 1) Enable `OpacCatalogConcerns` preference 2) Build the CSS for the OPAC 3) Check that there is a 'CatalogConcernHelp' block listed in the HTML Customisations page. 4) On the OPAC navigate to a record and click the 'Report a concern' button. 5) Confirm that the content of 'CatalogConcernHelp' displays beneath the detail entry box and that it displays as expected. 6) Check that there is a 'CatalogConcernTemplate' block listed in the HTML customisations page. 7) On the OPAC 'Report a concern' modal, you should see the content of the 'CatalogConcernTemplate' block pre-filled in the details textarea. Note: There is a caveat to the template.. as textarea can only be used to submit plaintext with this patch and as such the template needs to not utilise the WYSIWYG editor else you will be faced with raw HTML inside your textarea. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #455 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146877&action=edit Bug 31028: Add acknowledgement notice This patch adds an acknowledgement notice that will be sent to the opac user upon submission of a catalog concern report. Test plan 1) Confirm that a new notice template is added to the notices management page. 2) If using a sandbox, check the 'email log' from the management UI to see the resultant notice has been 'sent' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #456 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146878&action=edit Bug 31028: Add catalog concern management page to staff This patch adds a catalog concern management page to the staff client accessible via the cataloging home page and a new 'Pending catalog concerns' link on the front page. This includes added the requisit ticket_updates api endpoints and notice triggers and templates for notifying patrons of changes to their reported concerns. Test plan 1) Enable the `OpacCatalogConcerns` system preference 2) Catalog concern management is tied to your users ability to edit the catalog, `editcatalogue`. 3) Confirm that you can see 'Catalog concerns' listed on the cataloging home page if you have the `editcatalogue` permission and not if you do not. 4) Add a new concern as an opac user. 5) Confirm that once a concern is present in the system you see a count of 'catalog concerns pending' on the intranet main page if you have the `editcatalogue` permission. 6) Click through either the cataloging home page or pending concerns link on the main page to view the new concerns management page. 7) Confirm the table displays as one would expect. 8) Confirm clicking on details or the concern title exposes a 'details' modal with the option to add an update or resolve the concern. 9) Verify that if selecting 'notify' when updateing or resolving a concern triggers a notice to be sent to the opac user who first reported the issue. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #457 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146879&action=edit Bug 31028: Add email notification of cataloguers on submissions This patch adds an optional cataloger notification to email the cataloging team whenever a new catalog concern is reported. Test plan 1) Enable `OpacCatalogConcerns` 2) Add at least one email address to the new `CatalogerEmails` prefernce (a comma delimited list is also allowed). 3) Confirm that a default template has been added to the Notices management, `TICKET_NOTIFY`. 4) Submit a new concern using the OPAC 5) Confirm that an email is sent to those email addresses listed in CatalogerEmails. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #458 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146880&action=edit Bug 31028: Add ability to report concerns from the staff interface This patch brings the CatalogConcerns feature to the staff client allowing non-cataloguers to report issues with catalog records from the record details page. Test plan 1) Enable the new `CatalogConcerns` system preference 2) Confirm that without the `edit_catalogue` permission your user can submit a catalog concern via `New -> New catalog concern` from the toolbar on a records detail display. 3) Confirm that the right user was recorded as the reporter on the catalog concern management page (You must have logged in again as a user with the `edit_catalogue` permission to see this page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #459 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146881&action=edit Bug 31028: Add display to details page This patch adds the display of biblio specific concerns to the biblio detail display page. Test plan 1) Enable the feature as in prior patch test plans 2) Add a concern as per prior patch test plans 3) Confirm that a new tab appears at the bottom of the catalog record details display and all functionality from the concern management page is precent. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #460 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146882&action=edit Bug 31028: (follow-up) System preference terminology Capitalise NOTE and swap 'client' for 'interface'. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #461 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146883&action=edit Bug 31028: Only show pending concerns if there are some This patch adds logic to catch when pending_biblio_tickets equals zero. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #462 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146884&action=edit Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop the 'MENT' to ensure it fits. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #463 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146885&action=edit Bug 31028: (follow-up) Update notice module codes This patch updates the notice codes from 'catalog' to 'catalogue' to be consistent with the existing codebase. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #464 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146886&action=edit Bug 31028: (follow-up) Consistently style help-block This patch updates the opac and staff modals to set the help-block inside a div instead of a paragraph element allowing for the wysiwyg edited content to display as prescribed. We move the scss inside the fieldset definition to ensure we are specific enough to catch only the intended elements. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #465 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146887&action=edit Bug 31028: Add feedback to the patron on submission This patch adds a success alert box when a patron submits a concern sucessfully. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #466 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146888&action=edit Bug 31028: (follow-up) Fix permissions names Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #467 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146889&action=edit Bug 31028: (follow-up) Add <br> to notices This should resolve the lack of linebreaks in resulting emails Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #468 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146890&action=edit Bug 31028: (follow-up) Fix notices whitespace We we're using [% %] rather than [%- -%] in our the notice template introduced with this patchset. This leads to some interesting rendering results in some email clients. Using the proper whitespace ignoring template markup fixes the situation. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #469 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146891&action=edit Bug 31028: Update patron and biblio includes to remove whitespace These includes used lots of [% %] blocks instead of [%- -%] and as such the produced markup contains superflous spacing. This is OK in the browser, but for some reason does affect rendering in HTML email. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #470 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146892&action=edit Bug 31028: Unit tests for ticket create notice triggers This patch adds unit tests for the two notices that can be triggered upon ticket creation. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #471 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146893&action=edit Bug 31028: Unit tests for ticket update api's This patch adds the missing unit tests for the ticket updates api endpoints. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #472 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146894&action=edit Bug 31028: (follow-up) Mark public as boolean Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #473 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146895&action=edit Bug 31028: (follow-up) Move html_helpers into notices This patch removes the addition of html_helpers out of C4::Letters and into the relevant notice templates where it belongs. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #474 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146896&action=edit Bug 31028: (QA follow-up) Add koha_object(s)_class methods to TicketUpdate.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #475 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #476 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Awesome to see this in, thanks Tomas! As much as I'd love to backport this personally.. it's clearly a whole new feature so marking as 'Needs documentation' and we won't be backporting to 22.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137412|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #477 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147797&action=edit Final specification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #478 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The notice is generated with a lot of br tags: https://snipboard.io/ku4cOA.jpg Also note the missing space: Thankyou -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #479 from Jonathan Druart <jonathan.druart+koha@gmail.com> ---
Bug 31028: Update patron and biblio includes to remove whitespace
Well, now it's missing a whitespace between the surname and firstname: " Modify patron EdnaAcosta (23529001000463) (Patron)" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #480 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Failing tests. koha_1 | # Failed test at xt/find-misplaced-executables.t line 54. koha_1 | # got: '2' koha_1 | # expected: '0' koha_1 | # $VAR1 = './t/db_dependent/api/v1/ticket_updates.t'; koha_1 | # $VAR2 = './t/db_dependent/Koha/Ticket.t'; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #481 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- In datatables.js: if ( value === 'special:undefined' ) { That smells! Why don't you simply filter on an invisible column? I think that's how we do in other places. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #482 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #481)
In datatables.js: if ( value === 'special:undefined' ) {
That smells! Why don't you simply filter on an invisible column? I think that's how we do in other places.
Additionally, that does not work: Uncaught TypeError: concerns.DataTable is not a function After I replace "concerns" with "tickets" (which is the correct var name), it still does not work: the table is not filtered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #483 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147840&action=edit Bug 31028: (follow-up) Fix missing whitespace on patron-title This patch restores some missing whitespace in the patron-title include. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #484 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147841&action=edit Bug 31028: (follow-up) Fix executable bit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #485 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Two issue fixed in those follow-ups.. As for the special:undefined.. I tried a number of different ways to achieve this and none were any more elegant.. Please explain what you mean by 'filter on an invisible column'... Clearly this has broken with the many rebases I had to do in this area.. before I attempt to fix it as it was I'd like to hear if you have a better approach. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #486 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #485)
Two issue fixed in those follow-ups..
As for the special:undefined.. I tried a number of different ways to achieve this and none were any more elegant.. Please explain what you mean by 'filter on an invisible column'...
Clearly this has broken with the many rebases I had to do in this area.. before I attempt to fix it as it was I'd like to hear if you have a better approach.
Add the info you want to filter on in a separate column, then hide the column and use it for filtering purpose. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #487 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #486)
(In reply to Martin Renvoize from comment #485)
Two issue fixed in those follow-ups..
As for the special:undefined.. I tried a number of different ways to achieve this and none were any more elegant.. Please explain what you mean by 'filter on an invisible column'...
Clearly this has broken with the many rebases I had to do in this area.. before I attempt to fix it as it was I'd like to hear if you have a better approach.
Add the info you want to filter on in a separate column, then hide the column and use it for filtering purpose.
The point was I'm looking for a way to pass 'null' to the API so I can get 'WHERE resolved_date IS NULL' in the query.. I'm not sure how a hidden column will achieve that. Having said that.. the client side of this seems to send exactly the same as where I have this live and working for a customer.. so it would appear it's the API that's changed. I do have a minor improvement to my special:undefined fix (for working with multiple fields in a single column.. I didn't spot that until today).. but that doesn't resolve the underlying functionality issue :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #488 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147844&action=edit Bug 31028: (follow-up) Ensure special handling works accross fields This patch updates the `special:undefined` handling to work correctly over a datatable column that's made up of multiple database fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147840|0 |1 is obsolete| | --- Comment #489 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147859&action=edit Bug 31028: (follow-up) Fix missing whitespace on patron-title This patch restores some missing whitespace in the patron-title include. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147841|0 |1 is obsolete| | --- Comment #490 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147860&action=edit Bug 31028: (follow-up) Fix executable bit Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #491 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147861&action=edit Bug 31028: (follow-up) Remove special:undefined There's a cleaner way to achieve this now using `additional_filters` and passing a function. This patch removes the `special:undefined` handling, replacing it with a single field filter passed as a function via additional_filters. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147844|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #492 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks have to go to Jonathan here for helping me understand the issues here. Follow-ups should resolve the issues he raised and lead to cleaner, more accurate, code too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147861|0 |1 is obsolete| | --- Comment #493 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147866&action=edit Bug 31028: (follow-up) Remove special:undefined There's a cleaner way to achieve this now using `additional_filters` and passing a function. This patch removes the `special:undefined` handling, replacing it with a single field filter passed as a function via additional_filters. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #494 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Found something else: * The "Add concern" modal has "Please describe your concern: " in red, which implies it's mandatory. However you can submit even if the textarea is empty * When you submit the concern, the tab is not updated and the number of concerns is still 0 "Concerns (0)" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #495 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- New construct in kohastructure added here: +DROP TABLE IF EXISTS `tickets`; +/*!40101 SET @saved_cs_client = @@character_set_client */; +/*!40101 SET character_set_client = utf8 */; +CREATE TABLE IF NOT EXISTS `tickets` ( +DROP TABLE IF EXISTS `ticket_updates`; +/*!40101 SET @saved_cs_client = @@character_set_client */; +/*!40101 SET character_set_client = utf8 */; +CREATE TABLE IF NOT EXISTS `ticket_updates` ( Drop if exists. Create if not. Second check should not be needed.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32334 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33286 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286 [Bug 33286] 'Catalog record' should be 'Bibliographic record' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33288 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33288 [Bug 33288] Catalog concerns - Fallback email when CatalogerEmails is empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33266 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33266 [Bug 33266] Patron name missing space before surname -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33313 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33315 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33315 [Bug 33315] Missing space in TICKET_NOTIFY -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33327 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33327 [Bug 33327] Hide resolved catalog concerns by default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #496 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148673&action=edit Bug 31028: (follow-up) Unify table creation This patch updates kohastructure to use the same syntax we use everywhere else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33494 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33494 [Bug 33494] Catalog concerns - Toggle 'Hide resolved' and 'Show all' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33498 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33498 [Bug 33498] Catalog concerns - Lots of whitespace before the notice text -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/655 Documentation| |Caroline Cyr La Rose contact| | --- Comment #497 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I finished documenting this, but I see there are some patches that still need to be pushed. I hesitate to put it to "RESOLVED", but I don't have many choices after "Needs documenting" (RESOLVED or CLOSED). Can someone with more permissions maybe put it back to Passed QA or Signed off? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #498 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Caroline Cyr La Rose from comment #497)
I finished documenting this, but I see there are some patches that still need to be pushed. I hesitate to put it to "RESOLVED", but I don't have many choices after "Needs documenting" (RESOLVED or CLOSED).
Can someone with more permissions maybe put it back to Passed QA or Signed off?
Hi Caroline, it's a workflow thing, not a permission thing. You can only jump to certain status from one status... so you might have to step through some in order to get to where you want to be. - Maybe we could improve this for Needs documenting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33532 [Bug 33532] Catalog concerns - Title of the page says Tools instead of Cataloging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148673|0 |1 is obsolete| | --- Comment #499 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149931&action=edit Bug 31028: (follow-up) Unify table creation This patch updates kohastructure to use the same syntax we use everywhere else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #500 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think it's just the very last patch thats still outstanding on master.. it's just a tidy up so not 100% required, but a nice to have for consistency in our kohastructure file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33593 [Bug 33593] CatalogConcernTemplate needs to be HTML -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33314 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33658 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 [Bug 33658] Capitalization: **To Reproduce** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This brings the catalog release notes| |concerns feature to the | |OPAC and staff interface | |allowing non-cataloguers to | |report issues with catalog | |records from the record | |details page. | |Reported | |concerns will be visible in | |the dashboard on the staff | |interface start page. | |The | |feature can be enabled for | |OPAC and staff interface | |separately using the | |`OpacCatalogConcerns` and | |`CatalogConcerns` system | |preferences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This brings the catalog |This brings a new catalog release notes|concerns feature to the |concerns feature to the |OPAC and staff interface |OPAC and staff interface, |allowing non-cataloguers to |allowing non-cataloguers to |report issues with catalog |report issues with catalog |records from the record |records from the record |details page. |details pages. |Reported | |concerns will be visible in |Reported |the dashboard on the staff |concerns will be visible in |interface start page. |the dashboard on the staff |The |interface start page and |feature can be enabled for |available from the |OPAC and staff interface |cataloguing home page. |separately using the | |`OpacCatalogConcerns` and |The |`CatalogConcerns` system |feature can be |preferences. |independently enabled for | |OPAC and staff interface | |using the | |`OpacCatalogConcerns` and | |`CatalogConcerns` system | |preferences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This brings a new catalog |**Sponsored by** *Tavistock release notes|concerns feature to the |& Portman Library* |OPAC and staff interface, | |allowing non-cataloguers to |This |report issues with catalog |brings a new catalog |records from the record |concerns feature to the |details pages. |OPAC and staff interface, | |allowing non-cataloguers to |Reported |report issues with catalog |concerns will be visible in |records from the record |the dashboard on the staff |details pages. |interface start page and | |available from the |Reported |cataloguing home page. |concerns will be visible in | |the dashboard on the staff |The |interface start page and |feature can be |available from the |independently enabled for |cataloguing home page. |OPAC and staff interface | |using the |The |`OpacCatalogConcerns` and |feature can be |`CatalogConcerns` system |independently enabled for |preferences. |OPAC and staff interface | |using the | |`OpacCatalogConcerns` and | |`CatalogConcerns` system | |preferences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255 [Bug 34255] Add an enquiry/request/workflow management module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|34255 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255 [Bug 34255] Add an enquiry/request/workflow management module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255 [Bug 34255] Add an enquiry/request/workflow management module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34324 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34324 [Bug 34324] Merge OPACProblemReport and CatalogConcern functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|34255 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255 [Bug 34255] Add an enquiry/request/workflow management module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27052 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33759 [Bug 33759] Typo: Thankyou -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35081 [Bug 35081] "Your concern was sucessfully submitted." untranslatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35615 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35615 [Bug 35615] Merge AllowCheckoutNotes and CatalogConcern functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35616 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35616 [Bug 35616] Add a 'source' field to Koha::Tickets to denote the path taken to report the ticket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|34324 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34324 [Bug 34324] Merge OPACProblemReport and CatalogConcern functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35615 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35615 [Bug 35615] Merge AllowCheckoutNotes and CatalogConcern functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 [Bug 35628] Add additional statuses to catalog concerns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32435 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435 [Bug 32435] Add resolution types to catalog concerns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35628 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 [Bug 35628] Add additional statuses to catalog concerns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35657 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657 [Bug 35657] Add ability to assign tickets to librarians for catalog concerns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35657 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657 [Bug 35657] Add ability to assign tickets to librarians for catalog concerns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #501 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The modal only opens on opac-detail, however "Report a concern" is displayed on other pages (opac-isbd, opac-marc, etc.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35961 [Bug 35961] Modal include missing for catalog concerns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36612 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36612 [Bug 36612] The public tickets endpoint needs public fields list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32436 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32436 [Bug 32436] Add 'quick replies' to catalog concerns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36705 [Bug 36705] The 'Add new concern' button for catalog concerns is hidden away -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org