https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Bug ID: 40419 Summary: xt/find-license-problems.t isn't catching all instances of 51 Franklin St/Street Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org kohadev-koha@kohadevbox:koha(main)$ git grep '51 Franklin St' Koha/Course.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Course/Instructor.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Course/Instructors.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Course/Item.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Course/Items.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Course/Reserve.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Course/Reserves.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Courses.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Exceptions/MarcOverlayRule.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/REST/V1/CirculationRules.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. etc/zebradb/authorities/etc/dom-config-marc.xml:Free Software Foundation, 51 Franklin Street, Fifth Floor, Boston, etc/zebradb/authorities/etc/dom-config.xml:Free Software Foundation, 51 Franklin Street, Fifth Floor, Boston, etc/zebradb/biblios/etc/dom-config-marc.xml:Free Software Foundation, 51 Franklin Street, Fifth Floor, Boston, etc/zebradb/biblios/etc/dom-config.xml:Free Software Foundation, 51 Franklin Street, Fifth Floor, Boston, etc/zebradb/xsl/zebra.xsl:Free Software Foundation, 51 Franklin Street, Fifth Floor, Boston, koha-tmpl/intranet-tmpl/lib/greybox/GreyBox_v5_5/LGPL.txt: 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA koha-tmpl/intranet-tmpl/lib/greybox/GreyBox_v5_5/LGPL.txt: Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA koha-tmpl/intranet-tmpl/lib/tiny_mce/license.txt: 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA koha-tmpl/intranet-tmpl/lib/tiny_mce/license.txt: Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA koha-tmpl/opac-tmpl/lib/greybox/GreyBox_v5_5/LGPL.txt: 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA koha-tmpl/opac-tmpl/lib/greybox/GreyBox_v5_5/LGPL.txt: Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA xt/find-license-problems.t: $hasfranklinst = 1 if ( $line =~ /51 Franklin Street/ ); Two things here: 1. Sometimes it is 51 Franklin St and other times '51 Franklin Street' 2. Some of these are passing because they do do not contain the string 'Copyright'. We should probably catch all of these instances? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.