https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jake Deery from comment #20)
Any chance of a QA for this one in time for 24.11?
You wont pass the bug freeze anymore now. Sorry. Note that this feels like an enh instead of a bug ? This does not look good: + my $value = $input->param($field) if $input->param($field) ne ''; + $infos->{$field} = $value if defined $value; Never declare a variable with an if statement like that. The next line you are referring to it. Our qa tools see it too: FAIL tools/modborrowers.pl FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 4) Please tidy too. -- You are receiving this mail because: You are watching all bug changes.