https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I feel like we are trying to solve something that is not really a problem here, or I missed the original goal of this change. I do see how it can be useful to use this component for some specific data, but I don't think it is relevant for vendors. Anyway I've found 2 problematic behaviours with this patch: * If you go to /cgi-bin/koha/erm/agreements/add you will see 2 fetches: /api/v1/acquisitions/vendors?_per_page=-1 /api/v1/acquisitions/vendors?_page=1&_per_page=20 We can question the second fetch (and the next ones), why do we need to fetch if we fetched them all (and stored them) already? * The filtering does not work, it only works on the items fetched already. To recreate: Go to /cgi-bin/koha/erm/agreements/add, don't scroll down, search for a vendor name that is not in the set we fetched already => The vendor is not displayed. The main problem here is the first query that fetches all the vendors. And it will be hard to remove it as we need it for the column filtering feature. We could still use the component for other data, but the filtering bug needs to be fixed then. -- You are receiving this mail because: You are watching all bug changes.