[Bug 32474] New: Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Bug ID: 32474 Summary: Implement infinite scroll in vue-select Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: martin.renvoize@ptfs-europe.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com Depends on: 32468 We're using the vue-select component for our select pulldowns in ERM. We could do with reaching feature parity with our select2 wrapper and part of that is to implement an ajax driven infinite scroll as suggested in bug 32468. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 [Bug 32468] Vendors select only allows selecting from first 20 vendors by default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |testopia@bugs.koha-communit | |y.org Assignee|jonathan.druart+koha@gmail. |koha-bugs@lists.koha-commun |com |ity.org Component|ERM |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 144614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144614&action=edit Bug 32474: Infinite scrolling of selects Investigation of this shows that the data is loaded on first mount of the ERMMain.vue component and then cached in a Pinia store. This commit shows an example of an infinite scroll without the need for Ajax based scrolling as the data is already available and injected into AgreementsFormAdd.vue. I don't think we need Ajax based scrolling on these vendor selects as the data is front-loaded and cached. Based on that we would have two options: 1) Keep the selects as they are currently with all data available as per Jonathan's patch in bug 32468 2) Use the infinite scrolling as per this commit and extract that logic into a new component that we can plug in to all the components that use a select for vendors Let me know your thoughts, if you think option 2 is better then I am happy to pull that together Test plan for this commit: 1) Create more than 20 new vendors, the more you create the more obvious the infinite scroll 2) Add a new agreement and observe that the vendor select limits the selection to 20 vendors 3) Apply patch 4) Add a new agreement and observe that the vendor select now loads more options as you scroll -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- If we are going with infinity scroll I think it should be ajax-based. Only with this patch I am not sure I are getting much benefits. The idea would be to avoid a big GET when loading the app that would retrieve thousands of vendors. It's not an easy task, as we will want to implement it for other fetches (license, agreements, etc.) that populate dropdown lists. Don't forget to not embed main.js in your patch :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- I think we could use a single component for this and pass the type of data (vendor, agreement, license) as a prop to this to determine which API route is called. I'll experiment with getting the Ajax scrolling to work in a re-useable component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 144719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144719&action=edit Test data population script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 144720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144720&action=edit Bug 32474: Ajax based infinite scroll selects I have created a reuseable component called InfiniteScrollSelect which allows v-selects to load options in a paginated manner through Ajax requests rather than making expensive Ajax calls when the select box is first opened. All v-selects that are likely to need this functionality have been updated for Agreements, Licenses, Packages and Vendors. Test Plan: To test this requires adding enough dummy data to show the pagination fully. I have written a script that does this, please see the attachments if you wish to use this. 1) Navigate to a window that offers a dropdown menu for either Vendors, Agreements, Licenses, Packages. 2) Observe that all data is already pre-loaded into the options list and only one request is made for this data regardless of data size 3) Apply patch 4) Navigate to the same select box and observe that only the first 20 values are available with paginated Ajax requests being made as you scroll down -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144614|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32493 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32493 [Bug 32493] Vendor store loads unpaginated vendor list on ERM module main page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32494 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32494 [Bug 32494] Potentially expensive API calls made for conditional template rendering -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am getting a conflict, can you rebase please? Also, could you run the tidy script, I am seeing invalid changes: - licenses: [], + licenses: [], (space at the end of the line) Make sure you set up the pre-commit git hook https://wiki.koha-community.org/wiki/Tips_and_tricks#Hooks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144720|0 |1 is obsolete| | --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 145143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145143&action=edit Bug 32474: Ajax based infinite scroll selects I have created a reuseable component called InfiniteScrollSelect which allows v-selects to load options in a paginated manner through Ajax requests rather than making expensive Ajax calls when the select box is first opened. All v-selects that are likely to need this functionality have been updated for Agreements, Licenses, Packages and Vendors. Test Plan: To test this requires adding enough dummy data to show the pagination fully. I have written a script that does this, please see the attachments if you wish to use this. 1) Navigate to a window that offers a dropdown menu for either Vendors, Agreements, Licenses, Packages. 2) Observe that all data is already pre-loaded into the options list and only one request is made for this data regardless of data size 3) Apply patch 4) Navigate to the same select box and observe that only the first 20 values are available with paginated Ajax requests being made as you scroll down -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145143|0 |1 is obsolete| | --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 145144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145144&action=edit Bug 32474: Ajax based infinite scroll selects I have created a reuseable component called InfiniteScrollSelect which allows v-selects to load options in a paginated manner through Ajax requests rather than making expensive Ajax calls when the select box is first opened. All v-selects that are likely to need this functionality have been updated for Agreements, Licenses, Packages and Vendors. Test Plan: To test this requires adding enough dummy data to show the pagination fully. I have written a script that does this, please see the attachments if you wish to use this. 1) Navigate to a window that offers a dropdown menu for either Vendors, Agreements, Licenses, Packages. 2) Observe that all data is already pre-loaded into the options list and only one request is made for this data regardless of data size 3) Apply patch 4) Navigate to the same select box and observe that only the first 20 values are available with paginated Ajax requests being made as you scroll down -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145144|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 145154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145154&action=edit Bug 32474: Ajax based infinite scroll selects I have created a reuseable component called InfiniteScrollSelect which allows v-selects to load options in a paginated manner through Ajax requests rather than making expensive Ajax calls when the select box is first opened. All v-selects that are likely to need this functionality have been updated for Agreements, Licenses, Packages and Vendors. Test Plan: To test this requires adding enough dummy data to show the pagination fully. I have written a script that does this, please see the attachments if you wish to use this. 1) Navigate to a window that offers a dropdown menu for either Vendors, Agreements, Licenses, Packages. 2) Observe that all data is already pre-loaded into the options list and only one request is made for this data regardless of data size 3) Apply patch 4) Navigate to the same select box and observe that only the first 20 values are available with paginated Ajax requests being made as you scroll down Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Bug 32474 depends on bug 32468, which changed state. Bug 32468 Summary: Vendors select only allows selecting from first 20 vendors by default https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I feel like we are trying to solve something that is not really a problem here, or I missed the original goal of this change. I do see how it can be useful to use this component for some specific data, but I don't think it is relevant for vendors. Anyway I've found 2 problematic behaviours with this patch: * If you go to /cgi-bin/koha/erm/agreements/add you will see 2 fetches: /api/v1/acquisitions/vendors?_per_page=-1 /api/v1/acquisitions/vendors?_page=1&_per_page=20 We can question the second fetch (and the next ones), why do we need to fetch if we fetched them all (and stored them) already? * The filtering does not work, it only works on the items fetched already. To recreate: Go to /cgi-bin/koha/erm/agreements/add, don't scroll down, search for a vendor name that is not in the set we fetched already => The vendor is not displayed. The main problem here is the first query that fetches all the vendors. And it will be hard to remove it as we need it for the column filtering feature. We could still use the component for other data, but the filtering bug needs to be fixed then. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Additionally: * This is only displayed for the second fetch. + <li v-show="hasNextPage" ref="load" class="loader"> + {{ $__("Loading more options...") }} + </li> To recreate (add a 'sleep 5' in Koha::REST::V1::Acquisitions::Vendors->list): open the dropdown list scroll down => You see "Loading more options..." scroll down again => We are loading more options but there is no visual feedback. * There is a frustrating behaviour, if you are at the bottom of the dropdown and it's still fetching, the scrollbar will hit the top when the new data are fetched (feel like a broken lift) * this.limit += 10 What's the point of this? Feel like this should be 20 (see returnedValuesPerPage) If so we need a variable in store and retrieve it from there when we need it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- For discussion/failed QA. Let me know if you have any questions or need help! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32607 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144719|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145154|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 150030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150030&action=edit Data creation script Script for creating licenses to test patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 150031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150031&action=edit Bug 32474: Infinite scroll v-selects This patch is an example ajax based v-select. The v-select will load the first 20 items and then continue to load paginated sections of 20 items as the user scrolls down. The v-select also offers ajax based searches (unpaginated) and will return to 20 item pagination if the search is cleared. Currently the pagination just works with an Intersection Observer based on scrolling - the main issue with this is that the size of the v-select window changes every time new data is added to the list and this causes the scrollbar to jump before resetting at the correct size. This can be a bit annoying, especially when scrolling quickly. The only way round this will either be to paginate using buttons i.e. (previous/next page) or to limit the data to 20 items at all times and re-paginate when scrolling back up - interested to hear thoughts/suggestions on this or whether anyone has a magic CSS fix that solves it ;) The new v-select is only in one location so far as a test - Agreement Licenses Test plan: 1) You will need to add multiple licenses in order to see the pagination, attached is a script that will create 100 dummy licenses at a time if you wish to use that 2) Once licenses are created, apply patch and run yarn build 3) Navigate to Agreements and click the New Agreement button 4) Scroll down to the Add new license option and click the button 5) The License select is the InfiniteScrollSelect and should display the licenses you have added 6) Open the dropdown and 20 items will be listed 7) Scroll down and as you scroll, more items will be loaded (this can be seen in the Network tab in developer tools) 8) Enter a search query and the results should reflect the search query 9) Delete the search query and the dropdown should return to the first 20 paginated items and pagination will work again when scrolling 10) Try submitting the form with paginate/searched options and the form should still work as intended -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33623 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Found some problems, this needs to depend on bug 33623, follow-ups coming. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 [Bug 33623] getAll not encoding URL params -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150282&action=edit Bug 32474: Do not fetch all the licenses Otherwise we are loosing all the point of the pagination! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150283&action=edit Bug 32474: Allow getAll to pass params We may want to extend that to other getAll functions as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150284&action=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Additional notes: * It would be interesting to have a delay between the requests * We are retrieving the 20 first license when clicking the "Add new license" button and when opening the dropdown list. Seems like there is an extra one, is it hiding something? * About the scrollbar hitting top when scrolling down, did you have a look at 'more'? https://select2.org/data-sources/ajax#pagination -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150284|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150287&action=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #21 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 150305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150305&action=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and improves functionality Test plan as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #22 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #19)
Additional notes: * It would be interesting to have a delay between the requests
I've added a setTimeout for 2 seconds between the requests
* We are retrieving the 20 first license when clicking the "Add new license" button and when opening the dropdown list. Seems like there is an extra one, is it hiding something?
This is now fixed, originally I need to pre-fill the data in the component to make the pagination work but I've solved that issue and it now loads the data only when its opened
* About the scrollbar hitting top when scrolling down, did you have a look at 'more'? https://select2.org/data-sources/ajax#pagination
There isn't a similar functionality for v-select, I'm trying a different method using v-autocomplete as a second option. I'll try and finish that before I go on holiday and see if it offers any improvement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Matt Blenkinsop from comment #22)
(In reply to Jonathan Druart from comment #19)
Additional notes: * It would be interesting to have a delay between the requests
I've added a setTimeout for 2 seconds between the requests
IIRC we are using 250ms in other places. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150305|0 |1 is obsolete| | --- Comment #24 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 150308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150308&action=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150308|0 |1 is obsolete| | --- Comment #25 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 150309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150309&action=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Matt Blenkinsop from comment #22)
(In reply to Jonathan Druart from comment #19)
* About the scrollbar hitting top when scrolling down, did you have a look at 'more'? https://select2.org/data-sources/ajax#pagination
There isn't a similar functionality for v-select, I'm trying a different method using v-autocomplete as a second option. I'll try and finish that before I go on holiday and see if it offers any improvement
What about this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #27 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- It didn't make any difference unfortunately, the key functionality is the same as the v-select so the same issues arose -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Bug 32474 depends on bug 33623, which changed state. Bug 33623 Summary: getAll not encoding URL params https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED Depends on| |34219 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Working on this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34219 [Bug 34219] getAll not allowing additional parameters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150031|0 |1 is obsolete| | Attachment #150282|0 |1 is obsolete| | Attachment #150283|0 |1 is obsolete| | Attachment #150287|0 |1 is obsolete| | Attachment #150309|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153110&action=edit Bug 32474: Infinite scroll v-selects This patch is an example ajax based v-select. The v-select will load the first 20 items and then continue to load paginated sections of 20 items as the user scrolls down. The v-select also offers ajax based searches (unpaginated) and will return to 20 item pagination if the search is cleared. Currently the pagination just works with an Intersection Observer based on scrolling - the main issue with this is that the size of the v-select window changes every time new data is added to the list and this causes the scrollbar to jump before resetting at the correct size. This can be a bit annoying, especially when scrolling quickly. The only way round this will either be to paginate using buttons i.e. (previous/next page) or to limit the data to 20 items at all times and re-paginate when scrolling back up - interested to hear thoughts/suggestions on this or whether anyone has a magic CSS fix that solves it ;) The new v-select is only in one location so far as a test - Agreement Licenses Test plan: 1) You will need to add multiple licenses in order to see the pagination, attached is a script that will create 100 dummy licenses at a time if you wish to use that 2) Once licenses are created, apply patch and run yarn build 3) Navigate to Agreements and click the New Agreement button 4) Scroll down to the Add new license option and click the button 5) The License select is the InfiniteScrollSelect and should display the licenses you have added 6) Open the dropdown and 20 items will be listed 7) Scroll down and as you scroll, more items will be loaded (this can be seen in the Network tab in developer tools) 8) Enter a search query and the results should reflect the search query 9) Delete the search query and the dropdown should return to the first 20 paginated items and pagination will work again when scrolling 10) Try submitting the form with paginate/searched options and the form should still work as intended -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153111&action=edit Bug 32474: Do not fetch all the licenses Otherwise we are loosing all the point of the pagination! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153112&action=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153113&action=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I rebased the patch and created bug 32474 to move the getAll changes to a separate bug report. I didn't manage to fix the scrollbar bump, it's quite annoying IMO. I am not sure this is good enough to be pushed. Maybe we should try the example in the guide https://vue-select.org/guide/infinite-scroll.html and see if the problem exists there. If yes, ask them? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #34 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 154094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154094&action=edit Bug 32474: TEST ONLY - DO NOT PUSH This commit adds the example for inifinite scrolling for the vue-select as per the docs to check scroll behaviour -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #35 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- I added the example from the docs next to the same select in Agreement licenses. I've added 200 items (not AJAX based) and the behaviour still isn't perfect. There's still a bump on the scrollbar, especially on the first few iterations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #36 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Let me know your thoughts, I think this might need to be raised with them -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34762 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Matt Blenkinsop from comment #36)
Let me know your thoughts, I think this might need to be raised with them
Yes, please reach me if you have some time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154094|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #38 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 156410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156410&action=edit Bug 32474: Fix scroll bump when new data loads This patch addresses an annoying scroll bump when new data loads. Previously the scrollbar would jump all the way to the top of the selct before resetting, this has now been stopped -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #39 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- I think this fixes the scroll bump - have a play with it and let me know what you think If this behaviour is an improvement then I'll look at rebasing and re-formatting the patches because there has been quite a few versions of this bug now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Matt, thanks, this is working great now! I remember I played with that scrollTop trick, I must have missed the right place to put it! I think this can go as it now and we will implement it for the other dropdown lists on separate bug reports. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153110|0 |1 is obsolete| | Attachment #153111|0 |1 is obsolete| | Attachment #153112|0 |1 is obsolete| | Attachment #153113|0 |1 is obsolete| | Attachment #156410|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156470&action=edit Bug 32474: Infinite scroll v-selects This patch is an example ajax based v-select. The v-select will load the first 20 items and then continue to load paginated sections of 20 items as the user scrolls down. The v-select also offers ajax based searches (unpaginated) and will return to 20 item pagination if the search is cleared. Currently the pagination just works with an Intersection Observer based on scrolling - the main issue with this is that the size of the v-select window changes every time new data is added to the list and this causes the scrollbar to jump before resetting at the correct size. This can be a bit annoying, especially when scrolling quickly. The only way round this will either be to paginate using buttons i.e. (previous/next page) or to limit the data to 20 items at all times and re-paginate when scrolling back up - interested to hear thoughts/suggestions on this or whether anyone has a magic CSS fix that solves it ;) The new v-select is only in one location so far as a test - Agreement Licenses Test plan: 1) You will need to add multiple licenses in order to see the pagination, attached is a script that will create 100 dummy licenses at a time if you wish to use that 2) Once licenses are created, apply patch and run yarn build 3) Navigate to Agreements and click the New Agreement button 4) Scroll down to the Add new license option and click the button 5) The License select is the InfiniteScrollSelect and should display the licenses you have added 6) Open the dropdown and 20 items will be listed 7) Scroll down and as you scroll, more items will be loaded (this can be seen in the Network tab in developer tools) 8) Enter a search query and the results should reflect the search query 9) Delete the search query and the dropdown should return to the first 20 paginated items and pagination will work again when scrolling 10) Try submitting the form with paginate/searched options and the form should still work as intended Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156471&action=edit Bug 32474: Do not fetch all the licenses Otherwise we are loosing all the point of the pagination! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156472&action=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156473&action=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156474&action=edit Bug 32474: Fix scroll bump when new data loads This patch addresses an annoying scroll bump when new data loads. Previously the scrollbar would jump all the way to the top of the selct before resetting, this has now been stopped Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |pedro.amorim@ptfs-europe.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It's great to see this has moved.. are you comfortable for me to QA Jonathan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156470|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 156475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156475&action=edit Bug 32474: Infinite scroll v-selects This patch is an example ajax based v-select. The v-select will load the first 20 items and then continue to load paginated sections of 20 items as the user scrolls down. The v-select also offers ajax based searches (unpaginated) and will return to 20 item pagination if the search is cleared. Currently the pagination just works with an Intersection Observer based on scrolling - the main issue with this is that the size of the v-select window changes every time new data is added to the list and this causes the scrollbar to jump before resetting at the correct size. This can be a bit annoying, especially when scrolling quickly. The only way round this will either be to paginate using buttons i.e. (previous/next page) or to limit the data to 20 items at all times and re-paginate when scrolling back up - interested to hear thoughts/suggestions on this or whether anyone has a magic CSS fix that solves it ;) The new v-select is only in one location so far as a test - Agreement Licenses Test plan: 1) You will need to add multiple licenses in order to see the pagination, attached is a script that will create 100 dummy licenses at a time if you wish to use that 2) Once licenses are created, apply patch and run yarn build 3) Navigate to Agreements and click the New Agreement button 4) Scroll down to the Add new license option and click the button 5) The License select is the InfiniteScrollSelect and should display the licenses you have added 6) Open the dropdown and 20 items will be listed 7) Scroll down and as you scroll, more items will be loaded (this can be seen in the Network tab in developer tools) 8) Enter a search query and the results should reflect the search query 9) Delete the search query and the dropdown should return to the first 20 paginated items and pagination will work again when scrolling 10) Try submitting the form with paginate/searched options and the form should still work as intended Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156471|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 156476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156476&action=edit Bug 32474: Do not fetch all the licenses Otherwise we are loosing all the point of the pagination! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156472|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 156477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156477&action=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156473|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 156478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156478&action=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156474|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 156479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156479&action=edit Bug 32474: Fix scroll bump when new data loads This patch addresses an annoying scroll bump when new data loads. Previously the scrollbar would jump all the way to the top of the selct before resetting, this has now been stopped. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|pedro.amorim@ptfs-europe.co |martin.renvoize@ptfs-europe |m |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is working great, so nice to see that bump gone too. Code looks solid, tests are passing and happy.. QA scripts happy, No regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Oop.. forgot to run the Cypress tests in my eaferness.. running those before switching state. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED Assignee|matt.blenkinsop@ptfs-europe |jonathan.druart+koha@gmail. |.com |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #54 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156481&action=edit Bug 32474: Fix required -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #55 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156482&action=edit Bug 32474: Adjust tests - X-Total-Count -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #56 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156483&action=edit Bug 32474: Pass label and identifier This is a try to fix the last remaining Cypress failure. The problem is that the label of the existing license does not display, only its id. To recreate: Create a license Create an agreement and select the license Edit the agreement => The display shows "License: {id}", not its name This patch is removing the code from created() because I thought it was the problem originally, and it didn't seem correct to let InfiniteScrollSelect deal with the "id" and "label" for the different dataType. But the problem is somewhere else: we have not fetched any licenses yet from the AgreementLicenses. However we do have the selected license that we could pass to InfiniteScrollSelect, but that's yet another param to pass. It feels like there is something better to do here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #57 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is also something else: we are passing "v-model" but InfiniteScrollSelect is expecting "modelValue". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |matt.blenkinsop@ptfs-europe |com |.com Status|ASSIGNED |NEW --- Comment #58 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- To summary the last changes: * The "required" was no longer working - It was not possible to save the form * Cypress tests were failing because we didn't mock correctly the response (X-Total-Count header was missing) * "Pass label and identifier" patch can be dropped if you disagree with it, but I think it's the correct way to fix the last remaining cypress failure (which is about the display of the license's name when we edit an agreement) * Something is wrong with "v-model" vs "modelValue", see previous comment. Handing it back to Matt. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #59 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Passing the data to the component from the parent causes issues because we can't guarantee that there is a match for the "label" property in that data object. For example, in the case of agreement licenses, if we pass the agreement license to the select component it doesn't have a "name" property which is used as the label. The "name" property exists in the license which appears to be embedded in that object. We'd need to iterate through all the properties to determine if any of them were embedded objects which might contain the "name" property and we could have a scenario where there are agreements and licenses embedded in the same object and both have the "name" property. This could be very inconsistent and difficult to maintain. To do it we would have to explicitly pass the actual name of the license itself as a prop e.g. :dataToEditLabel="agreement_license.license.name" This is the cleanest method in terms of code but involves passing another parameter each time The only other real option I can think of atm is to fetch it from the API when the component is rendered and add it to the options for the select. This means another API request but this is probably more reliable than passing the data from the parent and will be far easier to maintain when Vue gets used in other parts of Koha. Let me know your thoughts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #60 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156504&action=edit Bug 32474: Adjust tests We need to use the same data, for instance we had "license name" and "first license name" for the license with license_id=1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156483|0 |1 is obsolete| | --- Comment #61 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156505&action=edit Bug 32474: Pass label and identifier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #62 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is not very nice, but the tests now pass and it's flexible enough for now IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #63 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Signing off Joubu's patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156481|0 |1 is obsolete| | --- Comment #64 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159327&action=edit Bug 32474: Fix required Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156482|0 |1 is obsolete| | --- Comment #65 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159328&action=edit Bug 32474: Adjust tests - X-Total-Count Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156504|0 |1 is obsolete| | --- Comment #66 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159329&action=edit Bug 32474: Adjust tests We need to use the same data, for instance we had "license name" and "first license name" for the license with license_id=1 Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156505|0 |1 is obsolete| | --- Comment #67 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159330&action=edit Bug 32474: Pass label and identifier Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #68 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Found a bug. I have 500 licenses: use t::lib::TestBuilder; my $b = t::lib::TestBuilder->new; for ( 1 .. 500 ) { say $_; $b->build_object({ class => 'Koha::ERM::Licenses', value => {name => "License $_"}}); } Add a new agreement form: /cgi-bin/koha/erm/agreements/add In the license dropdown, search "license 1" Select "License 117" Selected text shows "License 117" click again the dropdown => greyed "117" (the id) click outside the dropdown => Selected text show "117" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #69 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159340&action=edit Bug 32474: Fix persistence of selections when pagination re-triggers Currently when the select is closed and then re-opens, the pagination is re-triggered which removes the data that the lable is being pulled from for the select. This patch addresses this by keeping the currently selected piece of data and adding it into the re-paginated array of data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #70 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Still having kind of the same problem. Select "License 3", save Edit Click in then click out => "3" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159340|0 |1 is obsolete| | --- Comment #71 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159343&action=edit Bug 32474: Fix persistence of selections when pagination re-triggers Currently when the select is closed and then re-opens, the pagination is re-triggered which removes the data that the lable is being pulled from for the select. This patch addresses this by keeping the currently selected piece of data and adding it into the re-paginated array of data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #72 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159386&action=edit Bug 32474: Store the selected option label It prevents the label to be removed when the selected option is not longer in the item list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #73 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This last patch is an alternative patch of "Bug 32474: Fix persistence of selections when pagination re-triggers" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #74 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159389&action=edit Bug 32474: Add cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159343|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159386|0 |1 is obsolete| | --- Comment #75 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159395&action=edit Bug 32474: Store the selected option label It prevents the label to be removed when the selected option is not longer in the item list. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156475|0 |1 is obsolete| | Attachment #156476|0 |1 is obsolete| | Attachment #156477|0 |1 is obsolete| | Attachment #156478|0 |1 is obsolete| | Attachment #156479|0 |1 is obsolete| | Attachment #159327|0 |1 is obsolete| | Attachment #159328|0 |1 is obsolete| | Attachment #159329|0 |1 is obsolete| | Attachment #159330|0 |1 is obsolete| | Attachment #159389|0 |1 is obsolete| | Attachment #159395|0 |1 is obsolete| | --- Comment #76 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159397&action=edit Bug 32474: Infinite scroll v-selects This patch is an example ajax based v-select. The v-select will load the first 20 items and then continue to load paginated sections of 20 items as the user scrolls down. The v-select also offers ajax based searches (unpaginated) and will return to 20 item pagination if the search is cleared. Currently the pagination just works with an Intersection Observer based on scrolling - the main issue with this is that the size of the v-select window changes every time new data is added to the list and this causes the scrollbar to jump before resetting at the correct size. This can be a bit annoying, especially when scrolling quickly. The only way round this will either be to paginate using buttons i.e. (previous/next page) or to limit the data to 20 items at all times and re-paginate when scrolling back up - interested to hear thoughts/suggestions on this or whether anyone has a magic CSS fix that solves it ;) The new v-select is only in one location so far as a test - Agreement Licenses Test plan: 1) You will need to add multiple licenses in order to see the pagination, attached is a script that will create 100 dummy licenses at a time if you wish to use that 2) Once licenses are created, apply patch and run yarn build 3) Navigate to Agreements and click the New Agreement button 4) Scroll down to the Add new license option and click the button 5) The License select is the InfiniteScrollSelect and should display the licenses you have added 6) Open the dropdown and 20 items will be listed 7) Scroll down and as you scroll, more items will be loaded (this can be seen in the Network tab in developer tools) 8) Enter a search query and the results should reflect the search query 9) Delete the search query and the dropdown should return to the first 20 paginated items and pagination will work again when scrolling 10) Try submitting the form with paginate/searched options and the form should still work as intended Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #77 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159398&action=edit Bug 32474: Do not fetch all the licenses Otherwise we are loosing all the point of the pagination! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #78 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159399&action=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #79 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159400&action=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #80 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159401&action=edit Bug 32474: Fix scroll bump when new data loads This patch addresses an annoying scroll bump when new data loads. Previously the scrollbar would jump all the way to the top of the selct before resetting, this has now been stopped. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #81 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159402&action=edit Bug 32474: Fix required Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #82 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159403&action=edit Bug 32474: Adjust tests - X-Total-Count Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #83 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159404&action=edit Bug 32474: Adjust tests We need to use the same data, for instance we had "license name" and "first license name" for the license with license_id=1 Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #84 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159405&action=edit Bug 32474: Pass label and identifier Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #85 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159406&action=edit Bug 32474: Add cypress tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #86 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159407&action=edit Bug 32474: Store the selected option label It prevents the label to be removed when the selected option is not longer in the item list. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #87 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #88 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #89 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tests were green when I ran them locally. so maybe something has changed, can you please check on this fail? https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testRe... koha_1 | Running: InfiniteScrollSelect_spec.ts (1 of 13) koha_1 | <?xml version="1.0" encoding="UTF-8"?> koha_1 | <testsuites name="Mocha Tests" time="27.603" tests="4" failures="1"> koha_1 | <testsuite name="Root Suite" timestamp="2024-02-02T09:46:14" tests="0" file="t/cypress/integration/InfiniteScrollSelect_spec.ts" time="0.000" failures="0"> koha_1 | </testsuite> koha_1 | <testsuite name="Infinite scroll" timestamp="2024-02-02T09:46:14" tests="4" time="27.592" failures="1"> koha_1 | <testcase name="Infinite scroll Should load the next page on scroll" time="0.000" classname="Should load the next page on scroll"> koha_1 | <failure message="Timed out retrying after 10000ms: Not enough elements found. Found '20', expected '40'." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Not enough elements found. Found '20', expected '40'. koha_1 | at Context.eval (webpack://koha/./t/cypress/integration/InfiniteScrollSelect_spec.ts:90:27) koha_1 | koha_1 | + expected - actual koha_1 | koha_1 | -20 koha_1 | +40 koha_1 | ]]></failure> koha_1 | </testcase> koha_1 | <testcase name="Infinite scroll Should correctly submit the form" time="4.166" classname="Should correctly submit the form"> koha_1 | </testcase> koha_1 | <testcase name="Infinite scroll Should correctly display labels" time="5.000" classname="Should correctly display labels"> koha_1 | </testcase> koha_1 | <testcase name="Infinite scroll Should correctly display the label when editing" time="3.848" classname="Should correctly display the label when editing"> koha_1 | </testcase> koha_1 | </testsuite> koha_1 | </testsuites> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #90 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Passes locally for me too but I think telling cypress to wait for the intercepted requests for pages two and three may help. I'll add a follow-up patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #91 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 161724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161724&action=edit Bug 32474: (follow-up): Tell the tests to wait for the intercepted request responses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #92 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Matt, follow-up pushed - now we need to wait and see :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #93 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36012 [Bug 36012] ERM/Agreements_spec.ts is failing if run too slow (?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #94 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- *** Bug 34762 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #95 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- *** Bug 32493 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37620 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37620 [Bug 37620] Fix randomly failing tests for cypress/integration/InfiniteScrollSelect_spec.ts -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org