https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Ok If I checkout the branch it fails Failed test 'Single Gir field OK' # at t/Ediorder.t line 104. # got: 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+CALL:LSM' # expected: 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+LOCATION:LSQ+CALL:LSM' Use of uninitialized value $lsq_field in hash element at /home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563. Use of uninitialized value $lsq_field in hash element at /home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563. Use of uninitialized value $got in string eq at (eval in cmp_ok) t/Ediorder.t line 117. # Failed test 'First part of split Gir field OK' # at t/Ediorder.t line 117. # got: undef # expected: 'GIR+002+BUDGET:LFN+BRANCH:LLO+TYPE:LST+LOCATION:LSQ+CALL:LSM' Use of uninitialized value $got in string eq at (eval in cmp_ok) t/Ediorder.t line 123. # Failed test 'Second part of split GIR field OK' # at t/Ediorder.t line 123. # got: undef # expected: 'GIR+002+S_I:LVT' # Looks like you failed 3 tests of 13. This is because this test is now db_dependent Koha/Edifact/Order.pm: my $lsq_field = C4::Context->preference('EdifactLSQ'); So it needs to probably be moved out of t, or that syspref needs to be mocked. The reason it works is if that syspref is set location. If I set the syspref to collection, the tests fail, if i set it location the tests pass. The problem is then when you are building a package you dont have a database, the t/ tests should all pass without relying on a syspref fetched from a db. Chris -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.