https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100221|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 100294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100294&action=edit Bug 23531: Fix ILS-DI non-implemented but documented parameters Koha's ILS-DI service does not implement the "needed_before_date" and "pickup_expiry_date" parameters for holds, although they are documented. This patch changes the parameter names and implements them: - needed_before_date => start_date - pickup_expiry_date => expiry_date Test plan: 1) Enable the ISL-DI system preference. 2) Submit a hold request using ILS-DI with "needed_before_date" and "pickp_expiry_date" parameters, for example (change the bib_id, item_id, and dates as appropriate): http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=19&bib_id=126&item_id=264&needed_before_date=2020-03-12&pickup_expiry_date=2020-03-31&pickup_location=CPL 3) Check that the dates in the request are NOT shown for the hold (go to the item record and then the holds section): - Date: will show the current date, rather than the needed_before_date entered - Expiration: will be empty, rather than the pickup_expiry_date entered 4) Delete the hold. 5) Apply the patch. 6) Resubmit the hold request in step 2 using "start_date" and "expiry_date" parameters, for example: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=19&bib_id=126&item_id=264&start_date=2020-03-12&expiry_date=2020-03-31&pickup_location=CPL 7) Check that dates shown for the hold are now correct: - Date: will show the start_date entered - Expiration: will show the expiry_date entered 8) Check that the tests pass (prove t/db_dependent/ILSDI_Services.t) 9) Sign off! Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com> Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.