[Bug 23531] New: ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Bug ID: 23531 Summary: ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: arthur.suzuki@biblibre.com QA Contact: testopia@bugs.koha-community.org tried to send the following request : GET /cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=196&bib_id=96629&item_id=112194&needed_before_date=2020-08-18&pickup_expiry_date=2020-10-18&pickup_location=BDY the reservation which is placed doesn't take the "needed_before_date" and pickup_expiry_date" parameter, although those are documented. Arthur -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #1 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 92538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92538&action=edit bug23531 : fix ILSDI non-implemented but documented parameters test plan : 1/ Submit a hold through ILSDI with needed_before_date and pickup_expiry_date parameters 2/ Verify in Koha those parameters are not applied to the newly created reserve. Delete reserve. 3/ Apply patch and repeat 1. 4/ Verify the reserve created by same request as 1 now has both dates applied and visible in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |arthur.suzuki@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23669 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23669 [Bug 23669] Verify if checkouts or reserves requests from ILS-DI periods overlap with existing reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92538|0 |1 is obsolete| | --- Comment #2 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 93475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93475&action=edit bug23531 : fix ILSDI non-implemented but documented parameters test plan : 1/ Submit a hold through ILSDI with needed_before_date and pickup_expiry_date parameters 2/ Verify in Koha those parameters are not applied to the newly created reserve. Delete reserve. 3/ Apply patch and repeat 1. 4/ Verify the reserve created by same request as 1 now has both dates applied and visible in Koha. Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Summary|ILS-DI doesn't implement |ILS-DI doesn't implement |needed_before_date and |needed_before_date and |pickup_expiry_date |pickup_expiry_date |parameters. |parameters CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Same formal issues than on bug 23015: - commit message - failing qa tools for tabs vs. spaces FAIL C4/ILSDI/Services.pm OK critic FAIL forbidden patterns forbidden pattern: tab char (line 730) forbidden pattern: tab char (line 735) forbidden pattern: tab char (line 816) forbidden pattern: tab char (line 821) OK git manipulation OK pod OK pod coverage OK spelling OK valid 2) Unit tests for change to Service.pm 3) I am not sure about the patch 'content'. needed_before_date = Visible on the Koha holds form as 'Hold not needed after'. Stored in the database in reserves.expirationdate. Correct? pickup_expiry_date = This one confuses me. The expiration date for pick-up is usually calculated by Koha using different configuration parameters and not something that the user can 'pick' at the time of placing a hold. But what makes it worse: Both go in the same column in the database atm (yes, bad). When a hold is set to waiting, the pick-up date is calculated and rebases the patron entered date in reserves.expirationdate. So... I think this cannot work? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #4 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- needed_before_date is actually stored in the "reservedate", this is just a way to place a reserve on a future date. pickup_expiry_date is the date after which the reserve is automatically cancelled if not picked up by the user and this one is stored in the "expirydate" Maybe the parameter "needed_before_date" shall be renamed another way. The use case is for example for teachers/students who need to reserve a book for a course, they need it between "needed_before_date" and "pickup_expiry_date". There is no way to provide either date from ILS-DI right now, but we have this need for bundled holds (for which Cecile showed the bundled loans counterpart at the Hackfest in Marseille). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Arthur Suzuki from comment #4)
needed_before_date is actually stored in the "reservedate", this is just a way to place a reserve on a future date. pickup_expiry_date is the date after which the reserve is automatically cancelled if not picked up by the user and this one is stored in the "expirydate"
Maybe the parameter "needed_before_date" shall be renamed another way.
The use case is for example for teachers/students who need to reserve a book for a course, they need it between "needed_before_date" and "pickup_expiry_date". There is no way to provide either date from ILS-DI right now, but we have this need for bundled holds (for which Cecile showed the bundled loans counterpart at the Hackfest in Marseille).
I think I would make it something like 'expiry_date' (doesn't matter if it has been waiting for pickup or not) and something like 'not_needed_before' or even 'start_date' to clear things up a bit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #6 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 96563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96563&action=edit Bug 23531: fix ILSDI non-implemented but documented parameters test plan : 1/ Submit a hold through ILSDI with start_date and expiry_date parameters 2/ Verify in Koha those parameters are not applied to the newly created reserve. Delete reserve. 3/ Apply patch and repeat 1. 4/ Verify the reserve created by same request as 1 now has both dates applied and visible in Koha. Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 96564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96564&action=edit Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93475|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11641 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11641 [Bug 11641] ILS-DI: Some more work for HoldTitle and HoldItem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #8 from David Nind <david@davidnind.com> --- Patch no longer applies: Applying: Bug 23531: fix ILSDI non-implemented but documented parameters Using index info to reconstruct a base tree... M C4/ILSDI/Services.pm Falling back to patching base and 3-way merge... Auto-merging C4/ILSDI/Services.pm CONFLICT (content): Merge conflict in C4/ILSDI/Services.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23531: fix ILSDI non-implemented but documented parameters Notes: - Get DataTables error on patrons hold tab before patch is applied (bug - Before patch applied query for use in koha-testing-docker: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=19&bib_id=126&item_id=264&needed_before_date=2020-03-02&pickup_expiry_date=2020-03-31&pickup_location=CPL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #9 from David Nind <david@davidnind.com> --- Bug for DataTables error on patrons hold tab is bug 24769 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96563|0 |1 is obsolete| | --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 100165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100165&action=edit Bug 23531: fix ILSDI non-implemented but documented parameters test plan : 1/ Submit a hold through ILSDI with start_date and expiry_date parameters 2/ Verify in Koha those parameters are not applied to the newly created reserve. Delete reserve. 3/ Apply patch and repeat 1. 4/ Verify the reserve created by same request as 1 now has both dates applied and visible in Koha. Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com> Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #11 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Hi David, I've rebased the patch on master so patch should apply now. I've also renamed the parameters according to comment 5 from Katrin. The functionality works for real but not the automated tests, I'll check it out with a colleague today, probably it's just me not being good at writing tests scripts (ILSDI_Service.t) Kr, Arthur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96564|0 |1 is obsolete| | --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 100166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100166&action=edit Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Hi David, tests are now green thanks to Julian :) patch ready for testing! (was previously signed off by christophe) have a nice one, Arthur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #14 from David Nind <david@davidnind.com> --- Sorry Arthur, patch no longer applies! Applying: Bug 23531: fix ILSDI non-implemented but documented parameters Using index info to reconstruct a base tree... M C4/ILSDI/Services.pm M koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt M opac/ilsdi.pl Falling back to patching base and 3-way merge... Auto-merging opac/ilsdi.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt Auto-merging C4/ILSDI/Services.pm CONFLICT (content): Merge conflict in C4/ILSDI/Services.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23531: fix ILSDI non-implemented but documented parameters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #15 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Hi David, last patch i can see on master is 22816, is it the same on your side?... I use gitlab as my remote : https://gitlab.com/koha-community/Koha I guess I'm doing smthg wrong but can't figure out what. I'll try to check around with my colleagues. Arthur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100165|0 |1 is obsolete| | Attachment #100166|0 |1 is obsolete| | --- Comment #16 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 100221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100221&action=edit Bug 23531: fix ILSDI non-implemented but documented parameters test plan : 1/ Submit a hold through ILSDI with start_date and expiry_date parameters 2/ Verify in Koha those parameters are not applied to the newly created reserve. Delete reserve. 3/ Apply patch and repeat 1. 4/ Verify the reserve created by same request as 1 now has both dates applied and visible in Koha. Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com> Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #17 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 100222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100222&action=edit Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #18 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to David Nind from comment #14)
Sorry Arthur, patch no longer applies!
Yup, had some issues with my remotes configuration, just got to learn that one shall not use gitlab anymore. Patch should apply now. Arthur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100221|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 100294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100294&action=edit Bug 23531: Fix ILS-DI non-implemented but documented parameters Koha's ILS-DI service does not implement the "needed_before_date" and "pickup_expiry_date" parameters for holds, although they are documented. This patch changes the parameter names and implements them: - needed_before_date => start_date - pickup_expiry_date => expiry_date Test plan: 1) Enable the ISL-DI system preference. 2) Submit a hold request using ILS-DI with "needed_before_date" and "pickp_expiry_date" parameters, for example (change the bib_id, item_id, and dates as appropriate): http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=19&bib_id=126&item_id=264&needed_before_date=2020-03-12&pickup_expiry_date=2020-03-31&pickup_location=CPL 3) Check that the dates in the request are NOT shown for the hold (go to the item record and then the holds section): - Date: will show the current date, rather than the needed_before_date entered - Expiration: will be empty, rather than the pickup_expiry_date entered 4) Delete the hold. 5) Apply the patch. 6) Resubmit the hold request in step 2 using "start_date" and "expiry_date" parameters, for example: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=19&bib_id=126&item_id=264&start_date=2020-03-12&expiry_date=2020-03-31&pickup_location=CPL 7) Check that dates shown for the hold are now correct: - Date: will show the start_date entered - Expiration: will show the expiry_date entered 8) Check that the tests pass (prove t/db_dependent/ILSDI_Services.t) 9) Sign off! Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com> Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100222|0 |1 is obsolete| | --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 100295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100295&action=edit Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #21 from David Nind <david@davidnind.com> --- (In reply to Arthur Suzuki from comment #18)
Yup, had some issues with my remotes configuration, just got to learn that one shall not use gitlab anymore. Patch should apply now. Arthur
Thanks Arthur for fixing _ I'm not sure I would have been much help working out what was wrong 8-) I also updated the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #22 from David Nind <david@davidnind.com> --- In the test plan "the ISL-DI system preference" should be "the ILS-DI system preference"! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #23 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- \o/ Many thanks for your help and fixing typo :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- <HoldItem><code>IllegalParameter</code><message>The parameter pickup_expiry_date is illegal.</message></HoldItem> Why do I get that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100895&action=edit Bug 23531: Simplify tests using build_object And build_sample_item. Also remove a debug statement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #24)
<HoldItem><code>IllegalParameter</code><message>The parameter pickup_expiry_date is illegal.</message></HoldItem>
Why do I get that?
Ok, forget that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100294|0 |1 is obsolete| | Attachment #100295|0 |1 is obsolete| | Attachment #100895|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100896&action=edit Bug 23531: fix ILSDI non-implemented but documented parameters test plan : 1/ Submit a hold through ILSDI with start_date and expiry_date parameters 2/ Verify in Koha those parameters are not applied to the newly created reserve. Delete reserve. 3/ Apply patch and repeat 1. 4/ Verify the reserve created by same request as 1 now has both dates applied and visible in Koha. Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com> Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100897&action=edit Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100898&action=edit Bug 23531: Simplify tests using build_object And build_sample_item. Also remove a debug statement Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILS-DI doesn't implement |ILS-DI doesn't implement |needed_before_date and |needed_before_date and |pickup_expiry_date |pickup_expiry_date |parameters |parameters (renamed | |start_date and expiry_date) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Not sure why we do not pick reserve_date here, but ok for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #32 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Yipee! awesome, thanks joubu & martin \o/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch implements the release notes| |documented "start_date" and | |"expiry_date" parameters | |for hold requests using | |Koha's ILS-DI service. | | | |Note: the previously | |documented but not | |implemented parameter names | |were changed: | |- | |needed_before_date => | |start_date | |- | |pickup_expiry_date => | |expiry_date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #33 from Joy Nelson <joy@bywatersolutions.com> --- Does not apply to 19.11.x branch. not backported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29002 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org