https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com --- Comment #16 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- (In reply to Katrin Fischer from comment #15)
Hi Liz, you check the preference only, but this can be overwritten for each patron category.
I think that the possible override is already taken into account here: C4/SIP/ILS/Transaction/Checkout.pm "do_checkout" calls "_can_we_issue" which calls "CanBookBeIssued" which calls "wants_check_for_previous_checkout" which checks for sypref, patron, and patron category. No need to re-check, right? (In reply to Jonathan Druart from comment #8)
Finally it sounds like this flag is set when the error/warning must be displayed, and maybe the following code would be enough:
} elsif ($confirmation eq 'PREVISSUE') { $self->screen_msg("This item was previously checked out by you"); last; }
I guess you're right, PREVISSUE is set after the syspref, patron and patron category were already checked by wants_check_for_previous_checkout in CanBookBeIssued, so no need to check again here. Imho, with Jonathan's modification, this patch is ok. -- You are receiving this mail because: You are watching all bug changes.