https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart@gmail.com |martin.renvoize@openfifth.c | |o.uk --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This is looking solid to me and helps to guide us toward consistency which is a big win in my book. Test coverage is good and code quality it solid. Matt, please check your commit hook, most of the file threw tidy errors for me during QA.. I've fixed those inline. I also improved the commit messages as they were a bit sparse. Passing QA -- You are receiving this mail because: You are watching all bug changes.