[Bug 40191] New: Design pattern: Redirect user to a view of the record after saving instead of list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Bug ID: 40191 Summary: Design pattern: Redirect user to a view of the record after saving instead of list Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: clemens.tubach@kit.edu, jonathan.druart@gmail.com, jonathan.field@openfifth.co.uk, martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, michaela.sieber@kit.edu, pedro.amorim@openfifth.co.uk In the ERM module (and admittedly some other parts of Koha) we redirect the user to the full list of records after a change to a record is saved. This means they need to search again to check the changes and seems counter intuitive. For us it would seem more intuitive to redirect the user to a "view" of the data instead. An example: 1. Add an agreement to the ERM module 2. Confirm: when you save you are redirected to the list of agreements https://staff.next.bsz-bw.de/cgi-bin/koha/erm/agreements 3. Edit the agreement, make a litle change and save again 4. Confirm: you are redirected to the list of agreements again Our suggestion would be to redirect to the view of the agreement on saving: https://staff.next.bsz-bw.de/cgi-bin/koha/erm/agreements/1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Further testing revealed: Editing data providers works like this already, so we have a "mixed" situation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- This is an interesting topic. Other software applications sometimes use 2 different buttons for these actions. Like a 'Save' button that saves the record and redirects to the full list, and an 'Apply' button that saves the record and reloads the same form. Personally, I feel like the above use case is not 100% clear on what each button does exactly, before clicking, but just sharing how other software apps handle this. Alternatively, we could have: 1) 'Save' // redirects to table list 2) 'Save and continue editing' // stays in form 3) 'Save and show %resource_name%' // redirects to 'show' page (if exists) With 2 and 3 perhaps being expandable option buttons? The above are just my brainstorming ideas. I really don't think we should set for one or the other behavior only, as inevitably someone will advocate for why the other way is preferable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Pedro Amorim from comment #2)
Alternatively, we could have: 1) 'Save' // redirects to table list 2) 'Save and continue editing' // stays in form 3) 'Save and show %resource_name%' // redirects to 'show' page (if exists)
With 2 and 3 perhaps being expandable option buttons?
The expandable option buttons could be annoying as it requires multiple clicks when we don't want the default option, but maybe this can be mitigated by having the default option controlled by a user setting, or maybe save & reuse the last option used, ... But if we had to choose a fixed default, I'd choose 'save and show'. From the 'show' page you should be able to go in 1 click to either the list (breadcrumbs) or the edit form (toolbar button). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #4 from Michaela Sieber <michaela.sieber@kit.edu> --- Perhaps I should add that this request comes from our colleagues who work with the ERM module on a daily basis. So this bug is based on user feedback. I think for consistency of a product it should be standardized in all modules what happens when you save a record. In most soft product I know you are redirected to a "view record" page. And also in Koha this is the majority in most modules: - catalog (edit biblio record) - patrons (edit borrower record) - serials (edit subscription) - course reserves (edit course) - acquisition (edit basket) - authorities (edit authority) I absolutley agree with Julien regarding the expandable option button if there is no setting (user or instance) to define the default behavior.
The expandable option buttons could be annoying as it requires multiple clicks when we don't want the default option, but maybe this can be mitigated by having the default option controlled by a user setting, or maybe save & reuse the last option used, ...
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 for the default being "Save and show" Usually on the edit forms we only have 2 options: Save, cancel Maybe having a third button would still be reasonable here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38201 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de --- Comment #6 from Jan Kissig <bibliothek@th-wildau.de> --- +1 for 'Save and show' as a default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@openfifth.co.uk --- Comment #7 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Specification for this could be as follows: 1) Implement this for forms at the VueJS architecture level (which includes ERM) 2) Each resource form will have a navigationOnFormSave setting which will allow developers to set A) goToShow B) stayInForm C) goToList 3) The ‘Submit’ form button will adopt the behavior picked above. 4) Rename ‘Submit’ to ‘Save’ when editing (Currently shows ‘Submit’ for both creating and editing a resource) 5) Implement as a dropdown button (like the save button when editing a bib record). The default option of 'Save' showing and this would be the behaviour if you just pressed it. The other two options would appear if you clicked the dropdown arrow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |matt.blenkinsop@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 188107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188107&action=edit Bug 40191: Allow customising the navigation behaviour of the form submit button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 188108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188108&action=edit Bug 40191: Update all resource components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 188109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188109&action=edit Bug 40191: Add dropdown buttons for the other navigation options Test plan: 1) Enable ERM and navigate to the agreements form 2) At the bottom, there should now be a button for "Submit" and a dropdown with two options - Submit and continue editing - Submit and return to list 3) Fill out the form three times, testing a different button each time 4) Click to edit one of your agreements 5) The buttons should operate the same but now they will start with 'Submit' instead of 'Save' 6) Navigate to licenses - for the purposes of testing the DO NOT PUSH commit has set this to have the behaviour where it returns to the list on save 7) On the form, the list option should be gone from the dropdowns and replaced by "Submit and show" 8) The buttons should all operate as described 9) Navigate to packages - for the purposes of testing they have been set to default to staying on the form when saving 10) The option to continue editing should be gone, replaced with the option to return to the list 11) The buttons should work as described Sponsored-by: Karlsruhe Institute of Technology (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Cypress tests to follow next week but the functionality is ready for testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #12 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Is there a reason for using ‘submit’ rather than ‘save’ as I had suggested in the spec? I would be interested in what others think in terms of submit vs save - whether submit is used more widely in Koha than save. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think "Save" is the common term used in Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188107|0 |1 is obsolete| | --- Comment #14 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 188137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188137&action=edit Bug 40191: Allow customising the navigation behaviour of the form submit button Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188108|0 |1 is obsolete| | --- Comment #15 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 188138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188138&action=edit Bug 40191: Update all resource components Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188109|0 |1 is obsolete| | --- Comment #16 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 188139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188139&action=edit Bug 40191: Add dropdown buttons for the other navigation options Test plan: 1) Enable ERM and navigate to the agreements form 2) At the bottom, there should now be a button for "Submit" and a dropdown with two options - Submit and continue editing - Submit and return to list 3) Fill out the form three times, testing a different button each time 4) Click to edit one of your agreements 5) The buttons should operate the same but now they will start with 'Submit' instead of 'Save' 6) Navigate to licenses - for the purposes of testing the DO NOT PUSH commit has set this to have the behaviour where it returns to the list on save 7) On the form, the list option should be gone from the dropdowns and replaced by "Submit and show" 8) The buttons should all operate as described 9) Navigate to packages - for the purposes of testing they have been set to default to staying on the form when saving 10) The option to continue editing should be gone, replaced with the option to return to the list 11) The buttons should work as described Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Michaela Sieber <michaela.sieber@kit.edu> --- Signed off because functional requirements are fulfilled. Please rename the button "Submit" to "Save" as Andrew and Katrin proposed. As long as you are adding a new record the button is labeled "Submit", after saving it is labeled "save" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #18 from Jan Kissig <bibliothek@th-wildau.de> --- I just tested: 1) Enable ERM and navigate to the agreements form 2) At the bottom, there should now be a button for "Submit" and a dropdown with two options - Submit and continue editing - Submit and return to list 3) Fill out the form three times, testing a different button each time 4) Click to edit one of your agreements 5) The buttons should operate the same but now they will start with 'Submit' instead of 'Save' 6) Navigate to licenses - for the purposes of testing the DO NOT PUSH commit has set this to have the behaviour where it returns to the list on save 7) On the form, the list option should be gone from the dropdowns and replaced by "Submit and show" 8) The buttons should all operate as described 9) Navigate to packages - for the purposes of testing they have been set to default to staying on the form when saving 10) The option to continue editing should be gone, replaced with the option to return to the list 11) The buttons should work as described In all 3 scenarios: 1 - agreements, 6 - licenses and 9 - packages, the behavior of the submit/save button was the same: - default: submit/save (and show) - submit/save and continue editing - submit/save and return to list Although all three options in all 3 scenarios worked as expected, I thought they should act differently according to the test plan. I would prefer both times "Save" over "Submit" and then "Save" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #19 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 188164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188164&action=edit Bug 40191: DO NOT PUSH: Set demo parameters for licenses and packages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #20 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Sorry Jan, forgot to attach the demo commit setting the different options on licenses and packages - it should work to the test plan now. I think the "Submit" v "Save" is my misunderstanding of the spec, I'll add a follow-up re-setting it to just be Save -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #21 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 188165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188165&action=edit Bug 40191: Replace 'Submit' with 'Save' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #22 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 188167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188167&action=edit Bug 40191: Add the new functionality to the sticky toolbar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188137|0 |1 is obsolete| | Attachment #188138|0 |1 is obsolete| | Attachment #188139|0 |1 is obsolete| | Attachment #188164|0 |1 is obsolete| | Attachment #188165|0 |1 is obsolete| | Attachment #188167|0 |1 is obsolete| | --- Comment #23 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 188193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188193&action=edit Bug 40191: Allow customising the navigation behaviour of the form submit button Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #24 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 188194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188194&action=edit Bug 40191: Update all resource components Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #25 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 188195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188195&action=edit Bug 40191: Add dropdown buttons for the other navigation options Test plan: 1) Enable ERM and navigate to the agreements form 2) At the bottom, there should now be a button for "Submit" and a dropdown with two options - Submit and continue editing - Submit and return to list 3) Fill out the form three times, testing a different button each time 4) Click to edit one of your agreements 5) The buttons should operate the same but now they will start with 'Submit' instead of 'Save' 6) Navigate to licenses - for the purposes of testing the DO NOT PUSH commit has set this to have the behaviour where it returns to the list on save 7) On the form, the list option should be gone from the dropdowns and replaced by "Submit and show" 8) The buttons should all operate as described 9) Navigate to packages - for the purposes of testing they have been set to default to staying on the form when saving 10) The option to continue editing should be gone, replaced with the option to return to the list 11) The buttons should work as described Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #26 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 188196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188196&action=edit Bug 40191: DO NOT PUSH: Set demo parameters for licenses and packages Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #27 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 188197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188197&action=edit Bug 40191: Replace 'Submit' with 'Save' Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #28 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 188198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188198&action=edit Bug 40191: Add the new functionality to the sticky toolbar Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #29 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 188201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188201&action=edit Bug 40191: Update existing cypress tests to account for the new functionality -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #30 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 188202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188202&action=edit Bug 40191: Add a cypress test for the new functionality -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #31 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 188203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188203&action=edit Bug 40191: Account for no show component being set in Record Sources -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40192 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40192 [Bug 40192] Add additional fields to ERM titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188193|0 |1 is obsolete| | Attachment #188194|0 |1 is obsolete| | Attachment #188195|0 |1 is obsolete| | Attachment #188196|0 |1 is obsolete| | Attachment #188197|0 |1 is obsolete| | Attachment #188198|0 |1 is obsolete| | Attachment #188201|0 |1 is obsolete| | Attachment #188202|0 |1 is obsolete| | Attachment #188203|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188768&action=edit Bug 40191: Add configurable post-save navigation for Vue resource forms This patch introduces a new navigation behavior system for resource forms, allowing each resource type to define its default post-save action (stay on form, show detail, or return to list). Changes: - Add `on_save_navigation` prop to ResourceFormSave component - Extend base-resource composable with navigation configuration - Implement navigation logic in ButtonSubmit component - Apply to AgreementResource as initial implementation This provides a more flexible UX by letting different resource types have appropriate default behaviors while maintaining consistent patterns. Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #33 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188769&action=edit Bug 40191: Apply configurable post-save navigation to all resource forms Extends the navigation behavior system to all Vue resource components: - EHoldings packages and titles (ERM) - Licenses (ERM) - Record sources (Admin) - Preservation trains - Vendors - SkeletonResource template Each resource can now define its preferred post-save behavior via the on_save_navigation prop. Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188770&action=edit Bug 40191: Add split button UI for alternative post-save navigation Introduces a split button pattern allowing users to override the default post-save behavior: - Primary button executes default action - Dropdown menu provides alternative navigation options - Adapts menu options based on resource configuration Components modified: - New DropdownButtons component for split button UI - Updated ButtonSubmit to support dropdown actions - Extended ResourceFormSave with action handlers - Applied to VendorResource and ToolbarButton The UI adapts based on resource configuration: - "show" default: offers "continue editing" and "return to list" - "edit" default: offers "show" and "return to list" - "list" default: offers "show" and "continue editing" Test plan: 1) Enable ERM and navigate to the agreements form 2) At the bottom, there should now be a button for "Submit" and a dropdown with two options - Submit and continue editing - Submit and return to list 3) Fill out the form three times, testing a different button each time 4) Click to edit one of your agreements 5) The buttons should operate the same but now they will start with 'Submit' instead of 'Save' 6) Navigate to licenses - for the purposes of testing the DO NOT PUSH commit has set this to have the behaviour where it returns to the list on save 7) On the form, the list option should be gone from the dropdowns and replaced by "Submit and show" 8) The buttons should all operate as described 9) Navigate to packages - for the purposes of testing they have been set to default to staying on the form when saving 10) The option to continue editing should be gone, replaced with the option to return to the list 11) The buttons should work as described Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Michaela <michaela.sieber@kit.edu> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #35 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188771&action=edit Bug 40191: DO NOT PUSH - Demo configuration for testing navigation behaviors Sets different default navigation behaviors for testing: - Licenses: default to "list" (return to list view) - Packages: default to "edit" (stay on form) This demonstrates how different resource types can have different defaults. Not for production - testing only. Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188772&action=edit Bug 40191: Change button text from 'Submit' to 'Save' for clarity Updates ResourceFormSave component button labels: - "Submit" → "Save" (more intuitive for editing forms) - "Submit and [action]" → "Save and [action]" Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188773&action=edit Bug 40191: Extend split button navigation to sticky toolbar Adds the same split button navigation options to the sticky toolbar that appears when scrolling resource forms, ensuring consistent functionality regardless of scroll position. Components modified: - Toolbar.vue: Support for dropdown button actions - ResourceFormSave.vue: Emit navigation events for toolbar - VendorResource.vue: Wire up toolbar navigation handlers Maintains UX consistency between main form buttons and sticky toolbar. Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188774&action=edit Bug 40191: Update Cypress tests for split button navigation changes Updates existing test selectors and assertions to work with the new split button UI pattern: - Admin/RecordSources_spec.ts: Update button selectors - ERM tests (Agreements, Licenses, Packages, Titles, Dialog): Update form save expectations - InfiniteScrollSelect_spec.ts: Update interaction patterns - Preservation/Trains.ts: Update save button selectors Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #39 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188775&action=edit Bug 40191: Add Cypress test coverage for split button navigation Adds E2E test in VueFramework_spec.ts verifying: - Split button renders with correct options - Primary action executes default navigation - Dropdown options execute alternative navigation behaviors - Behavior adapts correctly based on resource configuration Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188776&action=edit Bug 40191: Handle resources without detail view in navigation options Fixes an edge case where resources without a dedicated show/detail component (like Record Sources) would show invalid navigation options. - ResourceFormSave: Filter out "show" option when no_show is true - RecordSourcesResource: Set no_show flag to hide inappropriate options Ensures the split button menu only shows valid navigation targets. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart@gmail.com |martin.renvoize@openfifth.c | |o.uk --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This is looking solid to me and helps to guide us toward consistency which is a big win in my book. Test coverage is good and code quality it solid. Matt, please check your commit hook, most of the file threw tidy errors for me during QA.. I've fixed those inline. I also improved the commit messages as they were a bit sparse. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #42 from Jonathan Druart <jonathan.druart@gmail.com> --- When you edit a license you are redirected to the list view, but with agreement you get the show view, what's the reason? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #43 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #42)
When you edit a license you are redirected to the list view, but with agreement you get the show view, what's the reason?
Ah there is a "do not push" patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #44 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 41473 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #45 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- There are two files here that seems to now be not tidy: js/vue/components/ERM/EHoldingsLocalPackageResource.vue js/vue/components/ERM/LicenseResource.vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #46 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- I don't see those errors when I apply and run the QA script? .tidy.pl --js also produces no errors from this patchset Do you have other patches on your branch you haven't pushed yet that may have caused git to do some merging when applying this? Also just a reminder that there is a DO NOT PUSH patch on this bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #47 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191864&action=edit Bug 40191: Tidy files without the DO NOT PUSH patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 --- Comment #48 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_26_05_candidate |release-notes-needed --- Comment #49 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- please add release notes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #50 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This bug won't be backported to the 25.11.x branch as it has been deemed an enhancement or new feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42141 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42141 [Bug 42141] Design pattern introduced in 40191 does not work in staff SIP configuration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40191 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41916 [Bug 41916] SIP2 module cypress tests failing -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org