http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Galen Charlton from comment #24)
Comment on attachment 20343 [details] [review] Bug 9011 - QA Followup
Review of attachment 20343 [details] [review]: -----------------------------------------------------------------
::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt @@ +214,4 @@
<li><span class="label">Last seen:</span>[% IF ( ITEM_DAT.datelastseen ) %][% ITEM_DAT.datelastseen | $KohaDates %] [%END %] </li> <li><span class="label">Last borrowed:</span>[% IF (ITEM_DAT.datelastborrowed ) %][% ITEM_DAT.datelastborrowed | $KohaDates %][% END %] </li> + [% IF ( ITEM_DAT.last_returned_by && Koha.Preference('StoreLastBorrower') && !Koha.Preference('AnonymousPatron') ) %]<li><span class="label">Last returned by:</span> <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% ITEM_DAT.last_returned_by %]">[% KohaBorrowers.BorrowernumberToCardnumber( ITEM_DAT.last_returned_by ) %]</a> </li>[% END %]
Is "Koha.Preference('AnonymousPatron')" what is meant, not "!Koha.Preference('AnonymousPatron')"?
The AnonymousPatron system preference is not a Boolean, it's the borrowernumber of the record to which anonymized transactions should be linked.
Consequently, I think the QA follow-up has exactly the opposite of the intended effect.
If the pref AnonymousPatron is set to 0, that means that the feature is disabled. Else, it contains a borrowernumber and the feature is enabled. So !Koha.Preference('AnonymousPatron') means: the feature is enabled, we want to display the "last returned by" value. -- You are receiving this mail because: You are watching all bug changes.