https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36724 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hey Danyon, this looks great and is almost there. Just a few changes to make: 1. Rename the patch to: Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings (just moving the colon) 2. the `label` of the index needs to have no spaces, it's the name of the index. For eg: cartographic-mathematical-data 3. When a mapping uses multiple subfields from the same tag, you can consolidate them like this: marc_field: '255ab' Can you please make those changes and reattach the patch? -- You are receiving this mail because: You are watching all bug changes.