https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36724 --- Comment #1 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Created attachment 167426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167426&action=edit Bug: 36724 Add cartographic mathematical data to Elasticsearch index mappings Have written a patch to allow cartographic mathematical data to be searched using the default keyword search index. Testing plan: 1. Start up KTD with Elasticsearch: ktd --es8 up 2. Apply the patch and restart everything (restart_all). 3. Reset the mappings: Administration > Catalog > Search engine configuration (Elasticsearch) > Reset mappings (at the bottom of the page) 4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 5. Alternative to steps 3 and 4: reset_all 6. Update the visibility for 255$a & 255$b in the default framework so that it is visible in the Editor. 7. Add a new record using the default framework and put a unique term in both field 255$a and 255$b. 8. Using the basic keyword search, search for the terms you put in step 7. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36724 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hey Danyon, this looks great and is almost there. Just a few changes to make: 1. Rename the patch to: Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings (just moving the colon) 2. the `label` of the index needs to have no spaces, it's the name of the index. For eg: cartographic-mathematical-data 3. When a mapping uses multiple subfields from the same tag, you can consolidate them like this: marc_field: '255ab' Can you please make those changes and reattach the patch? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36724 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167426|0 |1 is obsolete| | --- Comment #3 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Created attachment 167428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167428&action=edit Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings ah my mistake, thanks for the pointers. Have gone ahead and made the requested changes. Testing plan: 1. Start up KTD with Elasticsearch: ktd --es8 up 2. Apply the patch and restart everything (restart_all). 3. Reset the mappings: Administration > Catalog > Search engine configuration (Elasticsearch) > Reset mappings (at the bottom of the page) 4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 5. Alternative to steps 3 and 4: reset_all 6. Update the visibility for 255$a & 255$b in the default framework so that it is visible in the Editor. 7. Add a new record using the default framework and put a unique term in both field 255$a and 255$b. 8. Using the basic keyword search, search for the terms you put in step 7. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36724 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- There is a sha1/fake ancestor error when applying the patch: git bz apply 36724 Bug 36724 - Add cartographic mathematical data to Elasticsearch index mappings 167428 - Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings error: sha1 information is lacking or useless (admin/searchengine/elasticsearch/mappings.yaml). error: could not build fake ancestor Patch failed at 0001 Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36724 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167428|0 |1 is obsolete| | --- Comment #5 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Created attachment 167647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167647&action=edit Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings Have reattached the patch hopefully this time without any sha1/fake ancestor errors. Testing plan: 1. Start up KTD with Elasticsearch: ktd --es8 up 2. Apply the patch and restart everything (restart_all). 3. Reset the mappings: Administration > Catalog > Search engine configuration (Elasticsearch) > Reset mappings (at the bottom of the page) 4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 5. Alternative to steps 3 and 4: reset_all 6. Update the visibility for 255$a & 255$b in the default framework so that it is visible in the Editor. 7. Add a new record using the default framework and put a unique term in both field 255$a and 255$b. 8. Using the basic keyword search, search for the terms you put in step 7. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36724 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36724 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167647|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 185255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185255&action=edit Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings Testing plan: 1. Start up KTD with Elasticsearch: ktd --es8 up 2. Apply the patch and restart everything (restart_all). 3. Reindex and reset mappings: koha-elasticsearch --rebuild -r -b -a kohadev 4. Go to Koha administration -> MARC bibliographic frameworks and edit the Default framework. Edit the subfields for the 255 tag. Update the visibility for 255$a & 255$b so that it is visible in the Editor. 5. Add a new record using the default framework and put a unique term in both field 255$a and 255$b. 6. Using the basic keyword search, search for the terms you put in step 7. Confirm your new record is returned in the results. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36724 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Values in 255$a and 255$b release notes| |in MARC21 bibliographic | |records are now indexed and | |searchable in | |Elasticsearch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36724 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185255|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 185435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185435&action=edit Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings Testing plan: 1. Start up KTD with Elasticsearch: ktd --es8 up 2. Apply the patch and restart everything (restart_all). 3. Reindex and reset mappings: koha-elasticsearch --rebuild -r -b -a kohadev 4. Go to Koha administration -> MARC bibliographic frameworks and edit the Default framework. Edit the subfields for the 255 tag. Update the visibility for 255$a & 255$b so that it is visible in the Editor. 5. Add a new record using the default framework and put a unique term in both field 255$a and 255$b. 6. Using the basic keyword search, search for the terms you put in step 7. Confirm your new record is returned in the results. Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36724 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185435|0 |1 is obsolete| | --- Comment #10 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 191514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191514&action=edit Bug 36724: Add cartographic mathematical data to Elasticsearch index mappings Testing plan: 1. Start up KTD with Elasticsearch: ktd --es8 up 2. Apply the patch and restart everything (restart_all). 3. Reindex and reset mappings: koha-elasticsearch --rebuild -r -b -a kohadev 4. Go to Koha administration -> MARC bibliographic frameworks and edit the Default framework. Edit the subfields for the 255 tag. Update the visibility for 255$a & 255$b so that it is visible in the Editor. 5. Add a new record using the default framework and put a unique term in both field 255$a and 255$b. 6. Using the basic keyword search, search for the terms you put in step 7. Confirm your new record is returned in the results. Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36724 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #12 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I think if these are distinct data point, we should really add them as distinct indexes - if Aleisha approves I think this can go to PQA -- You are receiving this mail because: You are watching all bug changes.