http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Based on my initial skimming of the patches, I think this looks great! The only very minor nitpicky suggestion would be the naming of the clases. You could rename Koha::Virtualshelf to Koha::List and Koha::Virtualshelfshares to Koha::List::Sharess or something along those lines so that we can start down the road to having our internal nomenclature match our external nomenclature. What do you think of that Jonathan? -- You are receiving this mail because: You are watching all bug changes.