http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Bug ID: 9848 Summary: SIP tests : fix in 10renew_all.t (additionnal checkin) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: SIP2 Assignee: adrien.saurat@biblibre.com Reporter: adrien.saurat@biblibre.com CC: colin.campbell@ptfs-europe.com [MT10401] An error occurs while trying the "renew all" SIP test, 10renew_all.t: # Failed test 'match leader Renew All: prep: check out 1783B to 1X981' # at /home/asaurat/workspace/versions/community/C4/SIP/t/SIPtest.pm line 204. # Response '121YNY20130319 153138AOVIL|AA1X981|AB1783B|AJL ANGOISSE DU ROI SALOMON|AH20130521 235900|AFItem already checked out to you: renewing item.|AY3AZD551' doesn't match pattern '(?-xism:^121NNY\d{8} {4}\d{6})' Koha sent: 121YNY The test expects: 121NNY 12 = code for "Checkout Response" message 1 = Operation succeeded The three following characters mean: - renewal ok - magnetic data - desensitize We have a difference on the "Renewal ok" field. I found the reason behind this: it happens when you run all the tests at once ("make test"). In this case, this "renew all" test starts with an item already checked out during a former test. The "renew all" test begins with a checkout operation, but as the item is already out, this results in a renewal when it's not expected yet. The solution I can see : adding a "checkin" operation at the very beginning of the test. But to let the test work even when launched alone, we must allow this checkin to be unsuccessfull, it's just part of the preparation before the actual renewal tests. -- You are receiving this mail because: You are watching all bug changes.