http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #109 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #108) Hi Chris,
The point of my counter proposal was that we do not need another module, we can add some lines to context.pm using Log4perl and not have another module to maintain ourselves.
Humm, I don't think it is a good argument. A module with unit tests is easiest to maintain than a module like C4::Context (~1000l) :)
Pushing this now as it is, would mean we would just have to remove it again if we wanted to do it the Log4perl way. IE if people think that is a good idea, then I can write a working patch for that, however if this is pushed, I won't. I also won't be happy that we have yet another module we have to maintain instead.
I maintain we dont need a new logging module, we just need to add logging to C4::Context.
There is no problem to propose an alternative working patch, but don't loose sight of the fact that the module we propose here does something else more than just logging: - a called by trace is displayed for some levels - a get_messages method allows to return all logged messages - messages are thrown to the stdout if the logger is not defined (ie. no filepatch defined or a bad configuration somewhere) - a parameter allows to dump a variable (using Data::Dumper or something else. e.g. $logger->debug($hashref, "dump_me");) -- You are receiving this mail because: You are watching all bug changes.