https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #72 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Paul Derscheid from comment #58)
Thanks Tomás! A few things before passing QA:
1. The [DO NOT PUSH] schema patch (attachment 200559 [details] [review]) is empty. The schema changes ended up in "Add materialized description columns". Also, the patron/pickup_library belongs_to aliases are below the md5 line, so they need to move to a regular patch ("Add holds queue REST API endpoint" already claims them).
Yeah, I reorganized it now. @RM, the fact we need tweaking the schema made me remove the 'DO NOT PUSH' status for that patch.
2. The rename follow-up also drops !is_superlibrarian from the HidePatronName check. The change looks right, but it should be squashed into the endpoint patch?
That was clearly a bad rebase. As it's been a discussed matter in community, I kept it now as a self-contained patch.
3. No test coverage for HidePatronName in t/db_dependent/api/v1/holds_queue.t.
Done, in the follow-up commit.
4. t/lib/sample_holds_queue.pl would be the first executable script in t/lib. Intentional, or should it live in misc/devel/?
This is a 'DO NOT PUSH' commit, shouldn't be a problem
5. Minor: does patron duplicate the existing borrower relationship because of the embed name?
That's correct. -- You are receiving this mail because: You are watching all bug changes.