https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198526&action=edit Bug 41769: Make ', by' string translatable in suggestions This fixes a translation issue in the purchase suggestions table in the staff interface - a ", by" is added between the title and the author in the suggestion column, the "by" is not translated when the language for the staff interface is a language other than English. Test plan: 1. Add another language to Koha: ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages: 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion: 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Apply patch. 7. Run these commands to update the translation: 7.1 ./misc/translator/translate update fr-CA 7.2 ./misc/translator/translate install fr-CA 8. Reload page. 9. Notice that ", by" is now translated. --> in this instance, you will see ", par" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.