[Bug 41769] New: ", by" in suggestions is untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Bug ID: 41769 Summary: ", by" in suggestions is untranslatable Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com When viewing purchase suggestions in the staff interface, a ", by" is added between the title and the author. This was translatable in 24.05, but several of our clients noticed it was not translated in 25.05 when we upgraded them. I cannot find the string in Weblate for this. The code changed in 25.05 with bug 33430. To recreate: 1. Add another language to Koha ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Search the .po files for ", by" grep -B 3 ", by" misc/translator/po/fr-CA* --> Nothing in suggestion.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33430 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 [Bug 33430] Use REST API for suggestions tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Ray Delahunty <raymund.delahunty@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |raymund.delahunty@outlook.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #1 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 192541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192541&action=edit Bug 41769: Make ', by' string translatable in suggestions To test: 1. Add another language to Koha ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Apply patch. 7. Reload page. 8. Notice that ", by" is now translated. --> in this instance, you will see ", par" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192541|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 192545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192545&action=edit Bug 41769: Make ', by' string translatable in suggestions To test: 1. Add another language to Koha ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Apply patch. 7. Reload page. 8. Notice that ", by" is now translated. --> in this instance, you will see ", par" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. After applying the patch you need to update the translation (this worked for me, not sure if both steps required): . ./misc/translator/translate update fr-CA . ./misc/translator/translate install fr-CA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ayoub.glizi-vicioso@inLibro |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #4 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- (In reply to David Nind from comment #3)
Testing notes (using KTD):
1. After applying the patch you need to update the translation (this worked for me, not sure if both steps required): . ./misc/translator/translate update fr-CA . ./misc/translator/translate install fr-CA
Yes indeed, i forgot to specify. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192545|0 |1 is obsolete| | --- Comment #5 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 192546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192546&action=edit Bug 41769: Make ', by' string translatable in suggestions To test: 1. Add another language to Koha ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Apply patch. 7. run those command: --> ./misc/translator/translate update fr-CA --> ./misc/translator/translate install fr-CA 8. Reload page. 9. Notice that ", by" is now translated. --> in this instance, you will see ", par" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to Ayoub Glizi-Vicioso from comment #4)
(In reply to David Nind from comment #3)
Testing notes (using KTD):
1. After applying the patch you need to update the translation (this worked for me, not sure if both steps required): . ./misc/translator/translate update fr-CA . ./misc/translator/translate install fr-CA
Yes indeed, i forgot to specify.
No problem! 8-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192546|0 |1 is obsolete| | --- Comment #7 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 192579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192579&action=edit Bug 41769: Make ', by' string translatable in suggestions To test: 1. Add another language to Koha ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Apply patch. 7. run those command: --> ./misc/translator/translate update fr-CA --> ./misc/translator/translate install fr-CA 8. Reload page. 9. Notice that ", by" is now translated. --> in this instance, you will see ", par" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <Raymund.delahunty@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #8 from Ray Delahunty <raymund.delahunty@outlook.com> --- Whether my signoff is valid or not is for others to decide, as I only used a sandbox, not this KTD. (Reading and learning about the KTD is on this weekend's 'to do list'). Rather than run the update of the already installed language pack, I ran patch in the sandbox and then installed the language, and 'by' was 'von' for the DE language option. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this works, but I wonder about the empty parameters: node += _("%s%s, by %s%s").format("", "", row.author.escapeHtml(), "") Why the additional %s? Why not: node += _(", by %s").format(row.author.escapeHtml()) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192579|0 |1 is obsolete| | --- Comment #10 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 194366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194366&action=edit Bug 41769: Make ', by' string translatable in suggestions To test: 1. Add another language to Koha ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Apply patch. 7. run those command: --> ./misc/translator/translate update fr-CA --> ./misc/translator/translate install fr-CA 8. Reload page. 9. Notice that ", by" is now translated. --> in this instance, you will see ", par" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <Raymund.delahunty@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #11 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 194367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194367&action=edit Bug 41769: (follow-up) Make ', by' string translatable in suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194366|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194367|0 |1 is obsolete| | --- Comment #12 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 194368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194368&action=edit Bug 41769: (follow-up) Make ', by' string translatable in suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Works for me. I can't sign off bc I work with Ayoub, but there are already two sign offs. Should it go directly to Signed Off to get QA'ed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #14 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 194562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194562&action=edit Bug 41769: (follow-up) Make ', by' string translatable in suggestions To test: 1. Add another language to Koha ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Apply patch. 7. run those command: --> ./misc/translator/translate update fr-CA --> ./misc/translator/translate install fr-CA 8. Reload page. 9. Notice that ", by" is now translated. --> in this instance, you will see ", par" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194368|0 |1 is obsolete| | --- Comment #15 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 194563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194563&action=edit Bug 41769: (follow-up) Make ', by' string translatable in suggestions To test: 1. Add another language to Koha ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Apply patch. 7. run those command: --> ./misc/translator/translate update fr-CA --> ./misc/translator/translate install fr-CA 8. Reload page. 9. Notice that ", by" is now translated. --> in this instance, you will see ", par" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194562|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #16 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- I have cleaned up the patches by obsoleting the previous ones and keeping only the necessary follow-up. I am also providing an updated test plan below. Since there are already two successful sign-offs and I have re-verified the fix, I am setting this to Signed Off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 194611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194611&action=edit Bug 41769: Make ', by' string translatable in suggestions This fixes a translation issue in the purchase suggestions table in the staff interface - a ", by" is added between the title and the author in the suggestion column, the "by" is not translated when the language for the staff interface is a language other than English. Test plan: 1. Add another language to Koha: ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages: 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion: 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Apply patch. 7. Run these commands to update the translation: 7.1 ./misc/translator/translate update fr-CA 7.2 ./misc/translator/translate install fr-CA 8. Reload page. 9. Notice that ", by" is now translated. --> in this instance, you will see ", par" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194563|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a translation release notes| |issue in the purchase | |suggestions | |table in the staff | |interface. When there is a | |suggestion title and | |author, a ", by" is added | |between the title and the | |author in the suggestion | |column. The "by" was not | |being translated when a | |language other than English | |was used for the staff | |interface. Summary|", by" in suggestions is |", by" in suggestions table |untranslatable |in the staff interface is | |not translated --- Comment #18 from David Nind <david@davidnind.com> --- I've added my sign-off. I also amended the commit message to fix the title (removed (follow-up)), added a description, and made some minor changes to the test plan David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194623&action=edit Bug 41769: Translate "%s, by %s" Instead of translating ", by" we add more flexibility for languages that need to invert author and title for instance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- What about this last patch? I think it's better to have "%s, by %s". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- Ayoub, Caroline, can you have a look at the follow-up please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #22 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- fix merge conflict -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194611|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194623|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #23 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 198062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198062&action=edit Bug 41769: Make ', by' string translatable in suggestions This fixes a translation issue in the purchase suggestions table in the staff interface - a ", by" is added between the title and the author in the suggestion column, the "by" is not translated when the language for the staff interface is a language other than English. Test plan: 1. Add another language to Koha: ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages: 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion: 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Apply patch. 7. Run these commands to update the translation: 7.1 ./misc/translator/translate update fr-CA 7.2 ./misc/translator/translate install fr-CA 8. Reload page. 9. Notice that ", by" is now translated. --> in this instance, you will see ", par" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #24 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 198063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198063&action=edit Bug 41769: Translate "%s, by %s" Instead of translating ", by" we add more flexibility for languages that need to invert author and title for instance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #25 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- (In reply to Jonathan Druart from comment #21)
Ayoub, Caroline, can you have a look at the follow-up please?
Hi, I tested it locally with the translations, and it works as expected. However, the string "%s, by %s" is not currently present in the .po files, so it will need to be added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|katrin.fischer@bsz-bw.de |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198062|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198063|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198526&action=edit Bug 41769: Make ', by' string translatable in suggestions This fixes a translation issue in the purchase suggestions table in the staff interface - a ", by" is added between the title and the author in the suggestion column, the "by" is not translated when the language for the staff interface is a language other than English. Test plan: 1. Add another language to Koha: ./misc/translator/translate install fr-CA 2. Enable the new language in StaffInterfaceLanguages: 2.1. Go to Administration > System preferences 2.2. Search for StaffInterfaceLanguages 2.3. Check the new language 2.4. Click Save all I18N/L10N preferences 3. Create a new purchase suggestion: 3.1. Go to More > Suggestions 3.2. Click New purchase suggestion 3.3. Fill out the title AND the author at least 3.4. Click Submit your suggestion 4. View the suggestion in the table --> It says title, by author 5. Switch language --> The ", by" is still in English 6. Apply patch. 7. Run these commands to update the translation: 7.1 ./misc/translator/translate update fr-CA 7.2 ./misc/translator/translate install fr-CA 8. Reload page. 9. Notice that ", by" is now translated. --> in this instance, you will see ", par" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198527&action=edit Bug 41769: Translate "%s, by %s" Instead of translating ", by" we add more flexibility for languages that need to invert author and title for instance. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42471 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #28 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 --- Comment #29 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org