https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #58 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Thanks Joubu for the time dedicated here. (In reply to Jonathan Druart from comment #50)
components/ILL/ISO18626MessageDisplay.vue 38 {{ new Date(message.timestamp).toLocaleString() }} Should certainly use format_date/$date (like everywhere else in .vue file)
Followed up.
Regarding the translatability patch, there are more to fix: components/ILL/ProgressRequest.vue 7 This request's status is 11 <p>Below are the possible actions in order to progress it.</p> 54 <p>This request has been completed. Nothing to do here.</p>
ProgressRequest.vue no longer exists.
components/ILL/ISO18626MessageDisplay.vue 13 <th>Type</th> 14 <th>Information</th> 15 <th>Timestamp</th> 16 <th>Content</th> 46 View message
components/ILL/SupplyingResource.vue 932 { name: "Request details", pane: 1 }, 933 { name: "ISO18626 Messages", pane: 1 }, 934 { name: "Circulation information", pane: 2 }, 935 { name: "Specified by the requesting agency", pane: 2 },
Not even talking about those ones that feel wrong: 32 {{ message.type }} 35 {{ getMessageData(message.content) }}
96 message_data = "Reason: " + message_data; 99 message_data = "Action: " + message_data;
I believe these are all fixed by prior follow-up(s).
Also caught this: 122 placeholder: $__( 123 "http://localhost:8081/api/v1/contrib/iso18626/supplying_agency_message" 124 ),
This is a visual placeholder illustrating how a requesting Koha URL would look like. It has no functional implications (i.e. 'localhost' here is not used for anything).
components/ModuleDashboard/Widgets/ILLRequests.vue (script part not needed) 16 {{ visitOldILLModuleText }} 45 const visitOldILLModuleText = $__( 46 "Visit ILL requests (previously ILL Module)" 47 ); 195 visitOldILLModuleText,
Followed up.
import statements use rel paths, should have used '@koha-vue'
This is being used: import { $__ } from "@koha-vue/i18n"; Where else do we need to add it? -- You are receiving this mail because: You are watching all bug changes.