https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #27)
Nick, this patch looks correct, but I may be missing why you didn't keep it like it was before.
Can you double check it please? In doubt, obsolete it.
$auto_renew->auto_renew_error is the result of last run, or renewal has not been attempted previously. In either case, it means that current run either: 1 - renewed it, so remains unset 2 - didn't renew it and we need to update it Either case means the issue was update and belongs in the report, and avoids checking an undef value against $error if it has value we should compare to $error -- You are receiving this mail because: You are watching all bug changes.