https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192187&action=edit Bug 36506: Use new rules in C4::Accounts This seems to be the only place processing fee is used, in chargelostitem This patch uses get_effective_rule_value, falling back to 0 if no rule. We also respect the new system preference, LostChargesControl, introduced in bug 39802 To test: 1 - Apply patch, updatedatabase, restart all 2 - Set a default/all branches processing rule for Books itemtype to 5 3 - Set a rule for branch 1 to 1 4 - Set a rule for branch 2 to 2 5 - Set a rule for branch 3 to 3 6 - Set a rule for branch 4 to 4 7 - Set LostChargesControl to 'library the patron is from' 8 - Check out a Books item from a different branch to a patron from branch 1 9 - Mark item lost, confirm processing fee is charged as 1 10 - Check out out a Books item from a different branch to a patron from branch 5 11 - Mark item lost, confirm processing fee is 5 12 - Set LostChargesControl to 'library you are logged in at' 13 - Check out a Books item from a different branch to a patron from branch 1 14 - Ensure you are logged in at branch 2 15 - Mark item lost, confirm processing fee is 2 16 - Set LostChargesControl to 'the library the item is from' 17 - Set HomeOrHoldingBranch to 'homebranch' 18 - Still at branch 2, check out a books item from branch 3 to a patron of branch 1, this ensure holdingbranch is not 3 19 - Mark item lost, confirm processing fee is 3 20 - Set HomeOrHoldingBranch to 'holdingbranch' 21 - Ensure you are logged in at branch 4 22 - Checkout an item from branch 1 to a patron from a different branch 23 - Mark item lost, confirm processing fee is 4 24 - Test other combos as you see fit 25 - Sign off! Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.