[Bug 36506] New: Processing Fee should be configurable by branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Bug ID: 36506 Summary: Processing Fee should be configurable by branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.scheer@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In a consortia environment, some branches might want a process fee and others might not. This could be worked around with multiple item types, but that can cause other issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25990 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39802 [Bug 39802] Add CircControl equivalent system preference for lost item fees and actions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This enhancement will need to include a system preference to determine which branch's processing fees should be used. Further, that system preference should cover branch selection for lost item behavior generally. I've filed bug 39802. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35612 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 [Bug 35612] Branchcode information for all customer fees lines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35612 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 [Bug 35612] Branchcode information for all customer fees lines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35612 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612 [Bug 35612] Record branch context in accountlines.branchcode for LOST and PROCESSING fees -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 187411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187411&action=edit Bug 36506: Add lost_item_processing_fee rule and CRUD Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 187412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187412&action=edit Bug 36506: Database update Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 187413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187413&action=edit Bug 36506: Remove API mapping Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 187414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187414&action=edit Bug 36506: Remove process fee from itemtype administration Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 187415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187415&action=edit Bug 36506: DO NOT PUSH - SCHEMA UPDATES Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 187416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187416&action=edit Bug 36506: Use new rules in C4::Accounts This seems to be the only place processing fee is used, in chargelostitem This patch uses get_effective_rule_value, falling back to 0 if no rule. We also respect the new system preference, LostChargesControl, introduced in bug 39802 To test: 1 - Apply patch, updatedatabase, restart all 2 - Set a default/all branches processing rule for Books itemtype to 5 3 - Set a rule for branch 1 to 1 4 - Set a rule for branch 2 to 2 5 - Set a rule for branch 3 to 3 6 - Set a rule for branch 4 to 4 7 - Set LostChargesControl to 'library the patron is from' 8 - Check out a Books item from a different branch to a patron from branch 1 9 - Mark item lost, confirm processing fee is charged as 1 10 - Check out out a Books item from a different branch to a patron from branch 5 11 - Mark item lost, confirm processing fee is 5 12 - Set LostChargesControl to 'library you are logged in at' 13 - Check out a Books item from a different branch to a patron from branch 1 14 - Ensure you are logged in at branch 2 15 - Mark item lost, confirm processing fee is 2 16 - Set LostChargesControl to 'the library the item is from' 17 - Set HomeOrHoldingBranch to 'homebranch' 18 - Still at branch 2, check out a books item from branch 3 to a patron of branch 1, this ensure holdingbranch is not 3 19 - Mark item lost, confirm processing fee is 3 20 - Set HomeOrHoldingBranch to 'holdingbranch' 21 - Ensure you are logged in at branch 4 22 - Checkout an item from branch 1 to a patron from a different branch 23 - Mark item lost, confirm processing fee is 4 24 - Test other combos as you see fit 25 - Sign off! Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 187417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187417&action=edit Bug 36506: Adjust existing tests and test builder All the previously written tests should continue to pass. Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #9 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 187418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187418&action=edit Bug 36506: Unit tests Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187411|0 |1 is obsolete| | --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187573&action=edit Bug 36506: Add lost_item_processing_fee rule and CRUD Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187412|0 |1 is obsolete| | --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187574&action=edit Bug 36506: Database update Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187413|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187575&action=edit Bug 36506: Remove API mapping Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187414|0 |1 is obsolete| | --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187576&action=edit Bug 36506: Remove process fee from itemtype administration Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187415|0 |1 is obsolete| | --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187577&action=edit Bug 36506: DO NOT PUSH - SCHEMA UPDATES Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187416|0 |1 is obsolete| | --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187578&action=edit Bug 36506: Use new rules in C4::Accounts This seems to be the only place processing fee is used, in chargelostitem This patch uses get_effective_rule_value, falling back to 0 if no rule. We also respect the new system preference, LostChargesControl, introduced in bug 39802 To test: 1 - Apply patch, updatedatabase, restart all 2 - Set a default/all branches processing rule for Books itemtype to 5 3 - Set a rule for branch 1 to 1 4 - Set a rule for branch 2 to 2 5 - Set a rule for branch 3 to 3 6 - Set a rule for branch 4 to 4 7 - Set LostChargesControl to 'library the patron is from' 8 - Check out a Books item from a different branch to a patron from branch 1 9 - Mark item lost, confirm processing fee is charged as 1 10 - Check out out a Books item from a different branch to a patron from branch 5 11 - Mark item lost, confirm processing fee is 5 12 - Set LostChargesControl to 'library you are logged in at' 13 - Check out a Books item from a different branch to a patron from branch 1 14 - Ensure you are logged in at branch 2 15 - Mark item lost, confirm processing fee is 2 16 - Set LostChargesControl to 'the library the item is from' 17 - Set HomeOrHoldingBranch to 'homebranch' 18 - Still at branch 2, check out a books item from branch 3 to a patron of branch 1, this ensure holdingbranch is not 3 19 - Mark item lost, confirm processing fee is 3 20 - Set HomeOrHoldingBranch to 'holdingbranch' 21 - Ensure you are logged in at branch 4 22 - Checkout an item from branch 1 to a patron from a different branch 23 - Mark item lost, confirm processing fee is 4 24 - Test other combos as you see fit 25 - Sign off! Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187417|0 |1 is obsolete| | --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187579&action=edit Bug 36506: Adjust existing tests and test builder All the previously written tests should continue to pass. Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187418|0 |1 is obsolete| | --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187580&action=edit Bug 36506: Unit tests Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Dare I ask.. as we're migrating from Itemtypes to Circulation Rules... why limit ourselves to Itemtype/Branchcode combinations.. it feels like it would be a tiny extra step to include the Patron Category as an optional filter too at this stage? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Comment on attachment 187578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187578 Bug 36506: Use new rules in C4::Accounts Review of attachment 187578: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=36506&attachment=187578) ----------------------------------------------------------------- ::: C4/Accounts.pm @@ +78,5 @@
+ my $lost_control_branch; + if ( $lost_control_pref eq 'PatronLibrary' ) { + $lost_control_branch = $patron->branchcode; + } elsif ( $lost_control_pref eq 'PickupLibrary' ) { + $lost_control_branch = C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef;
Can you explain the reasoning here.. a lost item won't necessarily be related to a hold.. so I get we can't easily pass a PickupLibrary and I understand using the userenv.. i.e. your using 'PickupLibrary' to mean 'Library the patron is standing in' if this is getting charged via the UI.. but when that's not the case.. i.e. when running from a cron?. Does it really make sense to fall back to the 'default rule for all libraries' if set.. or should we instead fall back to the patrons home library on the assumption they'd 'Pickup' from their home branch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |The Main Library Alliance list of Sponsors| |<https://www.mainlib.org/> Status|Signed Off |Passed QA Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187573|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187574|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187575|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187576|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187577|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187578|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192182&action=edit Bug 36506: Add lost_item_processing_fee rule and CRUD Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192183&action=edit Bug 36506: Database update Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192184&action=edit Bug 36506: Remove API mapping Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192185&action=edit Bug 36506: Remove process fee from itemtype administration Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192186&action=edit Bug 36506: DO NOT PUSH - SCHEMA UPDATES Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192187&action=edit Bug 36506: Use new rules in C4::Accounts This seems to be the only place processing fee is used, in chargelostitem This patch uses get_effective_rule_value, falling back to 0 if no rule. We also respect the new system preference, LostChargesControl, introduced in bug 39802 To test: 1 - Apply patch, updatedatabase, restart all 2 - Set a default/all branches processing rule for Books itemtype to 5 3 - Set a rule for branch 1 to 1 4 - Set a rule for branch 2 to 2 5 - Set a rule for branch 3 to 3 6 - Set a rule for branch 4 to 4 7 - Set LostChargesControl to 'library the patron is from' 8 - Check out a Books item from a different branch to a patron from branch 1 9 - Mark item lost, confirm processing fee is charged as 1 10 - Check out out a Books item from a different branch to a patron from branch 5 11 - Mark item lost, confirm processing fee is 5 12 - Set LostChargesControl to 'library you are logged in at' 13 - Check out a Books item from a different branch to a patron from branch 1 14 - Ensure you are logged in at branch 2 15 - Mark item lost, confirm processing fee is 2 16 - Set LostChargesControl to 'the library the item is from' 17 - Set HomeOrHoldingBranch to 'homebranch' 18 - Still at branch 2, check out a books item from branch 3 to a patron of branch 1, this ensure holdingbranch is not 3 19 - Mark item lost, confirm processing fee is 3 20 - Set HomeOrHoldingBranch to 'holdingbranch' 21 - Ensure you are logged in at branch 4 22 - Checkout an item from branch 1 to a patron from a different branch 23 - Mark item lost, confirm processing fee is 4 24 - Test other combos as you see fit 25 - Sign off! Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192188&action=edit Bug 36506: Adjust existing tests and test builder All the previously written tests should continue to pass. Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192189&action=edit Bug 36506: Unit tests Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192190&action=edit Bug 36506: (QA follow-up) Add test for missing circulation rule This adds a test case to verify that when no lost_item_processing_fee circulation rule exists for a branch/itemtype combination, the system correctly defaults to 0 (no processing fee charged). The test confirms: - No PROCESSING account line is created when the rule is missing - The LOST fee is still created normally (only processing fee affected) - The // 0 fallback in C4::Accounts::chargelostitem works correctly Test plan: 1. prove t/db_dependent/Accounts.t 2. Verify all tests pass, including the new "missing circulation rule" test case Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #29 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Martin Renvoize (ashimema) from comment #19)
Comment on attachment 187578 [details] [review]
+ } elsif ( $lost_control_pref eq 'PickupLibrary' ) {
"PickupLibrary" is really a misnomer here, I held it over from the pref we split off from in bug 39802 The interface translates PickupLibrary as 'the library you are logged in at' If you don't have a userenv (i.e. you are a cronjob) then we assume the default rules - which is where we copy the current itemtype rules - so falling back to default/undef made sense to me here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This enhancement adds a new release notes| |section to the Circulation | |and fines rules page, and | |allows the configuration of | |processing fees per branch | |and itemtype. | | | |Following the | |LostChargesControl syspref, | |the rule will be chosen | |based on the branch | |selected and items will be | |charged the corresponding | |processing fee when marked | |lost if there is one | |defined. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192182|0 |1 is obsolete| | Attachment #192183|0 |1 is obsolete| | Attachment #192184|0 |1 is obsolete| | Attachment #192185|0 |1 is obsolete| | Attachment #192186|0 |1 is obsolete| | Attachment #192187|0 |1 is obsolete| | Attachment #192188|0 |1 is obsolete| | Attachment #192189|0 |1 is obsolete| | Attachment #192190|0 |1 is obsolete| | --- Comment #30 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192924&action=edit Bug 36506: Add lost_item_processing_fee rule and CRUD Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #31 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192925&action=edit Bug 36506: Database update Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #32 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192926&action=edit Bug 36506: Remove API mapping Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #33 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192927&action=edit Bug 36506: Remove process fee from itemtype administration Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #34 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192928&action=edit Bug 36506: Use new rules in C4::Accounts This seems to be the only place processing fee is used, in chargelostitem This patch uses get_effective_rule_value, falling back to 0 if no rule. We also respect the new system preference, LostChargesControl, introduced in bug 39802 To test: 1 - Apply patch, updatedatabase, restart all 2 - Set a default/all branches processing rule for Books itemtype to 5 3 - Set a rule for branch 1 to 1 4 - Set a rule for branch 2 to 2 5 - Set a rule for branch 3 to 3 6 - Set a rule for branch 4 to 4 7 - Set LostChargesControl to 'library the patron is from' 8 - Check out a Books item from a different branch to a patron from branch 1 9 - Mark item lost, confirm processing fee is charged as 1 10 - Check out out a Books item from a different branch to a patron from branch 5 11 - Mark item lost, confirm processing fee is 5 12 - Set LostChargesControl to 'library you are logged in at' 13 - Check out a Books item from a different branch to a patron from branch 1 14 - Ensure you are logged in at branch 2 15 - Mark item lost, confirm processing fee is 2 16 - Set LostChargesControl to 'the library the item is from' 17 - Set HomeOrHoldingBranch to 'homebranch' 18 - Still at branch 2, check out a books item from branch 3 to a patron of branch 1, this ensure holdingbranch is not 3 19 - Mark item lost, confirm processing fee is 3 20 - Set HomeOrHoldingBranch to 'holdingbranch' 21 - Ensure you are logged in at branch 4 22 - Checkout an item from branch 1 to a patron from a different branch 23 - Mark item lost, confirm processing fee is 4 24 - Test other combos as you see fit 25 - Sign off! Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #35 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192929&action=edit Bug 36506: Adjust existing tests and test builder All the previously written tests should continue to pass. Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #36 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192930&action=edit Bug 36506: Unit tests Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #37 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192931&action=edit Bug 36506: (QA follow-up) Add test for missing circulation rule This adds a test case to verify that when no lost_item_processing_fee circulation rule exists for a branch/itemtype combination, the system correctly defaults to 0 (no processing fee charged). The test confirms: - No PROCESSING account line is created when the rule is missing - The LOST fee is still created normally (only processing fee affected) - The // 0 fallback in C4::Accounts::chargelostitem works correctly Test plan: 1. prove t/db_dependent/Accounts.t 2. Verify all tests pass, including the new "missing circulation rule" test case Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #38 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192932&action=edit Bug 36506: DO NOT PUSH - SCHEMA UPDATES -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #39 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- git show b0cb46e0f626f15b9224bbf63f18dcff35f314cc: -There are merge markers left in the codebase. -itemtype.tt isn't tidy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192924|0 |1 is obsolete| | --- Comment #40 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194110&action=edit Bug 36506: Add lost_item_processing_fee rule and CRUD Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192925|0 |1 is obsolete| | --- Comment #41 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194111&action=edit Bug 36506: Database update Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192926|0 |1 is obsolete| | --- Comment #42 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194112&action=edit Bug 36506: Remove API mapping Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192927|0 |1 is obsolete| | --- Comment #43 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194113&action=edit Bug 36506: Remove process fee from itemtype administration Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192928|0 |1 is obsolete| | --- Comment #44 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194114&action=edit Bug 36506: Use new rules in C4::Accounts This seems to be the only place processing fee is used, in chargelostitem This patch uses get_effective_rule_value, falling back to 0 if no rule. We also respect the new system preference, LostChargesControl, introduced in bug 39802 To test: 1 - Apply patch, updatedatabase, restart all 2 - Set a default/all branches processing rule for Books itemtype to 5 3 - Set a rule for branch 1 to 1 4 - Set a rule for branch 2 to 2 5 - Set a rule for branch 3 to 3 6 - Set a rule for branch 4 to 4 7 - Set LostChargesControl to 'library the patron is from' 8 - Check out a Books item from a different branch to a patron from branch 1 9 - Mark item lost, confirm processing fee is charged as 1 10 - Check out out a Books item from a different branch to a patron from branch 5 11 - Mark item lost, confirm processing fee is 5 12 - Set LostChargesControl to 'library you are logged in at' 13 - Check out a Books item from a different branch to a patron from branch 1 14 - Ensure you are logged in at branch 2 15 - Mark item lost, confirm processing fee is 2 16 - Set LostChargesControl to 'the library the item is from' 17 - Set HomeOrHoldingBranch to 'homebranch' 18 - Still at branch 2, check out a books item from branch 3 to a patron of branch 1, this ensure holdingbranch is not 3 19 - Mark item lost, confirm processing fee is 3 20 - Set HomeOrHoldingBranch to 'holdingbranch' 21 - Ensure you are logged in at branch 4 22 - Checkout an item from branch 1 to a patron from a different branch 23 - Mark item lost, confirm processing fee is 4 24 - Test other combos as you see fit 25 - Sign off! Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192929|0 |1 is obsolete| | --- Comment #45 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194115&action=edit Bug 36506: Adjust existing tests and test builder All the previously written tests should continue to pass. Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192930|0 |1 is obsolete| | --- Comment #46 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194116&action=edit Bug 36506: Unit tests Sponsored-by: The Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192931|0 |1 is obsolete| | --- Comment #47 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194117&action=edit Bug 36506: (QA follow-up) Add test for missing circulation rule This adds a test case to verify that when no lost_item_processing_fee circulation rule exists for a branch/itemtype combination, the system correctly defaults to 0 (no processing fee charged). The test confirms: - No PROCESSING account line is created when the rule is missing - The LOST fee is still created normally (only processing fee affected) - The // 0 fallback in C4::Accounts::chargelostitem works correctly Test plan: 1. prove t/db_dependent/Accounts.t 2. Verify all tests pass, including the new "missing circulation rule" test case Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192932|0 |1 is obsolete| | --- Comment #48 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 194118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194118&action=edit Bug 36506: DO NOT PUSH - SCHEMA UPDATES -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 --- Comment #49 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Processing Fee should be |Processing fee should be |configurable by branch |configurable by library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #50 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43941 [Bug 43941] Add template plugin for fetching processing fee -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org