https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27340 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #8)
IIUC this would change what we understand as a pick-up location. Currently we understand the pick-up location as the library the item is waiting at. We'd like to add the desk to this as another optional factor.
pickup_location_id (PK) library_id desk_id description public_description
My feeling is that we don't need a new table here as we already have all the information in "desks", especially since they are already tied to a library. I don't feel like we need to be able to reuse desks at different libraries, the current implementation defining them as a "place" within a library feels correct and sufficient.
We need a table in which each row represents each allowed combination. Not all combinations are necessarily valid pickup locations.
I am not sure a separate description is strictly needed either - we could imagine 2 possible implementations in the interface:
* Have 2 separate pull-downs: select the library first, then see a list of available desks for it. * Have a combined pull-down of library + desk name.
This is overcomplicating it, actually. UI-wise it would be clearer if we just provided a 'Pickup location' pull down. And in some cases you just wouldn't specify a description and it will fall back to the library or 'Library name (desk)'. On the other hand, whenever we add endpoints for things that are not really mapped to a table with other linked tables, we end up generating weird controller code that is buggy and too complex :-D Happy to keep the discussion open, I'm not really attached to any solution. I just think our current approach to pickup locations is too limited on the API front. -- You are receiving this mail because: You are watching all bug changes.