https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #62 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Rebased patches. (In reply to Sally from comment #54)
Works as described; it shows for me as FineNoRenewals. I've signed off because all of the functionality is fine.
There were a couple of formatting issues around the currency in the pop-up box:
1) The trailing full stop / period feels a bit odd when it's currency: Shows: The patron has a debt of 3.21. Perhaps: The patron has a debt of 3.21
2) If it's a round number, then pennies/cents aren't shown - it looks a bit odd: Shows: The patron has a debt of 3. Perhaps: The patron has a debt of 3.00
These have been added in new patch.
3) Is there any scope for adding the appropriate currency symbol? Shows: The patron has a debt of 3.21 Perhaps: The patron has a debt of £3.21 And: The patron has a debt of $3.21 And: The patron has a debt of €3.21
This isn't currently possible so I left this out.
The other query was system preferences.
OPACFineNoRenewals has been renamed to FineNoRenewals. There are two other system preferences: OPACFineNoRenewalsBlockAutoRenew and OPACFineNoRenewalsIncludeCredits
The descriptions (values) of these have been updated by this bug to refer to FineNoRenewals, but should we also consider renaming the system preferences themselves to: FineNoRenewalsBlockAutoRenew and FineNoRenewalsIncludeCredits ?
I realise this last point might be out of scope of the bug. Hmm, I'm not sure if these are still used just in OPAC.
-- You are receiving this mail because: You are watching all bug changes.