https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #1 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Created attachment 92039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92039&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92039|0 |1 is obsolete| | --- Comment #2 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Created attachment 92541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92541&action=edit Bug 23415: Notify patron fines when renewing In previous patch error message wasn't translatable. Fixed that and made sure loading gif on checkout list works correctly after this patch is applied. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #4 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I also tried this patch on a sandbox and the alert was displayed on moremember.pl-page and renew.pl-page. It was not displayed on circulation.pl-page, where it should also appear. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #6 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tested this again using a sandbox with this bug number (using master) and it worked perfectly well on all three pages. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92541|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 98442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98442&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Emmi, there are some fails with the QA tools for missing filters, can you please fix? FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL filters missing_filter at line 1071 ( var amountlimit = "[% Koha.Preference('noissuescharge') %]";) missing_filter at line 1072 ( var fines = "[% fines %]";) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt FAIL filters missing_filter at line 890 ( var amountlimit = "[% Koha.Preference('noissuescharge') %]";) missing_filter at line 891 ( var fines = "[% fines %]";) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98634|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 98997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98997&action=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am wondering if noissuecharge is the right value here. We got: OPACFineNoRenewals = fine limit for renewals in the OPAC, but nothing for staff specifically. noissuecharge = fine limit for checkouts (as name says). It's used in this patch set, but there are other complications with this one: noissuescharge Prevent patrons from checking out books if they have more than EUR in fines. HoldsInNoissuesCharge [Don't include|Include] hold charges when summing up charges for noissuescharge. ManInvInNoissuesCharge [Don't include|Include] custom debit type charges when summing up charges for noissuescharge. RentalsInNoissuesCharge [Don't include|Include] rental charges when summing up charges for noissuescharge. NoIssuesChargeGuarantees Prevent a patron from checking out if the patron has guarantees owing in total more than EUR in fines. So I think this is not covering it: + my $amountlimit = C4::Context->preference("noissuescharge"); + var fines = "[% fines | html %] We'd need the amount calculated taking all noissues* prefs into account. I think I'd prefer not using noissuecharge here, as it only speaks of checkouts and we have a distinct one for renewals. Using OPACFineNoRenewals would make sense to me, as you can still override in the staff interface. So having a 'hint' there would work. Also a little worried that this adds a confirm step - but as none of the testers complained, I think it's probably ok :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #15 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Created attachment 105894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105894&action=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple holds and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has holds. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple holds (at least two) 2. Renew all holds from checkout list 3. Confirmation pop-up is displayed for every hold 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105894|0 |1 is obsolete| | --- Comment #16 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Created attachment 108392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108392&action=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98996|0 |1 is obsolete| | --- Comment #17 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Created attachment 109871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109871&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105893|0 |1 is obsolete| | --- Comment #19 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Created attachment 109876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109876&action=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #21 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Rebased patches against current master. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109871|0 |1 is obsolete| | --- Comment #23 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 116919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116919&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109876|0 |1 is obsolete| | --- Comment #25 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 116921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116921&action=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116919|0 |1 is obsolete| | --- Comment #28 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 118175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118175&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116921|0 |1 is obsolete| | --- Comment #30 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 118177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118177&action=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Stina Hallin <stina.hallin@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118176|0 |1 is obsolete| | --- Comment #34 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 119301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119301&action=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118183|0 |1 is obsolete| | --- Comment #36 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 119303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119303&action=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- I think OPACFineNoRenewals needs to be renamed to FineNoRenewals or something along those lines to prevent confusion in the future. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #38 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Kyle M Hall from comment #37)

I think OPACFineNoRenewals needs to be renamed to FineNoRenewals or something along those lines to prevent confusion in the future.

Makes sense...maybe it should also be moved from OPAC preferences to Circulation preferences. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119300|0 |1 is obsolete| | --- Comment #41 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 139670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139670&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119302|0 |1 is obsolete| | --- Comment #43 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 139672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139672&action=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121472|0 |1 is obsolete| | --- Comment #45 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 139674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139674&action=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Laura <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #46 from Laura <Laura.escamilla@bywatersolutions.com> --- The test plan still works but OPACFineNoRenewals is still showing as OPACFineNoRenewals and not FineNoRenewals. (In reply to Emmi Takkinen from comment #45)

Created attachment 139674 [details] [review] Bug 23415: Rename OPACFineNoRenewals

OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code.

To test, confirm everything works as described in previous test plans.

Also prove t/db_dependent/Circulation.t

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #48 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Laura Escamilla from comment #46)

The test plan still works but OPACFineNoRenewals is still showing as OPACFineNoRenewals and not FineNoRenewals.

(In reply to Emmi Takkinen from comment #45)

...

Created attachment 139674 [details] [review] [review] Bug 23415: Rename OPACFineNoRenewals

OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code.

To test, confirm everything works as described in previous test plans.

Also prove t/db_dependent/Circulation.t

I rebased patch and added new atomicupdate file. Could it be that patch didn't previously apply? Was syspref still named as OPACFineNoRenewals in systempreference page or was it still OPACFineNoRenewals in database and code? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139671|0 |1 is obsolete| | --- Comment #50 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 148199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148199&action=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139673|0 |1 is obsolete| | --- Comment #52 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 148201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148201&action=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #54 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described; it shows for me as FineNoRenewals. I've signed off because all of the functionality is fine. There were a couple of formatting issues around the currency in the pop-up box: 1) The trailing full stop / period feels a bit odd when it's currency: Shows: The patron has a debt of 3.21. Perhaps: The patron has a debt of 3.21 2) If it's a round number, then pennies/cents aren't shown - it looks a bit odd: Shows: The patron has a debt of 3. Perhaps: The patron has a debt of 3.00 3) Is there any scope for adding the appropriate currency symbol? Shows: The patron has a debt of 3.21 Perhaps: The patron has a debt of £3.21 And: The patron has a debt of $3.21 And: The patron has a debt of €3.21 The other query was system preferences. OPACFineNoRenewals has been renamed to FineNoRenewals. There are two other system preferences: OPACFineNoRenewalsBlockAutoRenew and OPACFineNoRenewalsIncludeCredits The descriptions (values) of these have been updated by this bug to refer to FineNoRenewals, but should we also consider renaming the system preferences themselves to: FineNoRenewalsBlockAutoRenew and FineNoRenewalsIncludeCredits ? I realise this last point might be out of scope of the bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148198|0 |1 is obsolete| | --- Comment #56 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 152776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152776&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148200|0 |1 is obsolete| | --- Comment #58 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 152778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152778&action=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148202|0 |1 is obsolete| | --- Comment #60 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 152780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152780&action=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #62 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Rebased patches. (In reply to Sally from comment #54)

Works as described; it shows for me as FineNoRenewals. I've signed off because all of the functionality is fine.

There were a couple of formatting issues around the currency in the pop-up box:

1) The trailing full stop / period feels a bit odd when it's currency: Shows: The patron has a debt of 3.21. Perhaps: The patron has a debt of 3.21

2) If it's a round number, then pennies/cents aren't shown - it looks a bit odd: Shows: The patron has a debt of 3. Perhaps: The patron has a debt of 3.00

These have been added in new patch.

3) Is there any scope for adding the appropriate currency symbol? Shows: The patron has a debt of 3.21 Perhaps: The patron has a debt of £3.21 And: The patron has a debt of $3.21 And: The patron has a debt of €3.21

This isn't currently possible so I left this out.

The other query was system preferences.

OPACFineNoRenewals has been renamed to FineNoRenewals. There are two other system preferences: OPACFineNoRenewalsBlockAutoRenew and OPACFineNoRenewalsIncludeCredits

The descriptions (values) of these have been updated by this bug to refer to FineNoRenewals, but should we also consider renaming the system preferences themselves to: FineNoRenewalsBlockAutoRenew and FineNoRenewalsIncludeCredits ?

I realise this last point might be out of scope of the bug. Hmm, I'm not sure if these are still used just in OPAC.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152777|0 |1 is obsolete| | --- Comment #64 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 154596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154596&action=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Veli-Matti <veli-matti.hakkinen@jyu.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152779|0 |1 is obsolete| | --- Comment #66 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 154598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154598&action=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Veli-Matti <veli-matti.hakkinen@jyu.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152781|0 |1 is obsolete| | --- Comment #68 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 154600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154600&action=edit Bug 23415: Add fine formatting To test: 1. Find patron with checkouts and fines over allowed limit. 2. Renew checkouts either from renew page or checkout list. => Confirm that fines are formated correctly e.g. "The patron has a debt of 20.00" not like "The patron has a debt of 20." Signed-off-by: Veli-Matti <veli-matti.hakkinen@jyu.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |martin.renvoize@ptfs-europe | |.com --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry guys, came to QA but we need a rebase first. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154595|0 |1 is obsolete| | --- Comment #71 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 158302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158302&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154597|0 |1 is obsolete| | --- Comment #73 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 158304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158304&action=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154599|0 |1 is obsolete| | --- Comment #75 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 158306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158306&action=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #77 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Rebased patches. Setting this back to "Signed Off". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158302|0 |1 is obsolete| | --- Comment #79 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 161964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161964&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158304|0 |1 is obsolete| | --- Comment #81 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 161966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161966&action=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158306|0 |1 is obsolete| | --- Comment #83 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 161968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161968&action=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #85 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Rebased patches. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161965|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162172&action=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161967|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162174&action=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161969|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162176&action=edit Bug 23415: Add fine formatting To test: 1. Find patron with checkouts and fines over allowed limit. 2. Renew checkouts either from renew page or checkout list. => Confirm that fines are formated correctly e.g. "The patron has a debt of 20.00" not like "The patron has a debt of 20." Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #93 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162178&action=edit Bug 23415: Tidy template parameters block Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #95 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162180&action=edit Bug 23415: (QA follow-up) Fix rebase code re-introduction Looks like some code was re-introduced during rebases, this patch switches it back to calling the newly introduced 'renew' function rather than doing the post inline. I also compared the two posts and updated the function to match the updated post from upstream. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is really close.. but.. May I ask why you chose to handle this at the controller level rather than adding/moving the check into CanBookBeRenewed? I see you do handle it in the _CanBookBeAutoRenewed version, but I think I am confused that it's not there in parent function. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #99 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- It seems that last patch is partially dated. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com --- Comment #100 from Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> --- It would be great to keep this moving along as so much work has been done already. I currently have a library asking for this functionality. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #102 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry to hear this Emmi, I hope we didn't make it harder. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162175|0 |1 is obsolete| | --- Comment #104 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 171621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171621&action=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162178|0 |1 is obsolete| | --- Comment #106 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 171623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171623&action=edit Bug 23415: Tidy template parameters block Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #108 from Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> --- Thank you for looking at this again Emmi and all. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171621|0 |1 is obsolete| | --- Comment #110 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 171984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171984&action=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171623|0 |1 is obsolete| | --- Comment #112 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 171986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171986&action=edit Bug 23415: Tidy template parameters block Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171983|0 |1 is obsolete| | --- Comment #113 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172906&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Sponsored-by: Koha-Suomi Oy Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171985|0 |1 is obsolete| | --- Comment #115 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172908&action=edit Bug 23415: (QA follow-up) Remove OPACFineNoRenewals from syspres.sql Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #117 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172910&action=edit Bug 23415: (QA follow-up) Move to Circulation::CanBookBeRenewed This moves the basic calculation for too_much_oweing out of the controller and into the class method. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #119 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Translations (follow-up please) + var MSG_CONFIRM_RENEW = _("The patron has a debt of %s\nAre you sure you want to renew checkout(s)?").format(fines); The \n is likely to cause issues in translations (haven't checked with Weblate, but was definitely an issue with Pootle. Please split into separate strings. 2) too_much_oweing (question, not blocker) Wondering if that should be "owing"? If so, we could fix it globally on a separate bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #122 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have to admit I got a bit confused about the before and after, but could something like AllowFineOverride be helpful here? Or a confirmation with an option to override. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #124 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We could do another pref... but before considering that it would maybe be good to get some libraries opinions on the use case and if that is really required. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate |rel_25_05_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #127 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Martin Renvoize (ashimema) from comment #126)

Do you think you'll be able to get back to this one Emmi?

I'm not currently able to work with this. Feel free to take this one if you (or someone else) have time :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #129 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I would be lovely to get this moving again.. but I'm not sure I can commit any more time here either :( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172907|0 |1 is obsolete| | --- Comment #131 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 185271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185271&action=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172909|0 |1 is obsolete| | --- Comment #133 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 185273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185273&action=edit Bug 23415: Tidy template parameters block Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #135 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 185275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185275&action=edit Bug 23415: Add new syspref AllowFineOverrideRenewing This patch adds new syspref AllowFineOverrideRenewing. It allows staff to renew items for patrons whose fines are over limit set in syspref FineNoRenewals. Otherwise renewing is prevented. If renewing items is allowed staff is still required to confirm if they really want to renew items for the patron. To test: 1. Apply this patch, update database and restart all services. 2. Find patron with fines over limit set in FineNoRenewals and renewable items. => Note that renewing is prevented with message "Cannot renew, he patron has a debt of..." 3. Set syspref AllowFineOverrideRenewing as "Allow". => Note that items can now be renewed and renewing them displays confirmation pop-up. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #138 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 186014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186014&action=edit Bug 23415: Fix QA issues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #140 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Sorry Emmi, I hit sha1 issues trying to apply this one. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185270|0 |1 is obsolete| | --- Comment #142 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188331&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Sponsored-by: Koha-Suomi Oy Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185272|0 |1 is obsolete| | --- Comment #144 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188333&action=edit Bug 23415: (QA follow-up) Remove OPACFineNoRenewals from syspres.sql Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185274|0 |1 is obsolete| | --- Comment #146 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188335&action=edit Bug 23415: (QA follow-up) Move to Circulation::CanBookBeRenewed This moves the basic calculation for too_much_oweing out of the controller and into the class method. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186014|0 |1 is obsolete| | --- Comment #148 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188337&action=edit Bug 23415: Fix QA issues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #150 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188339&action=edit Bug 23415: (QA follow-up) Fix spelling: oweing -> owing Standardizes error code spelling across the codebase: - Changes 'too_much_oweing' to 'too_much_owing' - Changes 'auto_too_much_oweing' to 'auto_too_much_owing' The word "owing" is the correct spelling in English. Files updated: - C4/Circulation.pm - C4/SIP/Sip/MsgType.pm - circ/renew.pl - koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt - koha-tmpl/intranet-tmpl/prog/js/checkouts.js - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt - misc/cronjobs/automatic_renewals.pl - opac/opac-reserve.pl - opac/opac-user.pl - t/db_dependent/Circulation.t All tests pass successfully. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #152 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188341&action=edit Bug 23415: Add API tests for fine override on renewal This commit adds comprehensive REST API tests to verify the x-koha-override: debt_limit functionality for renewals. Tests cover: - Renewal blocked due to excessive fines - Override fails when AllowFineOverrideRenewing is disabled - Override succeeds when AllowFineOverrideRenewing is enabled - Both /renewal and /renewals endpoints Test plan: 1. Run: prove t/db_dependent/api/v1/checkouts.t 2. All 110 tests should pass -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #154 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Test Plan ## Add a syspref to allow a fine override for renewals ### Test Overview This test plan focuses on verifying that staff are properly alerted when patrons with excessive fines attempt to renew items, and that the optional override functionality works correctly. --- ## Prerequisites 1. Apply all patches from Bug 23415 2. Run database updates: `perl installer/data/mysql/updatedatabase.pl` 3. Rebuild assets: `yarn build` (in KTD: `ktd --shell` then `yarn build`) 4. Restart services: `restart_all` (in KTD) 5. Have staff account with circulation permissions --- ## Test Scenario 1: Verify Fine Blocking Works ### Setup 1. Go to **Administration** > **System Preferences** 2. Search for **FineNoRenewals** 3. Set value to: **5.00** 4. Search for **AllowFineOverrideRenewing** 5. Set to: **Don't allow** (0) 6. Click **Save all Circulation Preferences** ### Create Test Patron with Fines 1. Go to **Patrons** > **New patron** (or use existing patron) 2. Create/select a patron 3. Note the patron's card number 4. Go to patron's **Fines** tab 5. Click **Create manual invoice** - Type: Choose "Overdue" - Amount: **10.00** (exceeds the 5.00 threshold) - Description: "Test fine for Bug 23415" 6. Click **Save** 7. Verify patron now has **$10.00 in fines** ### Check Out an Item to the Patron 1. Go to **Circulation** > **Check out** 2. Scan/enter patron card number 3. Check out any available item to the patron 4. Note the item barcode ### Test Renewal Blocking 1. Go to **Circulation** > **Renew** 2. Scan/enter the item barcode from above 3. Click **Submit** or press Enter **Expected Results:** - ❌ Renewal should be **BLOCKED** - 🔴 You should see a **red alert/error message** stating: - "The patron has a debt of $10.00" - ❌ You should **NOT** see any button to override or proceed with renewal - The item should **NOT** be renewed **PASS/FAIL:** _______ --- ## Test Scenario 2: Verify Override Button Appears When Enabled ### Setup 1. Go to **Administration** > **System Preferences** 2. Search for **AllowFineOverrideRenewing** 3. Set to: **Allow** (1) 4. Click **Save all Circulation Preferences** ### Test Renewal with Override Available 1. Go to **Circulation** > **Renew** 2. Scan/enter the same item barcode from Scenario 1 3. Click **Submit** or press Enter **Expected Results:** - ❌ Renewal should initially be **BLOCKED** - 🔴 You should see a **red alert/error message** stating: - "The patron has a debt of $10.00" - ✅ You **SHOULD** now see a **"Renew checkout(s)" button** - The button should be clearly visible within or near the alert message - It should be styled as an action button (likely green or prominent) **PASS/FAIL:** _______ --- ## Test Scenario 3: Verify Override Functionality Works ### Test Using Override Button 1. Still on the renewal page with the alert showing 2. Click the **"Renew checkout(s)"** button **Expected Results:** - ✅ The renewal should **SUCCEED** - ✅ You should see a **green success message** stating: - "Item renewed" - 📅 The due date should be updated/extended - The patron should **still have $10.00 in fines** (override doesn't remove fines) **PASS/FAIL:** _______ ### Verify Renewal in Patron Record 1. Go to the patron's record 2. Click on **Checkouts** tab **Expected Results:** - ✅ The item should show an **updated/extended due date** - ✅ The **Renewals count** should have increased by 1 **PASS/FAIL:** _______ --- ## Test Scenario 4: Verify No Override When Preference Disabled ### Setup 1. Go to **Administration** > **System Preferences** 2. Search for **AllowFineOverrideRenewing** 3. Set to: **Don't allow** (0) 4. Click **Save all Circulation Preferences** ### Attempt Another Renewal 1. Go to **Circulation** > **Renew** 2. Scan/enter the same item barcode (should still be checked out) 3. Click **Submit** or press Enter **Expected Results:** - ❌ Renewal should be **BLOCKED** - 🔴 You should see the error message about patron debt - ❌ You should **NOT** see the "Renew checkout(s)" button - The override button should have **disappeared** since the preference is disabled **PASS/FAIL:** _______ --- ## Test Scenario 5: Verify Renewal Allowed When Fines Below Threshold ### Setup - Pay Down Fines 1. Go to the patron's record 2. Click on **Fines** tab 3. Find the $10.00 fine 4. Click **Pay** or **Pay amount** 5. Pay **$7.00** (leaving $3.00 outstanding) 6. Verify patron now has **$3.00 in fines** (below the 5.00 threshold) ### Test Renewal with Low Fines 1. Go to **Circulation** > **Renew** 2. Scan/enter the item barcode 3. Click **Submit** or press Enter **Expected Results:** - ✅ Renewal should **SUCCEED** immediately - ✅ You should see a **green success message**: "Item renewed" - ❌ You should **NOT** see any error about fines - ❌ You should **NOT** need to override anything **PASS/FAIL:** _______ --- ## Test Scenario 6: Verify Checkout Page Behavior ### Test from Patron Checkout Page 1. Go to **Circulation** > **Check out** 2. Search for and load the patron (who still has $3.00 in fines) 3. Look at the patron details section and checkout summary **Expected Results:** - The patron's outstanding fines should be **displayed** - There should be **no blocking message** (since $3.00 < $5.00 threshold) **PASS/FAIL:** _______ ### Increase Fines Above Threshold Again 1. While on the checkout page, open a new tab 2. Go to the patron's record > **Fines** tab 3. Click **Create manual invoice** - Type: "Overdue" - Amount: **5.00** - Description: "Additional test fine" 4. Click **Save** 5. Return to the checkout page tab 6. Refresh the page or re-scan patron card number **Expected Results:** - The patron now has **$8.00 in fines** (above threshold) - When attempting to check out a new item, you should see appropriate warnings - Existing checkouts should show renewal is blocked for this patron **PASS/FAIL:** _______ --- ## Test Scenario 7: Test Both Renewal Endpoints ### Test from Patron Checkouts Tab 1. Go to patron's record > **Checkouts** tab 2. Find the checked-out item 3. Click the **Renew** button in the checkouts table **Expected Results (if AllowFineOverrideRenewing = Don't allow):** - ❌ Should see error message about patron debt - ❌ Renewal should fail **PASS/FAIL:** _______ ### Enable Override and Test Again 1. Set **AllowFineOverrideRenewing** to **Allow** 2. Return to patron's **Checkouts** tab 3. Click **Renew** button again **Expected Results:** - Should see the override option - Should be able to complete renewal with override **PASS/FAIL:** _______ --- ## Edge Case Testing ### Test Scenario 8: Verify Auto-Renewal Blocking (OPAC) **Note:** This requires the patron to have the item checked out and auto-renewal enabled 1. Set **AllowFineOverrideRenewing** to **Allow** 2. Ensure patron has fines > $5.00 3. Ensure **OPACFineNoRenewalsBlockAutoRenew** is set to **Allow** 4. Log into **OPAC** as the patron 5. Go to patron's account > **Checked out items** 6. Find the item and look for renewal options **Expected Results:** - If auto-renewals are enabled, they should be blocked - Manual renewal from OPAC should also be blocked - The **override functionality is NOT available in OPAC** (staff interface only) **PASS/FAIL:** _______ --- ## Test Scenario 9: Verify Error Codes ### Test API Error Codes (Optional - Advanced Testing) If you have API access configured: 1. Set **FineNoRenewals** to **5.00** 2. Set **AllowFineOverrideRenewing** to **Don't allow** 3. Attempt renewal via REST API without override header - Should return error code: `too_much_owing` or `auto_too_much_owing` 4. Set **AllowFineOverrideRenewing** to **Allow** 5. Attempt renewal with `x-koha-override: debt_limit` header - Should succeed (201 status) **PASS/FAIL:** _______ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415

David Nind <david@davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #155 from David Nind <david@davidnind.com> ---
I attempted to test, but have Failed QA because:

1. Running the cypress tests failed: npx cypress run --spec
"t/cypress/integration/Circulation/FineNoRenewals_spec.ts"

2. If AllowFineOverrideRenewing is set to "Don't allow", on the checkouts list
on the patron's page the "Renew all" action button under the table is still
active, although it does renew any items when you click it (there are pop-up
windows "The patron has a debt of 8.00Are you sure you want to renew
checkout(s)?", click OK, "There are no items to be renewed").


Testing notes (using KTD):

1. I attempted to follow the individual; patch test plans, but gave up.

2. I followed the obsoleted test plan in comment #154, and everything seemed to
work as described (I didn't test the API things).

3. Tests:
   . prove t/db_dependent/Circulation.t
   . npx cypress run --spec
"t/cypress/integration/Circulation/FineNoRenewals_spec.ts"
   . prove t/db_dependent/api/v1/checkouts.t

4. Notes on system preference changes (for updating the documentation):
   - OPACFineNoRenewals: no longer exists
   - FineNoRenewals: replaces OPACFineNoRenewals, now located under Circulation
> Checkout policy, wording is now: 
      Only allow patrons or staff to renew items if patron has less than [5]
USD in fines (leave blank to disable).
   - OPACFineNoRenewalsBlockAutoRenew: text updated with FineNoRenewals system
preference link
   - OPACFineNoRenewalsIncludeCredits: text updated with FineNoRenewals system
preference link
   - AllowFineOverrideRenewing: new preference, text is:
      [Don't allow|Allow] staff to manually override and renew items for
patrons who have more in fines than set in the FineNoRenewals system
preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #157 from David Nind <david@davidnind.com> --- (In reply to Martin Renvoize (ashimema) from comment #156)

Thanks for testing David, I was meaning to revisit the test plan as I wasn't happy with how verbose it ended up relying on AI to generate it... but I'm glad it helped.

I've found and fixed the issue with the Cypress test (caching in the tests themselves), but whilst doing so I also found a few more edge cases in the implementation to test (namely, renewing from the checkouts list tables)

I'll be submitting a new patchset soon, rebased and with a few follow-ups.

Thanks again

+10 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188332|0 |1 is obsolete| | --- Comment #159 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188709&action=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188334|0 |1 is obsolete| | --- Comment #161 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188711&action=edit Bug 23415: Tidy template parameters block Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188336|0 |1 is obsolete| | --- Comment #163 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188713&action=edit Bug 23415: Add new syspref AllowFineOverrideRenewing This patch adds new syspref AllowFineOverrideRenewing. It allows staff to renew items for patrons whose fines are over limit set in syspref FineNoRenewals. Otherwise renewing is prevented. If renewing items is allowed staff is still required to confirm if they really want to renew items for the patron. To test: 1. Apply this patch, update database and restart all services. 2. Find patron with fines over limit set in FineNoRenewals and renewable items. => Note that renewing is prevented with message "Cannot renew, he patron has a debt of..." 3. Set syspref AllowFineOverrideRenewing as "Allow". => Note that items can now be renewed and renewing them displays confirmation pop-up. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188338|0 |1 is obsolete| | --- Comment #165 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188715&action=edit Bug 23415: (QA follow-up) Fix critical logic and security issues This commit addresses several critical issues found in QA review: 1. Fixed critical logic bug in C4::Circulation::CanBookBeRenewed - Removed incorrect check of AllowFineOverrideRenewing preference - The function now always returns 'too_much_oweing' error when patron balance exceeds FineNoRenewals limit - AllowFineOverrideRenewing should only control UI override capability, not the core renewal check 2. Added permission check in circ/renew.pl - Override is now only allowed when both override_debt parameter is set AND AllowFineOverrideRenewing preference is enabled - Prevents security issue where staff could bypass the preference by crafting POST requests 3. Fixed template to conditionally display override button - Override button in renew.tt now only shows when AllowFineOverrideRenewing is enabled - Prevents confusion when override is not permitted 4. Added comprehensive test coverage - Tests verify CanBookBeRenewed behavior with AllowFineOverrideRenewing both enabled and disabled - Confirms error is always returned regardless of preference setting - Increased test count from 116 to 120 5. Fixed minor issues - Fixed typo: "he patron" -> "the patron" in checkouts.js - Fixed typo: OPACFineNoRenewalsIncludeCredit -> OPACFineNoRenewalsIncludeCredits in test All tests pass successfully. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188708|0 |1 is obsolete| | --- Comment #167 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188717&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Sponsored-by: Koha-Suomi Oy Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188710|0 |1 is obsolete| | --- Comment #169 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188719&action=edit Bug 23415: (QA follow-up) Remove OPACFineNoRenewals from syspres.sql Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #172 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188739&action=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #174 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188741&action=edit Bug 23415: (QA follow-up) Move to Circulation::CanBookBeRenewed This moves the basic calculation for too_much_oweing out of the controller and into the class method. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #176 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188743&action=edit Bug 23415: Fix QA issues Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #178 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188745&action=edit Bug 23415: (QA follow-up) Fix spelling: oweing -> owing Standardizes error code spelling across the codebase: - Changes 'too_much_oweing' to 'too_much_owing' - Changes 'auto_too_much_oweing' to 'auto_too_much_owing' The word "owing" is the correct spelling in English. Files updated: - C4/Circulation.pm - C4/SIP/Sip/MsgType.pm - circ/renew.pl - koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt - koha-tmpl/intranet-tmpl/prog/js/checkouts.js - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt - misc/cronjobs/automatic_renewals.pl - opac/opac-reserve.pl - opac/opac-user.pl - t/db_dependent/Circulation.t All tests should pass successfully. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #180 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188747&action=edit Bug 23415: Add API tests for fine override on renewal This commit adds REST API tests to verify the x-koha-override: debt_limit functionality for renewals. Tests cover: - Renewal blocked due to excessive fines - Override fails when AllowFineOverrideRenewing is disabled - Override succeeds when AllowFineOverrideRenewing is enabled - Both /renewal and /renewals endpoints Test plan: 1. Run: prove t/db_dependent/api/v1/checkouts.t 2. All 110 tests should pass Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #182 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188749&action=edit Bug 23415: Fix FineNoRenewals to use non_issues_charges and improve template This commit addresses two issues: 1. Fixes FineNoRenewals logic to properly use non_issues_charges Both CanBookBeRenewed() and _CanBookBeAutoRenewed() were incorrectly using the patron's total balance when checking against FineNoRenewals. They now use non_issues_charges, which returns only charges that should restrict checkouts (e.g., overdues, lost items) as defined by debit types with restricts_checkouts=1. This ensures charges like rental fees don't inappropriately block renewals. 2. Improves renewal template for AllowFineOverrideRenewing - Adds special handling for auto_too_much_owing error to check AllowFineOverrideRenewing preference instead of AllowRenewalLimitOverride - Adds missing id="barcode" attribute to input field for Cypress tests - Adds .dialog CSS class to error/success divs for consistent styling - Fixes HTML structure with proper <ul><li> wrapping - Adds btn btn-default classes to override button 3. Fixes Cypress test issues - Corrects data structure access: items[0] instead of item - Uses external_id instead of barcode (API field name) - Improves form submission selector specificity - Uses REPLACE INTO for system preference setup Test plan: 1. Run t/cypress/integration/Circulation/FineNoRenewals_spec.ts 2. Verify 4 out of 5 tests pass (one remaining template comparison issue) 3. Manually test that patrons with non-issue charges (rental fees) can renew when those charges alone don't exceed FineNoRenewals 4. Verify that patrons with issue-blocking charges (overdues) are properly blocked from renewal when exceeding FineNoRenewals Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #184 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188751&action=edit Bug 23415: (follow-up) Respect OPACFineNoRenewalsIncludeCredits preference This patch fixes a regression introduced in the previous commits where we changed FineNoRenewals checking to use non_issues_charges instead of balance. While this change was correct for focusing on blocking charges, we inadvertently removed the handling of the OPACFineNoRenewalsIncludeCredits preference. The OPACFineNoRenewalsIncludeCredits preference controls whether unapplied account credits should be included when calculating if a patron exceeds the FineNoRenewals threshold. When this preference is enabled, the patron's net balance (debits minus credits) should be used instead of just their outstanding debits. This patch restores the preference handling for both: 1. Manual renewals in CanBookBeRenewed() 2. Auto renewals in _CanBookBeAutoRenewed() When OPACFineNoRenewalsIncludeCredits = 1: Use balance (all charges net of credits) When OPACFineNoRenewalsIncludeCredits = 0: Use non_issues_charges (only blocking charges, no credits) This ensures that patrons with sufficient credits can renew their items when the preference is enabled, while still maintaining the focus on non-issuing charges introduced in the previous commits. Test plan: 1. Run prove t/db_dependent/Circulation.t 2. All tests should pass, particularly the "auto_too_much_owing | OPACFineNoRenewalsBlockAutoRenew & OPACFineNoRenewalsIncludeCredits" subtest Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #186 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- These sysprefs should get their names adjusted to remove the "OPAC" so they match the new name of FineNoRenewals: OPACFineNoRenewalsIncludeCredits, OPACFineNoRenewalsBlockAutoRenew. These patches also block renewals via the web-based selfcheck when the patron has fines over FineNoRenewals, which is a change in behavior. OPACFineNoRenewals does not currently block renewals via the web-based selfcheck. This needs a syspref to allow the choice of how self-check renewals are handled so users can maintain current behavior if desired. That said, I really like these changes and will be happy to help sign it off! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #188 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189722&action=edit Bug 23415: Rename OPACFineNoRenewals OPACFineNoRenewals no longer applies just to OPAC. To avoid confusion rename it as FineNoRenewals and also rename all occurences in code. To test, confirm everything works as described in previous test plans. Also prove t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #190 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189724&action=edit Bug 23415: (QA follow-up) Move to Circulation::CanBookBeRenewed This moves the basic calculation for too_much_oweing out of the controller and into the class method. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #192 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189726&action=edit Bug 23415: Fix QA issues Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #194 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189728&action=edit Bug 23415: (QA follow-up) Fix spelling: oweing -> owing Standardizes error code spelling across the codebase: - Changes 'too_much_oweing' to 'too_much_owing' - Changes 'auto_too_much_oweing' to 'auto_too_much_owing' The word "owing" is the correct spelling in English. Files updated: - C4/Circulation.pm - C4/SIP/Sip/MsgType.pm - circ/renew.pl - koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt - koha-tmpl/intranet-tmpl/prog/js/checkouts.js - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt - misc/cronjobs/automatic_renewals.pl - opac/opac-reserve.pl - opac/opac-user.pl - t/db_dependent/Circulation.t All tests should pass successfully. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.