http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3591, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9304 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22757&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22757|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22770&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22771|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22772&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22772|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22783&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22783|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22789|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22790&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #9)

Kyle, why do you add the new field issue_id? You don't use it in your code. I mark this patch as failed QA. I did't test it but you modify the structure of the issues table without modifying the old_issues table.

The issue's table needs a primary key in order to fetch related rows via DBIx::Class. I'm not sure where you say I'm not modifying the old_issues table. I see my changes in both updastedatabase.pl and kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Kyle M Hall from comment #10)

The issue's table needs a primary key in order to fetch related rows via DBIx::Class. I'm not sure where you say I'm not modifying the old_issues table. I see my changes in both updastedatabase.pl and kohastructure.sql

Whaou, yes! I don't know what I did. Maybe I looked to an older patch (where there was no change on old_issues)... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- I am not sure to understand the test plan. I did: - A is guarantor for B - I check out 1 item to A and 1 item to B - On the staff interface, I see the relative's checkouts. - At the OPAC: log as A: there is a relative's checkouts tab but with an empty table. (debug: opac-user.pl l.358: warn Dumper \@borrowernumbers; displays [borrowernumber_B] and @relatives contains 1 object Koha::Schema::Result::Borrower) log as B: there is no relative's checkouts tab. (debug: \@borrowernumbers => [borrowernumber_A], @relatives is empty) Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #13)

Kyle, I don't understand some changes in the DB schema: "datetime_undef_if_invalid => 1" and "is_deferrable => 1" are removed, is it intentional?

That is just a product of the dbix class schema re-generator. It updates it based on the schema, so I imagine we should keep those changes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22966|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22967&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22809|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22968&action=edit Bug 9303 [QA Followup] - relative's checkouts in the opac -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #14)

I am not sure to understand the test plan. I did: - A is guarantor for B - I check out 1 item to A and 1 item to B - On the staff interface, I see the relative's checkouts. - At the OPAC: log as A: there is a relative's checkouts tab but with an empty table. (debug: opac-user.pl l.358: warn Dumper \@borrowernumbers; displays [borrowernumber_B] and @relatives contains 1 object Koha::Schema::Result::Borrower) log as B: there is no relative's checkouts tab. (debug: \@borrowernumbers => [borrowernumber_A], @relatives is empty)

Marked as Failed QA.

I was able to test this just fine in a sandbox. Try http://catalogue.test8.biblibre.com/cgi-bin/koha/opac-user.pl The users/passwords are ace, ron, and lisa. Admin is "test" as usual. I don't know how long this will stay up before someone blows it away of course. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22967|0 |1 is obsolete| | Attachment #22968|0 |1 is obsolete| | Attachment #22974|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22975&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22975|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23086&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23087|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23088&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #27 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Heather Braum <hbraum@nekls.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #28 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 23090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23090&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Signed-off-by: Heather Braum <hbraum@nekls.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #22)

Hi Kyle, I like that it is an option for the borrower to set, but could we also tie the whole feature to a system preference maybe? I am a bit worried about data privacy implications and that would make it a bit easier.

Can you expand a bit? The option is off by default, and if you opt to leave opacprivacy disabled, there's no even a way to turn it on. I guess I want to avoid YASP syndrome without absolute necessity. If you can describe to me a way that it could cause a privacy concern in its current state, I'll be more than happy to address the issue! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23525|0 |1 is obsolete| | --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23526&action=edit Bug 9303 [1/2] - relative's checkouts in the opac - Schema Updates This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Signed-off-by: Heather Braum <hbraum@nekls.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23527&action=edit Bug 9303 [2/2] - relative's checkouts in the opac Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Signed-off-by: Heather Braum <hbraum@nekls.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #35 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Kyle M Hall from comment #19)

I was able to test this just fine in a sandbox. Try http://catalogue.test8.biblibre.com/cgi-bin/koha/opac-user.pl

The users/passwords are ace, ron, and lisa. Admin is "test" as usual.

I don't know how long this will stay up before someone blows it away of course.

Sandboxes are reset all nights. Could you confirm (or not), the tab "relatives's checkouts" should have the same contain on both interfaces? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23526|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24009&action=edit Bug 9303 [1/2] - relative's checkouts in the opac - Schema Updates This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Signed-off-by: Heather Braum <hbraum@nekls.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #38)

In my database, afer update: old_issues - 1-18 issues - 19-20 - returned 19, 20 old_issues 1-20 issues empty - checked out 2 items old_issues 1-20 issues 3,4

My bad! I forget to update the auto_increment value. Silly me expected mysql to use the max(issue_id) + 1 by default ; ) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24774&action=edit Bug 9303 [2] - relative's checkouts in the opac - Database Updates -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24776&action=edit Bug 9303 [QA Followup] - Set AUTO_INCREMENT value for issues.issue_id -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I can see that you split the database update, but not sure which other changes you included - could you leave a comment about my comments? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I had asked a few more questions in comment 37 - especially about a change related to reserves. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #54 from Heather Braum <hbraum@nekls.org> --- Katrin, just to help in the explanation, since Kyle mentioned the sponsor requirement in his most recent comment back to you: I represent the organization that is sponsoring this development and since we requested the additional setting on the staff side to be able to turn this feature on and off through a borrower account, we are having to do this, because if you have the sys pref OPACPrivacy set to Don't Allow (which we have), patrons have no ability to even turn this new feature on/off in an OPAC account (if I remember correctly from our testing a few months ago). We have that sys pref turned off because it currently wrecks havoc on checkout history links for items if patrons "opt-out" of checkout history being left. In a consortia of 42 libraries with materials going everywhere, we have to have that checkout history to track down materials. Additionally, if you have a guarantor with 2 or more kids, it's much easier for this feature to be turned on from the staff side as well -- instead of having to log into each guarantee's account to turn this feature on. We thought adding the ability to turn this on and off from the staff side would actually help out patrons. I understand the privacy concerns -- we have them too -- and I'll let you all continue to sort this out, but I wanted to explain where we're coming from as the sponsor of this development. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #56 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Kyle M Hall from comment #30)

(In reply to Katrin Fischer from comment #22)

...

Hi Kyle, I like that it is an option for the borrower to set, but could we also tie the whole feature to a system preference maybe? I am a bit worried about data privacy implications and that would make it a bit easier.

Can you expand a bit? The option is off by default, and if you opt to leave opacprivacy disabled, there's no even a way to turn it on. I guess I want to avoid YASP syndrome without absolute necessity.

There is a difference between retaining circ history (and OpacPrivacy might be batter called PatronCircHistoryRetentionPolicy) and making patron's information available to other patrons. As you know, I'm not a fan of increasing the number of system preferences without due cause -- but in this case, YASP is called. Katrin can speak more to the specifics, but my understanding is that European data privacy laws are a Big Legal Deal, to the point that I feel strongly that we should give weight to concerns raised by Koha users who work in those jurisdictions. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, could you please syspref the feature in staff/intranet? Additionally I think the options in the patron account shoudl only be visible when BorrowerRelationships is not empty. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25585|0 |1 is obsolete| | --- Comment #61 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25586&action=edit Bug 9303 [QA Followup 4] - Syspref the feature for staff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, could you please rebase? Sorry it took me so long to get back to this. I fixed a conflict in the third patch, but then there is another on the last, that I can't resolve: Applying: Bug 9303 [QA Followup] - Set AUTO_INCREMENT value for issues.issue_id Applying: Bug 9303 [QA Followup 2] - Undo changes to GetReserve Applying: Bug 9303 [QA Followup 3] - Add borrowerRelationship syspref check Applying: Bug 9303 [QA Followup 4] - Syspref the feature for staff fatal: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9303 [QA Followup 4] - Syspref the feature for staff The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-9303-QA-Followup-4---Syspref-the-feature-for-s-hwC6Eh.patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #64 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27538&action=edit Bug 9303 [2] - relative's checkouts in the opac - Database Updates -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #66 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27540&action=edit Bug 9303 [QA Followup] - Set AUTO_INCREMENT value for issues.issue_id -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #68 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27542&action=edit Bug 9303 [QA Followup 3] - Add borrowerRelationship syspref check -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #70 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

There is a difference between retaining circ history (and OpacPrivacy might be batter called PatronCircHistoryRetentionPolicy) and making patron's information available to other patrons.

The new system preference (AllowStaffToSetRelativesCheckoutsVisibility) will allow to disallow staff to change the relative's checkouts sharing in OPAC. I like that, but I still see a problem with the reading history and the relative's checkout being tied together. If you allow one, you HAVE to allow the other - but both are quite different features. I think both can be on the same page, but you should be able to configure both separately. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27543|0 |1 is obsolete| | --- Comment #72 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27698&action=edit Bug 9303 [QA Followup 4] - Syspref the feature for staff Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed sequence of sysprefs in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Attaching 2 patches - one follow up with capitalization changes and an amended patch for the system preference, putting sysprefs.sql in correct alphabetic order. I am not sure I can finish this today, so here is what I have tested so far: 1) issue_id added to issues and old_issues - Checked numbering was correct, starting with old_issues and continueing in issues - Checked in an item, verified it got moved to old_issues correctly. - Checked out an item, verified next unused issue_id was assigned 2) AllowStaffToSetRelativesCheckoutsVisibility - off by default on new installations, option doesn't show on memberentry - If activated, option can be set and saves correctly - [BUG] The new setting doesn't show on the patron's detail page. The privacy setting for the reading history does. This is important as some libraries print this page, when patrons ask what is stored about them. 3) OPAC: bootstrap - relative's checkouts display after being allowed to 4) OPAC: prog - relative's checkouts display after being allowed to 5) Turning off OPAC privacy - [BUG?] When OPAC privacy is turned off, the patron is left without an option to deactivate the visibility of his/her account to others - the checkouts still show. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27537|0 |1 is obsolete| | Attachment #27538|0 |1 is obsolete| | Attachment #27539|0 |1 is obsolete| | Attachment #27540|0 |1 is obsolete| | Attachment #27541|0 |1 is obsolete| | Attachment #27542|0 |1 is obsolete| | Attachment #27698|0 |1 is obsolete| | Attachment #27699|0 |1 is obsolete| | --- Comment #76 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28153&action=edit Bug 9303 [1] - relative's checkouts in the opac - Schema Updates This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Signed-off-by: Heather Braum <hbraum@nekls.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #78 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28155&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> Signed-off-by: Heather Braum <hbraum@nekls.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #80 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28157&action=edit Bug 9303 [QA Followup 2] - Undo changes to GetReserve -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #82 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28159&action=edit Bug 9303 [QA Followup 4] - Syspref the feature for staff Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed sequence of sysprefs in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #84 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28161&action=edit Bug 9303 [QA Followup 5] - Show setting on patron details page -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #85 from Kyle M Hall <kyle@bywatersolutions.com> ---

- [BUG] The new setting doesn't show on the patron's detail page. The privacy setting for the reading history does. This is important as some libraries print this page, when patrons ask what is stored about them.

Fixed!

5) Turning off OPAC privacy - [BUG?] When OPAC privacy is turned off, the patron is left without an option to deactivate the visibility of his/her account to others - the checkouts still show.

I would *not* consider this a bug. If OPAC privacy was turned off, the patron would need to go to a librarian to have it enabled in the first place. In that case, I see no issue with the patron needing to have a librarian to disable it in the same way. Setting to "In Discussion" for now. Katrin, please set to failed or passed qa. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #87 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have just retested this and after giving it some more thought... I am still worried. My point is: As a user, I should be able to find out if my checkouts are visible to others at any time. If the library opts to disable OpacPrivacy (and I still think it's not a good thing to tie different functionalities to the same pref), I don't see anywhere in my account that my data is shared with others. Please feel free to get more opinions, eyes on this. I don't want to be unreasonable and I hope I am not. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #89 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Mickey Coalwell from comment #88)

I agree with Kyle, and share that point of view. At some point, the library simply has to be allowed/trusted to manage the library user's account in an appropriate manner.

Not all legal jurisdictions would agree, and it would not surprise me if there are some where there is an absolute right, even for juveniles, to prevents relatives from seeing checkouts. I believe that Koha should respect stronger data privacy laws when applicable, and this is one such case. I believe that a resolution is the move the OPAC page for toggling privacy_relative_checkout so that it is not dependent on the value OpacPrivacy. This change would be small and would allow general circ privacy to be orthogonal to linked patron checkout visibility. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #91 from Owen Leonard <oleonard@myacpl.org> --- Picture this scenario: 1. Husband and wife enable each other to see the other's checkouts. 2. Marriage goes bad, wife wants to check out books on divorce. 3. Library has turned off OpacPrivacy, wife can't block husband from seeing her checkouts. It's not hard to see situations like this where this bug could have very real and negative effects on people's use of the library. I agree that this is a bug and there should be a way to control it separate from OpacPrivacy. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #93 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28912&action=edit Bug 9303 [QA Followup 6] - Allow patrons to set visibility from "your personal details" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28160|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #95 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Kyle M Hall from comment #93)

Created attachment 28912 [details] [review] Bug 9303 [QA Followup 6] - Allow patrons to set visibility from "your personal details"

While this now decouples from the opac privacy, there is now no way to turn this feature on or off. It's on all the time. Was that the desired outcome? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #97 from Liz Rea <liz@catalyst.net.nz> --- Eek,yes, this should work just as the staff client does, that a guarantee only sees their own issues, and a guarantor sees all guarantee's issues. Another example is in a corporate library, the supervisor may want to see all subordinates issues, but each subordinate should have the expectation of privacy. This feature isn't only used for familial relationships. Liz -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #99 from Owen Leonard <oleonard@myacpl.org> --- In my opinion this would be a good time to get a single squashed patch to re-test and get a fresh signoff. With so many follow-ups I find it hard to track what really needs to be tested. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #101 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Liz Rea from comment #97)

Eek,yes, this should work just as the staff client does, that a guarantee only sees their own issues, and a guarantor sees all guarantee's issues.

But that's not how it works in the staff client! In the staff client, viewing a guarantee will show all guarantors checkouts. I just retested this assumption and it still holds. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29171|0 |1 is obsolete| | --- Comment #103 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29172&action=edit Bug 9303 [4] [QA Followup] * Set AUTO_INCREMENT value for issues.issue_id * Undo changes to GetReserve * Add borrowerRelationship syspref check * Syspref the feature for staff * Show setting on patron details page * Allow patrons to set visibility from "your personal details" * Add system preference to control ability to set visibility from "your personal details" * Show only guarantee's checkouts to guarantor, not visa-versa * Only show relatives' checkouts if either new system preference is enabled -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #105 from Kyle M Hall <kyle@bywatersolutions.com> --- Now that I've squashed all the followups together, would someone be able to sign off on the patch? * Test the syspref for allowing staff to set relatives' checkouts visibility * Test the ability to set relatives' checkouts visibility from opac patron details page, and the syspref that enables it. * Ensure only guarantors can see checkouts of guarantees, and not visa versa * Only show the relatives' checkouts in the OPAC if either of the new system preferences is enabled. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29172|0 |1 is obsolete| | --- Comment #107 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29215&action=edit Bug 9303 [4] [QA Followup] * Set AUTO_INCREMENT value for issues.issue_id * Undo changes to GetReserve * Add borrowerRelationship syspref check * Syspref the feature for staff * Show setting on patron details page * Allow patrons to set visibility from "your personal details" * Add system preference to control ability to set visibility from "your personal details" * Show only guarantee's checkouts to guarantor, not visa-versa * Only show relatives' checkouts if either new system preference is enabled -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #109 from Christopher Brannon <cbrannon@cdalibrary.org> --- One other small observation. It seems we keep bouncing between the terms of relatives and guarantor/guarantee. If the purpose of this feature encompasses more than parents and children, I think the term "relative" needs to be ditched and changed to "guarantor" in the labels (moremember.pl) and in all permissions (memberentry.pl, preferences.pl, opac-privacy.pl). It should also be changed out on the tabs on opac-user.pl. Just my nit-picky two cents. Christopher -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #111 from Kyle M Hall <kyle@bywatersolutions.com> ---

It is a little confusing (as a parent), to see and give permission in the OPAC to Allow relatives to view your current checkouts. What's missing is an understanding from the parent's point of view that they will NEVER be able to allow their kids to see what they have checked out.

Should this option even be available to the patron unless they are listed as someone's guarantee? Or should that be spelled out better next to the permission? It seems that the permission should rather say "Allow guarantor(parent) to view your current checkouts. And then there should be a status next to the permission and in the personal details tab that says "Your guarantor is: (GUARANTOR NAME/NOT SPECIFIED)".

I agree, the option shouldn't even be presented to a patron that isn't guaranteed by another patron. I can also add the guarantor name.

Katrin's comment in comment 73 still needs to be addressed. I do see that Call No. exists in the Checked out tab, so if it is going to be changed on the Relatives' checkouts tab, it needs to be changed in both.

I'll take care of this.

I set the AllowPatronToSetRelativesCheckoutsVisibility permission to Don't Allow and the option doesn't go away. Patrons are still able to set this option in the OPAC. This is the case in all three themes. BUSTED

Please read the details of the system preference. It only controls the option from opac-memberentry.pl, and does *not* affect it being available from opac-privacy.pl. BUSTED ;)= However, I see no reason to not to have the setting control it in both places. In fact, I think also that we should hide it from "your personal details" if OPACPrivacy is enabled. No point in having the setting in two different places! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #115 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29289&action=edit Bug 9303 [6] [QA Followup 3] - Rename prefs and field * Change AllowStaffToSetRelativesCheckoutsVisibility to AllowStaffToSetCheckoutsVisibilityForGuarantor * Change AllowPatronToSetRelativesCheckoutsVisibility to AllowPatronToSetCheckoutsVisibilityForGuarantor * Change borrowers field privacy_relative_checkouts to privacy_guarantor_checkouts -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #117 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Kyle M Hall from comment #113) As far as bootstrap goes:

* Hides the ability to set visibility of checkouts if patron has no guarantor

GOOD

* Hides the setting on "your personal details" if OPACPrivacy is enabled

GOOD

* Adds the name of the guarantor near the setting on both opac pages

GOOD

* Changes "Call No." to "Call number". There is plenty of space for the real word, so why not use it?

GOOD I failed due to results in ccsr and prog themes. I know these themes are being phased out, but as long as these themes remain it use and are accessible, I think they all need to be addressed. I am also failing because the setting shows in "my privacy" opac-privacy.pl and "my personal details" opac-memberentry.pl under ccsr and prog whether setting is on or off. I still think the tabs in all three themes should read "Guarantees' checkouts" rather than "Relatives' checkouts". Thanks for addressing the terminology issues that you have so far. :) I know you are still working on some stuff, so I am replying specifically to what you have done so far. Christopher -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #119 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle and Christopher, the prog and ccsr themes are officially deprecated now - I think best would probably be to remove the proc and ccsr files from the patch totally as we don't want to add any new features to them. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #121 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29288|0 |1 is obsolete| | Attachment #29290|0 |1 is obsolete| | Attachment #29299|0 |1 is obsolete| | --- Comment #123 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29302&action=edit Bug 9303 [5] [QA Followup 2] * Hides the ability to set visibility of checkouts if patron has no guarantor * Hides the setting on "your personal details" if OPACPrivacy is enabled * Adds the name of the guarantor near the setting on both opac pages * Changes "Call No." to "Call number". There is pleny of space for the real word, so why not use it? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #125 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29304&action=edit Bug 9303 [7] [QA Followup 4] - Undo changes to prog and ccsr themes -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #126 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm fairly sure we've got our bases cover now! Please retest. Thanks again for your testing and feedback Christopher and Katrin! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #129 from Kyle M Hall <kyle@bywatersolutions.com> ---

I still think the tabs ... should read "Guarantees' checkouts" rather than "Relatives' checkouts".

I did not change that because I think that will only cause patrons to ask "What is a Guarantee?" I think that question should be left to the QA'er.

Also, do you think the secondary checkout tab (Relatives/Gaurentees) should have a count next to it like the Checked out tab does, for consistency? Or is that another enhancement?

That would be a great addition, but definitely an enhancement outside the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #130 from Heather Braum <hbraum@nekls.org> --- Kyle, I went to sign off on this patch again using the sandboxes, and got this error that the sandbox wasn't ready: Some problems occurred applying patches from bug 9303: <h1>Something went wrong !</h1>Applying: Bug 9303 [1] - relative's checkouts in the opac - Schema Updates Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Borrower.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Borrower.pm Auto-merging Koha/Schema/Result/Issue.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Issue.pm Auto-merging Koha/Schema/Result/OldIssue.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/OldIssue.pm Failed to merge in the changes. Patch failed at 0001 Bug 9303 [1] - relative's checkouts in the opac - Schema Updates When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 9303 - relative's checkouts in the opac 28153 - Bug 9303 [1] - relative's checkouts in the opac - Schema Updates 28154 - Bug 9303 [2] - relative's checkouts in the opac - Database Updates 28155 - Bug 9303 [3] - relative's checkouts in the opac 29215 - Bug 9303 [4] [QA Followup] 29302 - Bug 9303 [5] [QA Followup 2] 29303 - Bug 9303 [6] [QA Followup 3] - Rename prefs and field 29304 - Bug 9303 [7] [QA Followup 4] - Undo changes to prog and ccsr themes -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #132 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29933&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29932|0 |1 is obsolete| | Attachment #29933|0 |1 is obsolete| | Attachment #29934|0 |1 is obsolete| | --- Comment #134 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29935&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #136 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29937&action=edit Bug 9303 [3] - relative's checkouts in the opac -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #138 from Nick Clemens <nick@quecheelibrary.org> --- This needs rebased on master I tested on sandbox and got Error 500 when trying to sign in to patron's account I tested in VM and all seems good after clearing the merge conflict in updatedatabase.pl but I don't know the procedure to submit rebased patches so I will retest and sign off ASAP when rebased -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #140 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30288&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #142 from Christopher Brannon <cbrannon@cdalibrary.org> --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 9303: <h1>Something went wrong !</h1>Applying: Bug 9303 [1] - relative's checkouts in the opac - Database Updates fatal: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9303 [1] - relative's checkouts in the opac - Database Updates When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 9303 - relative's checkouts in the opac 30287 - Bug 9303 [1] - relative's checkouts in the opac - Database Updates 30288 - Bug 9303 [2] - relative's checkouts in the opac - Schema Updates 30289 - Bug 9303 [3] - relative's checkouts in the opac Christopher -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30297|0 |1 is obsolete| | --- Comment #145 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 30298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30298&action=edit [SIGNED OFF] Bug 9303 [1] - relative's checkouts in the opac - Database Updates Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #147 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 30300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30300&action=edit [SIGNED OFF] Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #150 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32054&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #152 from Kyle M Hall <kyle@bywatersolutions.com> --- Those are not a problem. Unfortunately there is no IF EXISTS for adding and dropping indexes. You should have had those indexes, but since you didn't, it's not an issue. The situation is similar to if a db update were to attempt to insert a system preference that already exists, or create a table column that already exists. It will fail, but cause absolutely no harm. (In reply to Jonathan Druart from comment #148)

Kyle, I got these 2 errors on launching the updatedb script:

DBD::mysql::db do failed: Can't DROP 'PRIMARY'; check that column/key exists at installer/data/mysql/updatedatabase.pl line 8788. DBD::mysql::db do failed: Can't DROP 'itemnumber_idx'; check that column/key exists at installer/data/mysql/updatedatabase.pl line 8794.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9011 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #154 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33049&action=edit Bug 9303 [QA Followup] - Don't drop non-existant keys -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #155 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Working on this. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #157 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I tried to test this last minute, but I found a blocker: Changing the allowance from the 'personal details' page is not being saved. I tried using the update button and also make a full change request, nothing worked. Firefox shows a network error: NetworkError: 404 Not Found - http://localhost/cgi-bin/koha/svc/patron/show_checkouts_to_relatives If Javscript is needed to make this work, please also consider a non-Javascript fallback. The stars * mark questions or problems, questions are questions :) 1)* Code review - OK passes QA script and tests - OK ModPrivacy is removed, no other references found * Note: There is some use of the TT plugin $EncodeUTF8, which might be obsoleted if the UTF-8 patches get pushes. 2)* Database structure - OK Patch adds an issue_id PK column to issues/old_issues * Problem (normal): I think old_issues PK should not be AUTO_INCREMENT (see old_reserves) - OK Patch adds privacy_guarantor_checkouts to borrowers/deletedborrowers * Problem (trivial): Please add 'AFTER privacy' to updatedatabase to ensure the correct sequence for new and updated installations - OK 2 new system preferences are added: - AllowPatronToSetCheckoutsVisibilityForGuarantor - AllowStaffToSetCheckoutsVisibilityForGuarantor - OK updatedatabase works - OK changes with kohastructure are consistent 3) Testing the new issue_id - OK Numbering after update appears ok: old_issues: 1-23 issues: 24-26 - OK New Check-outs get the next higher number. - OK Check-ins are correctly moved to old_issues. 4) Testing changes on borrower record (staff) - OK Deleted patron is moved to deletedborrowers. - OK Editing patrons. - OK Adding patrons. 5) Testing 'Show checkouts to guarantor' (staff) * Details: The information now always shows on the patron record, if yes or no independent from the system preference settings independent from the patron being guarantor/guarantee Question: Can we think of a better way here? Maybe only show the information when (either pref is ON and the patron is a guarantee) OR (setting is set to yes)? Really not sure what is best here, sounds too complicated. * Edit form: Settings shows next to privacy Question: Maybe it would make sense to group it with the guarantor information? * Terminology: The setting is "...to guarantor" but the tab is labelled "Relative's checkouts" Question: Should we make them match? 6)* Testing options and visibility in OPAC * AllowPatronToSetCheckoutsVisibilityForGuarantor is ON OpacPrivacy is OFF Problem (blocker) changes to the display made from the personal details tab won't save. - OpacPrivacy is ON OK Setting can be changed. - AllowPatronToSetCheckoutsVisibilityForGuarantor is ON OK Setting is not displayed. Found preexisting BUGS! * Problem (also in master): Author's don't display correctly on the relative's checkouts issues list in staff: Vogelfang und Vogelberingung / by _AUTHOR_ Bub, Hans * Problem (also in master) Table layout on the 'details' tab in staff is broken. Notes: - Should we not generally display information about an existing guarantor in the patron's details in OPAC? - If both settings are OFF the user has no information in the OPAC, but we still show it on staff - not sure how to make this better. It feels a bit like this is not 'round' yet. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32053|0 |1 is obsolete| | Attachment #32054|0 |1 is obsolete| | Attachment #32055|0 |1 is obsolete| | Attachment #33049|0 |1 is obsolete| | --- Comment #158 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34629&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #160 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34631&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #162 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34633&action=edit Bug 9303 [QA Followup 2] - Fix db update, move 'show' field to guarantor area -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #164 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, have you been able to reproduce/fix the first issue with the javascript error in the OPAC? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #166 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I tried to retest the problem, but the database update gives me problems :( bumblebee:~/kohaclone (38-9303-relativecheckouts|AM 1/1) $ ./installer/data/mysql/updatedatabase.pl DBD::mysql::db do failed: Can't DROP 'PRIMARY'; check that column/key exists at ./installer/data/mysql/updatedatabase.pl line 9681. DBD::mysql::db do failed: Can't DROP 'itemnumber_idx'; check that column/key exists at ./installer/data/mysql/updatedatabase.pl line 9687. DBD::mysql::db do failed: Can't DROP 'PRIMARY'; check that column/key exists at ./installer/data/mysql/updatedatabase.pl line 9690. DBD::mysql::db do failed: Cannot drop index 'itemnumber_idx': needed in a foreign key constraint at ./installer/data/mysql/updatedatabase.pl line 9696. DBD::mysql::db do failed: Duplicate key name 'itemnumber_idx' at ./installer/data/mysql/updatedatabase.pl line 9699. Upgrade to 3.19.00.XXX done (Bug 9303 - relative's checkouts in the opac) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34629|0 |1 is obsolete| | Attachment #34630|0 |1 is obsolete| | Attachment #34631|0 |1 is obsolete| | Attachment #34632|0 |1 is obsolete| | Attachment #34633|0 |1 is obsolete| | Attachment #35519|0 |1 is obsolete| | --- Comment #169 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35520&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #171 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35522&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #173 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35524&action=edit Bug 9303 [QA Followup 2] - Fix db update, move 'show' field to guarantor area -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35526|0 |1 is obsolete| | --- Comment #176 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35527&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #178 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35529&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.