[Bug 21798] New: We need t::lib::gimme_a_biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Bug ID: 21798 Summary: We need t::lib::gimme_a_biblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|We need |We need |t::lib::gimme_a_biblio |t::lib::TestBuilder::gimme_ | |a_biblio Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82116&action=edit Bug 21798: We need t::lib::TestBuilder::gimme_a_biblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Had to leave, will provide tests tomorrow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The word gimme is not conform our naming standards imo :) And gimme_a_biblio should imo not be in TestBuilder. We can already get a biblio from TestBuilder. What you actually want is a simple MARC record in the metadata table. I think your code should follow that design and keep TestBuilder cleaner. Just my thought ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #3)
The word gimme is not conform our naming standards imo :) And gimme_a_biblio should imo not be in TestBuilder. We can already get a biblio from TestBuilder. What you actually want is a simple MARC record in the metadata table. I think your code should follow that design and keep TestBuilder cleaner. Just my thought ;)
I filed a bug to gather ideas on what to name the lib. I found it cool that we already have a $builder objecet in many test files, so $builder->gimme_a_biblio seemed reasonable. I know neither the name or the place are fine. He. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am quite ok to create such methods in TestBuilder.pm This new method will replace the multiple occurrences of: * add_biblio * create_helper_biblio * get_biblio We also will need methods to generate: * a logged in patron (with correct flag, library, userenv) * a superlibrarian patron * a MARC record * an item that can be checked out (itemtype, onloan, withdrawn, etc.) * a checkout * etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21816 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21816 [Bug 21816] [OMNIBUS] Ease the write of our tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #5)
I am quite ok to create such methods in TestBuilder.pm
This new method will replace the multiple occurrences of: * add_biblio * create_helper_biblio * get_biblio
We also will need methods to generate: * a logged in patron (with correct flag, library, userenv) * a superlibrarian patron * a MARC record * an item that can be checked out (itemtype, onloan, withdrawn, etc.) * a checkout * etc.
Or create a TestBuilder dependent module? You want an interface between the test and TestBuilder in order to shorten TestBuilder calls. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 82276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82276&action=edit Bug 21798: Unify the creation of bibliographic record in tests Using the newly created subroutine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 82277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82277&action=edit Bug 21798: Fix a wrong test Now biblioitem.itemtype has a value, GetItem should fill itype with this value if item-level_itypes it not set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 82278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82278&action=edit Bug 21798: Fix another test We should correctly generate the data we need, here we expect 2 records with title starting with "Silence in the". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 82943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82943&action=edit Bug 21798: Replace 2 more occurrences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- create_biblio ? build_biblio ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #11)
create_biblio ? build_biblio ?
Or perhaps is build_sample_biblio even better on second thought. It conveys also that it is a sample. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82943|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83136&action=edit Bug 21798: Replace 2 more occurrences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83137&action=edit Bug 21798: replace gimme_a_biblio with build_sample_biblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I can replace gimme_a_biblio with whatever you want in 5 secondes. However it will take much longer to rebase the patch given its size :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Applying: Bug 21798: Unify the creation of bibliographic record in tests fatal: sha1 information is lacking or useless (t/db_dependent/Circulation.t). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 [Bug 21971] TestBuilder::build_sample_item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82116|0 |1 is obsolete| | Attachment #82276|0 |1 is obsolete| | Attachment #82277|0 |1 is obsolete| | Attachment #82278|0 |1 is obsolete| | Attachment #83136|0 |1 is obsolete| | Attachment #83137|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83149&action=edit Bug 21798: We need t::lib::TestBuilder::gimme_a_biblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83150&action=edit Bug 21798: Unify the creation of bibliographic record in tests Using the newly created subroutine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83151&action=edit Bug 21798: Fix a wrong test Now biblioitem.itemtype has a value, GetItem should fill itype with this value if item-level_itypes it not set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83152&action=edit Bug 21798: Fix another test We should correctly generate the data we need, here we expect 2 records with title starting with "Silence in the". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83153&action=edit Bug 21798: Replace 2 more occurrences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83154&action=edit Bug 21798: replace gimme_a_biblio with build_sample_biblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 83156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83156&action=edit Bug 21798: (QA follow-up) Fix Biblios.t Global symbol "$bibnum" requires explicit package name Test plan: Run test Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This fails with me (with and without your patches): not ok 4 - Item on hold skipped, count makes sense # Failed test 'Item on hold skipped, count makes sense' # at t/db_dependent/Items/GetItemsForInventory.t line 121. # got: '11' # expected: '12' Might depend on some settings not made explicit in the script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83149|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 83157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83157&action=edit Bug 21798: We need t::lib::TestBuilder::gimme_a_biblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83150|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 83158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83158&action=edit Bug 21798: Unify the creation of bibliographic record in tests Using the newly created subroutine Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83151|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 83159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83159&action=edit Bug 21798: Fix a wrong test Now biblioitem.itemtype has a value, GetItem should fill itype with this value if item-level_itypes it not set Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83152|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 83160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83160&action=edit Bug 21798: Fix another test We should correctly generate the data we need, here we expect 2 records with title starting with "Silence in the". Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83153|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 83161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83161&action=edit Bug 21798: Replace 2 more occurrences Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83154|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 83162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83162&action=edit Bug 21798: replace gimme_a_biblio with build_sample_biblio Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83156|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 83163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83163&action=edit Bug 21798: (QA follow-up) Fix Biblios.t Global symbol "$bibnum" requires explicit package name Test plan: Run test Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Taking the liberty of passing QA in one run. Nick: Only affects test suite. Multiple rebasing avoided? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|We need |We need |t::lib::TestBuilder::gimme_ |t::lib::TestBuilder::build_ |a_biblio |sample_biblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #32)
Taking the liberty of passing QA in one run. Nick: Only affects test suite. Multiple rebasing avoided?
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |nick@bywatersolutions.com --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #32)
Taking the liberty of passing QA in one run. Nick: Only affects test suite. Multiple rebasing avoided?
It needs a simple rebase - do we not need rollback since bug 14334 - or did we just forgot to add a rollback for the schema? t/db_dependent/Serials.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83157|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83158|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83160|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83161|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83162|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83163|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84490&action=edit Bug 21798: We need t::lib::TestBuilder::gimme_a_biblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84491&action=edit Bug 21798: Unify the creation of bibliographic record in tests Using the newly created subroutine Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84492&action=edit Bug 21798: Fix a wrong test Now biblioitem.itemtype has a value, GetItem should fill itype with this value if item-level_itypes it not set Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #38 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84493&action=edit Bug 21798: Fix another test We should correctly generate the data we need, here we expect 2 records with title starting with "Silence in the". Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84494&action=edit Bug 21798: Replace 2 more occurrences Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84495&action=edit Bug 21798: replace gimme_a_biblio with build_sample_biblio Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84496&action=edit Bug 21798: (QA follow-up) Fix Biblios.t Global symbol "$bibnum" requires explicit package name Test plan: Run test Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #42 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported at this time to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 - This was required for bug 22140 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #45 from Lucas Gass <lucas@bywatersolutions.com> --- lots of troubles applying this one to 18.05.x, not backporting to 18.05.x, enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23821 [Bug 23821] Reintroduction of create_helper_biblio -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org