[Bug 10321] New: Followup on hold notes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 Bug ID: 10321 Summary: Followup on hold notes Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl CC: gmcharlt@gmail.com This is a followup report on bug 9722. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9722 Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18364&action=edit Bug 10321: Followup for hold notes Based on work for report 9722. This patch resolves a small display problem with the number of columns of the table on opac-reserve. Test plan: Enable OPACShowHoldQueueDetails and OpacShowHoldNotes. Without this patch, the hold notes end at the one-but-last column. Test this by placing a hold in opac and click on Edit notes. Apply this patch: repeat what you did, the display should be correct. Toggle the value of OPACShowHoldQueueDetails. And check again. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18365&action=edit Bug 10321: QA Followup on report 9722 As Jonathan suggested, use jQuery toggle function. Test plan: Enable OPACShowHoldNotes. Place one hold. Repeat clicking on Edit notes to show and hide notes. Place a multi hold (two biblios at the same time). Check again with both. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10343 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18364|0 |1 is obsolete| | Attachment #18365|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 18594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18594&action=edit [SIGNED-OFF] Bug 10321: Followup for hold notes Based on work for report 9722. This patch resolves a small display problem with the number of columns of the table on opac-reserve. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 --- Comment #4 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 18595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18595&action=edit [SIGNED-OFF] Bug 10321: QA Followup on report 9722 As Jonathan suggested, use jQuery toggle function. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18594|0 |1 is obsolete| | Attachment #18595|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18759&action=edit Bug 10321: Followup for hold notes Based on work for report 9722. This patch resolves a small display problem with the number of columns of the table on opac-reserve. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18760&action=edit Bug 10321: QA Followup on report 9722 As Jonathan suggested, use jQuery toggle function. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org