https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42637 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 199260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199260&action=edit Bug 42637: Check if biblio exists before checking if it is fast add This patch reorders code to make sure the biblio record exists before checking if the framework is a fast add framework. To test: 1. Go to a non existing biblio record like: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=99999999 2. See a 500 error or in ktd: Can't call method "frameworkcode" on an undefined value 3. Apply patch and restart_all 4. Repeat step 1 5. Now you get the nice error message: The record you requested does not exist (99999999). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42637 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199260|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42637 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a regression release notes| |from Bug 32773 - Have the | |ability to have more than 1 | |Fast Add framework, added | |to Koha 26.05. | | | |If you tried to access a | |record that doesn't exist, | |you got a 500 error "Can't | |call method "frameworkcode" | |on an undefined value at | |/kohadevbox/koha/catalogue/ | |detail.pl line 94". | | | |With this fix, you now get | |a message saying "The | |record you requested does | |not exist (XXXXXX)." (where | |XXXX is the biblionumber | |you were trying to access). CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42637 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42637 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199279&action=edit Bug 42637: Check if biblio exists before checking if it is fast add This patch reorders code to make sure the biblio record exists before checking if the framework is a fast add framework. To test: 1. Go to a non existing biblio record like: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=99999999 2. See a 500 error or in ktd: Can't call method "frameworkcode" on an undefined value 3. Apply patch and restart_all 4. Repeat step 1 5. Now you get the nice error message: The record you requested does not exist (99999999). Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42637 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.