[Bug 27526] New: Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Bug ID: 27526 Summary: Remove Mod/AddItemFromMarc from additem.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org There is a lot of code in additem.pl that is transforming an item representation from/to HTML, XML, MARC::Record, Koha::Item We really don't need all this overhead, having the Koha::Item's attributes would be enough to update/create the item into the DB (it's no longer in the biblio MARC::Record!) Of course other places where we add/update items are valid as well: acquisition, batch item modification, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115679&action=edit Bug 27526: Remove ModItemFromMarc from additem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115680&action=edit Bug 27526: Remove AddItemFromMarc from additem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion CC| |dcook@prosentient.com.au, | |julian.maurice@biblibre.com | |, | |kyle@bywatersolutions.com, | |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com, | |tomascohen@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Those two patches are a first (POC) step. Lot of code from the controller and template must be adjusted and removed. I would like to know how people are feeling about this move and if some of you can commit to test and review the patches if I am continuing the rewrite. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- I would happily test these, this code is confusing and due for an overhaul -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Count me in for testing/review too.. it would be a lovely area to clean up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I expected to see Koha::Item->new_from_marc({ }) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #6)
I expected to see Koha::Item->new_from_marc({ })
No, the idea is to remove MARC::Record completely when dealing with items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #7)
(In reply to Tomás Cohen Arazi from comment #6)
I expected to see Koha::Item->new_from_marc({ })
No, the idea is to remove MARC::Record completely when dealing with items.
Yes. When I read the patches, I noticed you were tackling the cataloging form. But there is also import. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #3)
Those two patches are a first (POC) step. Lot of code from the controller and template must be adjusted and removed.
Do you mean that you're planning to move the new replacement code from additem.pl and put it in a module? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27545 [Bug 27545] NewItemsDefaultLocation is only used from additem.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116006&action=edit Bug 27526: Adjust code to use Koha::Items Not that we removed all the transformations of the item and are using Koha::Item from DB to TT (and the other way around), some code needs adjustments. - Retrieve host items can be simplified (see Koha::Biblio->host_items) - Some TT variables have been renamed for better understanding - Koha::Item->columns_to_str return a hashref with the representation string of the columns. A date will return the value how it must be displayed, using output_pref. A subfield linked with a AV will be replaced with the AV's description. - LastCreatedItem cookie serializes and stores Koha::Item->unblessed, no longer the MARC::Record Change in behaviour: If a subfield is linked with a AV cat and the value is not a valid AV, before this patch the column was displayed with an empty value. Now the column is hidden, it's considered empty. In the sample data it happens with itemlost (0) and withdrawn (0). Test plan: 1. Test the Prefill a. Turn PrefillItem on b. Fill in SubfieldsToUseWhenPrefill with some subfield codes c. Catalogue an item, save => The values from subfields listed in SubfieldsToUseWhenPrefill must be kept 2. more subfields a. Add subfields that are not linked with a koha field (k is available) b. Create an item and fill in all the values c. Confirm that non linked subfields are stored and displayed correctly d. Try with a "more subfield" that is linked with an authorised value category 3. Test barcode values 4. Test the different "Add" buttons at the bottom of the form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8976 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 [Bug 8976] Default sequence of subfields in cataloguing editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This patch is not ready, at least tests are missing. But I really would like to get early feedbacks on it to know if I continue working on it. To understand a bit more the method and how I wrote this patch, I think it may be easier to read the step by step approach I've pushed remotely: https://gitlab.com/joubu/Koha/-/commits/bug_27526_dirty If we all agree it's the way to go, we could then extend the code (and so make it even more flexible) to other areas. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + if ( $c eq 'more_subfields_xml' ) { + my @more_subfields_xml = $input->multi_param("items.more_subfields_xml"); + my @unlinked_item_subfields; + for my $subfield ( @more_subfields_xml ) { + my $v = $input->param('items.more_subfields_xml_' . $subfield); + push @unlinked_item_subfields, $subfield, $v; + } + if ( @unlinked_item_subfields ) { + my $marc = MARC::Record->new(); + # use of tag 999 is arbitrary, and doesn't need to match the item tag + # used in the framework + $marc->append_fields(MARC::Field->new('999', ' ', ' ', @unlinked_item_subfields)); + $marc->encoding("UTF-8"); + $item->more_subfields_xml($marc->as_xml("USMARC")); + next; + } + $item->more_subfields_xml(undef); + } else { + my $v = $input->param("items.".$c); + next unless defined $v; + $item->$c($v); + } Is this the time to get rid of the MARC stuff for items completely? Do we really need more_subfields_xml or could we resolve otherwise? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #7)
(In reply to Tomás Cohen Arazi from comment #6)
I expected to see Koha::Item->new_from_marc({ })
No, the idea is to remove MARC::Record completely when dealing with items.
^^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Well, that's not what I meant. *almost* completely :D But yes, we could move them to a new DB table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #12)
+ if ( $c eq 'more_subfields_xml' ) { + my @more_subfields_xml = $input->multi_param("items.more_subfields_xml"); + my @unlinked_item_subfields; + for my $subfield ( @more_subfields_xml ) { + my $v = $input->param('items.more_subfields_xml_' . $subfield); + push @unlinked_item_subfields, $subfield, $v; + } + if ( @unlinked_item_subfields ) { + my $marc = MARC::Record->new(); + # use of tag 999 is arbitrary, and doesn't need to match the item tag + # used in the framework + $marc->append_fields(MARC::Field->new('999', ' ', ' ', @unlinked_item_subfields)); + $marc->encoding("UTF-8"); + $item->more_subfields_xml($marc->as_xml("USMARC")); + next; + } + $item->more_subfields_xml(undef); + } else { + my $v = $input->param("items.".$c); + next unless defined $v; + $item->$c($v); + }
Is this the time to get rid of the MARC stuff for items completely? Do we really need more_subfields_xml or could we resolve otherwise?
+1, please file that bug! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Can I get some testing on this please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115679|0 |1 is obsolete| | Attachment #115680|0 |1 is obsolete| | Attachment #116006|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117806&action=edit Bug 27526: Remove ModItemFromMarc from additem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117807&action=edit Bug 27526: Remove AddItemFromMarc from additem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117808&action=edit Bug 27526: Adjust code to use Koha::Items Not that we removed all the transformations of the item and are using Koha::Item from DB to TT (and the other way around), some code needs adjustments. - Retrieve host items can be simplified (see Koha::Biblio->host_items) - Some TT variables have been renamed for better understanding - Koha::Item->columns_to_str return a hashref with the representation string of the columns. A date will return the value how it must be displayed, using output_pref. A subfield linked with a AV will be replaced with the AV's description. - LastCreatedItem cookie serializes and stores Koha::Item->unblessed, no longer the MARC::Record Change in behaviour: If a subfield is linked with a AV cat and the value is not a valid AV, before this patch the column was displayed with an empty value. Now the column is hidden, it's considered empty. In the sample data it happens with itemlost (0) and withdrawn (0). Test plan: 1. Test the Prefill a. Turn PrefillItem on b. Fill in SubfieldsToUseWhenPrefill with some subfield codes c. Catalogue an item, save => The values from subfields listed in SubfieldsToUseWhenPrefill must be kept 2. more subfields a. Add subfields that are not linked with a koha field (k is available) b. Create an item and fill in all the values c. Confirm that non linked subfields are stored and displayed correctly d. Try with a "more subfield" that is linked with an authorised value category 3. Test barcode values 4. Test the different "Add" buttons at the bottom of the form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've somewhat lost track of this one I'm afraid.. I'll try to take a look next week.. do you think we're still aiming for 21.05 for it Jonathan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #20)
I've somewhat lost track of this one I'm afraid.. I'll try to take a look next week.. do you think we're still aiming for 21.05 for it Jonathan?
Yes, I am still willing to push it for 21.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #21)
(In reply to Martin Renvoize from comment #20)
I've somewhat lost track of this one I'm afraid.. I'll try to take a look next week.. do you think we're still aiming for 21.05 for it Jonathan?
Yes, I am still willing to push it for 21.05.
I'm playing with this at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
c. Confirm that non linked subfields are stored and displayed correctly
- item edition list - MARC details - OPAC marc view Is that it?
d. Try with a "more subfield" that is linked with an authorised value category
what is a "more subfield"?
3. Test barcode values
just put a barcode and using it afterwards? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #23)
c. Confirm that non linked subfields are stored and displayed correctly
- item edition list - MARC details - OPAC marc view
Is that it?
This patch set is affecting the add item form only.
d. Try with a "more subfield" that is linked with an authorised value category
what is a "more subfield"?
A subfield that is not mapped with a DB column (and so stored in items.more_subfields_xml)
3. Test barcode values
just put a barcode and using it afterwards?
barcode generated by a plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27837 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #25 from Victor Grousset/tuxayo <victor@tuxayo.net> --- error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Test note: Here is how to generate barcodes by a plugin:
952$p mapped to barcode.pl plugin in frameworks C4::Context->preference("autoBarcode"); set autobarcode and then clicking in the field fro new item should generate
thanks kidclamp and cait :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117806|0 |1 is obsolete| | Attachment #117807|0 |1 is obsolete| | Attachment #117808|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121589&action=edit Bug 27526: Remove ModItemFromMarc from additem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121590&action=edit Bug 27526: Remove AddItemFromMarc from additem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121591&action=edit Bug 27526: Adjust code to use Koha::Items Not that we removed all the transformations of the item and are using Koha::Item from DB to TT (and the other way around), some code needs adjustments. - Retrieve host items can be simplified (see Koha::Biblio->host_items) - Some TT variables have been renamed for better understanding - Koha::Item->columns_to_str return a hashref with the representation string of the columns. A date will return the value how it must be displayed, using output_pref. A subfield linked with a AV will be replaced with the AV's description. - LastCreatedItem cookie serializes and stores Koha::Item->unblessed, no longer the MARC::Record Change in behaviour: If a subfield is linked with a AV cat and the value is not a valid AV, before this patch the column was displayed with an empty value. Now the column is hidden, it's considered empty. In the sample data it happens with itemlost (0) and withdrawn (0). Test plan: 1. Test the Prefill a. Turn PrefillItem on b. Fill in SubfieldsToUseWhenPrefill with some subfield codes c. Catalogue an item, save => The values from subfields listed in SubfieldsToUseWhenPrefill must be kept 2. more subfields a. Add subfields that are not linked with a koha field (k is available) b. Create an item and fill in all the values c. Confirm that non linked subfields are stored and displayed correctly d. Try with a "more subfield" that is linked with an authorised value category 3. Test barcode values 4. Test the different "Add" buttons at the bottom of the form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL pod coverage POD is missing for 'host_items' FAIL pod coverage POD is missing for 'columns_to_str' FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt FAIL filters missing_filter at line 174 ( <input type="hidden" id="[%- mv.id | html -%]" name="[% kohafield %]" class="input_marceditor" size="50" maxlength="[%- mv.maxlength | html -%]" value="[%- mv.value | html -%]">) missing_filter at line 177 ( <select name="[% kohafield %]" id="[%- mv.id | html -%]" class="input_marceditor" readonly="readonly" disabled="disabled">) missing_filter at line 179 ( <select name="[% kohafield %]" id="[%- mv.id | html -%]" class="input_marceditor" data-category="[% mv.category | html %]">) missing_filter at line 195 ( <input type="text" id="[%- mv.id | html -%]" name="[% kohafield %]" class="input_marceditor" size="50" maxlength="[%- mv.maxlength | html -%]" value="[%- mv.value | html -%]" readonly="readonly" />) missing_filter at line 197 ( <input type="text" id="[%- mv.id | html -%]" name="[% kohafield %]" class="input_marceditor" size="50" maxlength="[%- mv.maxlength | html -%]" value="[%- mv.value | html -%]" />) missing_filter at line 203 ( <input type="text" id="[%- mv.id | html -%]" name="[% kohafield %]" class="input_marceditor" size="50" maxlength="[%- mv.maxlength | html -%]" value="[%- mv.value | html -%]" readonly="readonly" />) missing_filter at line 205 ( <input type="text" id="[%- mv.id | html -%]" name="[% kohafield %]" class="input_marceditor" size="50" maxlength="[%- mv.maxlength | html -%]" value="[%- mv.value | html -%]" />) missing_filter at line 215 ( <input type="text" id="[%- mv.id | html -%]" name="[% kohafield %]" class="input_marceditor" size="50" maxlength="[%- mv.maxlength | html -%]" value="[%- mv.value | html -%]" readonly="readonly" />) missing_filter at line 217 ( <input type="text" id="[%- mv.id | html -%]" name="[% kohafield %]" class="input_marceditor" size="50" maxlength="[%- mv.maxlength | html -%]" value="[%- mv.value | html -%]" />) missing_filter at line 221 ( <textarea id="[%- mv.id | html -%]" name="[% kohafield %]" class="input_marceditor" rows="5" cols="64" readonly="readonly" >[% mv.value | html %]</textarea>) missing_filter at line 223 ( <textarea id="[%- mv.id | html -%]" name="[% kohafield %]" class="input_marceditor" rows="5" cols="64" >[% mv.value | html %]</textarea>) missing_filter at line 228 ( <input type="hidden" name="items.more_subfields_xml" value="[% subfield.subfield %]" />) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121591|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122288&action=edit Bug 27526: Adjust code to use Koha::Items Not that we removed all the transformations of the item and are using Koha::Item from DB to TT (and the other way around), some code needs adjustments. - Retrieve host items can be simplified (see Koha::Biblio->host_items) - Some TT variables have been renamed for better understanding - Koha::Item->columns_to_str return a hashref with the representation string of the columns. A date will return the value how it must be displayed, using output_pref. A subfield linked with a AV will be replaced with the AV's description. - LastCreatedItem cookie serializes and stores Koha::Item->unblessed, no longer the MARC::Record Change in behaviour: If a subfield is linked with a AV cat and the value is not a valid AV, before this patch the column was displayed with an empty value. Now the column is hidden, it's considered empty. In the sample data it happens with itemlost (0) and withdrawn (0). Test plan: 1. Test the Prefill a. Turn PrefillItem on b. Fill in SubfieldsToUseWhenPrefill with some subfield codes c. Catalogue an item, save => The values from subfields listed in SubfieldsToUseWhenPrefill must be kept 2. more subfields a. Add subfields that are not linked with a koha field (k is available) b. Create an item and fill in all the values c. Confirm that non linked subfields are stored and displayed correctly d. Try with a "more subfield" that is linked with an authorised value category 3. Test barcode values 4. Test the different "Add" buttons at the bottom of the form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #30) Added the missing html filters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Found something very strange - master - no need to touch any setting - add an item and fill "g - Cost, normal purchase price" with a number - save - apply patches & restart services - refresh the add item page (additem.pl?biblionumber=295) (a refresh without resending the POST request) Template process failed: undef error - The given date (503.00) does not match the date format (iso) - got back to master & restart services - refresh the add item page (additem.pl?biblionumber=295) - it works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122318&action=edit Bug 27526: Improve grep for date fields 'replacementpricedate' should not catch 'price' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #33)
Found something very strange
Yes, silly error in the code. Should be fixed now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122288|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122318|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121589|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121590|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 122655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122655&action=edit Bug 27526: Remove ModItemFromMarc from additem Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 122656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122656&action=edit Bug 27526: Remove AddItemFromMarc from additem Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #38 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 122657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122657&action=edit Bug 27526: Adjust code to use Koha::Items Not that we removed all the transformations of the item and are using Koha::Item from DB to TT (and the other way around), some code needs adjustments. - Retrieve host items can be simplified (see Koha::Biblio->host_items) - Some TT variables have been renamed for better understanding - Koha::Item->columns_to_str return a hashref with the representation string of the columns. A date will return the value how it must be displayed, using output_pref. A subfield linked with a AV will be replaced with the AV's description. - LastCreatedItem cookie serializes and stores Koha::Item->unblessed, no longer the MARC::Record Change in behaviour: If a subfield is linked with a AV cat and the value is not a valid AV, before this patch the column was displayed with an empty value. Now the column is hidden, it's considered empty. In the sample data it happens with itemlost (0) and withdrawn (0). Test plan: 1. Test the Prefill a. Turn PrefillItem on b. Fill in SubfieldsToUseWhenPrefill with some subfield codes c. Catalogue an item, save => The values from subfields listed in SubfieldsToUseWhenPrefill must be kept 2. more subfields a. Add subfields that are not linked with a koha field (k is available) b. Create an item and fill in all the values c. Confirm that non linked subfields are stored and displayed correctly d. Try with a "more subfield" that is linked with an authorised value category 3. Test barcode values 4. Test the different "Add" buttons at the bottom of the form Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 122658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122658&action=edit Bug 27526: Improve grep for date fields 'replacementpricedate' should not catch 'price' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Needed a rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I tested with this results: - I added an extended attribute R, repeatable. Saved with values 3 and 4 => FAIL: the MARC ended up with 3 | 3 - Marked another attribute as 'Important' (yellow message in the form, correct) => FAIL: Even if I choose a value it keeps saying I didn't fill it. - Marked an attribute as 'Mandatory' => FAIL: It keeps saying I need to fill them - AV-linked (including branches, csource, etc) field work correctly as before So it looks good overall, only this small glitches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28687 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28687 [Bug 28687] Add Koha::Item::Attribute(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122676&action=edit Bug 27526: Fix repeatable more subfields We retrieved always the first value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122677&action=edit Bug 27526: Fix mandatory and important checks The input names have been changed from "field_value" to $kohafield. Modifying this could have an impact in other area, where CheckMandatorySubfields and CheckImportantSubfields are called. Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones. Note that the other ones are actually broken (!) Also note that there is a typo in the error message alertString2 += "\n- " + "%s " + MSG_MANDATORY_FIELDS_EMPTY.format(total_errors); There is an extra %s -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28689, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28690 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #43)
Note that the other ones are actually broken (!)
Opened bug 28690.
Also note that there is a typo in the error message alertString2 += "\n- " + "%s " + MSG_MANDATORY_FIELDS_EMPTY.format(total_errors); There is an extra %s
Opened bug 28689. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122676|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122677|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #45 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 122681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122681&action=edit Bug 27526: Fix repeatable more subfields We retrieved always the first value. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #46 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 122682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122682&action=edit Bug 27526: Fix mandatory and important checks The input names have been changed from "field_value" to $kohafield. Modifying this could have an impact in other area, where CheckMandatorySubfields and CheckImportantSubfields are called. Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones. Note that the other ones are actually broken (!) Also note that there is a typo in the error message alertString2 += "\n- " + "%s " + MSG_MANDATORY_FIELDS_EMPTY.format(total_errors); There is an extra %s Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #47 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Nice work! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #48 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Hi :) Issue found. master enable prefill on e f g h add an item, next item e f g h are prefilled apply patch, restart go back to edit item page (not prefilled) add an item, next item isn't prefilled so it's confirmed prefill doesn't work now something less on topic that I really don't understand: rollback code to master restart all service go back to edit item page Can't call method "field" on unblessed reference at /kohadevbox/koha/cataloguing/additem.pl line 978 How can this happen? There isn't a DB upgrade so rollbacking the code and restarting should be enough, right? Anyway, resetting all data allowed to retry on master and confirm that it works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #49 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #48)
now something less on topic that I really don't understand: rollback code to master restart all service go back to edit item page Can't call method "field" on unblessed reference at /kohadevbox/koha/cataloguing/additem.pl line 978
How can this happen? There isn't a DB upgrade so rollbacking the code and restarting should be enough, right?
Can you try cleaning the cookies? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #50 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Tomás Cohen Arazi from comment #49)
Can you try cleaning the cookies?
Indeed it was that, thanks! (tried in private browsing) Mystery solved about this secondary testing issue. That's scary that something like that can happen and persist even after a logout. (but a server side reset solves it o_O ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28694 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #51 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122694&action=edit Bug 27526: Fix PrefillItem We are basically adding: $current_item = $item->unblessed; Other changes are for readability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #52 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122695&action=edit Bug 27526: Fix Add & duplicate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #53 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122696&action=edit Bug 27526: Fix Add multiple copies This has been moved to Koha::Item->store by bug 27545. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #54 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Good catch Victor! I found other issues as well. It would be great to have somebody familiar with the different options (auto barcode, duplicate copies, prefillitem, etc.) test those follow-ups. Nick or Andrew maybe? Unless you are, Victor! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #55 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Jonathan Druart from comment #54)
Unless you are, Victor!
Nope, I'm learning everything there! Really, for main 4 things of the test plan I had to ask or dig a tutorial for each one ^^" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28694 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 [Bug 28694] Check alert in cataloguing should be a modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122655|0 |1 is obsolete| | --- Comment #56 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122946&action=edit Bug 27526: Remove ModItemFromMarc from additem Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122656|0 |1 is obsolete| | --- Comment #57 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122947&action=edit Bug 27526: Remove AddItemFromMarc from additem Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122657|0 |1 is obsolete| | --- Comment #58 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122948&action=edit Bug 27526: Adjust code to use Koha::Items Not that we removed all the transformations of the item and are using Koha::Item from DB to TT (and the other way around), some code needs adjustments. - Retrieve host items can be simplified (see Koha::Biblio->host_items) - Some TT variables have been renamed for better understanding - Koha::Item->columns_to_str return a hashref with the representation string of the columns. A date will return the value how it must be displayed, using output_pref. A subfield linked with a AV will be replaced with the AV's description. - LastCreatedItem cookie serializes and stores Koha::Item->unblessed, no longer the MARC::Record Change in behaviour: If a subfield is linked with a AV cat and the value is not a valid AV, before this patch the column was displayed with an empty value. Now the column is hidden, it's considered empty. In the sample data it happens with itemlost (0) and withdrawn (0). Test plan: 1. Test the Prefill a. Turn PrefillItem on b. Fill in SubfieldsToUseWhenPrefill with some subfield codes c. Catalogue an item, save => The values from subfields listed in SubfieldsToUseWhenPrefill must be kept 2. more subfields a. Add subfields that are not linked with a koha field (k is available) b. Create an item and fill in all the values c. Confirm that non linked subfields are stored and displayed correctly d. Try with a "more subfield" that is linked with an authorised value category 3. Test barcode values 4. Test the different "Add" buttons at the bottom of the form Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122658|0 |1 is obsolete| | --- Comment #59 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122949&action=edit Bug 27526: Improve grep for date fields 'replacementpricedate' should not catch 'price' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122681|0 |1 is obsolete| | --- Comment #60 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122950&action=edit Bug 27526: Fix repeatable more subfields We retrieved always the first value. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122682|0 |1 is obsolete| | --- Comment #61 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122951&action=edit Bug 27526: Fix mandatory and important checks The input names have been changed from "field_value" to $kohafield. Modifying this could have an impact in other area, where CheckMandatorySubfields and CheckImportantSubfields are called. Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones. Note that the other ones are actually broken (!) Also note that there is a typo in the error message alertString2 += "\n- " + "%s " + MSG_MANDATORY_FIELDS_EMPTY.format(total_errors); There is an extra %s Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122694|0 |1 is obsolete| | --- Comment #62 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122952&action=edit Bug 27526: Fix PrefillItem We are basically adding: $current_item = $item->unblessed; Other changes are for readability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122695|0 |1 is obsolete| | --- Comment #63 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122953&action=edit Bug 27526: Fix Add & duplicate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122696|0 |1 is obsolete| | --- Comment #64 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122954&action=edit Bug 27526: Fix Add multiple copies This has been moved to Koha::Item->store by bug 27545. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #65 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patches have been rebased (easy conflicts with bug 17600). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #66 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122957&action=edit Bug 27526: Fix incorrect condition The barcode was always prefilled! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122957|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122958&action=edit Bug 27526: Fix incorrect condition The barcode was always prefilled! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #68 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122959&action=edit Bug 27526: Fix empty string vs undef Empty strings must be removed, not inserted as empty strings in DB. The relevant code is in TransformHtmlToXml, $skip variable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #69 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Note that after this patchset the "Total Checkouts" column displays "0" instead of an empty string. It is a bugfix IMO: items.issues has 0 in DB (before and after this patchset). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #70 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122974&action=edit Bug 27526: Remove uneeded call to TransformMarcToKoha And also clean some imports. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122974|0 |1 is obsolete| | --- Comment #71 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123006&action=edit Bug 27526: Remove uneeded call to TransformMarcToKoha And also clean some imports. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #72 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123007&action=edit Bug 27526: Fix encoding issue on subfield If you have a "é" subfield it should work! Note that VARCHAR(1) for binary means 1-byte (from MySQL doc): "For example, if the default character set is utf8mb4, CHAR(5) BINARY is treated as CHAR(5) CHARACTER SET utf8mb4 COLLATE utf8mb4_bin. This differs from BINARY(5), which stores 5-byte binary strings that have the binary character set and collation." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #73 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123110&action=edit Bug 27526: Fix cn_source display For an unknown reason C4::Biblio::GetAuthorisedValueDesc (that we are calling from Koha::Item->columns_to_str) does not deal with class sources. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi --- Comment #74 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- This should be need sign-off? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #75 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Joonas Kylmälä from comment #74)
This should be need sign-off?
I am building a lot of things on top of this and fixing bugs when I find them. A strong QA review would be good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28769 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28769 [Bug 28769] tabloop not used in cataloguing plugins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 [Bug 26080] Use the task queue for the batch delete records tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26080 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 [Bug 26080] Use the task queue for the batch delete records tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 [Bug 28445] Use the task queue for the batch delete and update items tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28783 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #76 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- - Koha::Biblio::host_items and Koha::Item::columns_to_str need POD and tests. The additem.pl doesn't load because "The method Koha::Biblio->host_items is not covered by tests!" so testing cannot be done currently. - I noticed a lot of bug fixes outside the scope of just removing Mod/AddItemFromMarc would be nice if those could be splitted to separate patches that don't even depend on this, also same goes with other patches having multiple changes in them that are not intertwined. I would be hesitant to merge these without detailed explanations for every individual change but not blocking in case other QA team member wants to approve these. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #77 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Joonas Kylmälä from comment #76)
- Koha::Biblio::host_items and Koha::Item::columns_to_str need POD and tests. The additem.pl doesn't load because "The method Koha::Biblio->host_items is not covered by tests!" so testing cannot be done currently.
It's working for me, looks like you forgot to restart plack. Koha/Biblio.pm:sub host_items { cataloguing/additem.pl:for my $item ( $biblio->items->as_list, $biblio->host_items->as_list ) {
- I noticed a lot of bug fixes outside the scope of just removing Mod/AddItemFromMarc would be nice if those could be splitted to separate patches that don't even depend on this, also same goes with other patches having multiple changes in them that are not intertwined. I would be hesitant to merge these without detailed explanations for every individual change but not blocking in case other QA team member wants to approve these.
I don't really see how I could have split more, the patches have quite isolated changes. I am even suggesting you to review the before/after additem side-by-side. That will be easier to catch potential issues. That being said, I have been working several days on top of those patches and I am pretty confident in them. I am only expected very hard to catch regressions, that are, most of the time, never caught during SO or QA step. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #78 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123329&action=edit Bug 27526: Add missing POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #79 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I will provide the missing tests next week. Thanks for the reminder! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #80 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123372&action=edit Bug 27526: Add tests for columns_to_str and host_items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #81 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #79)
I will provide the missing tests next week. Thanks for the reminder!
Done! And I found a bug, so tests++ :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123372|0 |1 is obsolete| | --- Comment #82 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123415&action=edit Bug 27526: Add tests for columns_to_str and host_items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #83 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- txn_begin was missing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28832 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122946|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123757&action=edit Bug 27526: Remove ModItemFromMarc from additem Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122947|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123758&action=edit Bug 27526: Remove AddItemFromMarc from additem Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122948|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123759&action=edit Bug 27526: Adjust code to use Koha::Items Not that we removed all the transformations of the item and are using Koha::Item from DB to TT (and the other way around), some code needs adjustments. - Retrieve host items can be simplified (see Koha::Biblio->host_items) - Some TT variables have been renamed for better understanding - Koha::Item->columns_to_str return a hashref with the representation string of the columns. A date will return the value how it must be displayed, using output_pref. A subfield linked with a AV will be replaced with the AV's description. - LastCreatedItem cookie serializes and stores Koha::Item->unblessed, no longer the MARC::Record Change in behaviour: If a subfield is linked with a AV cat and the value is not a valid AV, before this patch the column was displayed with an empty value. Now the column is hidden, it's considered empty. In the sample data it happens with itemlost (0) and withdrawn (0). Test plan: 1. Test the Prefill a. Turn PrefillItem on b. Fill in SubfieldsToUseWhenPrefill with some subfield codes c. Catalogue an item, save => The values from subfields listed in SubfieldsToUseWhenPrefill must be kept 2. more subfields a. Add subfields that are not linked with a koha field (k is available) b. Create an item and fill in all the values c. Confirm that non linked subfields are stored and displayed correctly d. Try with a "more subfield" that is linked with an authorised value category 3. Test barcode values 4. Test the different "Add" buttons at the bottom of the form Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122949|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123760&action=edit Bug 27526: Improve grep for date fields 'replacementpricedate' should not catch 'price' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122950|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123761&action=edit Bug 27526: Fix repeatable more subfields We retrieved always the first value. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122951|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123762&action=edit Bug 27526: Fix mandatory and important checks The input names have been changed from "field_value" to $kohafield. Modifying this could have an impact in other area, where CheckMandatorySubfields and CheckImportantSubfields are called. Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones. Note that the other ones are actually broken (!) Also note that there is a typo in the error message alertString2 += "\n- " + "%s " + MSG_MANDATORY_FIELDS_EMPTY.format(total_errors); There is an extra %s Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122952|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123763&action=edit Bug 27526: Fix PrefillItem We are basically adding: $current_item = $item->unblessed; Other changes are for readability Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122953|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123764&action=edit Bug 27526: Fix Add & duplicate Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122954|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123765&action=edit Bug 27526: Fix Add multiple copies This has been moved to Koha::Item->store by bug 27545. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122958|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123766&action=edit Bug 27526: Fix incorrect condition The barcode was always prefilled! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122959|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123767&action=edit Bug 27526: Fix empty string vs undef Empty strings must be removed, not inserted as empty strings in DB. The relevant code is in TransformHtmlToXml, $skip variable. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123006|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123768&action=edit Bug 27526: Remove uneeded call to TransformMarcToKoha And also clean some imports. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123007|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123769&action=edit Bug 27526: Fix encoding issue on subfield If you have a "é" subfield it should work! Note that VARCHAR(1) for binary means 1-byte (from MySQL doc): "For example, if the default character set is utf8mb4, CHAR(5) BINARY is treated as CHAR(5) CHARACTER SET utf8mb4 COLLATE utf8mb4_bin. This differs from BINARY(5), which stores 5-byte binary strings that have the binary character set and collation." Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123110|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123770&action=edit Bug 27526: Fix cn_source display For an unknown reason C4::Biblio::GetAuthorisedValueDesc (that we are calling from Koha::Item->columns_to_str) does not deal with class sources. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123329|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123771&action=edit Bug 27526: Add missing POD Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123415|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123772&action=edit Bug 27526: Add tests for columns_to_str and host_items Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #100 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I tested pretty thoroughly but will admit this isn't an area I'm most familiar with. Added my SO line to all the patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123772|0 |1 is obsolete| | --- Comment #101 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125069&action=edit Bug 27526: Add tests for columns_to_str and host_items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125069|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123757|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123758|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123764|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123765|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123766|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123767|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123768|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123769|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123770|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123771|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #102 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125605&action=edit Bug 27526: Remove ModItemFromMarc from additem Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #103 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125606&action=edit Bug 27526: Remove AddItemFromMarc from additem Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #104 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125607&action=edit Bug 27526: Adjust code to use Koha::Items Not that we removed all the transformations of the item and are using Koha::Item from DB to TT (and the other way around), some code needs adjustments. - Retrieve host items can be simplified (see Koha::Biblio->host_items) - Some TT variables have been renamed for better understanding - Koha::Item->columns_to_str return a hashref with the representation string of the columns. A date will return the value how it must be displayed, using output_pref. A subfield linked with a AV will be replaced with the AV's description. - LastCreatedItem cookie serializes and stores Koha::Item->unblessed, no longer the MARC::Record Change in behaviour: If a subfield is linked with a AV cat and the value is not a valid AV, before this patch the column was displayed with an empty value. Now the column is hidden, it's considered empty. In the sample data it happens with itemlost (0) and withdrawn (0). Test plan: 1. Test the Prefill a. Turn PrefillItem on b. Fill in SubfieldsToUseWhenPrefill with some subfield codes c. Catalogue an item, save => The values from subfields listed in SubfieldsToUseWhenPrefill must be kept 2. more subfields a. Add subfields that are not linked with a koha field (k is available) b. Create an item and fill in all the values c. Confirm that non linked subfields are stored and displayed correctly d. Try with a "more subfield" that is linked with an authorised value category 3. Test barcode values 4. Test the different "Add" buttons at the bottom of the form Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #105 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125608&action=edit Bug 27526: Improve grep for date fields 'replacementpricedate' should not catch 'price' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #106 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125609&action=edit Bug 27526: Fix repeatable more subfields We retrieved always the first value. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #107 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125610&action=edit Bug 27526: Fix mandatory and important checks The input names have been changed from "field_value" to $kohafield. Modifying this could have an impact in other area, where CheckMandatorySubfields and CheckImportantSubfields are called. Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones. Note that the other ones are actually broken (!) Also note that there is a typo in the error message alertString2 += "\n- " + "%s " + MSG_MANDATORY_FIELDS_EMPTY.format(total_errors); There is an extra %s Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #108 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125611&action=edit Bug 27526: Fix PrefillItem We are basically adding: $current_item = $item->unblessed; Other changes are for readability Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #109 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125612&action=edit Bug 27526: Fix Add & duplicate Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #110 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125613&action=edit Bug 27526: Fix Add multiple copies This has been moved to Koha::Item->store by bug 27545. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #111 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125614&action=edit Bug 27526: Fix incorrect condition The barcode was always prefilled! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #112 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125615&action=edit Bug 27526: Fix empty string vs undef Empty strings must be removed, not inserted as empty strings in DB. The relevant code is in TransformHtmlToXml, $skip variable. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #113 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125616&action=edit Bug 27526: Remove uneeded call to TransformMarcToKoha And also clean some imports. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #114 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125617&action=edit Bug 27526: Fix encoding issue on subfield If you have a "é" subfield it should work! Note that VARCHAR(1) for binary means 1-byte (from MySQL doc): "For example, if the default character set is utf8mb4, CHAR(5) BINARY is treated as CHAR(5) CHARACTER SET utf8mb4 COLLATE utf8mb4_bin. This differs from BINARY(5), which stores 5-byte binary strings that have the binary character set and collation." Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #115 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125618&action=edit Bug 27526: Fix cn_source display For an unknown reason C4::Biblio::GetAuthorisedValueDesc (that we are calling from Koha::Item->columns_to_str) does not deal with class sources. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #116 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125619&action=edit Bug 27526: Add missing POD Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #117 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125620&action=edit Bug 27526: Add tests for columns_to_str and host_items Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #118 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok, I already tested and signed this before. Tests were added as requested and they pass. All found issues by testers addressed in follow-up patches. No QA issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #119 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great to see this one PQA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29111 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 [Bug 29111] Remove dead code from intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26351 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 [Bug 26351] Add plugin hooks to transform item barcodes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #120 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #121 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125818&action=edit Bug 27526: Fix perlcritic in tests Problem while critiquing "t/db_dependent/Koha/Item.t": Can't parse code: Encountered unexpected character '195' non-ascii chars must be quoted when used as hash keys -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #122 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125839&action=edit Bug 27526: (QA follow-up) Wrap tests in transaction Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #123 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125863&action=edit Bug 27526: Improve robustness of tests * Could fail if not using the original sample data: build the AV we need instead of relying on what is in the DB -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #124 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Last 3 patches pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust@univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #125 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126034&action=edit Bug 27526: Correct NULL vs empty string when editing When an item is edit we must keep the NULL values in DB if the input have been left empty. It also fixes the "barcode cannot be unique" error when an item does not have a barcode. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #126 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Nick, Tomas, can you have a close look at this patch please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #127 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #125)
When an item is edit we must keep the NULL values in DB if the input have been left empty.
I saw that before? It is presented as a fact, but I am not sure about that. When the user saved the form and left a few fields empty, you could argue that empty string reflects this 'choice', while NULL says that we just dont know. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #128 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #127)
(In reply to Jonathan Druart from comment #125)
When an item is edit we must keep the NULL values in DB if the input have been left empty.
I saw that before? It is presented as a fact, but I am not sure about that. When the user saved the form and left a few fields empty, you could argue that empty string reflects this 'choice', while NULL says that we just dont know.
We use NULL when creating, we should keep it when editing IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #129 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126051&action=edit Bug 27526: (follow-up) Remove uneeded call to TransformMarcToKoha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #130 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #129)
Created attachment 126051 [details] [review] Bug 27526: (follow-up) Remove uneeded call to TransformMarcToKoha
Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #131 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126143&action=edit Bug 27526: Fix 'duplicate item' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #132 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126144&action=edit Bug 27526: Fix 'add & duplicate item' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #133 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126393&action=edit Bug 27526: Fix for prefill preventing duplication -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #134 from Andrew Nugged <nugged@gmail.com> --- JD: we still "hotfixing" so I adding a link to the chain with your hotfixes, this one above made it working at last on our live server. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #135 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Last 3 patches pushed to master! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #136 from Andrew Nugged <nugged@gmail.com> --- (In reply to Jonathan Druart from comment #125)
Created attachment 126034 [details] [review] Bug 27526: Correct NULL vs empty string when editing
looks like we lost this one from master. Jonathan: for a reason? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #137 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Andrew Nugged from comment #136)
(In reply to Jonathan Druart from comment #125)
Created attachment 126034 [details] [review] [review] Bug 27526: Correct NULL vs empty string when editing
looks like we lost this one from master.
Jonathan: for a reason?
Oops, sorry, I forgot it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #138 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I was actually waiting for confirmation, I haven't flagged it as pushed. It's now pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #139 from Andrew Nugged <nugged@gmail.com> --- thanks! Now I am doing my build for piloting library, production, let's see what else pops-up! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #140 from Andrew Nugged <nugged@gmail.com> --- Created attachment 127025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127025&action=edit Bug 27526: Fix for prefill preventing duplication 2 Prefill feature should not be in the priority when user choose "Duplicate" for the item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #141 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127032&action=edit Bug 27526: Fix SubfieldsToUseWhenPrefill my $a = "z"; my @x = split ( ' ', $a ) || (""); @x will be [1] Which is not at all what we are expecting here! Be more verbose and don't introduce bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #142 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Last two patches pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29496 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 [Bug 29496] can't save an order with mandatory items subfields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29633 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29962 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29962 [Bug 29962] Table of items on item edit page missing columns button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30178 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178 [Bug 30178] Every librarian can edit every item with IndependentBranches on -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30909 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909 [Bug 30909] Regression, Permanent shelving location is always updated when editing location if both are mapped to MARC fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30717 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30717 [Bug 30717] Dates displayed in ISO format when editing items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179 [Bug 31179] Duplicate item is duplicating internal item fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34689 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34689 [Bug 34689] Add and duplicate item - Error 500 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31323 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31323 [Bug 31323] Edit item highlighting problem -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org