[Bug 39652] New: Pseudonymized_borrower_attributes causes subsequent pseudonymized_transactions to not be added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 Bug ID: 39652 Summary: Pseudonymized_borrower_attributes causes subsequent pseudonymized_transactions to not be added Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com, martin.renvoize@openfifth.co.uk, nick@bywatersolutions.com And the new PseudonymizedBorrowerAttribute entries to attach to the previous PseudonymizedTransaction -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181001&action=edit Bug 39652: Add tests These tests prove the bug: perl t/db_dependent/Koha/Pseudonymization.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181002&action=edit Bug 39652: store PseudonymizedTransaction before adding related entries Test plan: Run the tests before and after applying this patch: perl t/db_dependent/Koha/Pseudonymization.t They should fail before this patch and pass after applying patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37901 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37901 [Bug 37901] Add ILL pseudonymization -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- The approach seems sound to me and works; I've already spoken to Pedro about the `new_` name and we agreed to perhaps rename to `create_` to clarify that in this case the method is actually storing data now do no subsequent 'store' is required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181109&action=edit Bug 39652: Rename new_from_statistic This new method name better reflects the fact that it now creates - and stores - the PseudonymizedTransaction object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181109|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181110&action=edit Bug 39652: Rename new_from_statistic This new method name better reflects the fact that it now creates - and stores - the PseudonymizedTransaction object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181001|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 181209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181209&action=edit Bug 39652: Add tests These tests prove the bug: perl t/db_dependent/Koha/Pseudonymization.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181002|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 181210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181210&action=edit Bug 39652: store PseudonymizedTransaction before adding related entries Test plan: Run the tests before and after applying this patch: perl t/db_dependent/Koha/Pseudonymization.t They should fail before this patch and pass after applying patch. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181110|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 181211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181211&action=edit Bug 39652: Rename new_from_statistic This new method name better reflects the fact that it now creates - and stores - the PseudonymizedTransaction object Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Apply the first patch. 2. The tests should fail: prove t/db_dependent/Koha/Pseudonymization.t 3. Apply the remaining patches. 3. The tests should now pass: prove t/db_dependent/Koha/Pseudonymization.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181209|0 |1 is obsolete| | Attachment #181210|0 |1 is obsolete| | Attachment #181211|0 |1 is obsolete| | --- Comment #10 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 181382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181382&action=edit Bug 39652: Add tests These tests prove the bug: perl t/db_dependent/Koha/Pseudonymization.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 --- Comment #11 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 181383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181383&action=edit Bug 39652: store PseudonymizedTransaction before adding related entries Test plan: Run the tests before and after applying this patch: perl t/db_dependent/Koha/Pseudonymization.t They should fail before this patch and pass after applying patch. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 --- Comment #12 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 181384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181384&action=edit Bug 39652: Rename new_from_statistic This new method name better reflects the fact that it now creates - and stores - the PseudonymizedTransaction object Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 --- Comment #13 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 181385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181385&action=edit Bug 39652 (QA follow-up): Update misc/maintenance/pseudonymize_statistics.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed before pushing: Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - be2ae9c86ab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.10 released in| | Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #17 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39652 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #18 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org