[Bug 33012] New: Cannot logout with keyboard tabbing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Bug ID: 33012 Summary: Cannot logout with keyboard tabbing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Trivial edit. Remove tabindex -1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 146946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146946&action=edit Bug 33012: Remove tabindex from logout button Note: This is a trivial edit. But there is another logout link too in masthead with js-hide class and tabindex -1 which is rather mysterious to me ;) Test plan: Login on OPAC. Try to logout by tabbing to Logout button. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Trivial one liner. Self SO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like you can also not tab to 'search history' in the same menu as the log out link. Looking at masthead.inc we have a 'ton' of tabindex=-1. Another example would be the list menu, that cannot be navigated by tabbing, but you can use 'arrow down'. The same does not work for the 'Welcome...' menu. This would unlock one option, but it seems to be a bigger issue even in the same menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |--- Status|RESOLVED |REOPENED Summary|Cannot logout with keyboard |Accessibility: Some |tabbing |navigation items in OPAC | |cannot be accessed by | |keyboard (search history, | |log out) --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think in terms of accessibility we should investigate this further. I just felt not sure if your solution was the right one as it only fixed one of the items in this menu. I'll reopen with a different description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|m.de.rooy@rijksmuseum.nl |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Alexander Blanchard <alexander.blanchard@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.blanchard@openfif | |th.co.uk --- Comment #5 from Alexander Blanchard <alexander.blanchard@openfifth.co.uk> --- One of our sites had an accessibility audit and one of the things flagged was not being able to engage in certain functionality with the keyboard, including 'Log Out Link' and side navigation on 'Publication' page. The report also highlights not using tabindex="1" to prevent navigation order that is different from the visual / screen reader order. Is anyone currently working in this or should I take it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Alexander Blanchard from comment #5)
Is anyone currently working in this or should I take it?
If a bug has a "NEW" status you should be able to assume no one else is actively working on it. Please feel free to assign it to yourself! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nina.martinez@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |alexander.blanchard@openfif | |th.co.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 --- Comment #7 from Alexander Blanchard <alexander.blanchard@openfifth.co.uk> --- (In reply to Owen Leonard from comment #6)
(In reply to Alexander Blanchard from comment #5)
Is anyone currently working in this or should I take it?
If a bug has a "NEW" status you should be able to assume no one else is actively working on it. Please feel free to assign it to yourself!
Thank you Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 --- Comment #8 from Alexander Blanchard <alexander.blanchard@openfifth.co.uk> --- Created attachment 181509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181509&action=edit Bug 33012: Cannot Tab To Some Menu Items An accessibility audit highlighted that when logged in you cannot tab to the log out link in the welcome menu. The search history link in the same menu was also unable to be tabbed to. These links were also not able to be reached using arrows. The links for Your Lists, Private Lists and New List could be reached using the arrows on the keyboard but not via the tab option. To Test: 1) Navigate to Koha oPac. 2) Ensure you are logged in. 3) Use tabs to navigate the site. 4) When you reach the Welcome menu press enter. 5) Note that you can tab to 'Your Account' and the 'Clear' icon but not to 'Search History' or to 'Log Out' 6) Tab also to the hamburger menu and press enter 7) Note than you can navigate this menu via the arrows on the keyboard but not via the tab button 8) Apply patch 9) Repeat steps 1-7 10) Note that you can now tab to all of the above links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Alexander Blanchard <alexander.blanchard@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 --- Comment #9 from Alexander Blanchard <alexander.blanchard@openfifth.co.uk> --- Created attachment 181836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181836&action=edit An accessibility audit highlighted that when logged in you cannot tab to the log out link in the welcome menu. The search history link in the same menu was also unable to be tabbed to. These links were also not able to be reached using arrows. The links for Your Lists, Private Lists and New List could be reached using the arrows on the keyboard but not via the tab option. To Test: 1) Navigate to Koha oPac. 2) Ensure you are logged in. 3) Use tabs to navigate the site. 4) When you reach the Welcome menu press enter. 5) Note that you can tab to 'Your Account' and the 'Clear' icon but not to 'Search History' or to 'Log Out' 6) Tab also to the hamburger menu and press enter 7) Note than you can navigate this menu via the arrows on the keyboard but not via the tab button 8) Apply patch 9) Repeat steps 1-7 10) Note that you can now tab to all of the above links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 --- Comment #10 from Alexander Blanchard <alexander.blanchard@openfifth.co.uk> --- Created attachment 181837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181837&action=edit Bug 33012: Cannot Tab To Some Menu Items An accessibility audit highlighted that when logged in you cannot tab to the log out link in the welcome menu. The search history link in the same menu was also unable to be tabbed to. These links were also not abl The links for Your Lists, Private Lists and New List could be reached using the arrows on the keyboard but not via the tab option. To Test: 1) Navigate to Koha oPac. 2) Ensure you are logged in. 3) Use tabs to navigate the site. 4) When you reach the Welcome menu press enter. 5) Note that you can tab to 'Your Account' and the 'Clear' icon but not to 'Search History' or to 'Log Out' 6) Tab also to the hamburger menu and press enter 7) Note than you can navigate this menu via the arrows on the keyboard but not via the tab button 8) Apply patch 9) Repeat steps 1-7 10) Note that you can now tab to all of the above links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Alexander Blanchard <alexander.blanchard@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181509|0 |1 is obsolete| | --- Comment #11 from Alexander Blanchard <alexander.blanchard@openfifth.co.uk> --- Created attachment 181838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181838&action=edit Bug 33012: Cannot Tab To Some Menu Items An accessibility audit highlighted that when logged in you cannot tab to the log out link in the welcome menu. The search history link in the same menu was also unable to be tabbed to. These links were also not able to be reached using arrows. The links for Your Lists, Private Lists and New List could be reached using the arrows on the keyboard but not via the tab option. To Test: 1) Navigate to Koha oPac. 2) Ensure you are logged in. 3) Use tabs to navigate the site. 4) When you reach the Welcome menu press enter. 5) Note that you can tab to 'Your Account' and the 'Clear' icon but not to 'Search History' or to 'Log Out' 6) Tab also to the hamburger menu and press enter 7) Note than you can navigate this menu via the arrows on the keyboard but not via the tab button 8) Apply patch 9) Repeat steps 1-7 10) Note that you can now tab to all of the above links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Alexander Blanchard <alexander.blanchard@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146946|0 |1 is obsolete| | Attachment #181836|0 |1 is obsolete| | Attachment #181837|0 |1 is obsolete| | Attachment #181838|0 |1 is obsolete| | --- Comment #12 from Alexander Blanchard <alexander.blanchard@openfifth.co.uk> --- Created attachment 181839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181839&action=edit Bug 33012: Cannot Tab To Some Menu Items An accessibility audit highlighted that when logged in you cannot tab to the log out link in the welcome menu. The search history link in the same menu was also unable to be tabbed to. These links were also not able to be reached using arrows. The links for Your Lists, Private Lists and New List could be reached using the arrows on the keyboard but not via the tab option. To Test: 1) Navigate to Koha oPac. 2) Ensure you are logged in. 3) Use tabs to navigate the site. 4) When you reach the Welcome menu press enter. 5) Note that you can tab to 'Your Account' and the 'Clear' icon but not to 'Search History' or to 'Log Out' 6) Tab also to the hamburger menu and press enter 7) Note than you can navigate this menu via the arrows on the keyboard but not via the tab button 8) Apply patch 9) Repeat steps 1-7 10) Note that you can now tab to all of the above links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Alexander Blanchard <alexander.blanchard@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 181844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181844&action=edit Bug 33012: Accessibility - Fix OPAC navigation when using the tab key An accessibility audit highlighted that when logged in you cannot tab to the log out link in the welcome menu. The search history link in the same menu was also unable to be tabbed to. These links were also not able to be reached using arrows. The links for Your Lists, Private Lists and New List could be reached using the arrows on the keyboard but not via the tab option. Testi plan: 1) Navigate to the Koha OPAC. 2) Ensure you are logged in. 3) Use tabs to navigate the site. 4) When you reach the Welcome menu press enter. 5) Note that you can tab to 'Your Account' and the 'Clear' icon but not to 'Search History' or to 'Log Out' 6) Tab also to the hamburger menu and press enter 7) Note than you can navigate this menu via the arrows on the keyboard but not via the tab button 8) Apply patch 9) Repeat steps 1-7 10) Note that you can now tab to all of the above links Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181844|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 181845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181845&action=edit Bug 33012: Accessibility - Fix OPAC navigation when using the tab key An accessibility audit highlighted that when logged in you cannot tab to the log out link in the welcome menu. The search history link in the same menu was also unable to be tabbed to. These links were also not able to be reached using arrows. The links for Your Lists, Private Lists and New List could be reached using the arrows on the keyboard but not via the tab option. Test plan: 1) Navigate to the Koha OPAC. 2) Ensure you are logged in. 3) Use tabs to navigate the site. 4) When you reach the Welcome menu press enter. 5) Note that you can tab to 'Your Account' and the 'Clear' icon but not to 'Search History' or to 'Log Out' 6) Tab also to the hamburger menu and press enter 7) Note than you can navigate this menu via the arrows on the keyboard but not via the tab button 8) Apply patch 9) Repeat steps 1-7 10) Note that you can now tab to all of the above links Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #181839|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the OPAC release notes| |navigation menus when | |logged in so that keyboard | |users can use the tab key | |to navigation menus. Some | |menu items (such as some | |list options, search | |history, and log out) were | |not selectable when just | |using the tab key. --- Comment #15 from David Nind <david@davidnind.com> --- I've amended the commit message so that it is a bit more consist with the commit message guidelines (https://wiki.koha-community.org/wiki/Commit_messages): - Title in sentence case - Title = what the patch fixes, not what the problem is - "To test:" to "Test plan:" - Minor spelling correction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 --- Comment #16 from David Nind <david@davidnind.com> --- Thanks for working on theis accessibility bug! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181845|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181873&action=edit Bug 33012: Accessibility - Fix OPAC navigation when using the tab key An accessibility audit highlighted that when logged in you cannot tab to the log out link in the welcome menu. The search history link in the same menu was also unable to be tabbed to. These links were also not able to be reached using arrows. The links for Your Lists, Private Lists and New List could be reached using the arrows on the keyboard but not via the tab option. Test plan: 1) Navigate to the Koha OPAC. 2) Ensure you are logged in. 3) Use tabs to navigate the site. 4) When you reach the Welcome menu press enter. 5) Note that you can tab to 'Your Account' and the 'Clear' icon but not to 'Search History' or to 'Log Out' 6) Tab also to the hamburger menu and press enter 7) Note than you can navigate this menu via the arrows on the keyboard but not via the tab button 8) Apply patch 9) Repeat steps 1-7 10) Note that you can now tab to all of the above links Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Same company QA, I've not seen the patches prior to this point. All is looking good, and this is an important accessibility improvement without any regressions I can find. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40439 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.10 released in| | --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #21 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33012 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #22 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org