[Bug 40256] New: System defined MANUAL debit type description is hard coded but the description can be changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40256 Bug ID: 40256 Summary: System defined MANUAL debit type description is hard coded but the description can be changed Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Go to Admin -> Debit types 2. See MANUAL debit type with the description of 'Manual fee' 3. Click edit and edit the description. 4. Go back to the Debit types admin page. The description still reads "Manual fee" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40256 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- kohadev-koha@kohadevbox:koha(main)$ git grep 'Manual fee' koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc: <span>Manual fee</span> koha-tmpl/opac-tmpl/bootstrap/en/includes/accounts.inc: <span>Manual fee</span> t/mock_templates/intranet-tmpl/prog/en/includes/accounts.inc: <span>Manual fee</span> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40256 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40256 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40256 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 186549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186549&action=edit Bug 40256: Use debit_type.description for display of manual fees To test: 1 - edit the description of your MANUAL debit type to read "TEST" instead of "Manual fee" 2 - create a new debit type with code "BOO" and description "Broken" 3 - find a patron, go to accounting then to apply manual invoice 4 - note that the debit types presented for use show "Manual fee" instead of "TEST" 5 - create a debit on your patron with type MANAUAL and a second debit using the type created in step 2 6 - in your patron account, confirm your manual fee shows "Manual fee" in the Type column 7 - confirm the debit created in step 5 shows "broken" in the type column 8 - log into the OPAC as your patron, go to their account 9 - confirm your MANUAL debit shows "Manual fee" in the type column 10 - confirm your other debit shows no value in the type column -- for some reason the OPAC isn't showing non-system type values here, which seems to be a new issue APPLY PATCH 11 - reload patron account in staff client, see it now shows "TEST" in the type column for your MANUAL debit 12 - reload the debit types page in admin, confirm it now shows "TEST" in the description column for the MANUAL debit type 13 - reload the patron account on the OPAC, see it now shows no value in the Type column for either of your debits. Whatever's stopping the type from showing for the custom debit type is also stopping it from showing for the MANUAL debit type -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40256 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This patch fixes the issue for the staff client, but makes clear that there's something else going wrong on the OPAC. In the patron accounts page on the OPAC, it's for some reason failing to display type values for any debit that's not part of the standard install. I didn't tease out why that's failing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40256 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40836 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 [Bug 40836] Credit and debit types are not shown in patron account on OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40256 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Filed bug 40836 for this missing Type values. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40256 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40256 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40256 Amanda Campbell <acampbell@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell@hmcpl.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org