[Bug 39827] New: Wrong framework in edit framework button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 Bug ID: 39827 Summary: Wrong framework in edit framework button Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In Administration > MARC bibliographic frameworks the "Edit framework" button in tools bar always edits default framework -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 181899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181899&action=edit Bug 39827: Fix framework code in edit framework button In Administration > MARC bibliographic frameworks the "Edit framework" button in tools bar always edits default framework Test plan : 1) Go to Administration > MARC bibliographic frameworks 2) On any framework except default one click on actions then "MARC structure" 3) In tools bar click on "Edit framework" 4) Check you are editing the correct framework -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- OMG using this button on default framework goes to framework creation. I open a new report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181899|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 181942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181942&action=edit Bug 39827: Fix framework code in edit framework button In Administration > MARC bibliographic frameworks the "Edit framework" button in tools bar always edits default framework Test plan : 1) Go to Administration > MARC bibliographic frameworks 2) On any framework except default one click on actions then "MARC structure" 3) In tools bar click on "Edit framework" 4) Check you are editing the correct framework Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- I have (In reply to Fridolin Somers from comment #2)
OMG using this button on default framework goes to framework creation. I open a new report.
I have signed off. However, before the patch I get this behavour for any framework, not just the default framework (MARC21 instance). That is, before the patch, clicking 'Edit framework' for any framework, shows the add framework form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- We don't allow editing the default framework from the place this link duplicates, the Edit option in the biblio_framework.pl list of frameworks. To allow dealing with it, with its special framework code of '' when a code is otherwise required, you would have to add special-casing for that. Or just hide the link on the default framework like we hide the Edit option. But a more accurate label for the link would be "Edit framework description" since that's the only thing you can edit, and that's something that you would generally do maybe once, if you made a typo while creating the framework. I really don't see any reason why this link was added. Even if you do notice that you have a description typo while in marctagstructure.pl and use this link, you're going to wind up dumped at biblio_framework.pl when you save your description change, so there's no real benefit over just going there in the first place to do your edit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181942|0 |1 is obsolete| | --- Comment #6 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182312&action=edit Bug 39827: Fix framework code in edit framework button In Administration > MARC bibliographic frameworks the "Edit framework" button in tools bar always edits default framework Test plan : 1) Go to Administration > MARC bibliographic frameworks 2) On any framework except default one click on actions then "MARC structure" 3) In tools bar click on "Edit framework" 4) Check you are editing the correct framework Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40088 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40088 [Bug 40088] Do not show edit button for default framework -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | Status|Pushed to main |Pushed to stable --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes editing release notes| |bibliographic framework | |descriptions. In Koha | |administration > Catalog > | |MARC bibliographic | |framework, the Actions > | |Edit framework option for | |any framework was always | |including showing the edit | |form for the default | |framework description, | |instead of the actual | |framework selected. | | | |Note: Bug 40088 removes the | |'Edit' option for the | |default framework. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes editing |This fixes editing release notes|bibliographic framework |bibliographic framework |descriptions. In Koha |descriptions. In Koha |administration > Catalog > |administration > Catalog > |MARC bibliographic |MARC bibliographic |framework, the Actions > |framework, the Actions > |Edit framework option for |Edit framework option for |any framework was always |any framework was always |including showing the edit |showing the edit form for |form for the default |the default framework |framework description, |description, instead of the |instead of the actual |actual framework selected. |framework selected. | | | |Note: Bug 40088 removes the | |'Edit' option for the | |default framework. | --- Comment #9 from David Nind <david@davidnind.com> --- Fixed release note - removed note about bug 40088. I misunderstood what it does! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39827 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #11 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org