[Bug 37634] New: JS error on debit detail page when showLastPatron is used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Bug ID: 37634 Summary: JS error on debit detail page when showLastPatron is used Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When showLastPatron is active, there is a JS error when looking at the details of a debit: Uncaught ReferenceError: showLastPatronCount is not defined <anonymous> http://localhost:8081/intranet-tmpl/prog/js/staff-global_24.0600023.js:215 jQuery 13 To test: * Activate showLastPatron * Go to a patron account (Henry will do) * Add a manual invoice * Click on the "Details" for this invoice * Verify there is a JS error on the page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Also in "Files" tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|JS error on debit detail |Missing "USE Koha" causes |page when showLastPatron is |JS errors and missing "Last |used |patron" menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174986&action=edit Bug 37634: Missing "USE Koha" causes JS errors and missing "Last patron" menu This patch adds "[% USE Koha %]" to templates which lack it. Without this, the "Last patron" menu item doesn't work and will cause a JS error on many pages. The patch also removes some USE entries which were duplicates. To test, apply the patch and test all 176 different pages to confirm they all work correctly. I mean, maybe. Or maybe sample a few to confirm they work? - Go to Administration -> System preferences and enable "showLastPatron" - If the preference was not enabled, you probably need to go to Circulation and open a patron account for checkout so that there is a "last patron" to show. - Test a sampling of pages affected by this patch: - Acquisitions -> Acquisitions home page - Administration -> Cities and towns - Catalog -> Item search - Cataloging -> Label creator - Patrons -> Patron account -> Set permissions - Reports -> Items lost - Serials -> Serials home page - Tools -> Calendar - Pages which had duplicate lines (not necessarily "USE Koha"): - Acquisitions -> Vendor -> Receive shipments - Administration -> Manage jobs - Administration -> Record overlay rules - Catalog -> Search results - Catalog -> Bibliographic detail page -> Items - Circulation -> Holds queue - Patrons -> Patron detail page -> Accounting -> Transactions tab - Serials -> Subscription details -> Create/edit routing list - OPAC -> Search results -> Request article Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174986|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 175038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175038&action=edit Bug 37634: Missing "USE Koha" causes JS errors and missing "Last patron" menu This patch adds "[% USE Koha %]" to templates which lack it. Without this, the "Last patron" menu item doesn't work and will cause a JS error on many pages. The patch also removes some USE entries which were duplicates. To test, apply the patch and test all 176 different pages to confirm they all work correctly. I mean, maybe. Or maybe sample a few to confirm they work? - Go to Administration -> System preferences and enable "showLastPatron" - If the preference was not enabled, you probably need to go to Circulation and open a patron account for checkout so that there is a "last patron" to show. - Test a sampling of pages affected by this patch: - Acquisitions -> Acquisitions home page - Administration -> Cities and towns - Catalog -> Item search - Cataloging -> Label creator - Patrons -> Patron account -> Set permissions - Reports -> Items lost - Serials -> Serials home page - Tools -> Calendar - Pages which had duplicate lines (not necessarily "USE Koha"): - Acquisitions -> Vendor -> Receive shipments - Administration -> Manage jobs - Administration -> Record overlay rules - Catalog -> Search results - Catalog -> Bibliographic detail page -> Items - Circulation -> Holds queue - Patrons -> Patron detail page -> Accounting -> Transactions tab - Serials -> Subscription details -> Create/edit routing list - OPAC -> Search results -> Request article Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the cause of the release notes| |"Last patron" menu not | |displaying on many staff | |interface pages, or | |generating JavaScript | |errors (where | |showLastPatron is enabled). | |(It adds "[% USE Koha %]" | |to templates where it was | |missing. It also removes | |some duplicate USE | |entries.) CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. The pages to check in the test plan: 1.1 JavaScript error message only generated on Patrons > Patron account > Set permissions 1.2 Before the patch, most pages were missing the "Last patron" menu. 1.3 After the patch, the "Last patron" menu now appears on all pages checked. Should we add a test or something to the QA tools to check for "[% USE Koha %]" in all template pages? (I don't know how this is to do 8-).) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175038|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175447&action=edit Bug 37634: Missing "USE Koha" causes JS errors and missing "Last patron" menu This patch adds "[% USE Koha %]" to templates which lack it. Without this, the "Last patron" menu item doesn't work and will cause a JS error on many pages. The patch also removes some USE entries which were duplicates. To test, apply the patch and test all 176 different pages to confirm they all work correctly. I mean, maybe. Or maybe sample a few to confirm they work? - Go to Administration -> System preferences and enable "showLastPatron" - If the preference was not enabled, you probably need to go to Circulation and open a patron account for checkout so that there is a "last patron" to show. - Test a sampling of pages affected by this patch: - Acquisitions -> Acquisitions home page - Administration -> Cities and towns - Catalog -> Item search - Cataloging -> Label creator - Patrons -> Patron account -> Set permissions - Reports -> Items lost - Serials -> Serials home page - Tools -> Calendar - Pages which had duplicate lines (not necessarily "USE Koha"): - Acquisitions -> Vendor -> Receive shipments - Administration -> Manage jobs - Administration -> Record overlay rules - Catalog -> Search results - Catalog -> Bibliographic detail page -> Items - Circulation -> Holds queue - Patrons -> Patron detail page -> Accounting -> Transactions tab - Serials -> Subscription details -> Create/edit routing list - OPAC -> Search results -> Request article Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175447|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175591&action=edit Bug 37634: Missing "USE Koha" causes JS errors and missing "Last patron" menu This patch adds "[% USE Koha %]" to templates which lack it. Without this, the "Last patron" menu item doesn't work and will cause a JS error on many pages. The patch also removes some USE entries which were duplicates. To test, apply the patch and test all 176 different pages to confirm they all work correctly. I mean, maybe. Or maybe sample a few to confirm they work? - Go to Administration -> System preferences and enable "showLastPatron" - If the preference was not enabled, you probably need to go to Circulation and open a patron account for checkout so that there is a "last patron" to show. - Test a sampling of pages affected by this patch: - Acquisitions -> Acquisitions home page - Administration -> Cities and towns - Catalog -> Item search - Cataloging -> Label creator - Patrons -> Patron account -> Set permissions - Reports -> Items lost - Serials -> Serials home page - Tools -> Calendar - Pages which had duplicate lines (not necessarily "USE Koha"): - Acquisitions -> Vendor -> Receive shipments - Administration -> Manage jobs - Administration -> Record overlay rules - Catalog -> Search results - Catalog -> Bibliographic detail page -> Items - Circulation -> Holds queue - Patrons -> Patron detail page -> Accounting -> Transactions tab - Serials -> Subscription details -> Create/edit routing list - OPAC -> Search results -> Request article Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175591|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175592&action=edit Bug 37634: Missing "USE Koha" causes JS errors and missing "Last patron" menu This patch adds "[% USE Koha %]" to templates which lack it. Without this, the "Last patron" menu item doesn't work and will cause a JS error on many pages. The patch also removes some USE entries which were duplicates. To test, apply the patch and test all 176 different pages to confirm they all work correctly. I mean, maybe. Or maybe sample a few to confirm they work? - Go to Administration -> System preferences and enable "showLastPatron" - If the preference was not enabled, you probably need to go to Circulation and open a patron account for checkout so that there is a "last patron" to show. - Test a sampling of pages affected by this patch: - Acquisitions -> Acquisitions home page - Administration -> Cities and towns - Catalog -> Item search - Cataloging -> Label creator - Patrons -> Patron account -> Set permissions - Reports -> Items lost - Serials -> Serials home page - Tools -> Calendar - Pages which had duplicate lines (not necessarily "USE Koha"): - Acquisitions -> Vendor -> Receive shipments - Administration -> Manage jobs - Administration -> Record overlay rules - Catalog -> Search results - Catalog -> Bibliographic detail page -> Items - Circulation -> Holds queue - Patrons -> Patron detail page -> Accounting -> Transactions tab - Serials -> Subscription details -> Create/edit routing list - OPAC -> Search results -> Request article Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175593&action=edit Bug 37634: (follow-up) Add 'Koha' to LOAD_PLUGINS This patch adds the Koha plugin that's used in almost every template and include for some basic functions to the LOAD_PLUGINS directive on Template load.. this way we shouldn't need to keep adding it to the top of every TT file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175594&action=edit Bug 37634: Remove [% USE Koha %] from all templates We now load this plugin by default using LOAD_PLUGINS so we no longer need to reference it in a USE statement in every template file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- So.. it felt a bit mad adding all these USE statements to pretty much every template file in Koha so I asked myself.. "Can't we just load that plugin by default?" Setting back to NSO to get some attention and testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |kyle@bywatersolutions.com, | |nick@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Alias| |Move, default, tt, plugins, | |to, LOAD_PLUGINS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Alias|tt |TT, "Move, LOAD_PLUGINS" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Alias|"Move, default, | |LOAD_PLUGINS, | |LOAD_PLUGINS", Move, | |plugins, to, TT | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38723 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38723 [Bug 38723] Move widely used TT plugins to LOAD_PLUGINS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175593|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Obsoleted my follow-ups and moved them to their own bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Are we going to add it even if the template does not use it? I don't think it's a good idea... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Glad to see this fixed :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #12)
Are we going to add it even if the template does not use it?
I don't think it's a good idea...
Too bad this has been ignored. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure it has been. But isn't the last patron available on all pages? We could have wrapped it into an IF/END maybe in case the feature is turned off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- This bug should have been fixed by adding [% USE Koha %] to koha-tmpl/intranet-tmpl/prog/en/includes/last-borrower.inc This was the proper fix, because this file is using Koha.Preference. Now it's still missing from this include file (which is wrong IMO) and we have USE Koha where it's not needed (ie. when we don't use the Koha TT plugin). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #17)
This bug should have been fixed by adding [% USE Koha %] to koha-tmpl/intranet-tmpl/prog/en/includes/last-borrower.inc This was the proper fix, because this file is using Koha.Preference. Now it's still missing from this include file (which is wrong IMO) and we have USE Koha where it's not needed (ie. when we don't use the Koha TT plugin).
Would the "double declaration" be a problem if it's in the include and on the page itself or could that be safely ignored? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- keep the code clean? It's all what I am talking about. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #19)
keep the code clean? It's all what I am talking about.
Sorry, I am trying to understand the issue. If we move it to the include, we'd end up with a lot of multiple "USE Koha" on pages. I was wondering if that was not worse than adding it to the templates or if it could be ignored. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #20)
(In reply to Jonathan Druart from comment #19)
keep the code clean? It's all what I am talking about.
Sorry, I am trying to understand the issue. If we move it to the include, we'd end up with a lot of multiple "USE Koha" on pages. I was wondering if that was not worse than adding it to the templates or if it could be ignored.
We have this already in several places, it's not a problem. I guess TT won't load the plugin if it has been loaded already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- I confirm this is a problem. If you include sub-header.inc to use the breadcrumb from a plugin, you get: Template process failed: undef error - : filter not found at /kohadevbox/koha/C4/Templates.pm line 134 Absolutely not meaningful. This is because shortcut.inc is using Koha.Preference without 'USE Koha' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #23 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- This is in the commit log for 24.11, though not noted here yet. Not backporting to 24.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.02 released in| | CC| |paul.derscheid@lmscloud.de --- Comment #24 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #25 from Jesse Maseto <jesse@bywatersolutions.com> --- Merge conflicts with 24.05.x Please resolve if needed in 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183152&action=edit Bug 37634: [24.04] Missing "USE Koha" causes JS errors and missing "Last patron" menu This patch adds "[% USE Koha %]" to templates which lack it. Without this, the "Last patron" menu item doesn't work and will cause a JS error on many pages. The patch also removes some USE entries which were duplicates. To test, apply the patch and test all 176 different pages to confirm they all work correctly. I mean, maybe. Or maybe sample a few to confirm they work? - Go to Administration -> System preferences and enable "showLastPatron" - If the preference was not enabled, you probably need to go to Circulation and open a patron account for checkout so that there is a "last patron" to show. - Test a sampling of pages affected by this patch: - Acquisitions -> Acquisitions home page - Administration -> Cities and towns - Catalog -> Item search - Cataloging -> Label creator - Patrons -> Patron account -> Set permissions - Reports -> Items lost - Serials -> Serials home page - Tools -> Calendar - Pages which had duplicate lines (not necessarily "USE Koha"): - Acquisitions -> Vendor -> Receive shipments - Administration -> Manage jobs - Administration -> Record overlay rules - Catalog -> Search results - Catalog -> Bibliographic detail page -> Items - Circulation -> Holds queue - Patrons -> Patron detail page -> Accounting -> Transactions tab - Serials -> Subscription details -> Create/edit routing list - OPAC -> Search results -> Request article Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #26)
Created attachment 183152 [details] [review] Bug 37634: [24.04] Missing "USE Koha" causes JS errors and missing "Last patron" menu
Sorry that should be [24.05] of course! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #28 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #29 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org