[Bug 39826] New: vendor interface's password not utf8 decoded on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 Bug ID: 39826 Summary: vendor interface's password not utf8 decoded on display Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org We store an encrypted version of the passwords for vendor's interfaces, but we don't utf8 decode it after it is decrypted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38010 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181897&action=edit Bug 39826: UTF8-decode vendor interface's password on display We store an encrypted version of the passwords for vendor's interfaces, but we don't utf8 decode it after it is decrypted Test plan: 0. Do not apply this patch 1. Create or edit a vendor and add at least one interface with non ascii characters, eg. émyPassword❤ 2. Go to the detail view of the vendor and click the "Show password" link => The password is not correctly utf8-decoded 3. Apply this patch, repeat 2 => The password is correctly displayed 4. Repeat 1 and 2 => The password is correctly displayed Note that maybe we should make sure the encrypt_hex is getting a valid utf8-encoded variable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |unspecified Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Version(s)| |25.05.00 released in| | --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Oops, I... inadvertently pushed this to main. Can I still get a SO and QA anyway please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181897|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 181943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181943&action=edit Bug 39826: UTF8-decode vendor interface's password on display We store an encrypted version of the passwords for vendor's interfaces, but we don't utf8 decode it after it is decrypted Test plan: 0. Do not apply this patch 1. Create or edit a vendor and add at least one interface with non ascii characters, eg. émyPassword❤ 2. Go to the detail view of the vendor and click the "Show password" link => The password is not correctly utf8-decoded 3. Apply this patch, repeat 2 => The password is correctly displayed 4. Repeat 1 and 2 => The password is correctly displayed Note that maybe we should make sure the encrypt_hex is getting a valid utf8-encoded variable. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Summary|vendor interface's password |Vendor interface's password |not utf8 decoded on display |not utf8 decoded on display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Happy to PQA on this.. works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | Status|Passed QA |Pushed to main --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This had already been pushed "by accident". So marking as Pushed to main now officially. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39826 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #8 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org