[Bug 9003] New: Add css fix for opac news items with strong and em
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003 Priority: P5 - low Change sponsored?: --- Bug ID: 9003 Assignee: oleonard@myacpl.org Summary: Add css fix for opac news items with strong and em Severity: minor Classification: Unclassified OS: All Reporter: dcook@prosentient.com.au Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Currently, if you have nested strong and em tags in Opac News, you will only get the properties of the inner tag, since reset-fonts-grids.css resets the font weight and style (for both strong and em) to normal. So if you have em as your inner tag, you'll have italics but reset-fonts-grids.css also makes em have a font-weight of normal, so your strong tag is bypassed. I suggest adding some css that takes into account this descendant/nested situation, so that users can actually both bold and italicize news items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 13161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13161&action=edit Bug 9003 - Add css fix for opac news items with strong and em Simple bit of css which doesn't affect anything outside of the opac news box. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13161|0 |1 is obsolete| | --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 13162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13162&action=edit Bug 9003 - Add css fix for opac news items with strong and em Replaced child selector with descendant selector to match the rest the staff-global.css file... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This change looks correct to me, but I don't see any reason for you to limit it to #news. Can you please resubmit so that em and strong work well together globally? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13162|0 |1 is obsolete| | --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 15127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15127&action=edit Bug 9003 - Add css fix for opac items with strong and em Good point, Owen. I notice in the staff client that it handles the strong and em nesting for all items and not just news, so here is my updated patch! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15127|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15193&action=edit [SIGNED-OFF] Bug 9003 - Add css fix for opac items with strong and em Currently, if you have nested strong and em tags in the opac, you will only get the properties of the inner tag. This seems to be due to reset-fonts-grids.css resetting the font weight and style (for both strong and em) to normal. So if you have strong as your outer tag and em as your inner tag, you'll have italics but no bold. To test: Before applying the patch... 1) Put <em> and <strong> tags around some text in the opacnav, opac news, opacheader, or any other area of the opac where you can enter html text. 2) Look at the opac and notice that only the inner tag styles are being applied to the text Apply the patch 3) Refresh the opac (you may need to bypass or clear your browser cache for the new style to pick up) 4) Note that both the inner and outer <em> and <strong> tags are being applied to the text (i.e. your text should be bold and italicized) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Small change that works. No errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15193|0 |1 is obsolete| | --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 16833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16833&action=edit Bug 9003 - Add css fix for opac items with strong and em Currently, if you have nested strong and em tags in the opac, you will only get the properties of the inner tag. This seems to be due to reset-fonts-grids.css resetting the font weight and style (for both strong and em) to normal. So if you have strong as your outer tag and em as your inner tag, you'll have italics but no bold. To test: Before applying the patch... 1) Put <em> and <strong> tags around some text in the opacnav, opac news, opacheader, or any other area of the opac where you can enter html text. 2) Look at the opac and notice that only the inner tag styles are being applied to the text Apply the patch 3) Refresh the opac (you may need to bypass or clear your browser cache for the new style to pick up) 4) Note that both the inner and outer <em> and <strong> tags are being applied to the text (i.e. your text should be bold and italicized) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Small change that works. No errors. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.de.rooy@rijksmuseum.nl QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Nothing to say. Very small css change. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch (and a follow-up for CCSR) has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9003 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org