[Bug 35013] New: Font Awesome icons broken in self checkout and self checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 Bug ID: 35013 Summary: Font Awesome icons broken in self checkout and self checkin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Self checkout Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 32910 When we upgraded Font Awesome to v6 we missed updating the way the assets are included in self checkout and self checkin. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 [Bug 32910] Upgrade fontawesome icons to V6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156747&action=edit Bug 35013: Font Awesome icons broken in self checkout and self checkin This patch updates the way Font Awesome icon assets are included on the self checkout and self checkin pages. This change should have been made during the upgrade to Font Awesome 6 (Bug 32910). To test, apply the patch and make sure both SelfCheckInModule and WebBasedSelfCheck system preferences are enabled. - Go to the self checkout module (/cgi-bin/koha/sco/sco-main.pl) and log in. - Check that Font Awesome icons are working: You should see an information icon by the "Help" link in the header, and a check mark icon in the "Finish" button. - Click the help link to confirm that the icon appears there too. - Go to the self checkin module (/cgi-bin/koha/sci/sci-main.pl). - In the header you should see the information icon by the help link and an icon with the "Log out" link too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156747|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156751&action=edit Bug 35013: Font Awesome icons broken in self checkout and self checkin This patch updates the way Font Awesome icon assets are included on the self checkout and self checkin pages. This change should have been made during the upgrade to Font Awesome 6 (Bug 32910). To test, apply the patch and make sure both SelfCheckInModule and WebBasedSelfCheck system preferences are enabled. - Go to the self checkout module (/cgi-bin/koha/sco/sco-main.pl) and log in. - Check that Font Awesome icons are working: You should see an information icon by the "Help" link in the header, and a check mark icon in the "Finish" button. - Click the help link to confirm that the icon appears there too. - Go to the self checkin module (/cgi-bin/koha/sci/sci-main.pl). - In the header you should see the information icon by the help link and an icon with the "Log out" link too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156751|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156761&action=edit Bug 35013: Font Awesome icons broken in self checkout and self checkin This patch updates the way Font Awesome icon assets are included on the self checkout and self checkin pages. This change should have been made during the upgrade to Font Awesome 6 (Bug 32910). To test, apply the patch and make sure both SelfCheckInModule and WebBasedSelfCheck system preferences are enabled. - Go to the self checkout module (/cgi-bin/koha/sco/sco-main.pl) and log in. - Check that Font Awesome icons are working: You should see an information icon by the "Help" link in the header, and a check mark icon in the "Finish" button. - Click the help link to confirm that the icon appears there too. - Go to the self checkin module (/cgi-bin/koha/sci/sci-main.pl). - In the header you should see the information icon by the help link and an icon with the "Log out" link too. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Misusing my powers a little... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- ... was just about to sign off, but noticed you had already done so. Can confirm that everything works as per the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Nind from comment #5)
... was just about to sign off, but noticed you had already done so. Can confirm that everything works as per the test plan.
Sorry :) Please feel free to add your sign-off line too! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156761|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 156769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156769&action=edit Bug 35013: Font Awesome icons broken in self checkout and self checkin This patch updates the way Font Awesome icon assets are included on the self checkout and self checkin pages. This change should have been made during the upgrade to Font Awesome 6 (Bug 32910). To test, apply the patch and make sure both SelfCheckInModule and WebBasedSelfCheck system preferences are enabled. - Go to the self checkout module (/cgi-bin/koha/sco/sco-main.pl) and log in. - Check that Font Awesome icons are working: You should see an information icon by the "Help" link in the header, and a check mark icon in the "Finish" button. - Click the help link to confirm that the icon appears there too. - Go to the self checkin module (/cgi-bin/koha/sci/sci-main.pl). - In the header you should see the information icon by the help link and an icon with the "Log out" link too. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 --- Comment #8 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #6)
(In reply to David Nind from comment #5)
... was just about to sign off, but noticed you had already done so. Can confirm that everything works as per the test plan.
Sorry :) Please feel free to add your sign-off line too!
8-) Have added my sign-off as well... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 32910 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35013 Bug 35013 depends on bug 32910, which changed state. Bug 32910 Summary: Upgrade fontawesome icons to V6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org