[Bug 20695] New: Upload does not show all results when uploading multiple files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 Bug ID: 20695 Summary: Upload does not show all results when uploading multiple files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org In the migration from routine get in Uploader.pm to Koha::UploadedFiles, the multiple upload result got hurt. If you upload 3 files, you get 1 result, but all files have been uploaded. E.g. 16.11 contains the statement in tools/upload.pl: my @uploads = Koha::Upload->new($upar)->get($h); And this worked for multiple uploads. But master now has: my $rec = Koha::UploadedFiles->find( $id ); And that works for just one upload. The fix is simple. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 74967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74967&action=edit Bug 20695: Fix multiple upload result in tools/upload script Instead of calling UploadedFiles->find only once with $id, we should extract all comma separated id's from the parameter. Test plan: [1] Before this patch, upload two files at once in Tools/Upload. After doing so, you should see only one result reported. But both files should have been uploaded. [2] With this patch, repeat step 1 and see two upload results. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Jonathan: If this one could still reach 18.05 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes of course, if PQA before May 11th -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74967|0 |1 is obsolete| | --- Comment #4 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 75199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75199&action=edit Bug 20695: Fix multiple upload result in tools/upload script Instead of calling UploadedFiles->find only once with $id, we should extract all comma separated id's from the parameter. Test plan: [1] Before this patch, upload two files at once in Tools/Upload. After doing so, you should see only one result reported. But both files should have been uploaded. [2] With this patch, repeat step 1 and see two upload results. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Patch applies and functions as described. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Dilan Johnpullé from comment #4)
Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Thx Dilan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75199|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 75234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75234&action=edit Bug 20695: Fix multiple upload result in tools/upload script Instead of calling UploadedFiles->find only once with $id, we should extract all comma separated id's from the parameter. Test plan: [1] Before this patch, upload two files at once in Tools/Upload. After doing so, you should see only one result reported. But both files should have been uploaded. [2] With this patch, repeat step 1 and see two upload results. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Patch applies and functions as described. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org