http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 23972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23972&action=edit Bug 11310: update the XSLT for the Bootstrap theme When the Bootstrap theme was started, the XSLT directory was copied over from the prog theme. However, it was not kept up to date with respect to changes to prog's XSLT. This patch rectifies the problem by copying over the current state of prog/en/xslt to bootstrap/en/xslt. As a consequence, the following bugs or enhancements should now be reflected in the Bootstrap theme: * 6886 * 10905 * 10465 * 10564 * 10793 * 10218 * 6594 * 9820 * 10745 * 6553 * 10218 * 10284 To test: [1] Apply the patch and ensure that OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay are set to 'default' and that OPAC theme is set to 'bootstrap'. [2] Ensure that OPAC results and bib details look OK. [3] To be really thorough, run through the test plans for the other bugs referenced by this patch. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Galen Charlton from comment #2)

I think it would be reasonable to consider making the OPAC XSLT stylesheets not be specific to a particular theme, but instead be shared by all of them. Even if that's the final decision, I think it would be a good idea for this patch to be reviewed and pushed, as having the XSLT be identical in the two major themes prior to moving it will make it easier to validate the consolidation.

+1 Personally, I don't see a need to duplicate XSLTs across the different themes. I think it just adds more chance of error. In theory, someone might want to tie an XSLT to a theme, so that different themes show different data, but I don't see the purpose of that, since we can already specify different XSLTs in the system preferences. Reduce the boilerplate, me thinks. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23972|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 25314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25314&action=edit Bug 11310: update the XSLT for the Bootstrap theme When the Bootstrap theme was started, the XSLT directory was copied over from the prog theme. However, it was not kept up to date with respect to changes to prog's XSLT. This patch rectifies the problem by copying over the current state of prog/en/xslt to bootstrap/en/xslt. As a consequence, the following bugs or enhancements should now be reflected in the Bootstrap theme: * 6886 * 10905 * 10465 * 10564 * 10793 * 10218 * 6594 * 9820 * 10745 * 6553 * 10218 * 10284 To test: [1] Apply the patch and ensure that OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay are set to 'default' and that OPAC theme is set to 'bootstrap'. [2] Ensure that OPAC results and bib details look OK. [3] To be really thorough, run through the test plans for the other bugs referenced by this patch. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Dan, as this is marked as bug (vs. enhancement or new feature) it is likely to be backported to earlier versions, but it's up to the RMaint to make the decision. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #11 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- There was no pb backporting this bug. I've just waited a bit because of previous string freeze. -- You are receiving this mail because: You are watching all bug changes.