[Bug 42233] New: OPAC suggestions table header contains no text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 Bug ID: 42233 Summary: OPAC suggestions table header contains no text Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org To recreate: 1. Log in to the OPAC 2. Make a purchase suggestion 3. In the suggestions table, the first <th> contains no text. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 196683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196683&action=edit Bug 42233: Add accessible text to empty purchase suggestions table header The first header cell in the OPAC purchase suggestions table contains only an icon, leaving the <th> without accessible text. This causes the column header to be announced unclearly by assistive technology and can be flagged by accessibility testing as an empty table header. Add visually hidden text to the header so the column has a meaningful accessible name while preserving the current visual display. Test plan: 1. Log in to the OPAC 2. Make a purchase suggestion 3. In the suggestions table, the first <th> contains no text 4. Apply the patch 5. Repeat steps 1-2 6. Inspect the suggestions table header 7. Confirm the first <th> now contains visually hidden text describing the checkbox selection column 8. Confirm the info icon still appears and its tooltip still works 9. Run an accessibility checker or inspect the DOM and confirm the empty table header issue is resolved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- It looks like the last header in the table has the same issue. Should this patch contain a fix for that too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196683|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 197118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197118&action=edit Bug 42233: Add accessible text to empty purchase suggestions table header The first header cell in the OPAC purchase suggestions table contains only an icon, leaving the <th> without accessible text. This causes the column header to be announced unclearly by assistive technology and can be flagged by accessibility testing as an empty table header. Add visually hidden text to the header so the column has a meaningful accessible name while preserving the current visual display. Test plan: 1. Log in to the OPAC 2. Make a purchase suggestion 3. In the suggestions table, the first <th> contains no text 4. Apply the patch 5. Repeat steps 1-2 6. Inspect the suggestions table header 7. Confirm the first <th> now contains visually hidden text describing the checkbox selection column 8. Confirm the info icon still appears and its tooltip still works 9. Run an accessibility checker or inspect the DOM and confirm the empty table header issue is resolved Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Before the patch (normal screen size - not narrowed so that responsive controls are shown), axe DevTools has an issue for the first table header column - "Table header text should not be empty". 2. Before the patch, inspecting the HTML source: ... <tr> <th data-dt-column="0" rowspan="1" colspan="1" class="dt-orderable-none" aria-label=""> <span class="dt-column-title"> <i data-bs-toggle="tooltip" data-bs-placement="right" class="fa fa-info-circle" tabindex="0" aria-label="Check the boxes in this column to select purchase suggestions for deletion" data-bs-original-title="Check the boxes in this column to select purchase suggestions for deletion"></i></span> <span class="dt-column-order"></span> </th> ... 3. After the patch: ... updated - aria-label text--> <th data-dt-column="0" rowspan="1" colspan="1" class="dt-orderable-none" aria-label="Select purchase suggestions for deletion"> <span class="dt-column-title"> added --> <span class="visually-hidden">Select purchase suggestions for deletion</span> <i data-bs-toggle="tooltip" data-bs-placement="right" class="fa fa-info-circle" tabindex="0" aria-label="Check the boxes in this column to select purchase suggestions for deletion" data-bs-original-title="Check the boxes in this column to select purchase suggestions for deletion"></i></span> <span class="dt-column-order"></span></th> ... 4. axe DevTools no longer has an issue for the first column header row (there is still one if you narrow the browser width and have the responsive controls shown - as the column header cell has no text). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197118|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200198&action=edit Bug 42233: Add accessible text to empty purchase suggestions table header The first header cell in the OPAC purchase suggestions table contains only an icon, leaving the <th> without accessible text. This causes the column header to be announced unclearly by assistive technology and can be flagged by accessibility testing as an empty table header. Add visually hidden text to the header so the column has a meaningful accessible name while preserving the current visual display. Test plan: 1. Log in to the OPAC 2. Make a purchase suggestion 3. In the suggestions table, the first <th> contains no text 4. Apply the patch 5. Repeat steps 1-2 6. Inspect the suggestions table header 7. Confirm the first <th> now contains visually hidden text describing the checkbox selection column 8. Confirm the info icon still appears and its tooltip still works 9. Run an accessibility checker or inspect the DOM and confirm the empty table header issue is resolved Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.01 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42233 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01 |26.11.00,26.05.01,25.11.07 released in| | Status|Pushed to stable |Pushed to oldstable CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.07 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org